dajac commented on code in PR #16158:
URL: https://github.com/apache/kafka/pull/16158#discussion_r1623901700
##
core/src/test/scala/unit/kafka/server/KafkaApisTest.scala:
##
@@ -7086,6 +7086,7 @@ class KafkaApisTest extends Logging {
def testConsumerGroupDescribe(): Unit = {
dajac commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2144482983
@chia7712 Do you want to review it too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
[
https://issues.apache.org/jira/browse/KAFKA-16713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-16713.
--
Resolution: Fixed
ShareGroupHeartbeat, ShareGroupDescribe, ShareFetch and ShareAcknowl
[
https://issues.apache.org/jira/browse/KAFKA-16721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andrew Schofield resolved KAFKA-16721.
--
Resolution: Fixed
Delivered as part of https://github.com/apache/kafka/pull/16022.
>
nizhikov commented on PR #16106:
URL: https://github.com/apache/kafka/pull/16106#issuecomment-2144496534
@jsancio Are we have some dependencies of this PR?
Do we still want to merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
chia7712 commented on PR #16153:
URL: https://github.com/apache/kafka/pull/16153#issuecomment-2144639394
> isRemoteLogStorageSystemEnabled is a getter which makes the code clear to
read.
Pardon me, do you mean `RemoteLogManagerConfig#enableRemoteStorageSystem()`
should be renamed to
chia7712 commented on PR #16163:
URL: https://github.com/apache/kafka/pull/16163#issuecomment-2144640823
> Do you want to review it too?
I will take a look later!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
clolov merged PR #16154:
URL: https://github.com/apache/kafka/pull/16154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.o
chia7712 commented on code in PR #16163:
URL: https://github.com/apache/kafka/pull/16163#discussion_r1624060061
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -13166,6 +13166,50 @@ public void
testClassicGroupLeaveToCo
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2144668220
@gongxuanzhang Could you please check the build error?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1624069652
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/GroupSpecImpl.java:
##
@@ -75,36 +75,61 @@ public SubscriptionType subscriptionType() {
edoardocomar commented on code in PR #16151:
URL: https://github.com/apache/kafka/pull/16151#discussion_r1624103535
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4569,7 +4569,7 @@ public ListTransactionsResult
listTransactions(ListTransac
edoardocomar commented on code in PR #16151:
URL: https://github.com/apache/kafka/pull/16151#discussion_r1624103535
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -4569,7 +4569,7 @@ public ListTransactionsResult
listTransactions(ListTransac
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1624107462
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -239,6 +244,13 @@ private void removeMetrics() {
remoteStorageReaderThreadPool.removeMe
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1624108252
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() {
assertEquals(1, rl
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1624108812
##
core/src/main/java/kafka/log/remote/RemoteLogManager.java:
##
@@ -750,6 +762,23 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedExcepti
abhijeetk88 commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1624109218
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2716,6 +2728,198 @@ public void testFetchQuotaManagerConfig() {
assertEquals(1, rl
kamalcph commented on PR #16153:
URL: https://github.com/apache/kafka/pull/16153#issuecomment-2144721460
> > isRemoteLogStorageSystemEnabled is a getter which makes the code clear
to read.
>
> Pardon me, do you mean
`RemoteLogManagerConfig#enableRemoteStorageSystem()` should be renam
kamalcph commented on code in PR #16154:
URL: https://github.com/apache/kafka/pull/16154#discussion_r1624154594
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -466,6 +496,14 @@ public int remoteLogManagerThreadPoolSize() {
[
https://issues.apache.org/jira/browse/KAFKA-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851571#comment-17851571
]
Abhi commented on KAFKA-4094:
-
Hi [~jkreps]
Can you describe this issue more and also mentio
muralibasani commented on PR #16138:
URL: https://github.com/apache/kafka/pull/16138#issuecomment-2144802607
@clolov had to fix conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
[
https://issues.apache.org/jira/browse/KAFKA-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851571#comment-17851571
]
Abhi edited comment on KAFKA-4094 at 6/3/24 10:27 AM:
--
Hi [~jkreps]
[
https://issues.apache.org/jira/browse/KAFKA-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851575#comment-17851575
]
Edoardo Comar edited comment on KAFKA-16488 at 6/3/24 10:30 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-16488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851575#comment-17851575
]
Edoardo Comar commented on KAFKA-16488:
---
This failure may be due to https://issues
[
https://issues.apache.org/jira/browse/KAFKA-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851577#comment-17851577
]
Dmitry Werner commented on KAFKA-15743:
---
[~chia7712] Hello, could you look at the
AndrewJSchofield closed pull request #16134: KAFKA-16715: Create
KafkaShareConsumer interfaces
URL: https://github.com/apache/kafka/pull/16134
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
AndrewJSchofield commented on PR #16134:
URL: https://github.com/apache/kafka/pull/16134#issuecomment-2144903896
Closing and re-opening PR to force rebuild. This should fix the build
failures because of a recent merge.
--
This is an automated message from the Apache Git Service.
To respon
m1a2st commented on PR #16153:
URL: https://github.com/apache/kafka/pull/16153#issuecomment-2144905450
@kamalcph, Thanks for your comment. So you think that we should remove the
`def remoteLogManagerConfig = _remoteLogManagerConfig` to avoid other developer
can use `KafkaConfig.remoteLogMan
frankvicky commented on code in PR #16163:
URL: https://github.com/apache/kafka/pull/16163#discussion_r1624235852
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java:
##
@@ -13166,6 +13166,50 @@ public void
testClassicGroupLeaveTo
muralibasani commented on code in PR #16154:
URL: https://github.com/apache/kafka/pull/16154#discussion_r1624251243
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -466,6 +496,14 @@ public int remoteLogManagerThreadPoolSize(
[
https://issues.apache.org/jira/browse/KAFKA-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Muralidhar Basani reassigned KAFKA-16880:
-
Assignee: Muralidhar Basani
> Update equals and hashcode for two new *threadPoo
Muralidhar Basani created KAFKA-16880:
-
Summary: Update equals and hashcode for two new *threadPool
attributes
Key: KAFKA-16880
URL: https://issues.apache.org/jira/browse/KAFKA-16880
Project: Kafk
[
https://issues.apache.org/jira/browse/KAFKA-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Muralidhar Basani updated KAFKA-16880:
--
Description:
Update equals and hashCode methods for the below in RemoteLogManagerConfi
kamalcph commented on PR #16153:
URL: https://github.com/apache/kafka/pull/16153#issuecomment-2144957061
we can deprecate the `RemoteLogManagerConfig#enableRemoteStorageSystem()`
and add a new method in `RemoteLogManagerConfig#isRemoteStorageSystemEnabled()`
then refactor the existing usage
muralibasani opened a new pull request, #16173:
URL: https://github.com/apache/kafka/pull/16173
Resolves https://issues.apache.org/jira/browse/KAFKA-16880
Update equals and hashcode methods for two
remoteLogManagerCopierThreadPoolSize & remoteLogManagerExpirationThreadPoolSize
[
https://issues.apache.org/jira/browse/KAFKA-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851590#comment-17851590
]
Muralidhar Basani edited comment on KAFKA-16880 at 6/3/24 11:33 AM:
--
[
https://issues.apache.org/jira/browse/KAFKA-16880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851590#comment-17851590
]
Muralidhar Basani commented on KAFKA-16880:
---
[~Kamal C] or [~clolov] would yo
muralibasani commented on code in PR #16154:
URL: https://github.com/apache/kafka/pull/16154#discussion_r1624267630
##
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##
@@ -466,6 +496,14 @@ public int remoteLogManagerThreadPoolSize(
mimaison commented on PR #16122:
URL: https://github.com/apache/kafka/pull/16122#issuecomment-2144986729
It looks like one of the new tests is failing in the CI:
https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-16122/2/
--
This is an automated message from the Apache Git Service
mimaison commented on code in PR #15834:
URL: https://github.com/apache/kafka/pull/15834#discussion_r1624282626
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1457,6 +1465,18 @@ class KafkaConfig private(doLog: Boolean, val props:
java.util.Map[_, _], dynami
FrankYang0529 commented on PR #15908:
URL: https://github.com/apache/kafka/pull/15908#issuecomment-2145024531
> @FrankYang0529 please fix the conflicts, thanks!
Resolved it. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-16031?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851604#comment-17851604
]
PoAn Yang commented on KAFKA-16031:
---
Hi [~showuon], I think we can close this issue si
[
https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851610#comment-17851610
]
Roland Sommer commented on KAFKA-15330:
---
I did a new custom build of kafka (the HE
showuon commented on code in PR #16105:
URL: https://github.com/apache/kafka/pull/16105#discussion_r1624333042
##
core/src/main/scala/kafka/coordinator/group/GroupMetadataManager.scala:
##
@@ -383,8 +383,7 @@ class GroupMetadataManager(brokerId: Int,
[
https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851610#comment-17851610
]
Roland Sommer edited comment on KAFKA-15330 at 6/3/24 12:20 PM:
--
chia7712 commented on PR #16153:
URL: https://github.com/apache/kafka/pull/16153#issuecomment-2145070179
> we can deprecate the RemoteLogManagerConfig#enableRemoteStorageSystem()
and add a new method in RemoteLogManagerConfig#isRemoteStorageSystemEnabled()
then refactor the existing usages.
chia7712 commented on PR #16173:
URL: https://github.com/apache/kafka/pull/16173#issuecomment-2145074398
As this is a kind of bug fix, could you please add UT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
mimaison commented on code in PR #15834:
URL: https://github.com/apache/kafka/pull/15834#discussion_r1624370212
##
core/src/main/scala/kafka/tools/StorageTool.scala:
##
@@ -45,89 +45,124 @@ import scala.jdk.CollectionConverters._
import scala.collection.mutable.ArrayBuffer
o
cadonna commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1624238381
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -827,26 +808,15 @@ abstract class RetriableRequestState extends Re
Mickael Maison created KAFKA-16881:
--
Summary: InitialState type leaks into the Connect REST API OpenAPI
spec
Key: KAFKA-16881
URL: https://issues.apache.org/jira/browse/KAFKA-16881
Project: Kafka
dajac opened a new pull request, #16174:
URL: https://github.com/apache/kafka/pull/16174
This patch is a small refactoring which mainly aims at avoid to construct a
copy of the new target assignment in the TargetAssignmentBuilder because the
copy is not used by the caller. The change relies
chia7712 commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2145167748
It seems we are facing Trolley problem :(
1. we use spotless 6.13 in order to **support JDK 8**
2. the google-format version used by spotless 6.13 **has issue in JDK 21**
(https
[
https://issues.apache.org/jira/browse/KAFKA-16881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851628#comment-17851628
]
黃竣陽 commented on KAFKA-16881:
-
I'm interesting in this issue, I can handle it.
> InitialSta
m1a2st opened a new pull request, #16175:
URL: https://github.com/apache/kafka/pull/16175
https://issues.apache.org/jira/browse/KAFKA-16881
I add @JsonProperty value to match the `initial_state` to solve the problem
### Committer Checklist (excluded from commit message)
- [ ]
gongxuanzhang commented on PR #16172:
URL: https://github.com/apache/kafka/pull/16172#issuecomment-2145206355
I agree remove support JDK8.
I will change spotless version and comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
sjhajharia commented on code in PR #16049:
URL: https://github.com/apache/kafka/pull/16049#discussion_r162444
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -1336,13 +1335,13 @@ public ClientResponse mockOffsetCommit
sjhajharia commented on code in PR #16049:
URL: https://github.com/apache/kafka/pull/16049#discussion_r1624466257
##
clients/src/main/java/org/apache/kafka/common/utils/Utils.java:
##
@@ -371,6 +371,7 @@ public static boolean isEqualConstantTime(char[] first,
char[] second) {
sjhajharia commented on code in PR #16049:
URL: https://github.com/apache/kafka/pull/16049#discussion_r1624467049
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinatorTest.java:
##
@@ -311,7 +311,7 @@ public void
testPerformAssignmentShouldUpd
viktorsomogyi merged PR #15914:
URL: https://github.com/apache/kafka/pull/15914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.a
muralibasani commented on PR #16173:
URL: https://github.com/apache/kafka/pull/16173#issuecomment-2145257548
> As this is a kind of bug fix, could you please add UT?
Ah yes, done now. thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
clolov commented on code in PR #16132:
URL: https://github.com/apache/kafka/pull/16132#discussion_r1624512832
##
storage/src/main/java/org/apache/kafka/storage/internals/log/LogConfig.java:
##
@@ -179,6 +182,7 @@ public Optional serverConfigName(String configName)
{
public
[
https://issues.apache.org/jira/browse/KAFKA-15330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851655#comment-17851655
]
David Arthur commented on KAFKA-15330:
--
If the controller is not seeing the ZK brok
omkreddy commented on PR #16134:
URL: https://github.com/apache/kafka/pull/16134#issuecomment-2145321139
there are checkstyle errors:
```
[2024-06-03T13:13:54.181Z] * What went wrong:
[2024-06-03T13:13:54.181Z] Execution failed for task
':clients:checkstyleMain'.
[202
fvaleri closed pull request #14847: KAFKA-14585: Move StorageTool to tools
URL: https://github.com/apache/kafka/pull/14847
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To un
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1624549518
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/TopicMetadataRequestManager.java:
##
@@ -210,7 +194,7 @@ private NetworkClientDelegate.UnsentReques
mumrah commented on PR #16131:
URL: https://github.com/apache/kafka/pull/16131#issuecomment-2145338647
I don't think we should be adding any new ZK features at this point.
KIP-405 was first in early access in 3.6 and ZK was deprecated in 3.5. It
seems pretty reasonable to require use
brenden20 commented on PR #16115:
URL: https://github.com/apache/kafka/pull/16115#issuecomment-2145353574
@philipnee I have implemented all suggested changes except for the
whitespace issue, I am going to use Emacs to try to figure it out
--
This is an automated message from the Apache Gi
omkreddy commented on code in PR #16134:
URL: https://github.com/apache/kafka/pull/16134#discussion_r1624558823
##
clients/src/main/java/org/apache/kafka/clients/consumer/MockShareConsumer.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
C0urante commented on PR #16122:
URL: https://github.com/apache/kafka/pull/16122#issuecomment-2145362279
Ugh, misunderstood the signature of `ConnectorHandle::expectedStarts`.
Pushed a fix, will ping if/when the test passes again.
--
This is an automated message from the Apache Git Servic
chia7712 commented on code in PR #16174:
URL: https://github.com/apache/kafka/pull/16174#discussion_r1624569720
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##
@@ -64,11 +64,11 @@ public static class TargetAssignmen
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624575007
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
brandboat commented on code in PR #16165:
URL: https://github.com/apache/kafka/pull/16165#discussion_r1624576565
##
core/src/test/java/kafka/server/LogManagerIntegrationTest.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624577785
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
dajac commented on code in PR #16174:
URL: https://github.com/apache/kafka/pull/16174#discussion_r1624578908
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##
@@ -64,11 +64,11 @@ public static class TargetAssignmentRe
[
https://issues.apache.org/jira/browse/KAFKA-16838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851667#comment-17851667
]
Chris Egerton commented on KAFKA-16838:
---
It's probably possible but it might get a
chia7712 commented on code in PR #16176:
URL: https://github.com/apache/kafka/pull/16176#discussion_r1624574894
##
build.gradle:
##
@@ -47,9 +47,10 @@ plugins {
// Updating the shadow plugin version to 8.1.1 causes issue with signing and
publishing the shadowed
// artifac
[
https://issues.apache.org/jira/browse/KAFKA-16881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17851669#comment-17851669
]
Chris Egerton commented on KAFKA-16881:
---
[~m1a2st] I've assigned the issue to you.
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624583148
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
[
https://issues.apache.org/jira/browse/KAFKA-16881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Egerton reassigned KAFKA-16881:
-
Assignee: 黃竣陽
> InitialState type leaks into the Connect REST API OpenAPI spec
> --
dajac commented on code in PR #16174:
URL: https://github.com/apache/kafka/pull/16174#discussion_r1624578908
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##
@@ -64,11 +64,11 @@ public static class TargetAssignmentRe
brenden20 commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624585035
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
brenden20 commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1624585963
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr
brenden20 commented on code in PR #16140:
URL: https://github.com/apache/kafka/pull/16140#discussion_r1624586673
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerNetworkThreadTest.java:
##
@@ -149,20 +164,28 @@ public void testStartupAndTearDown() thr
kamalcph commented on code in PR #16173:
URL: https://github.com/apache/kafka/pull/16173#discussion_r1624594062
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java:
##
@@ -105,4 +116,79 @@ private Map
extractProps(RemoteLogManager
kamalcph commented on code in PR #16173:
URL: https://github.com/apache/kafka/pull/16173#discussion_r1624595821
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java:
##
@@ -105,4 +116,79 @@ private Map
extractProps(RemoteLogManager
kamalcph commented on code in PR #16173:
URL: https://github.com/apache/kafka/pull/16173#discussion_r1624595821
##
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfigTest.java:
##
@@ -105,4 +116,79 @@ private Map
extractProps(RemoteLogManager
philipnee commented on code in PR #16115:
URL: https://github.com/apache/kafka/pull/16115#discussion_r1624598671
##
clients/src/test/java/org/apache/kafka/clients/consumer/internals/CommitRequestManagerTest.java:
##
@@ -123,6 +123,46 @@ public void setup() {
this.props.
chia7712 commented on code in PR #16174:
URL: https://github.com/apache/kafka/pull/16174#discussion_r1624601766
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##
@@ -64,11 +64,11 @@ public static class TargetAssignmen
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1624620726
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -432,7 +436,7 @@ private void commitSyncWithRetries(OffsetCommitRe
lianetm commented on code in PR #16031:
URL: https://github.com/apache/kafka/pull/16031#discussion_r1624620726
##
clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java:
##
@@ -432,7 +436,7 @@ private void commitSyncWithRetries(OffsetCommitRe
apourchet commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1624625757
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/AssignmentConfigs.java:
##
@@ -29,20 +32,47 @@ public class AssignmentConfigs {
private fi
clolov commented on code in PR #15673:
URL: https://github.com/apache/kafka/pull/15673#discussion_r1624631817
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -228,7 +231,7 @@ public enum MetadataVersion {
* Think carefully before y
AndrewJSchofield commented on code in PR #16134:
URL: https://github.com/apache/kafka/pull/16134#discussion_r1624638311
##
clients/src/main/java/org/apache/kafka/clients/consumer/MockShareConsumer.java:
##
@@ -0,0 +1,170 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
C0urante opened a new pull request, #16177:
URL: https://github.com/apache/kafka/pull/16177
For nested subprojects like `:connect:runtime`, the `project.name` field
will only return the name of the leaf project, e.g., `runtime`, which can be
ambiguous and confusing when reading and modifyin
C0urante commented on PR #16177:
URL: https://github.com/apache/kafka/pull/16177#issuecomment-2145492208
@chia7712 does this seem reasonable to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
[
https://issues.apache.org/jira/browse/KAFKA-16882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash updated KAFKA-16882:
-
Fix Version/s: (was: 3.9.0)
> Migrate RemoteLogSegmentLifecycleTest to new t
[
https://issues.apache.org/jira/browse/KAFKA-16882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kamal Chandraprakash reassigned KAFKA-16882:
Assignee: Kamal Chandraprakash (was: Kuan Po Tseng)
> Migrate RemoteLogS
Kamal Chandraprakash created KAFKA-16882:
Summary: Migrate RemoteLogSegmentLifecycleTest to new test infra
Key: KAFKA-16882
URL: https://issues.apache.org/jira/browse/KAFKA-16882
Project: Kafka
apourchet commented on code in PR #16147:
URL: https://github.com/apache/kafka/pull/16147#discussion_r1624647021
##
streams/src/main/java/org/apache/kafka/streams/processor/assignment/assignors/StickyTaskAssignor.java:
##
@@ -331,7 +328,7 @@ public Set findClientsWithoutAssigned
Nicolas Henneaux created KAFKA-16883:
Summary: Zookeeper-Kraft failing migration - RPC got timed out
before it could be sent
Key: KAFKA-16883
URL: https://issues.apache.org/jira/browse/KAFKA-16883
1 - 100 of 310 matches
Mail list logo
