dajac commented on code in PR #16174:
URL: https://github.com/apache/kafka/pull/16174#discussion_r1624578908
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##########
@@ -64,11 +64,11 @@ public static class TargetAssignmentResult {
/**
* The new target assignment for the group.
*/
- private final Map<String, Assignment> targetAssignment;
+ private final Map<String, MemberAssignment> targetAssignment;
TargetAssignmentResult(
List<CoordinatorRecord> records,
- Map<String, Assignment> targetAssignment
+ Map<String, MemberAssignment> targetAssignment
Review Comment:
`MemberAssignment` is part of the public interface so I don't want to change
it and I'd like to keep it immutable. For the context, `Assignment` will have
more fields in the future when we implement client side assignors. This is why
we have it. Otherwise, I would have dropped it and directly used the `Map<Uuid,
Set<Interger>>` (internally).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
