chia7712 commented on code in PR #16174:
URL: https://github.com/apache/kafka/pull/16174#discussion_r1624601766
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##########
@@ -64,11 +64,11 @@ public static class TargetAssignmentResult {
/**
* The new target assignment for the group.
*/
- private final Map<String, Assignment> targetAssignment;
+ private final Map<String, MemberAssignment> targetAssignment;
TargetAssignmentResult(
List<CoordinatorRecord> records,
- Map<String, Assignment> targetAssignment
+ Map<String, MemberAssignment> targetAssignment
Review Comment:
> and I'd like to keep it immutable.
Pardon me, do you mean the variables of `MemberAssignment` is immutable? if
so, there are use cases that modify the inner collection. For example:
https://github.com/apache/kafka/blob/a68a1cce824a8346509d5194e0e43a3cb36ba09a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/AbstractUniformAssignmentBuilder.java#L46
https://github.com/apache/kafka/blob/a68a1cce824a8346509d5194e0e43a3cb36ba09a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java#L180
https://github.com/apache/kafka/blob/a68a1cce824a8346509d5194e0e43a3cb36ba09a/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/RangeAssignor.java#L201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
