showuon commented on PR #15751:
URL: https://github.com/apache/kafka/pull/15751#issuecomment-2132839294
@soarez , could you have another look at this PR since you're the expert in
KRaft JBOD?
It seems after partition reassignment, the directory is set as `UNASSIGNED`,
and that causes the
fanyang commented on PR #16035:
URL: https://github.com/apache/kafka/pull/16035#issuecomment-2132884096
Hi Greg @gharris1727 ,
Thank you for the comments. I'm interest in this item, and my current usage
scenario is also related to avro schema and connect schema. For example, when
we writ
abhijeetk88 opened a new pull request, #16087:
URL: https://github.com/apache/kafka/pull/16087
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of tes
Fan Yang created KAFKA-16844:
Summary: ByteArrayConverter can't convert ByteBuffer
Key: KAFKA-16844
URL: https://issues.apache.org/jira/browse/KAFKA-16844
Project: Kafka
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/KAFKA-16805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849675#comment-17849675
]
Chia-Ping Tsai commented on KAFKA-16805:
[~gharris1727] thanks for your response
chia7712 commented on code in PR #16081:
URL: https://github.com/apache/kafka/pull/16081#discussion_r1615743021
##
build.gradle:
##
@@ -743,7 +743,7 @@ subprojects {
test.dependsOn('spotbugsMain')
tasks.withType(com.github.spotbugs.snom.SpotBugsTask) {
-reports {
+
chia7712 commented on PR #15848:
URL: https://github.com/apache/kafka/pull/15848#issuecomment-2133045240
I just notice that this test requires `SaslSetup`. the new test infra does
not support that for now (https://issues.apache.org/jira/browse/KAFKA-16680).
Hence, I'd like to pending this r
Chia-Ping Tsai created KAFKA-16845:
--
Summary: Migrate ReplicationQuotasTestRig to new test infra
Key: KAFKA-16845
URL: https://issues.apache.org/jira/browse/KAFKA-16845
Project: Kafka
Issue
nizhikov commented on PR #15848:
URL: https://github.com/apache/kafka/pull/15848#issuecomment-2133050783
Got it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
chia7712 commented on code in PR #15675:
URL: https://github.com/apache/kafka/pull/15675#discussion_r1615769194
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java:
##
@@ -0,0 +1,820 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
chia7712 commented on code in PR #15675:
URL: https://github.com/apache/kafka/pull/15675#discussion_r1615769708
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java:
##
@@ -0,0 +1,820 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
nizhikov commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2133054563
> We can postpone rewriting for a while (especially, 3.8.0 is going to be
released)
@chia7712 @mimaison
Can you, please, clarify.
Are we stop this PR until 3.8 or until
showuon commented on code in PR #15820:
URL: https://github.com/apache/kafka/pull/15820#discussion_r1615786577
##
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##
@@ -2530,6 +2549,269 @@ int lookupPositionForOffset(RemoteLogSegmentMetadata
remoteLogSegmentMetad
chia7712 commented on PR #15417:
URL: https://github.com/apache/kafka/pull/15417#issuecomment-2133076712
> Are we stop this PR until 3.8 or until all dependencies will be moved out
of core?
short answer: Yes!
Personally, it would be great to address the final purpose - all in j
showuon commented on PR #15634:
URL: https://github.com/apache/kafka/pull/15634#issuecomment-2133081717
@kamalcph , could we close this PR since
https://github.com/apache/kafka/pull/15825 is merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
chia7712 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1615797305
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -17,449 +17,502 @@
package org.apache.kafka.tools.consumer.group;
im
[
https://issues.apache.org/jira/browse/KAFKA-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen updated KAFKA-16452:
--
Fix Version/s: 3.8.0
> Bound highwatermark offset to range b/w local-log-start-offset and
> log-end-o
showuon merged PR #15825:
URL: https://github.com/apache/kafka/pull/15825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849681#comment-17849681
]
Luke Chen commented on KAFKA-16531:
---
I'm taking this over and will ask questions if an
[
https://issues.apache.org/jira/browse/KAFKA-16531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16531:
-
Assignee: Luke Chen (was: José Armando García Sancio)
> Fix check-quorum calculation to not as
chia7712 commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615806392
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
p
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615832739
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
pub
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615834596
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
pub
chia7712 commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615843755
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
p
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615855598
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
pub
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615857895
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
pub
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615857895
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
pub
chia7712 commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615862590
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
p
kamalcph closed pull request #15634: KAFKA-16452: Bound high-watermark offset
to range between LLSO and LEO
URL: https://github.com/apache/kafka/pull/15634
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-16780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849695#comment-17849695
]
Kamal Chandraprakash commented on KAFKA-16780:
--
The issue mentioned above a
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615878763
##
core/src/test/java/kafka/admin/ConfigCommandIntegrationTest.java:
##
@@ -65,219 +75,494 @@
@ExtendWith(value = ClusterTestExtensions.class)
@Tag("integration")
pub
muralibasani closed pull request #16069: Adding standalone parameter to
kafka-storage.sh [KAFKA-16518]
URL: https://github.com/apache/kafka/pull/16069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
cadonna commented on PR #15973:
URL: https://github.com/apache/kafka/pull/15973#issuecomment-2133255333
@loicgreffier Thanks for the PR!
A 1700 lines PR is quite hard to review.
Could you please split this PR into multiple smaller ones?
300-500 lines is a good upper bound for the s
dajac opened a new pull request, #16088:
URL: https://github.com/apache/kafka/pull/16088
This patch optimizes uniform (homogenous) assignor by avoiding creating a
copy of all the assignments. Instead, the assignor creates a copy only if the
assignment is updated. It is a sort of copy-on-wri
David Jacot created KAFKA-16846:
---
Summary: Should TxnOffsetCommit API fail all the offsets if any
fails the validation?
Key: KAFKA-16846
URL: https://issues.apache.org/jira/browse/KAFKA-16846
Project: K
dajac commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-213709
Opened: https://issues.apache.org/jira/browse/KAFKA-16846.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
loicgreffier commented on PR #15973:
URL: https://github.com/apache/kafka/pull/15973#issuecomment-2133364757
@cadonna Understood
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
chia7712 commented on code in PR #15862:
URL: https://github.com/apache/kafka/pull/15862#discussion_r1615991000
##
core/src/test/java/kafka/test/junit/ClusterTestExtensionsUnitTest.java:
##
@@ -17,29 +17,66 @@
package kafka.test.junit;
+import kafka.test.ClusterConfig;
imp
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615996251
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -244,8 +248,11 @@ object ConfigCommand extends Logging {
" to override the default encoding para
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849721#comment-17849721
]
Chia-Ping Tsai commented on KAFKA-15203:
{quote}
The requirement is to use Servi
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1615996251
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -244,8 +248,11 @@ object ConfigCommand extends Logging {
" to override the default encoding para
chia7712 commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616011793
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(enco
chia7712 commented on code in PR #16042:
URL: https://github.com/apache/kafka/pull/16042#discussion_r1616025501
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1258,7 +1258,7 @@ class ReplicaManager(val config: KafkaConfig,
.setOffsetLag(get
nicolasguyomar opened a new pull request, #16089:
URL: https://github.com/apache/kafka/pull/16089
We recently increased that log verbosity from INFO to DEBUG, but this is
causing some confusion among users when an idle connection is disconnected,
which is a normal activity. This is a propos
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616037991
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(encode
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616037991
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(encode
chia7712 commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616045902
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(enco
loicgreffier opened a new pull request, #16090:
URL: https://github.com/apache/kafka/pull/16090
This PR is part of KAFKA-16448 which aims to bring a
ProcessingExceptionHandler to Kafka Streams in order to deal with exceptions
that occur during processing.
This PR brings `ProcessingEx
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616061164
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(encode
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616061164
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(encode
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616061164
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(encode
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616061164
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(encode
m1a2st commented on code in PR #15840:
URL: https://github.com/apache/kafka/pull/15840#discussion_r1616061164
##
core/src/main/scala/kafka/admin/ConfigCommand.scala:
##
@@ -210,15 +210,19 @@ object ConfigCommand extends Logging {
}
}
- def createPasswordEncoder(encode
FrankYang0529 commented on code in PR #15675:
URL: https://github.com/apache/kafka/pull/15675#discussion_r1616073769
##
tools/src/test/java/org/apache/kafka/tools/reassign/ReassignPartitionsCommandTest.java:
##
@@ -0,0 +1,820 @@
+/*
+ * Licensed to the Apache Software Foundation
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616077491
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616082089
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616090879
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
[
https://issues.apache.org/jira/browse/KAFKA-14588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849743#comment-17849743
]
Nikolay Izhikov commented on KAFKA-14588:
-
Review of the PR for this Jira postpo
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616099696
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -28,37 +28,37 @@
* This is applicable when the consumer is having Kaf
[
https://issues.apache.org/jira/browse/KAFKA-16583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849745#comment-17849745
]
Igor Soarez commented on KAFKA-16583:
-
Hi [~robinhan]. Thanks for filling this.
Ca
lianetm commented on code in PR #16083:
URL: https://github.com/apache/kafka/pull/16083#discussion_r1616124179
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerRebalanceListener.java:
##
@@ -119,15 +119,15 @@
public interface ConsumerRebalanceListener {
nizhikov opened a new pull request, #16091:
URL: https://github.com/apache/kafka/pull/16091
Changes in `DescribeQuorum` request and response regarding KIP-853
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage
soarez commented on PR #15862:
URL: https://github.com/apache/kafka/pull/15862#issuecomment-2133610600
@TaiJuWu sorry it has taken me a while to get back to this.
I agree with the simplification @chia7712 I suggesting.
--
This is an automated message from the Apache Git Service.
To
superhx commented on PR #15751:
URL: https://github.com/apache/kafka/pull/15751#issuecomment-2133641804
> PartitionRegistration
Pass the `metadataVersion` to `PartitionRegistration#merge` may be a more
appropriate fix. But I found that `PartitionRegistration#merge` is used in many
pl
dajac merged PR #16072:
URL: https://github.com/apache/kafka/pull/16072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
loicgreffier opened a new pull request, #16092:
URL: https://github.com/apache/kafka/pull/16092
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of te
dajac closed pull request #15536: KAFKA-16371: fix lingering pending commit
when handling OFFSET_METADATA_TOO_LARGE
URL: https://github.com/apache/kafka/pull/15536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
dajac commented on PR #15536:
URL: https://github.com/apache/kafka/pull/15536#issuecomment-2133676133
Addressed by https://github.com/apache/kafka/pull/16072.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/KAFKA-16371?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-16371.
-
Fix Version/s: 3.8.0
3.7.1
Assignee: David Jacot
Resolution: F
loicgreffier opened a new pull request, #16093:
URL: https://github.com/apache/kafka/pull/16093
This PR is part of KAFKA-16448 which aims to bring a
ProcessingExceptionHandler to Kafka Streams in order to deal with exceptions
that occur during processing.
This PR actually catches pro
FrankYang0529 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1616179624
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -17,449 +17,502 @@
package org.apache.kafka.tools.consumer.group;
dajac commented on PR #16072:
URL: https://github.com/apache/kafka/pull/16072#issuecomment-2133684583
Merged to trunk and 3.7.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849773#comment-17849773
]
Ganesh Sadanala commented on KAFKA-15203:
-
[~chia7712] To fully replace the `{{R
chia7712 commented on code in PR #15821:
URL: https://github.com/apache/kafka/pull/15821#discussion_r1616213225
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ListConsumerGroupTest.java:
##
@@ -17,449 +17,502 @@
package org.apache.kafka.tools.consumer.group;
im
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849776#comment-17849776
]
Chia-Ping Tsai commented on KAFKA-15203:
It seems to me the deprecation cycle is
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai updated KAFKA-15203:
---
Fix Version/s: 5.0.0
> Remove dependency on Reflections
> -
cmccabe closed pull request #16082: Revert "KAFKA-16515: Fix the ZK Metadata
cache confusion between brokers and controllers
URL: https://github.com/apache/kafka/pull/16082
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cmccabe commented on PR #16082:
URL: https://github.com/apache/kafka/pull/16082#issuecomment-2133753266
Sorry, there was a typo in the original commit that led to a variable
getting shadowed. I think it happened during rebasing on trunk. This should be
fixed now. Hence, closing this JIRA.
cmccabe commented on PR #16006:
URL: https://github.com/apache/kafka/pull/16006#issuecomment-2133754024
@jolshan : Sorry, there was a typo in the original commit that led to a
variable getting shadowed. I think it happened during rebasing on trunk. This
should be fixed now.
--
This is an
dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1616230602
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java:
##
@@ -370,16 +407,13 @@ private Assignment newMemberAssignme
dajac commented on code in PR #16068:
URL: https://github.com/apache/kafka/pull/16068#discussion_r1616231491
##
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/MemberSubscriptionSpecImpl.java:
##
@@ -0,0 +1,77 @@
+/*
+ * Licensed to the Apache Softwar
[
https://issues.apache.org/jira/browse/KAFKA-12708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849780#comment-17849780
]
Kuan Po Tseng commented on KAFKA-12708:
---
gentle ping [~Geordie] , are you still wo
chia7712 commented on PR #16081:
URL: https://github.com/apache/kafka/pull/16081#issuecomment-2133786536
@m1a2st Our QA can't verify this PR I feel, so could you please test related
configs and then attach the screenshot?
--
This is an automated message from the Apache Git Service.
To res
chia7712 commented on code in PR #16062:
URL: https://github.com/apache/kafka/pull/16062#discussion_r1616238052
##
clients/src/main/java/org/apache/kafka/common/PartitionInfo.java:
##
@@ -88,6 +90,28 @@ public Node[] offlineReplicas() {
return offlineReplicas;
}
chia7712 commented on code in PR #16042:
URL: https://github.com/apache/kafka/pull/16042#discussion_r1616243577
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1247,7 +1247,7 @@ class ReplicaManager(val config: KafkaConfig,
val usableBytes = adjustForLa
chia7712 commented on code in PR #16042:
URL: https://github.com/apache/kafka/pull/16042#discussion_r1616243847
##
core/src/main/scala/kafka/server/ReplicaManager.scala:
##
@@ -1247,7 +1247,7 @@ class ReplicaManager(val config: KafkaConfig,
val usableBytes = adjustForLa
[
https://issues.apache.org/jira/browse/KAFKA-16841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Justine Olshan resolved KAFKA-16841.
Resolution: Fixed
fixed by
https://github.com/apache/kafka/commit/bac8df56ffdf8a64ecfb78e
chia7712 commented on code in PR #16085:
URL: https://github.com/apache/kafka/pull/16085#discussion_r1616250511
##
core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala:
##
@@ -105,8 +109,6 @@ class LogSegmentsTest {
assertFalse(segments.nonEmpty)
assertEquals(0, se
brandboat commented on code in PR #16085:
URL: https://github.com/apache/kafka/pull/16085#discussion_r1616260244
##
core/src/test/scala/unit/kafka/log/LogSegmentsTest.scala:
##
@@ -105,8 +109,6 @@ class LogSegmentsTest {
assertFalse(segments.nonEmpty)
assertEquals(0, s
chia7712 commented on PR #16067:
URL: https://github.com/apache/kafka/pull/16067#issuecomment-2133819178
@sjhajharia Could you please fix the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
cadonna commented on code in PR #16090:
URL: https://github.com/apache/kafka/pull/16090#discussion_r1616218317
##
streams/src/main/java/org/apache/kafka/streams/errors/ErrorHandlerContext.java:
##
@@ -0,0 +1,133 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under o
[
https://issues.apache.org/jira/browse/KAFKA-12708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
GeordieMai reassigned KAFKA-12708:
--
Assignee: Kuan Po Tseng (was: GeordieMai)
> Rewrite org.apache.kafka.test.Microbenchmarks by
[
https://issues.apache.org/jira/browse/KAFKA-12708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849793#comment-17849793
]
GeordieMai commented on KAFKA-12708:
[~brandboat] Sure, you can take it :)
> Rewrit
muralibasani opened a new pull request, #16094:
URL: https://github.com/apache/kafka/pull/16094
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
- Adds a new a
muralibasani commented on PR #16094:
URL: https://github.com/apache/kafka/pull/16094#issuecomment-2133856644
@jsancio what do you think on this approach ?
it's abit not clear on creating the kRaftVersionRecord and votersRecord
though.
```
./bin/kafka-storage.sh format --clus
muralibasani commented on PR #16069:
URL: https://github.com/apache/kafka/pull/16069#issuecomment-2133857326
https://github.com/apache/kafka/pull/16094
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
[
https://issues.apache.org/jira/browse/KAFKA-16518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849794#comment-17849794
]
Muralidhar Basani commented on KAFKA-16518:
---
https://github.com/apache/kafka/p
[ https://issues.apache.org/jira/browse/KAFKA-16518 ]
Muralidhar Basani deleted comment on KAFKA-16518:
---
was (Author: muralibasani):
https://github.com/apache/kafka/pull/16094
> Storage tool changes for KIP-853
> -
[
https://issues.apache.org/jira/browse/KAFKA-16518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849795#comment-17849795
]
Muralidhar Basani commented on KAFKA-16518:
---
[~jsancio] have a new PR [https:/
ivanyu commented on code in PR #13277:
URL: https://github.com/apache/kafka/pull/13277#discussion_r1616292083
##
clients/src/main/java/org/apache/kafka/clients/NetworkClient.java:
##
Review Comment:
Thank you. I removed extra constructors in this case
--
This is an auto
1 - 100 of 173 matches
Mail list logo
