chia7712 commented on code in PR #16081:
URL: https://github.com/apache/kafka/pull/16081#discussion_r1615743021

##########
build.gradle:
##########
@@ -743,7 +743,7 @@ subprojects {
   test.dependsOn('spotbugsMain')
 
   tasks.withType(com.github.spotbugs.snom.SpotBugsTask) {
-    reports {
+    reports.configure { reports ->

Review Comment:
   We don't use variable `reports`, so `reports ->` can be omitted. 



##########
build.gradle:
##########
@@ -743,7 +743,7 @@ subprojects {
   test.dependsOn('spotbugsMain')
 
   tasks.withType(com.github.spotbugs.snom.SpotBugsTask) {

Review Comment:
   Could we address 
https://docs.gradle.org/current/userguide/task_configuration_avoidance.html in 
this PR?
   
   `tasks.withType(com.github.spotbugs.snom.SpotBugsTask).configureEach`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to