[ 
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849773#comment-17849773
 ] 

Ganesh Sadanala commented on KAFKA-15203:
-----------------------------------------

[~chia7712] To fully replace the `{{ReflectionScanner`}}, the community would 
need to ensure that all existing and new plugins are packaged with the required 
`ServiceLoader` manifests or module declarations, as per the guidelines in 
KIP-898. Once this migration is complete, the `{{ReflectionScanner`}} class can 
be safely removed from the codebase. 

 

The `{{{}ServiceLoaderScanner`{}}} class mentions that it "can only find 
plugins with corresponding {{`ServiceLoader`}} manifests, which are not 
required to be packaged with plugins. This has the effect that some plugins 
discoverable by the `{{{}ReflectionScanner`{}}} may not be visible with this 
implementation."

 

I am assuming that "all existing and new plugins are packaged with the required 
`ServiceLoader` manifests or module declarations" is already done. However, I 
want to recheck this before I can completely remove the Reflections. Could you 
confirm this as well?

> Remove dependency on Reflections 
> ---------------------------------
>
>                 Key: KAFKA-15203
>                 URL: https://issues.apache.org/jira/browse/KAFKA-15203
>             Project: Kafka
>          Issue Type: Bug
>          Components: connect
>            Reporter: Divij Vaidya
>            Assignee: Ganesh Sadanala
>            Priority: Major
>              Labels: newbie
>
> We currently depend on reflections library which is EOL. Quoting from the 
> GitHub site:
> _> Please note: Reflections library is currently NOT under active development 
> or maintenance_
>  
> This poses a supply chain risk for our project where the security fixes and 
> other major bugs in underlying dependency may not be addressed timely.
> Hence, we should plan to remove this dependency.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to