Re: [PR] MINOR: Clean up TestUtils.scala [kafka]

2024-04-30 Thread via GitHub
m1a2st commented on code in PR #15808: URL: https://github.com/apache/kafka/pull/15808#discussion_r1584248006 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -321,16 +322,16 @@ class RemoteIndexCacheTest { // Give the thread cleaner thread som

Re: [PR] KAFKA-16514: backdoor for modifying internal leave.group.on.close config [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #15819: URL: https://github.com/apache/kafka/pull/15819#discussion_r1584226418 ## streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java: ## @@ -1469,6 +1469,10 @@ private Thread shutdownHelper(final boolean error, final long timeoutMs

Re: [PR] MINOR: Clean up TestUtils.scala [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #15808: URL: https://github.com/apache/kafka/pull/15808#discussion_r1584251393 ## core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala: ## @@ -321,16 +322,16 @@ class RemoteIndexCacheTest { // Give the thread cleaner thread s

Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2084584466 any update here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Resolved] (KAFKA-10859) add @Test annotation to FileStreamSourceTaskTest.testInvalidFile and reduce the loop count to speedup the test

2024-04-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chia-Ping Tsai resolved KAFKA-10859. Resolution: Duplicate fixed by https://github.com/apache/kafka/commit/3dacdc5694da5db2835

Re: [PR] KAFKA-16362: Fix type-unsafety in KStreamKStreamJoin caused by isLeftSide [kafka]

2024-04-30 Thread via GitHub
raminqaf commented on PR #15601: URL: https://github.com/apache/kafka/pull/15601#issuecomment-2084636567 @gharris1727 Thanks for the positive feedback! I am happy that you like the changes! I addressed all your nit reviews and refactored the logic of the non-final boolean variables (i.e., `

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-30 Thread via GitHub
lucasbru commented on PR #15723: URL: https://github.com/apache/kafka/pull/15723#issuecomment-2084640215 @philipnee Since the unresolved conversation is only around an internal method name, I'm merging this. Feel free to ask for a follow-up PR -- This is an automated message from the Apac

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-30 Thread via GitHub
lucasbru merged PR #15723: URL: https://github.com/apache/kafka/pull/15723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-16407: Fix foreign key INNER join on change of FK from/to a null value [kafka]

2024-04-30 Thread via GitHub
AyoubOm commented on PR #15615: URL: https://github.com/apache/kafka/pull/15615#issuecomment-2084651380 > @AyoubOm -- Thanks for the PR! I did not forget about it. Just did not find time yet to take a look. Still plan to get this merged for 3.8 release... Sorry for the long wait, and thanks

[jira] [Commented] (KAFKA-16644) FK join emits duplicate tombstone on left-side delete

2024-04-30 Thread Ayoub Omari (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842285#comment-17842285 ] Ayoub Omari commented on KAFKA-16644: - Hi [~mjsax], I think this is the same issue r

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1584322426 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -196,16 +197,35 @@ private void processClusterTest(ExtensionContext context, ClusterTest anno

[jira] [Created] (KAFKA-16645) CVEs in 3.7.0 docker image

2024-04-30 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-16645: -- Summary: CVEs in 3.7.0 docker image Key: KAFKA-16645 URL: https://issues.apache.org/jira/browse/KAFKA-16645 Project: Kafka Issue Type: Task Affects V

[jira] [Updated] (KAFKA-16645) CVEs in 3.7.0 docker image

2024-04-30 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-16645: --- Description: Our [Docker Image CVE Scanner|https://github.com/apache/kafka/actions/runs/

[jira] [Created] (KAFKA-16646) Consider only running the CVE scanner action on apache/kafka and not in forks

2024-04-30 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-16646: -- Summary: Consider only running the CVE scanner action on apache/kafka and not in forks Key: KAFKA-16646 URL: https://issues.apache.org/jira/browse/KAFKA-16646 Pro

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-04-30 Thread Stanislav Spiridonov (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842293#comment-17842293 ] Stanislav Spiridonov commented on KAFKA-16382: -- Any updates/estimations on

[jira] [Created] (KAFKA-16647) Remove setMetadataDirectory from BrokerNode/ControllerNode

2024-04-30 Thread Chia-Ping Tsai (Jira)
Chia-Ping Tsai created KAFKA-16647: -- Summary: Remove setMetadataDirectory from BrokerNode/ControllerNode Key: KAFKA-16647 URL: https://issues.apache.org/jira/browse/KAFKA-16647 Project: Kafka

[jira] [Assigned] (KAFKA-16646) Consider only running the CVE scanner action on apache/kafka and not in forks

2024-04-30 Thread Vedarth Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vedarth Sharma reassigned KAFKA-16646: -- Assignee: Vedarth Sharma > Consider only running the CVE scanner action on apache/kaf

[jira] [Commented] (KAFKA-16646) Consider only running the CVE scanner action on apache/kafka and not in forks

2024-04-30 Thread Vedarth Sharma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842297#comment-17842297 ] Vedarth Sharma commented on KAFKA-16646: Created a fix PR https://github.com/apa

[jira] [Commented] (KAFKA-16647) Remove setMetadataDirectory from BrokerNode/ControllerNode

2024-04-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842298#comment-17842298 ] Chia-Ping Tsai commented on KAFKA-16647: btw, this jira can remove the duplicate

Re: [PR] KAFKA-16572: allow defining number of disks per broker in ClusterTest [kafka]

2024-04-30 Thread via GitHub
FrankYang0529 commented on code in PR #15745: URL: https://github.com/apache/kafka/pull/15745#discussion_r1584379526 ## core/src/test/java/kafka/test/junit/ClusterTestExtensions.java: ## @@ -162,32 +162,39 @@ private void processClusterTest(ExtensionContext context, ClusterTest

Re: [PR] KAFKA-15588 ConfigCommandIntegrationTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on PR #15645: URL: https://github.com/apache/kafka/pull/15645#issuecomment-2084760582 @chia7712 Thank you for the review and merge! Will prepare next test of ConfigCommand for review shortly. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] KAFKA-14133: Move StreamTaskTest to Mockito [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #14716: URL: https://github.com/apache/kafka/pull/14716#discussion_r1584442796 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java: ## @@ -411,25 +394,32 @@ public void seek(final TopicPartition partition, fi

Re: [PR] KAFKA-16223: Migrate KafkaConfigBackingStoreTest to Mockito [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on PR #15381: URL: https://github.com/apache/kafka/pull/15381#issuecomment-2084846862 @mukkachaitanya Could you please fix the conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842319#comment-17842319 ] PoAn Yang commented on KAFKA-16506: --- Yeah, if version 2.8 commands are only in folder

Re: [PR] KAFKA-16223: Migrate KafkaConfigBackingStoreTest to Mockito [kafka]

2024-04-30 Thread via GitHub
mukkachaitanya commented on PR #15381: URL: https://github.com/apache/kafka/pull/15381#issuecomment-2084860037 This can be closed. @hgeraldino has closed this ticket via other PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
cadonna commented on PR #15640: URL: https://github.com/apache/kafka/pull/15640#issuecomment-2084906500 > > Here I have a comment, I could not put at the right location in the code: > > On line 1362, in `commitSync()` the consumer waits on the `commitFuture` with a timer. I think, it shou

[PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov opened a new pull request, #15832: URL: https://github.com/apache/kafka/pull/15832 This is second part of https://github.com/apache/kafka/pull/15417 refactoring. PR intention - split big PR in parts to simplify review. PR contains UserScramCredentialsCommandTest rewritten in j

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2084909110 Hello @chia7712 Can you, please, take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Created] (KAFKA-16648) Question: KIP-848 and KafkaTestKit.java

2024-04-30 Thread sanghyeok An (Jira)
sanghyeok An created KAFKA-16648: Summary: Question: KIP-848 and KafkaTestKit.java Key: KAFKA-16648 URL: https://issues.apache.org/jira/browse/KAFKA-16648 Project: Kafka Issue Type: Bug

[jira] [Commented] (KAFKA-16223) Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest

2024-04-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842328#comment-17842328 ] Chia-Ping Tsai commented on KAFKA-16223: It seems `KafkaConfigBackingStoreMockit

[jira] [Updated] (KAFKA-16648) Question: KIP-848 and KafkaTestKit.java

2024-04-30 Thread sanghyeok An (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] sanghyeok An updated KAFKA-16648: - Description: Hi, Kafka Team. I am writing test code for the new rebalancing protocol proposed in

[jira] [Comment Edited] (KAFKA-16223) Replace EasyMock and PowerMock with Mockito for KafkaConfigBackingStoreTest

2024-04-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842328#comment-17842328 ] Chia-Ping Tsai edited comment on KAFKA-16223 at 4/30/24 10:29 AM:

Re: [PR] KAFKA-16223: Migrate KafkaConfigBackingStoreTest to Mockito [kafka]

2024-04-30 Thread via GitHub
chia7712 closed pull request #15381: KAFKA-16223: Migrate KafkaConfigBackingStoreTest to Mockito URL: https://github.com/apache/kafka/pull/15381 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-30 Thread Chia-Ping Tsai (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842330#comment-17842330 ] Chia-Ping Tsai commented on KAFKA-16506: [~yangpoan] thanks for the check. pleas

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584553620 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584629877 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Resolved] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] PoAn Yang resolved KAFKA-16506. --- Resolution: Not A Problem Compare commands between 2.8 and trunk brand in folders core/src/main/sca

[jira] [Comment Edited] (KAFKA-16506) add the scala version of tool-related classes back to core module to follow KIP-906

2024-04-30 Thread PoAn Yang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842340#comment-17842340 ] PoAn Yang edited comment on KAFKA-16506 at 4/30/24 11:44 AM: -

Re: [PR] KAFKA-16588: broker shutdown hangs when log.segment.delete.delay.ms is zero [kafka]

2024-04-30 Thread via GitHub
FrankYang0529 commented on code in PR #15773: URL: https://github.com/apache/kafka/pull/15773#discussion_r1584662969 ## server-common/src/main/java/org/apache/kafka/server/config/ServerLogConfigs.java: ## @@ -86,7 +86,7 @@ public class ServerLogConfigs { public static fin

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-30 Thread via GitHub
FrankYang0529 commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1584677103 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -172,14 +179,16 @@ public boolean equals(Object object) { && Objects.equals(adminClien

Re: [PR] KAFKA-16484: Support to define per broker/controller property by ClusterConfigProperty [kafka]

2024-04-30 Thread via GitHub
brandboat commented on code in PR #15715: URL: https://github.com/apache/kafka/pull/15715#discussion_r1584685682 ## core/src/test/java/kafka/test/ClusterConfig.java: ## @@ -172,14 +179,16 @@ public boolean equals(Object object) { && Objects.equals(adminClientPro

[jira] [Assigned] (KAFKA-16513) Allow WriteTxnMarkers API with Alter Cluster Permission

2024-04-30 Thread Siddharth Yagnik (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16513?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siddharth Yagnik reassigned KAFKA-16513: Assignee: Siddharth Yagnik > Allow WriteTxnMarkers API with Alter Cluster Permiss

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584714610 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2085194654 @soarez Thanks for the valuable feedback. I create java version of waitUntilTrue method and used it in test. Please, take a look. -- This is an automated message from the Apache Git Se

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584811761 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1584853415 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] KAFKA-14509: [3/4] Add integration test for consumerGroupDescribe Api [kafka]

2024-04-30 Thread via GitHub
riedelmax commented on PR #15727: URL: https://github.com/apache/kafka/pull/15727#issuecomment-2085407284 @dajac part 4/4 would be to handle IncludeAuthorizedOperations in the request -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1584897939 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,332 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1584897939 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,332 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1584902357 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,332 @@ package org.apache.kafka.tools.consumer.group;

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1584929720 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,332 @@ package org.apache.kafka.tools.consumer.group;

[jira] [Commented] (KAFKA-16604) Deprecate ConfigDef.ConfigKey constructor from public APIs

2024-04-30 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842412#comment-17842412 ] Chris Egerton commented on KAFKA-16604: --- We don't necessarily have to deprecate an

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584946619 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,184 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on PR #15832: URL: https://github.com/apache/kafka/pull/15832#issuecomment-2085538452 @chia7712 All your comments resolved. Please, take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] KAFKA-14588 UserScramCredentialsCommandTest rewritten in java [kafka]

2024-04-30 Thread via GitHub
nizhikov commented on code in PR #15832: URL: https://github.com/apache/kafka/pull/15832#discussion_r1584953273 ## core/src/test/java/kafka/admin/UserScramCredentialsCommandTest.java: ## @@ -0,0 +1,178 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Commented] (KAFKA-16644) FK join emits duplicate tombstone on left-side delete

2024-04-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842417#comment-17842417 ] Matthias J. Sax commented on KAFKA-16644: - Thanks for the pointer. I did not hav

[jira] [Updated] (KAFKA-16645) CVEs in 3.7.0 docker image

2024-04-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16645: Fix Version/s: 3.8.0 3.7.1 > CVEs in 3.7.0 docker image > -

[jira] [Updated] (KAFKA-16645) CVEs in 3.7.0 docker image

2024-04-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-16645: Priority: Blocker (was: Major) > CVEs in 3.7.0 docker image > --

[jira] [Commented] (KAFKA-16645) CVEs in 3.7.0 docker image

2024-04-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842419#comment-17842419 ] Matthias J. Sax commented on KAFKA-16645: - I believe fixing these CVEs should be

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585005659 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585003046 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585003046 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Fo

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585004533 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEventReaper.java: ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (KAFKA-16382) Kafka Streams drop NULL values after reset

2024-04-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842423#comment-17842423 ] Matthias J. Sax commented on KAFKA-16382: - Not yet from our side... Working on o

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585035057 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1853,6 +1824,40 @@ private void subscribeInternal(Collection topic

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585083395 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection topi

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585091606 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection topi

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585035057 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1853,6 +1824,40 @@ private void subscribeInternal(Collection topic

Re: [PR] MINOR: Add replayRecords to CoordinatorResult [kafka]

2024-04-30 Thread via GitHub
dajac merged PR #15818: URL: https://github.com/apache/kafka/pull/15818 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-04-30 Thread via GitHub
lianetm commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1585152310 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1892,13 +1897,13 @@ private void subscribeInternal(Collection topi

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-30 Thread via GitHub
philipnee commented on PR #15723: URL: https://github.com/apache/kafka/pull/15723#issuecomment-2085841809 Hey sorry for the delay, the changes look good to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-30 Thread via GitHub
dajac commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1585155736 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/ConsumerGroup.java: ## @@ -966,6 +979,55 @@ private static void maybeUpdateSubscribedTopicN

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-30 Thread via GitHub
rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1585158392 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

Re: [PR] KAFKA-16615: JoinGroup API for upgrading ConsumerGroup [kafka]

2024-04-30 Thread via GitHub
dajac commented on PR #15798: URL: https://github.com/apache/kafka/pull/15798#issuecomment-2085866313 @dongnuo123 Be aware of https://github.com/apache/kafka/pull/15785. The PR changes code that you have refactored or reused in this one. We will need to adapt when we merge it. -- This is

Re: [PR] KAFKA-16587: Add subscription model information to group state [kafka]

2024-04-30 Thread via GitHub
rreddy-22 commented on code in PR #15785: URL: https://github.com/apache/kafka/pull/15785#discussion_r1585160959 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -1307,13 +1307,14 @@ private CoordinatorResult consumerGr

[PR] KAFKA-16647: Remove setMetadataDirectory from BrokerNode/ControllerNode [kafka]

2024-04-30 Thread via GitHub
brandboat opened a new pull request, #15833: URL: https://github.com/apache/kafka/pull/15833 related to https://issues.apache.org/jira/browse/KAFKA-16647 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and

Re: [PR] KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters [kafka]

2024-04-30 Thread via GitHub
C0urante commented on PR #14309: URL: https://github.com/apache/kafka/pull/14309#issuecomment-2085912341 @gharris1727 I've resolved the merge conflicts again; can you please take a look when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the m

Re: [PR] MINOR: Replaced Utils.join() with JDK API. [kafka]

2024-04-30 Thread via GitHub
chiacyu commented on code in PR #15823: URL: https://github.com/apache/kafka/pull/15823#discussion_r1585188342 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -584,27 +584,6 @@ public static String formatBytes(long bytes) { } } -/** -

Re: [PR] KAFKA-16555: Consumer's RequestState has incorrect logic to determine if inflight [kafka]

2024-04-30 Thread via GitHub
kirktrue commented on PR #15723: URL: https://github.com/apache/kafka/pull/15723#issuecomment-2086027819 Thanks everyone for the reviews and @lucasbru for the merge! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Commented] (KAFKA-16623) KafkaAsyncConsumer system tests warn about revoking partitions that weren't previously assigned

2024-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842453#comment-17842453 ] Kirk True commented on KAFKA-16623: --- If I add the following code to {{test_fencing_sta

[jira] [Updated] (KAFKA-16623) KafkaAsyncConsumer system tests warn about revoking partitions that weren't previously assigned

2024-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16623: -- Description: When running system tests for the KafkaAsyncConsumer, we occasionally see this warning:

[jira] [Updated] (KAFKA-16623) KafkaAsyncConsumer system tests warn about revoking partitions that weren't previously assigned

2024-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16623: -- Description: When running system tests for the KafkaAsyncConsumer, we occasionally see this warning:

Re: [PR] KAFKA-16000: Migrate MembershipManagerImplTest away from ConsumerTestBuilder [kafka]

2024-04-30 Thread via GitHub
kirktrue closed pull request #14950: KAFKA-16000: Migrate MembershipManagerImplTest away from ConsumerTestBuilder URL: https://github.com/apache/kafka/pull/14950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]

2024-04-30 Thread via GitHub
Alexander-Aghili closed pull request #15055: KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership URL: https://github.com/apache/kafka/pull/15055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

Re: [PR] KAFKA-16027: MINOR Refactor MetadataTest#testUpdatePartitionLeadership [kafka]

2024-04-30 Thread via GitHub
Alexander-Aghili commented on PR #15055: URL: https://github.com/apache/kafka/pull/15055#issuecomment-2086139400 Okay I messed up the git a little here (still have much to learn), the current trunk does exist on my Kafka-16027 branch but I had to redo it force push which led to auto-closing

[jira] [Assigned] (KAFKA-9401) High lock contention for kafka.server.FetchManager.newContext

2024-04-30 Thread Gaurav Narula (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gaurav Narula reassigned KAFKA-9401: Assignee: Gaurav Narula > High lock contention for kafka.server.FetchManager.newContext >

[PR] KAFKA-16307: fix coordinator thread idle ratio [kafka]

2024-04-30 Thread via GitHub
jeffkbkim opened a new pull request, #15835: URL: https://github.com/apache/kafka/pull/15835 This PR fixes the thread idle ratio. We take a similar approach to the kafka request handler idle ratio: https://github.com/apache/kafka/blob/trunk/core/src/main/scala/kafka/server/KafkaRequestHandl

Re: [PR] KAFKA-16307: fix coordinator thread idle ratio [kafka]

2024-04-30 Thread via GitHub
jeffkbkim commented on code in PR #15835: URL: https://github.com/apache/kafka/pull/15835#discussion_r1585255667 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/runtime/MultiThreadedEventProcessorTest.java: ## @@ -461,26 +459,30 @@ public void testMetrics()

[jira] [Updated] (KAFKA-16558) Implement HeartbeatRequestState.toStringBase()

2024-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16558?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16558: -- Priority: Minor (was: Major) > Implement HeartbeatRequestState.toStringBase() > -

[jira] [Updated] (KAFKA-16557) Fix OffsetFetchRequestState.toString()

2024-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16557: -- Priority: Minor (was: Major) > Fix OffsetFetchRequestState.toString() > -

[jira] [Commented] (KAFKA-16637) KIP-848 does not work well

2024-04-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842470#comment-17842470 ] Lianet Magrans commented on KAFKA-16637: Hey [~chickenchickenlove], just to rule

[jira] [Comment Edited] (KAFKA-16637) KIP-848 does not work well

2024-04-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842470#comment-17842470 ] Lianet Magrans edited comment on KAFKA-16637 at 4/30/24 6:10 PM: -

[jira] [Comment Edited] (KAFKA-16637) KIP-848 does not work well

2024-04-30 Thread Lianet Magrans (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842470#comment-17842470 ] Lianet Magrans edited comment on KAFKA-16637 at 4/30/24 6:10 PM: -

[PR] KAFKA-9401: Reduce contention for Fetch requests [kafka]

2024-04-30 Thread via GitHub
gaurav-narula opened a new pull request, #15836: URL: https://github.com/apache/kafka/pull/15836 KIP-227 introduced in-memory caching of FetchSessions. Brokers with a large number of Fetch requests suffer from contention on trying to acquire a lock on FetchSessionCache. This change a

Re: [PR] KAFKA-16593: Rewrite DeleteConsumerGroupsTest by ClusterTestExtensions [kafka]

2024-04-30 Thread via GitHub
chia7712 commented on code in PR #15766: URL: https://github.com/apache/kafka/pull/15766#discussion_r1585308784 ## tools/src/test/java/org/apache/kafka/tools/consumer/group/DeleteConsumerGroupsTest.java: ## @@ -17,279 +17,332 @@ package org.apache.kafka.tools.consumer.group;

[jira] [Updated] (KAFKA-16110) Implement consumer performance tests

2024-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16110: -- Priority: Major (was: Blocker) > Implement consumer performance tests > -

Re: [PR] KAFKA-9401: Reduce contention for Fetch requests [kafka]

2024-04-30 Thread via GitHub
gaurav-narula commented on PR #15836: URL: https://github.com/apache/kafka/pull/15836#issuecomment-2086478984 The following images show lock profiles collected using async-profiler before and after this change with numCacheShards = numIoThreads = 64 and demonstrates significant reduction in

Re: [PR] KAFKA-13328, KAFKA-13329 (2): Add custom preflight validation support for connector header, key, and value converters [kafka]

2024-04-30 Thread via GitHub
gharris1727 commented on code in PR #14309: URL: https://github.com/apache/kafka/pull/14309#discussion_r1585294415 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/AbstractHerder.java: ## @@ -655,27 +811,38 @@ private static ConfigInfos validateClientOverrides(S

[jira] [Updated] (KAFKA-16290) Investigate propagating subscription state updates via queues

2024-04-30 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16290?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk True updated KAFKA-16290: -- Priority: Major (was: Critical) > Investigate propagating subscription state updates via queues > ---

[jira] [Updated] (KAFKA-16110) Document and publicize performance test results for AsyncKafkaConsumer

2024-04-30 Thread Philip Nee (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-16110?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-16110: --- Summary: Document and publicize performance test results for AsyncKafkaConsumer (was: Implement con

  1   2   >