chia7712 commented on code in PR #15808:
URL: https://github.com/apache/kafka/pull/15808#discussion_r1584251393
##########
core/src/test/scala/unit/kafka/log/remote/RemoteIndexCacheTest.scala:
##########
@@ -321,16 +322,16 @@ class RemoteIndexCacheTest {
// Give the thread cleaner thread some time to throw an exception
Thread.sleep(100)
// Verify that Cleaner thread is still running even when exception is
thrown in doWork()
- var threads =
TestUtils.numThreadsRunning(REMOTE_LOG_INDEX_CACHE_CLEANER_THREAD, isDaemon =
true)
+ var threads = getRunningCleanerThread
assertEquals(1, threads.size,
- s"Found unexpected ${threads.size} threads=${threads.map(t =>
t.getName).mkString(", ")}")
+ s"Found unexpected ${threads.size} threads=${threads.stream().map(t =>
t.getName).collect(Collectors.joining(", "))}")
Review Comment:
nice job!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
