brandboat commented on code in PR #15715:
URL: https://github.com/apache/kafka/pull/15715#discussion_r1584685682
##########
core/src/test/java/kafka/test/ClusterConfig.java:
##########
@@ -172,14 +179,16 @@ public boolean equals(Object object) {
&& Objects.equals(adminClientProperties,
clusterConfig.adminClientProperties)
&& Objects.equals(saslServerProperties,
clusterConfig.saslServerProperties)
&& Objects.equals(saslClientProperties,
clusterConfig.saslClientProperties)
- && Objects.equals(perBrokerOverrideProperties,
clusterConfig.perBrokerOverrideProperties);
+ && Objects.equals(perBrokerOverrideProperties,
clusterConfig.perBrokerOverrideProperties)
+ && Objects.equals(perControllerOverrideProperties,
clusterConfig.perControllerOverrideProperties);
}
@Override
public int hashCode() {
return Objects.hash(type, brokers, controllers, name, autoStart,
securityProtocol, listenerName,
trustStoreFile, metadataVersion, serverProperties,
producerProperties, consumerProperties,
- adminClientProperties, saslServerProperties,
saslClientProperties, perBrokerOverrideProperties);
+ adminClientProperties, saslServerProperties,
saslClientProperties, perBrokerOverrideProperties,
+ perControllerOverrideProperties);
Review Comment:
> Do we need equals and hashCode, or we can just remove it?
Just remove it 😃 , as you already done in the pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
