clolov commented on code in PR #14716:
URL: https://github.com/apache/kafka/pull/14716#discussion_r1577406177
##
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamTaskTest.java:
##
@@ -293,17 +288,12 @@ public void cleanup() throws IOException {
dajac commented on code in PR #15721:
URL: https://github.com/apache/kafka/pull/15721#discussion_r1577407602
##
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java:
##
@@ -198,6 +207,43 @@ private static void assertApiMessageAndVersionEquals(
brandboat commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2074282565
Failed tests seems related to this pr, I'll check them later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
dajac commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1577437212
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundation (A
dajac commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2074307269
@jolshan Thanks for the PR. Is there a reason why you removed
[216cc9d](https://github.com/apache/kafka/pull/15755/commits/216cc9dce46b7837282bd67bfab06ec045c9902c)?
It does not apply 1:1 b
dajac commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1577450172
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
dajac commented on code in PR #15727:
URL: https://github.com/apache/kafka/pull/15727#discussion_r1577450806
##
core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala:
##
@@ -0,0 +1,175 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577491649
##
core/src/main/scala/kafka/server/SharedServer.scala:
##
@@ -107,16 +107,16 @@ class SharedServer(
@volatile var brokerMetrics: BrokerServerMetrics = _
@volati
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577499800
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577503137
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
[
https://issues.apache.org/jira/browse/KAFKA-15838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mario Fiore Vitale reassigned KAFKA-15838:
--
Assignee: Mario Fiore Vitale
> [Connect] ExtractField and InsertField NULL Va
frankvicky commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577504946
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupExecutor.java:
##
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
lucasbru closed pull request #15789: Current working branch for KIP-848 kip
URL: https://github.com/apache/kafka/pull/15789
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074488094
@chia7712 & @mimaison can you please have a look into this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
OmniaGM commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2074499876
> @johnnychhsu Instead of removing them, could you make `MetadataLogConfig`
use those help methods?
>
>
https://github.com/apache/kafka/blob/1b301b30207ed8fca9f0aea5cf940b0353a1abc
kamalcph commented on code in PR #15625:
URL: https://github.com/apache/kafka/pull/15625#discussion_r1577552070
##
core/src/main/java/kafka/log/remote/quota/RLMQuotaManagerConfig.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
showuon commented on PR #15616:
URL: https://github.com/apache/kafka/pull/15616#issuecomment-2074547860
Failed tests are unrelated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
showuon merged PR #15616:
URL: https://github.com/apache/kafka/pull/15616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-16424?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-16424.
---
Fix Version/s: 3.8.0
Resolution: Fixed
> truncated logs will be left undeleted after alter di
kamalcph closed pull request #15141: KAFKA-16073: [Tiered] Update
localLogStartOffset before deleting segments in memory t…
URL: https://github.com/apache/kafka/pull/15141
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
kamalcph commented on PR #15141:
URL: https://github.com/apache/kafka/pull/15141#issuecomment-2074558819
The patch is landed to trunk, 3.7 and 3.6 branches so closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
showuon merged PR #15787:
URL: https://github.com/apache/kafka/pull/15787
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577653920
##
core/src/main/scala/kafka/metrics/LinuxIoMetricsCollector.scala:
##
@@ -29,9 +29,9 @@ import scala.jdk.CollectionConverters._
*/
class LinuxIoMetricsCollector(pr
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577656938
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -347,7 +347,7 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577660497
##
core/src/main/scala/kafka/zookeeper/ZooKeeperClient.scala:
##
@@ -52,8 +51,8 @@ object ZooKeeperClient {
* @param sessionTimeoutMs session timeout in milliseconds
mimaison commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577677934
##
core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala:
##
@@ -2192,8 +2192,8 @@ class PlaintextAdminIntegrationTest extends
BaseAdminIntegr
chia7712 commented on code in PR #15786:
URL: https://github.com/apache/kafka/pull/15786#discussion_r1577684664
##
core/src/test/scala/unit/kafka/integration/KafkaServerTestHarness.scala:
##
@@ -347,7 +347,7 @@ abstract class KafkaServerTestHarness extends
QuorumTestHarness {
Chia-Ping Tsai created KAFKA-16610:
--
Summary: Replace "Map#entrySet#forEach" by "Map#forEach"
Key: KAFKA-16610
URL: https://issues.apache.org/jira/browse/KAFKA-16610
Project: Kafka
Issue Typ
Chia-Ping Tsai created KAFKA-16611:
--
Summary: Consider adding test name to "client.id" of Admin in
testing
Key: KAFKA-16611
URL: https://issues.apache.org/jira/browse/KAFKA-16611
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840392#comment-17840392
]
TengYao Chi commented on KAFKA-16610:
-
I can handle this issue :)
> Replace "Map#en
[
https://issues.apache.org/jira/browse/KAFKA-16610?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16610:
--
Assignee: TengYao Chi (was: Chia-Ping Tsai)
> Replace "Map#entrySet#forEach" by "Map
[
https://issues.apache.org/jira/browse/KAFKA-16483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16483.
Fix Version/s: 3.8.0
Resolution: Fixed
> Apply `ClusterTestExtensions` to
> Delete
chia7712 merged PR #15679:
URL: https://github.com/apache/kafka/pull/15679
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
Gantigmaa Selenge created KAFKA-16612:
-
Summary: Talking to controllers via AdminClient requires
reconfiguring controller listener
Key: KAFKA-16612
URL: https://issues.apache.org/jira/browse/KAFKA-16612
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16612:
-
Assignee: Luke Chen
> Talking to controllers via AdminClient requires reconfiguring controller
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-16612:
-
Assignee: (was: Luke Chen)
> Talking to controllers via AdminClient requires reconfiguring
[
https://issues.apache.org/jira/browse/KAFKA-16612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840402#comment-17840402
]
Luke Chen commented on KAFKA-16612:
---
[~cmccabe] , any thoughts about this?
> Talking
PoAn Yang created KAFKA-16613:
-
Summary: Remove TestUtils#subscribeAndWaitForRecords
Key: KAFKA-16613
URL: https://issues.apache.org/jira/browse/KAFKA-16613
Project: Kafka
Issue Type: Test
FrankYang0529 opened a new pull request, #15794:
URL: https://github.com/apache/kafka/pull/15794
After https://github.com/apache/kafka/pull/15679, we remove most of usage of
`TestUtils#subscribeAndWaitForRecords`. The only remaining case uses it is
`PlaintextAdminIntegrationTest#testDeleteC
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074832899
What about moving `KRaftConfig` to raft module? and we can moving all
configs from `RaftConfig` to `KRaftConfig`. With those changes, all
raft-related configs are in `KRaftConfig`. `Raft
chia7712 commented on PR #15762:
URL: https://github.com/apache/kafka/pull/15762#issuecomment-2074861414
I don't see any related failure, so I'm going to merge it to trunk and
branch 3.7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
[
https://issues.apache.org/jira/browse/KAFKA-16592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16592.
Fix Version/s: 3.8.0
Resolution: Fixed
> ConfigKey constructor update can break cli
chia7712 commented on PR #15761:
URL: https://github.com/apache/kafka/pull/15761#issuecomment-2074923817
@brandboat Could you rebase code to trigger QA again? I run those tests on
my local. They pass
--
This is an automated message from the Apache Git Service.
To respond to the message, p
chia7712 commented on code in PR #15766:
URL: https://github.com/apache/kafka/pull/15766#discussion_r1577874954
##
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerRunnable.java:
##
@@ -0,0 +1,113 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
[
https://issues.apache.org/jira/browse/KAFKA-15749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840439#comment-17840439
]
Walter Hernandez commented on KAFKA-15749:
--
PR is officially stale: [https://gi
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2074952186
> > Note: We have already RaftConfig but it seems to contain limited amount
of configs that only configure controller raft and shouldn't include configs
shared by both broker/controller i
johnnychhsu commented on PR #15788:
URL: https://github.com/apache/kafka/pull/15788#issuecomment-2075021540
thanks for the review and suggestions @chia7712 @OmniaGM
let me check and address it
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-15203:
---
Assignee: Owen C.H. Leung
> Remove dependency on Reflections
> ---
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075082750
> Personally I think the first option (which keep the pr as it is) is easier
to navigate as we know where all the config used by Kafka Raft server (maybe
renaming this to KafkaRaftServer
[
https://issues.apache.org/jira/browse/KAFKA-15203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen C.H. Leung reassigned KAFKA-15203:
---
Assignee: (was: Owen C.H. Leung)
> Remove dependency on Reflections
>
mumrah commented on code in PR #15754:
URL: https://github.com/apache/kafka/pull/15754#discussion_r1577997204
##
tests/kafkatest/services/kafka/kafka.py:
##
@@ -463,6 +463,18 @@ def reconfigure_zk_for_migration(self, kraft_quorum):
# This is not added to "advertised.lis
mumrah commented on code in PR #15754:
URL: https://github.com/apache/kafka/pull/15754#discussion_r1577998958
##
tests/kafkatest/tests/core/zookeeper_migration_test.py:
##
@@ -86,10 +87,35 @@ def do_migration(self, roll_controller = False,
downgrade_to_zk = False):
chia7712 merged PR #15793:
URL: https://github.com/apache/kafka/pull/15793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840469#comment-17840469
]
Igor Soarez commented on KAFKA-16606:
-
I'm inclined to agree, I think we can still d
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Igor Soarez reopened KAFKA-16606:
-
Assignee: Igor Soarez
> JBOD support in KRaft does not seem to be gated by the metadata versio
chia7712 commented on PR #15791:
URL: https://github.com/apache/kafka/pull/15791#issuecomment-2075129365
not sure whether we have 3.6.3 release. It seems we don't have `.3` usually
:)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075131518
> just curios. Why moving to raft module can cause circle dependencies?
Currently raft doesn't depend of core or server but I just fear that mixing
quorum raft and KRaft mode related cl
chia7712 merged PR #15792:
URL: https://github.com/apache/kafka/pull/15792
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840472#comment-17840472
]
Jakub Scholz commented on KAFKA-16606:
--
Ok, thanks [~soarez] and [~mimaison].
> JB
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075158081
> If we start to move related kraft classes to raft module like
KafkaRaftManager this will be tricky as now
org.apache.kafka.raft.KafkaRaftManager needs
org.apache.kafka.server.config.K
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578074445
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578074445
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578083329
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
rreddy-22 commented on code in PR #15717:
URL: https://github.com/apache/kafka/pull/15717#discussion_r1578083329
##
jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/ServerSideAssignorBenchmark.java:
##
@@ -0,0 +1,281 @@
+/*
+ * Licensed to the Apache Software Foundatio
chia7712 commented on PR #15696:
URL: https://github.com/apache/kafka/pull/15696#issuecomment-2075243743
> Thanks for the reply. I have tried the following code and received the
results. Each time I run the code, the DescribeTopicsResult gives a different
configurations of the brokers in my
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075270699
> > If we start to move related kraft classes to raft module like
KafkaRaftManager this will be tricky as now
org.apache.kafka.raft.KafkaRaftManager needs
org.apache.kafka.server.config.
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075295917
> KafkaConfig will move out of core and into server, however, for the time
being I don't plan to make raft depend on server for now as far as I can see
the only case I might need to do s
[
https://issues.apache.org/jira/browse/KAFKA-15743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Proven Provenzano reopened KAFKA-15743:
---
The {{registerBroker}} function in this test file needs to use the directory
UUIDs assi
[
https://issues.apache.org/jira/browse/KAFKA-16217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840502#comment-17840502
]
Calvin Liu commented on KAFKA-16217:
[~kirktrue] The cherry-pick for the 3.7 is merg
jolshan commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075323626
Hey @dajac thanks for taking a look. We didn't include
https://github.com/apache/kafka/commit/a8203f9c7a2c449ee59ee29d775409b2f1e00d07
in 3.7 so I feel like adding this code is extraneou
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075340243
> I don't think we should merge them with RaftConfig as RaftConfig should be
separate as it is only for the quorum raft and not KRAFT mode which are a bit
different in my option.
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075356299
> It seems org.apache.kafka.raft.KafkaRaftManager needs
org.apache.kafka.server.config.KafkaConfig won't happen if the 5 getters are
moved, right?
Sorry I maybe wan't clear `org.ap
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075357578
> Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
This is good point, maybe this can be a followup PR
--
This is an automated
dajac commented on PR #15755:
URL: https://github.com/apache/kafka/pull/15755#issuecomment-2075368110
@jolshan That makes sense. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
chia7712 commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075392820
>> Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
> This is good point, maybe this can be a followup PR
After renaming
CalvinConfluent commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578296803
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -402,6 +412,30 @@ public synchronized void maybeAddPartition
CalvinConfluent commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578298683
##
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##
@@ -109,7 +109,7 @@ class AddPartitionsToTxnManager(
.setTransactionalId(transa
CalvinConfluent commented on PR #15657:
URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075521654
@jolshan Updated the PR
1. Reverted the KafkaApi changes. Now if the produce request with the
TransactionV2 supported version, the server will process it no matter what
Transac
jolshan commented on PR #15657:
URL: https://github.com/apache/kafka/pull/15657#issuecomment-2075537428
Thanks @CalvinConfluent I will try to take a look sometime today 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
chia7712 merged PR #15794:
URL: https://github.com/apache/kafka/pull/15794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache
[
https://issues.apache.org/jira/browse/KAFKA-16613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved KAFKA-16613.
Fix Version/s: 3.8.0
Resolution: Fixed
> Remove TestUtils#subscribeAndWaitForRecord
mimaison commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2075580384
It looks like the previous CI build had an issue with the Java 8/Scala 2.12
pipeline. I rekicked a build.
--
This is an automated message from the Apache Git Service.
To respond to the
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578346148
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -979,6 +1013,13 @@ void handleCoordinatorReady() {
jolshan commented on code in PR #15657:
URL: https://github.com/apache/kafka/pull/15657#discussion_r1578348187
##
clients/src/main/java/org/apache/kafka/common/requests/ProduceRequest.java:
##
@@ -40,6 +40,7 @@
import static org.apache.kafka.common.requests.ProduceResponse.INVA
TaiJuWu opened a new pull request, #15796:
URL: https://github.com/apache/kafka/pull/15796
As title
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (includi
OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075595461
> > > Maybe we should rename RaftConfig to QuorumConfig as all configs in
QuorumConfig have prefix QUORUM_
>
> > This is good point, maybe this can be a followup PR
>
> After
OmniaGM opened a new pull request, #15797:
URL: https://github.com/apache/kafka/pull/15797
For context
https://github.com/apache/kafka/pull/15775#issuecomment-2075340243
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify
chia7712 commented on PR #15786:
URL: https://github.com/apache/kafka/pull/15786#issuecomment-2075606243
> It looks like the previous CI build had an issue with the Java 8/Scala
2.12 pipeline. I rekicked a build.
oh, I rekicked it too :_
--
This is an automated message from the Apa
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
Chia-Ping Tsai created KAFKA-16614:
--
Summary: Disallow `@ClusterTemplate("")`
Key: KAFKA-16614
URL: https://issues.apache.org/jira/browse/KAFKA-16614
Project: Kafka
Issue Type: Improvement
lianetm commented on code in PR #15737:
URL: https://github.com/apache/kafka/pull/15737#discussion_r1578381540
##
tests/kafkatest/services/verifiable_consumer.py:
##
@@ -140,22 +150,32 @@ class
IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
def __init__(s
[
https://issues.apache.org/jira/browse/KAFKA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17840545#comment-17840545
]
TaiJuWu commented on KAFKA-16614:
-
Hello [~chia7712] , Could you assign this ticket to m
[
https://issues.apache.org/jira/browse/KAFKA-16614?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai reassigned KAFKA-16614:
--
Assignee: TaiJuWu (was: Chia-Ping Tsai)
> Disallow `@ClusterTemplate("")`
>
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
lianetm commented on code in PR #15778:
URL: https://github.com/apache/kafka/pull/15778#discussion_r1578363393
##
tests/kafkatest/tests/client/consumer_test.py:
##
@@ -242,16 +242,15 @@ def test_static_consumer_bounce(self, clean_shutdown,
static_membership, bounce_
Dongnuo Lyu created KAFKA-16615:
---
Summary: JoinGroup API for upgrading ConsumerGroup
Key: KAFKA-16615
URL: https://issues.apache.org/jira/browse/KAFKA-16615
Project: Kafka
Issue Type: Sub-task
chia7712 commented on code in PR #15797:
URL: https://github.com/apache/kafka/pull/15797#discussion_r1578498362
##
raft/src/main/java/org/apache/kafka/raft/QuorumConfigs.java:
##
@@ -47,7 +47,7 @@
* controller should be able to transition from standby to active without
reload
kirktrue opened a new pull request, #15799:
URL: https://github.com/apache/kafka/pull/15799
The format of the 'describe topic' output was changed as part of KAFKA-15585
which required an update in the parsing logic used by system tests.
### Committer Checklist (excluded from commit me
1 - 100 of 129 matches
Mail list logo
