OmniaGM commented on PR #15775:
URL: https://github.com/apache/kafka/pull/15775#issuecomment-2075356299

   > It seems org.apache.kafka.raft.KafkaRaftManager needs 
org.apache.kafka.server.config.KafkaConfig won't happen if the 5 getters are 
moved, right?
   
   Sorry I maybe wan't clear `org.apache.kafka.raft.KafkaRaftManage` this was 
an example for depend circle if we start to move quorum raft and Kraft code 
into `raft` module.  `KafkaRaftManage` at the moment is in core under 
`kafka.raft` package and not `raft` module and it need `KafkaConfig` to 
initialise `org.apache.kafka.raft.RaftConfig` (which is waiting for 
`AbstractConfig` and not `KafkaConfig` and to access the following getters 
`nodeId`, `ProcessRoles`, `metadataLogDir`, `quorumRequestTimeoutMs`, 
`controllerListenerNames`, `saslMechanismControllerProtocol`, 
`saslInterBrokerHandshakeRequestEnable`. 
   
   In the future if we decided to move `kafka.raft.KafkaRaftManage` it is most 
likely going to be moved into server and not raft


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to