OmniaGM commented on PR #15788: URL: https://github.com/apache/kafka/pull/15788#issuecomment-2074499876
> @johnnychhsu Instead of removing them, could you make `MetadataLogConfig` use those help methods? > > https://github.com/apache/kafka/blob/1b301b30207ed8fca9f0aea5cf940b0353a1abca/core/src/main/scala/kafka/MetadataLogConfig.scala#L38 This change also need to change `MetadataLogConfig` signature to use `KafkaConfig` instead of `AbstractConfig`. Which we actually do pass `KafkaConfig` in `KafkaRaftManager::buildMetadataLog` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
