[GitHub] [kafka] yashmayya opened a new pull request, #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API

2023-05-02 Thread via GitHub
yashmayya opened a new pull request, #13657: URL: https://github.com/apache/kafka/pull/13657 - Adds documentation for the new `PUT /connectors/{name}/stop` REST API for Connect (see [KIP-875](https://cwiki.apache.org/confluence/display/KAFKA/KIP-875%3A+First-class+offsets+support+in+Kafka+C

[jira] [Commented] (KAFKA-14876) Public documentation for new Kafka Connect offset management REST APIs in 3.5

2023-05-02 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718464#comment-17718464 ] Yash Mayya commented on KAFKA-14876: [~gharris1727] [~ChrisEgerton] sounds good, I'v

[GitHub] [kafka] yashmayya commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API

2023-05-02 Thread via GitHub
yashmayya commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182174568 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET /co

[GitHub] [kafka] showuon commented on pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

2023-05-02 Thread via GitHub
showuon commented on PR #13514: URL: https://github.com/apache/kafka/pull/13514#issuecomment-1531036253 @fvaleri , there is checkstyle failure. Could you fix it? ``` Execution failed for task ':examples:checkstyleMain'. ``` -- This is an automated message from the Apache Git S

[jira] [Updated] (KAFKA-14876) Public documentation for new Kafka Connect offset management REST APIs in 3.5

2023-05-02 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14876?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-14876: --- Description: Add public documentation for the new Kafka Connect REST APIs from [KIP-875|https://cwi

[GitHub] [kafka] fvaleri commented on pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

2023-05-02 Thread via GitHub
fvaleri commented on PR #13514: URL: https://github.com/apache/kafka/pull/13514#issuecomment-1531090993 Hi @showuon, I missed that. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1182279902 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1160,48 +1171,100 @@ class ReplicaManager(val config: KafkaConfig, fetchPartitionStatus

[GitHub] [kafka] showuon commented on pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

2023-05-02 Thread via GitHub
showuon commented on PR #13514: URL: https://github.com/apache/kafka/pull/13514#issuecomment-1531149504 Thanks for the update. I'll merge it after CI build completed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (KAFKA-14946) KRaft Node Shutting down while

2023-05-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14946: -- Summary: KRaft Node Shutting down while (was: Kafka Node Shutting Down Automatically) > KRaft Node

[jira] [Updated] (KAFKA-14946) KRaft Node Shutting down while renouncing leadership

2023-05-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14946: -- Summary: KRaft Node Shutting down while renouncing leadership (was: KRaft Node Shutting down while )

[jira] [Updated] (KAFKA-14946) KRaft controller node shutting down while renouncing leadership

2023-05-02 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14946?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-14946: -- Summary: KRaft controller node shutting down while renouncing leadership (was: KRaft Node Shutting do

[jira] [Created] (KAFKA-14953) Add metrics for expiration of delayed remote fetch

2023-05-02 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14953: Summary: Add metrics for expiration of delayed remote fetch Key: KAFKA-14953 URL: https://issues.apache.org/jira/browse/KAFKA-14953 Project: Kafka Issue Type

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1182326466 ## core/src/main/scala/kafka/server/DelayedRemoteFetch.scala: ## @@ -0,0 +1,112 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

[jira] [Created] (KAFKA-14954) Use BufferPools to optimize allocation in RemoteLogInputStream

2023-05-02 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14954: Summary: Use BufferPools to optimize allocation in RemoteLogInputStream Key: KAFKA-14954 URL: https://issues.apache.org/jira/browse/KAFKA-14954 Project: Kafka

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1182330923 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +622,208 @@ public String toString() { } } -long findHighestRemoteOf

[GitHub] [kafka] showuon commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-05-02 Thread via GitHub
showuon commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1182330077 ## clients/src/test/java/org/apache/kafka/common/utils/ByteUtilsTest.java: ## @@ -241,6 +244,119 @@ public void testDouble() throws IOException { assertDoubleS

[GitHub] [kafka] Hangleton commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-02 Thread via GitHub
Hangleton commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1182338603 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -595,6 +609,193 @@ public void run() { } } +public void handleLogS

[GitHub] [kafka] Hangleton commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-02 Thread via GitHub
Hangleton commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1182338603 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -595,6 +609,193 @@ public void run() { } } +public void handleLogS

[GitHub] [kafka] Hangleton commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
Hangleton commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1180448490 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -600,25 +622,208 @@ public String toString() { } } -long findHighestRemoteOffs

[GitHub] [kafka] sambhav-jain-16 commented on pull request #13646: KAFKA-14938: Fixing flaky test testConnectorBoundary

2023-05-02 Thread via GitHub
sambhav-jain-16 commented on PR #13646: URL: https://github.com/apache/kafka/pull/13646#issuecomment-1531223773 hi @vamossagar12 > For starters, can you try increasing CONSUME_RECORDS_TIMEOUT_MS to 100s or as such and see if it even works? Actually I tried it and it failed for me

[jira] [Commented] (KAFKA-14947) Duplicate records are getting created in the topic.

2023-05-02 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718513#comment-17718513 ] Yash Mayya commented on KAFKA-14947: [~krishnendudas] the offset commits for source

[GitHub] [kafka] Hangleton commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-02 Thread via GitHub
Hangleton commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1182338603 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -595,6 +609,193 @@ public void run() { } } +public void handleLogS

[GitHub] [kafka] Hangleton commented on a diff in pull request #13561: KAFKA-14888: Added remote log segments retention functionality based on time and size.

2023-05-02 Thread via GitHub
Hangleton commented on code in PR #13561: URL: https://github.com/apache/kafka/pull/13561#discussion_r1182338603 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -595,6 +609,193 @@ public void run() { } } +public void handleLogS

[GitHub] [kafka] dajac merged pull request #13652: Cherry pick KAFKA-14639

2023-05-02 Thread via GitHub
dajac merged PR #13652: URL: https://github.com/apache/kafka/pull/13652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[jira] [Updated] (KAFKA-14639) Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance cycle

2023-05-02 Thread David Jacot (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-14639: Fix Version/s: 3.4.1 > Kafka CooperativeStickyAssignor revokes/assigns partition in one rebalance

[GitHub] [kafka] dajac commented on pull request #13550: KAFKA-14639: A single partition may be revoked and assign during a single round of rebalance

2023-05-02 Thread via GitHub
dajac commented on PR #13550: URL: https://github.com/apache/kafka/pull/13550#issuecomment-1531331123 Merged https://github.com/apache/kafka/pull/13652 to 3.4. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1182398774 ## core/src/main/java/kafka/log/remote/RemoteLogManager.java: ## @@ -670,6 +875,14 @@ public void close() { } catch (InterruptedException e) {

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182450145 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182451755 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] cadonna merged pull request #13529: KAFKA-14133: Migrate topology builder mock in TaskManagerTest to mockito

2023-05-02 Thread via GitHub
cadonna merged PR #13529: URL: https://github.com/apache/kafka/pull/13529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182452889 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,698 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] cadonna commented on pull request #13621: KAFKA-14133: Migrate ChangeLogReader mock in TaskManagerTest to Mockito

2023-05-02 Thread via GitHub
cadonna commented on PR #13621: URL: https://github.com/apache/kafka/pull/13621#issuecomment-1531348081 @clolov Thanks for the updates! I just merged https://github.com/apache/kafka/pull/13529. Could you please rebase this PR? -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182453174 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182455767 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilderTest.java: ## @@ -0,0 +1,698 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13312: KAFKA-14766: Improve performance of VarInt encoding and decoding

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13312: URL: https://github.com/apache/kafka/pull/13312#discussion_r1182456902 ## clients/src/test/java/org/apache/kafka/common/utils/ByteUtilsTest.java: ## @@ -241,6 +244,119 @@ public void testDouble() throws IOException { assertDou

[GitHub] [kafka] dajac commented on pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on PR #13637: URL: https://github.com/apache/kafka/pull/13637#issuecomment-1531356888 @jeffkbkim I have addressed your comments. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] showuon commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

2023-05-02 Thread via GitHub
showuon commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1182450255 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -534,5 +421,157 @@ public void testSkipWaitForBrokersInDualWrite() th

[GitHub] [kafka] showuon commented on pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

2023-05-02 Thread via GitHub
showuon commented on PR #13514: URL: https://github.com/apache/kafka/pull/13514#issuecomment-1531392005 Failed tests are unrelated: ``` Build / JDK 8 and Scala 2.12 / org.apache.kafka.connect.integration.ExactlyOnceSourceIntegrationTest.testConnectorBoundary Build / JDK 8 an

[GitHub] [kafka] showuon merged pull request #13514: KAFKA-14752: Kafka examples improvements - consumer changes

2023-05-02 Thread via GitHub
showuon merged PR #13514: URL: https://github.com/apache/kafka/pull/13514 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] dajac commented on a diff in pull request #13644: KAFKA-14500; [1/N] Rewrite MemberMetadata in Java

2023-05-02 Thread via GitHub
dajac commented on code in PR #13644: URL: https://github.com/apache/kafka/pull/13644#discussion_r1182474216 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/generic/GenericGroupMember.java: ## @@ -0,0 +1,560 @@ +/** + * Licensed to the Apache Software Found

[GitHub] [kafka] Hangleton commented on a diff in pull request #13535: KAFKA-9579 Fetch implementation for records in the remote storage through a specific purgatory.

2023-05-02 Thread via GitHub
Hangleton commented on code in PR #13535: URL: https://github.com/apache/kafka/pull/13535#discussion_r1182493022 ## core/src/main/scala/kafka/server/ReplicaManager.scala: ## @@ -1160,48 +1171,100 @@ class ReplicaManager(val config: KafkaConfig, fetchPartitionStatus +=

[GitHub] [kafka] tinaselenge opened a new pull request, #13658: KAFKA-14669: Use the generated docs for MirrorMaker configs in the doc

2023-05-02 Thread via GitHub
tinaselenge opened a new pull request, #13658: URL: https://github.com/apache/kafka/pull/13658 Currently all three generated docs for MirrorMaker contain fields from BASE_CONNECTOR_CONFIG_DEF which results in duplicated fields when using them in the doc. This PR separates BASE_CONNECTOR_CON

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-02 Thread via GitHub
clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1182518605 ## tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] clolov commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-02 Thread via GitHub
clolov commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1182519045 ## tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java: ## @@ -0,0 +1,83 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [kafka] clolov commented on pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-02 Thread via GitHub
clolov commented on PR #13122: URL: https://github.com/apache/kafka/pull/13122#issuecomment-1531443138 Heya @mimaison, thank you for the review! I have updated the assertions to be more precise. I wanted to avoid creating a whole new POJO to turn the String into a navigable map, but if you

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182536794 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { in

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182552980 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { in

[GitHub] [kafka] divijvaidya commented on pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on PR #13623: URL: https://github.com/apache/kafka/pull/13623#issuecomment-1531493129 @mimaison when you get a chance, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
jeffkbkim commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182592483 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] machi1990 commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
machi1990 commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182592921 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { info

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
jeffkbkim commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182594976 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Softw

[GitHub] [kafka] splett2 commented on pull request #13655: MINOR: Reduce number of threads created for integration test brokers

2023-05-02 Thread via GitHub
splett2 commented on PR #13655: URL: https://github.com/apache/kafka/pull/13655#issuecomment-1531539359 @showuon not explicitly. I was hoping it would reduce some of the CI job resource utilization. -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [kafka] dajac commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
dajac commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182595446 ## core/src/test/scala/unit/kafka/log/LogCleanerTest.scala: ## @@ -62,6 +65,33 @@ class LogCleanerTest { Utils.delete(tmpdir) } + @Test + def testRemoveMetric

[GitHub] [kafka] fvaleri commented on pull request #13492: KAFKA-14752: Kafka examples improvements

2023-05-02 Thread via GitHub
fvaleri commented on PR #13492: URL: https://github.com/apache/kafka/pull/13492#issuecomment-1531544193 This PR was broken into multiple reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [kafka] fvaleri closed pull request #13492: KAFKA-14752: Kafka examples improvements

2023-05-02 Thread via GitHub
fvaleri closed pull request #13492: KAFKA-14752: Kafka examples improvements URL: https://github.com/apache/kafka/pull/13492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182598786 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182599075 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] dajac commented on a diff in pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac commented on code in PR #13637: URL: https://github.com/apache/kafka/pull/13637#discussion_r1182598786 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/consumer/TargetAssignmentBuilder.java: ## @@ -0,0 +1,327 @@ +/* + * Licensed to the Apache Software

[GitHub] [kafka] mumrah commented on a diff in pull request #13461: KAFKA-14840: Support for snapshots during ZK migration

2023-05-02 Thread via GitHub
mumrah commented on code in PR #13461: URL: https://github.com/apache/kafka/pull/13461#discussion_r1182705187 ## metadata/src/test/java/org/apache/kafka/metadata/migration/KRaftMigrationDriverTest.java: ## @@ -534,5 +421,157 @@ public void testSkipWaitForBrokersInDualWrite() thr

[jira] [Created] (KAFKA-14955) Validate that all partitions are assigned in TargetAssignmentBuilder

2023-05-02 Thread David Jacot (Jira)
David Jacot created KAFKA-14955: --- Summary: Validate that all partitions are assigned in TargetAssignmentBuilder Key: KAFKA-14955 URL: https://issues.apache.org/jira/browse/KAFKA-14955 Project: Kafka

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182715489 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -124,29 +124,37 @@ class LogCleaner(initialConfig: CleanerConfig, private def maxOverCleanerThreads(f: C

[GitHub] [kafka] rreddy-22 commented on a diff in pull request #13443: KAFKA-14514: Add Range Assignor on the Server (KIP-848)

2023-05-02 Thread via GitHub
rreddy-22 commented on code in PR #13443: URL: https://github.com/apache/kafka/pull/13443#discussion_r1182715705 ## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/RangeAssignorTest.java: ## @@ -0,0 +1,574 @@ +/* + * Licensed to the Apache Software Fo

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
divijvaidya commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182721302 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { in

[jira] [Created] (KAFKA-14956) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest#testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted

2023-05-02 Thread Sagar Rao (Jira)
Sagar Rao created KAFKA-14956: - Summary: Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest#testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted Key: KAFKA-14956 URL: https://issues.apache.o

[GitHub] [kafka] mimaison merged pull request #13259: MINOR: Remove accidental unnecessary code in src

2023-05-02 Thread via GitHub
mimaison merged PR #13259: URL: https://github.com/apache/kafka/pull/13259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182730958 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET /con

[GitHub] [kafka] mimaison commented on a diff in pull request #13122: KAFKA-14594: Move LogDirsCommand to tools module

2023-05-02 Thread via GitHub
mimaison commented on code in PR #13122: URL: https://github.com/apache/kafka/pull/13122#discussion_r1182729223 ## tools/src/test/java/org/apache/kafka/tools/LogDirsCommandTest.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182739254 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET /con

[GitHub] [kafka] dajac merged pull request #13637: KAFKA-14462; [10/N] Add TargetAssignmentBuilder

2023-05-02 Thread via GitHub
dajac merged PR #13637: URL: https://github.com/apache/kafka/pull/13637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] yashmayya commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
yashmayya commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182756093 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET /co

[GitHub] [kafka] yashmayya commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
yashmayya commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182756093 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET /co

[jira] [Assigned] (KAFKA-14956) Flaky test org.apache.kafka.connect.integration.OffsetsApiIntegrationTest#testGetSinkConnectorOffsetsDifferentKafkaClusterTargeted

2023-05-02 Thread Yash Mayya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14956?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya reassigned KAFKA-14956: -- Assignee: Yash Mayya > Flaky test > org.apache.kafka.connect.integration.OffsetsApiIntegrati

[jira] [Updated] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-05-02 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14661: - Fix Version/s: 3.6.0 > Upgrade Zookeeper to 3.8.1 > --- > >

[jira] [Commented] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-05-02 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718640#comment-17718640 ] Divij Vaidya commented on KAFKA-14661: -- Adding targeted fix version to 3.6.0. The K

[GitHub] [kafka] mjsax commented on pull request #13654: HOTFIX: fix broken Streams upgrade system test

2023-05-02 Thread via GitHub
mjsax commented on PR #13654: URL: https://github.com/apache/kafka/pull/13654#issuecomment-1531777179 Same issue. Trying again: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/5655/ -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] mjsax commented on a diff in pull request #13656: KAFKA-14911: Add system tests for rolling upgrade path of KIP-904

2023-05-02 Thread via GitHub
mjsax commented on code in PR #13656: URL: https://github.com/apache/kafka/pull/13656#discussion_r1182064875 ## streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java: ## @@ -126,7 +130,7 @@ static void generatePerpetually(final String kafka, data

[GitHub] [kafka] kirktrue commented on pull request #13640: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-05-02 Thread via GitHub
kirktrue commented on PR #13640: URL: https://github.com/apache/kafka/pull/13640#issuecomment-1531804943 @mimaison Would you be willing to merge this change? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182800168 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +1035,23 @@ private void transitionTo(State target) {

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182800998 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -263,7 +263,14 @@ public void run() { while (!forceClose && transactio

[GitHub] [kafka] kirktrue commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182801453 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/TransactionManagerTest.java: ## @@ -3405,6 +3406,52 @@ MAX_REQUEST_SIZE, ACKS_ALL, MAX_RETRIES, ne

[GitHub] [kafka] mimaison commented on pull request #13640: KAFKA-14937: Refactoring for client code to reduce boilerplate

2023-05-02 Thread via GitHub
mimaison commented on PR #13640: URL: https://github.com/apache/kafka/pull/13640#issuecomment-1531813505 @kirktrue I'm looking at it now. With this PR I consistently get failures with the following tests: ``` SslAdminIntegrationTest.testAclUpdatesUsingAsynchronousAuthorizer() SslAdm

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182805033 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ## @@ -263,7 +263,14 @@ public void run() { while (!forceClose && transaction

[GitHub] [kafka] jolshan commented on a diff in pull request #13591: KAFKA-14831: Illegal state errors should be fatal in transactional producer

2023-05-02 Thread via GitHub
jolshan commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182805477 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -968,13 +1035,23 @@ private void transitionTo(State target) { }

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182806166 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET /con

[GitHub] [kafka] C0urante commented on a diff in pull request #13657: KAFKA-14876: Document the new 'PUT /connectors/{name}/stop' REST API for Connect

2023-05-02 Thread via GitHub
C0urante commented on code in PR #13657: URL: https://github.com/apache/kafka/pull/13657#discussion_r1182806166 ## docs/connect.html: ## @@ -301,7 +301,8 @@ REST API GET /connectors/{name}/tasks - get a list of tasks currently running for a connector GET /con

[jira] [Created] (KAFKA-14957) Default value for state.dir is confusing

2023-05-02 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14957: -- Summary: Default value for state.dir is confusing Key: KAFKA-14957 URL: https://issues.apache.org/jira/browse/KAFKA-14957 Project: Kafka Issue Type: Bug

[GitHub] [kafka] cmccabe commented on a diff in pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

2023-05-02 Thread via GitHub
cmccabe commented on code in PR #13653: URL: https://github.com/apache/kafka/pull/13653#discussion_r1182836931 ## server-common/src/main/java/org/apache/kafka/timeline/SnapshottableHashTable.java: ## @@ -113,7 +113,7 @@ public void mergeFrom(long epoch, Delta source) {

[GitHub] [kafka] cmccabe commented on pull request #13653: KAFKA-14946: fix NPE when merging the deltatable

2023-05-02 Thread via GitHub
cmccabe commented on PR #13653: URL: https://github.com/apache/kafka/pull/13653#issuecomment-1531861352 Thanks, this is a very good find, @showuon ! We've been seeing this NPE occassionally but never found out where it was coming from. I left a correction, take a look -- This is an

[jira] [Updated] (KAFKA-14916) Fix code that assumes transactional ID implies all records are transactional

2023-05-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14916: --- Description: KAFKA-14561 wrote code that assumed that if a transactional ID was included, a

[jira] [Created] (KAFKA-14958) Investigate enforcing all batches have the same producer ID

2023-05-02 Thread Justine Olshan (Jira)
Justine Olshan created KAFKA-14958: -- Summary: Investigate enforcing all batches have the same producer ID Key: KAFKA-14958 URL: https://issues.apache.org/jira/browse/KAFKA-14958 Project: Kafka

[jira] [Updated] (KAFKA-14916) Fix code that assumes transactional ID implies all records are transactional

2023-05-02 Thread Justine Olshan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Justine Olshan updated KAFKA-14916: --- Description: KAFKA-14561 wrote code that assumed that if a transactional ID was included, a

[jira] [Created] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
Manyanda Chitimbo created KAFKA-14959: - Summary: Remove metrics on ClientQuota Managers shutdown Key: KAFKA-14959 URL: https://issues.apache.org/jira/browse/KAFKA-14959 Project: Kafka Iss

[jira] [Assigned] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo reassigned KAFKA-14959: - Assignee: (was: Divij Vaidya) > Remove metrics on ClientQuota Managers shut

[jira] [Updated] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo updated KAFKA-14959: -- Description: We register metrics in ClientQuotaManager.scala and its child classes but

[jira] [Updated] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo updated KAFKA-14959: -- Fix Version/s: (was: 3.6.0) > Remove metrics on ClientQuota Managers shutdown > --

[GitHub] [kafka] machi1990 commented on a diff in pull request #13623: KAFKA-14926: Remove metrics on Log Cleaner shutdown

2023-05-02 Thread via GitHub
machi1990 commented on code in PR #13623: URL: https://github.com/apache/kafka/pull/13623#discussion_r1182849704 ## core/src/main/scala/kafka/log/LogCleaner.scala: ## @@ -167,8 +167,20 @@ class LogCleaner(initialConfig: CleanerConfig, */ def shutdown(): Unit = { info

[jira] [Assigned] (KAFKA-14959) Remove metrics on ClientQuota Managers shutdown

2023-05-02 Thread Manyanda Chitimbo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manyanda Chitimbo reassigned KAFKA-14959: - Assignee: Manyanda Chitimbo > Remove metrics on ClientQuota Managers shutdown >

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-05-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17718669#comment-17718669 ] Chris Egerton commented on KAFKA-14666: --- Backported to 3.4 and 3.3. > MM2 should

[jira] [Updated] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-05-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14666: -- Fix Version/s: 3.4.1 3.3.3 > MM2 should translate consumer group offsets be

[jira] [Updated] (KAFKA-14837) The MirrorCheckPointConnector of MM2 will rebalance frequently, when the source cluster group is many more and changes frequently (but the list of configured synchronous

2023-05-02 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14837: -- Fix Version/s: 3.4.1 3.3.3 > The MirrorCheckPointConnector of MM2 will reba

  1   2   >