kirktrue commented on code in PR #13591: URL: https://github.com/apache/kafka/pull/13591#discussion_r1182800998
########## clients/src/main/java/org/apache/kafka/clients/producer/internals/Sender.java: ########## @@ -263,7 +263,14 @@ public void run() { while (!forceClose && transactionManager != null && transactionManager.hasOngoingTransaction()) { if (!transactionManager.isCompleting()) { log.info("Aborting incomplete transaction due to shutdown"); - transactionManager.beginAbort(); + + try { + // It is possible for the transaction manager to throw errors when aborting. Catch these Review Comment: No, this was discovered when auditing the `TransactionManager` call sites. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org