[GitHub] [kafka] chia7712 commented on pull request #13398: MINOR: Fix typos in valid range of socket buffer size

2023-03-16 Thread via GitHub
chia7712 commented on PR #13398: URL: https://github.com/apache/kafka/pull/13398#issuecomment-1471424149 @garyparrot nice catch. It is not only typo but also incorrect validation. the `atLeast(0)` disables users to input `-1` for socket buffer. Hence, this PR is fixing a `bug` rather than a

[GitHub] [kafka] robobario commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
robobario commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471424085 Maybe my thread safety explanation is incorrect, I'll look again tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] chia7712 commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
chia7712 commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471425767 > Maybe my thread safety explanation is incorrect, I'll look again tomorrow. the thread safety explanation is correct to me. My point was that we should not only fix `iteration` bu

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471428193 > > Maybe my thread safety explanation is incorrect, I'll look again tomorrow. > > the thread safety explanation is correct to me. My point was that we should not only fix `iteratio

[GitHub] [kafka] chia7712 commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
chia7712 commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471448616 > If all variables are volatile or atomic, will it affect the printing performance of this perf program? Or we just handle the `iteration` as it seems `iteration` is the only vari

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471460665 > > > If all variables are volatile or atomic, will it affect the printing performance of this perf program? > > Or we just handle the `iteration` as it seems `iterat

[GitHub] [kafka] chia7712 commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
chia7712 commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471465952 > In addition, does this repair need to open a new jira? In fact, we should revert this PR first. The solution offered by this PR bring antoher issue (thanks to @robobario). The or

[GitHub] [kafka] hudeqi commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
hudeqi commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471469700 > > In addition, does this repair need to open a new jira? > > In fact, we should revert this PR first. The solution offered by this PR bring antoher issue (thanks to @robobario). Th

[GitHub] [kafka] chia7712 opened a new pull request, #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed"

2023-03-16 Thread via GitHub
chia7712 opened a new pull request, #13400: URL: https://github.com/apache/kafka/pull/13400 Reverts apache/kafka#13348 #13348 brings another issue. ``` [2023-03-16 07:44:19,926] ERROR Error executing user-provided callback on message for topic-partition 'perf-test-3' (org.apach

[GitHub] [kafka] chia7712 commented on pull request #13348: MINOR: Fix ProducerPerformance still counting successful sending when sending failed

2023-03-16 Thread via GitHub
chia7712 commented on PR #13348: URL: https://github.com/apache/kafka/pull/13348#issuecomment-1471470912 > and then report back the original problem that failed to send but still recorded success, and solve the current problem at the same time, right? yep. #13400 is used to revert thi

[GitHub] [kafka] chia7712 commented on pull request #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed"

2023-03-16 Thread via GitHub
chia7712 commented on PR #13400: URL: https://github.com/apache/kafka/pull/13400#issuecomment-1471471412 @showuon PTAL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] hudeqi commented on pull request #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed"

2023-03-16 Thread via GitHub
hudeqi commented on PR #13400: URL: https://github.com/apache/kafka/pull/13400#issuecomment-1471474675 ok, I will submit a new jira and a pr. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Created] (KAFKA-14812) ProducerPerformance still counting successful sending in console when sending failed

2023-03-16 Thread hudeqi (Jira)
hudeqi created KAFKA-14812: -- Summary: ProducerPerformance still counting successful sending in console when sending failed Key: KAFKA-14812 URL: https://issues.apache.org/jira/browse/KAFKA-14812 Project: Kaf

[jira] [Updated] (KAFKA-14812) ProducerPerformance still counting successful sending in console when sending failed

2023-03-16 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-14812: --- Attachment: WechatIMG27.jpeg > ProducerPerformance still counting successful sending in console when sending

[GitHub] [kafka] hudeqi commented on pull request #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed"

2023-03-16 Thread via GitHub
hudeqi commented on PR #13400: URL: https://github.com/apache/kafka/pull/13400#issuecomment-1471559067 Hello, I have created a new [JIRA](https://issues.apache.org/jira/browse/KAFKA-14812) here, can this revert pr be executed? And I will submit a new pr based on the trunk, thank you. @chia

[jira] [Updated] (KAFKA-14812) ProducerPerformance still counting successful sending in console when sending failed

2023-03-16 Thread hudeqi (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] hudeqi updated KAFKA-14812: --- Issue Type: Bug (was: Improvement) > ProducerPerformance still counting successful sending in console when

[GitHub] [kafka] showuon commented on pull request #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed"

2023-03-16 Thread via GitHub
showuon commented on PR #13400: URL: https://github.com/apache/kafka/pull/13400#issuecomment-1471596731 Yes, I'll merge it after CI test passed. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] lucasbru commented on a diff in pull request #13369: [DO NOT MERGE] KAFKA-14172: Should clear cache when active recycled from standby

2023-03-16 Thread via GitHub
lucasbru commented on code in PR #13369: URL: https://github.com/apache/kafka/pull/13369#discussion_r1138444392 ## streams/src/main/java/org/apache/kafka/streams/state/internals/ThreadCache.java: ## @@ -280,6 +280,13 @@ synchronized void close(final String namespace) {

[GitHub] [kafka] lucasbru commented on pull request #13347: MINOR: Use JUnit-5 extension to enforce strict stubbing

2023-03-16 Thread via GitHub
lucasbru commented on PR #13347: URL: https://github.com/apache/kafka/pull/13347#issuecomment-1471705490 @guozhangwang ping? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] chia7712 opened a new pull request, #13401: Revert "MINOR: Fixed ProducerPerformance still counting successful se…

2023-03-16 Thread via GitHub
chia7712 opened a new pull request, #13401: URL: https://github.com/apache/kafka/pull/13401 This reverts commit 8e4c0d0b04580cde1e15e7b4793bae747d38999c. #13348 brings another issue. ``` [2023-03-16 07:44:19,926] ERROR Error executing user-provided callback on message for topic-

[GitHub] [kafka] chia7712 closed pull request #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed"

2023-03-16 Thread via GitHub
chia7712 closed pull request #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed" URL: https://github.com/apache/kafka/pull/13400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] chia7712 commented on pull request #13400: Revert "MINOR: Fix ProducerPerformance still counting successful sending when sending failed"

2023-03-16 Thread via GitHub
chia7712 commented on PR #13400: URL: https://github.com/apache/kafka/pull/13400#issuecomment-1471744939 close as I forgot to file PR from my repo... #13401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [kafka] hudeqi commented on pull request #13401: Revert "MINOR: Fixed ProducerPerformance still counting successful se…

2023-03-16 Thread via GitHub
hudeqi commented on PR #13401: URL: https://github.com/apache/kafka/pull/13401#issuecomment-1471765926 mark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[GitHub] [kafka] andymg3 opened a new pull request, #13402: MINOR: Use PartitionAssignment in ReplicationControlManager and PartitionReassignmentReplicas

2023-03-16 Thread via GitHub
andymg3 opened a new pull request, #13402: URL: https://github.com/apache/kafka/pull/13402 ### Details Updates `ReplicationControlManager` and `PartitionReassignmentReplicas` to use `PartitionAssignment` which was introduced in https://github.com/apache/kafka/pull/12892 ### Testin

[jira] [Updated] (KAFKA-14799) Source tasks fail if connector attempts to abort empty transaction

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14799: -- Fix Version/s: 3.4.1 3.3.3 > Source tasks fail if connector attempts to abo

[jira] [Commented] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701151#comment-17701151 ] Chris Egerton commented on KAFKA-14809: --- This is arguably the root cause of KAFKA-

[GitHub] [kafka] C0urante merged pull request #13386: KAFKA-14809 Fix logging conditional on WorkerSourceTask

2023-03-16 Thread via GitHub
C0urante merged PR #13386: URL: https://github.com/apache/kafka/pull/13386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on pull request #13386: KAFKA-14809 Fix logging conditional on WorkerSourceTask

2023-03-16 Thread via GitHub
C0urante commented on PR #13386: URL: https://github.com/apache/kafka/pull/13386#issuecomment-1471890863 Thanks @hgeraldino, I've merged and backported as far back as applicable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Resolved] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14809. --- Resolution: Fixed > Connect incorrectly logs that no records were produced by source tasks >

[jira] [Updated] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Affects Version/s: 3.3.2 3.3.1 3.2.3

[jira] [Updated] (KAFKA-14809) Connect incorrectly logs that no records were produced by source tasks

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14809: -- Fix Version/s: 3.2.4 3.1.3 3.0.3 3.5.0

[GitHub] [kafka] dajac commented on pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-16 Thread via GitHub
dajac commented on PR #13323: URL: https://github.com/apache/kafka/pull/13323#issuecomment-1471913482 Failed tests are not related to this PR: ``` [Build / JDK 17 and Scala 2.13 / kafka.zk.ZkMigrationIntegrationTest.[1] Type=ZK, Name=testDualWrite, MetadataVersion=3.4-IV0, Security=PL

[GitHub] [kafka] dajac merged pull request #13323: KAFKA-14617: Add ReplicaState to FetchRequest

2023-03-16 Thread via GitHub
dajac merged PR #13323: URL: https://github.com/apache/kafka/pull/13323 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] mimaison merged pull request #13389: MINOR: Log consumer groups mirrored by checkpoint tasks

2023-03-16 Thread via GitHub
mimaison merged PR #13389: URL: https://github.com/apache/kafka/pull/13389 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] chia7712 commented on pull request #13401: Revert "MINOR: Fixed ProducerPerformance still counting successful se…

2023-03-16 Thread via GitHub
chia7712 commented on PR #13401: URL: https://github.com/apache/kafka/pull/13401#issuecomment-1471950362 https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-13401/1/pipeline/13 `Build / JDK 17 and Scala 2.13` has passed. will merge it. -- This is an a

[GitHub] [kafka] chia7712 merged pull request #13401: Revert "MINOR: Fixed ProducerPerformance still counting successful se…

2023-03-16 Thread via GitHub
chia7712 merged PR #13401: URL: https://github.com/apache/kafka/pull/13401 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] hudeqi opened a new pull request, #13403: MINOR:Fix hint about alter in TopicCommand

2023-03-16 Thread via GitHub
hudeqi opened a new pull request, #13403: URL: https://github.com/apache/kafka/pull/13403 Since TopicCommand does not support updating the configuration of an existing topic, "and/or configuration for the topic." should be removed from the description of --alter, otherwise it will cause mis

[GitHub] [kafka] hudeqi opened a new pull request, #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-16 Thread via GitHub
hudeqi opened a new pull request, #13404: URL: https://github.com/apache/kafka/pull/13404 When using ProducerPerformance, I found that when the sending fails, it is still counted as successfully sent by stat and the metrics are printed in console. For example, when there is no write permiss

[GitHub] [kafka] hudeqi commented on pull request #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-16 Thread via GitHub
hudeqi commented on PR #13404: URL: https://github.com/apache/kafka/pull/13404#issuecomment-1472060451 About issues in #13348 , my solution is: remove the use of the iteration variable of stats from the main thread, the read and write it completely by the callback of a separate producer thr

[GitHub] [kafka] hzh0425 closed pull request #13342: MINOR: Parse file offset of Remote Index as Long type instead of Int type in RemoteIndexCache

2023-03-16 Thread via GitHub
hzh0425 closed pull request #13342: MINOR: Parse file offset of Remote Index as Long type instead of Int type in RemoteIndexCache URL: https://github.com/apache/kafka/pull/13342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[jira] [Created] (KAFKA-14813) Timeout Exception causes data loss

2023-03-16 Thread Nicola Stringari (Jira)
Nicola Stringari created KAFKA-14813: Summary: Timeout Exception causes data loss Key: KAFKA-14813 URL: https://issues.apache.org/jira/browse/KAFKA-14813 Project: Kafka Issue Type: Bug

[GitHub] [kafka] chia7712 opened a new pull request, #13405: KAFKA-14811 The forwarding requests are discarded when network client…

2023-03-16 Thread via GitHub
chia7712 opened a new pull request, #13405: URL: https://github.com/apache/kafka/pull/13405 related to https://issues.apache.org/jira/browse/KAFKA-14811 We don't check the in-flight requests when closing stale network client. If the in-flight requests are related to metadata request f

[GitHub] [kafka] pprovenzano closed pull request #13338: KAFKA-14765: Support SCRAM for brokers at bootstrap

2023-03-16 Thread via GitHub
pprovenzano closed pull request #13338: KAFKA-14765: Support SCRAM for brokers at bootstrap URL: https://github.com/apache/kafka/pull/13338 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] chia7712 commented on a diff in pull request #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-16 Thread via GitHub
chia7712 commented on code in PR #13404: URL: https://github.com/apache/kafka/pull/13404#discussion_r1138878548 ## tools/src/main/java/org/apache/kafka/tools/ProducerPerformance.java: ## @@ -113,7 +113,7 @@ void start(String[] args) throws IOException { record =

[GitHub] [kafka] chia7712 commented on pull request #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-16 Thread via GitHub
chia7712 commented on PR #13404: URL: https://github.com/apache/kafka/pull/13404#issuecomment-1472201788 @robobario please take a look if you have free cycle. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] C0urante commented on a diff in pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

2023-03-16 Thread via GitHub
C0urante commented on code in PR #13367: URL: https://github.com/apache/kafka/pull/13367#discussion_r1138945859 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java: ## @@ -45,7 +45,13 @@ public void startCl

[GitHub] [kafka] C0urante commented on a diff in pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

2023-03-16 Thread via GitHub
C0urante commented on code in PR #13367: URL: https://github.com/apache/kafka/pull/13367#discussion_r1138946676 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java: ## @@ -45,7 +45,13 @@ public void startCl

[jira] [Commented] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701271#comment-17701271 ] Chris Egerton commented on KAFKA-14666: --- This is touched on more extensively in a

[GitHub] [kafka] CalvinConfluent opened a new pull request, #13406: KAFKA-14617: Fill brokerEpoch in AlterPartitionRequest

2023-03-16 Thread via GitHub
CalvinConfluent opened a new pull request, #13406: URL: https://github.com/apache/kafka/pull/13406 As the second part of the [KIP-903](https://cwiki.apache.org/confluence/display/KAFKA/KIP-903%3A+Replicas+with+stale+broker+epoch+should+not+be+allowed+to+join+the+ISR), it updates the AlterPa

[GitHub] [kafka] cmccabe merged pull request #13394: MINOR: Remove unused MetadataSnapshotter.scala file

2023-03-16 Thread via GitHub
cmccabe merged PR #13394: URL: https://github.com/apache/kafka/pull/13394 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Updated] (KAFKA-14666) MM2 should translate consumer group offsets behind replication flow

2023-03-16 Thread Greg Harris (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Greg Harris updated KAFKA-14666: Labels: (was: needs-kip) > MM2 should translate consumer group offsets behind replication flow >

[GitHub] [kafka] CalvinConfluent commented on pull request #13406: KAFKA-14617: Fill brokerEpoch in AlterPartitionRequest

2023-03-16 Thread via GitHub
CalvinConfluent commented on PR #13406: URL: https://github.com/apache/kafka/pull/13406#issuecomment-1472363308 Will send the API change and the controller side change first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] CalvinConfluent closed pull request #13406: KAFKA-14617: Fill brokerEpoch in AlterPartitionRequest

2023-03-16 Thread via GitHub
CalvinConfluent closed pull request #13406: KAFKA-14617: Fill brokerEpoch in AlterPartitionRequest URL: https://github.com/apache/kafka/pull/13406 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [kafka] C0urante commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-16 Thread via GitHub
C0urante commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1139041573 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConfig.java: ## @@ -73,6 +73,18 @@ public class MirrorSourceConfig extends MirrorConnector

[jira] [Commented] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

2023-03-16 Thread Siddharth Anand (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701313#comment-17701313 ] Siddharth Anand commented on KAFKA-14757: - Hi [~pnee]  We implemented onPartitio

[jira] [Comment Edited] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

2023-03-16 Thread Siddharth Anand (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701313#comment-17701313 ] Siddharth Anand edited comment on KAFKA-14757 at 3/16/23 5:35 PM:

[GitHub] [kafka] ivanyu commented on a diff in pull request #13362: KAFKA-14795: Provide message formatter for RemoteLogMetadata

2023-03-16 Thread via GitHub
ivanyu commented on code in PR #13362: URL: https://github.com/apache/kafka/pull/13362#discussion_r1139132047 ## storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/serialization/RemoteLogMetadataSerde.java: ## @@ -107,4 +110,13 @@ private RemoteLogMetadata

[jira] [Comment Edited] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

2023-03-16 Thread Siddharth Anand (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701313#comment-17701313 ] Siddharth Anand edited comment on KAFKA-14757 at 3/16/23 5:41 PM:

[jira] [Comment Edited] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

2023-03-16 Thread Siddharth Anand (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701313#comment-17701313 ] Siddharth Anand edited comment on KAFKA-14757 at 3/16/23 5:42 PM:

[jira] [Comment Edited] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

2023-03-16 Thread Siddharth Anand (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701313#comment-17701313 ] Siddharth Anand edited comment on KAFKA-14757 at 3/16/23 6:00 PM:

[jira] [Comment Edited] (KAFKA-14757) Kafka Cooperative Sticky Assignor results in significant duplicate consumption

2023-03-16 Thread Siddharth Anand (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701313#comment-17701313 ] Siddharth Anand edited comment on KAFKA-14757 at 3/16/23 6:05 PM:

[GitHub] [kafka] divijvaidya commented on pull request #13362: KAFKA-14795: Provide message formatter for RemoteLogMetadata

2023-03-16 Thread via GitHub
divijvaidya commented on PR #13362: URL: https://github.com/apache/kafka/pull/13362#issuecomment-1472489702 @satishd perhaps you would like to review this since it's associated with KIP405? -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] tinaselenge commented on a diff in pull request #13373: Kafka-14420 Use incrementalAlterConfigs API for syncing topic configurations (KIP-894)

2023-03-16 Thread via GitHub
tinaselenge commented on code in PR #13373: URL: https://github.com/apache/kafka/pull/13373#discussion_r1139190436 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorSourceConnector.java: ## @@ -117,6 +122,16 @@ public MirrorSourceConnector() { this.c

[GitHub] [kafka] mumrah opened a new pull request, #13407: KAFKA-14805 KRaft controller supports pre-migration mode

2023-03-16 Thread via GitHub
mumrah opened a new pull request, #13407: URL: https://github.com/apache/kafka/pull/13407 This patch adds the concepts of pre-migration mode to the KRaft controller. While in this mode, the controller will only allow certain write operations. The purpose of this is to disallow metadata chan

[jira] [Created] (KAFKA-14814) Skip restart of connectors when redundant resume request is made

2023-03-16 Thread Chris Egerton (Jira)
Chris Egerton created KAFKA-14814: - Summary: Skip restart of connectors when redundant resume request is made Key: KAFKA-14814 URL: https://issues.apache.org/jira/browse/KAFKA-14814 Project: Kafka

[jira] [Updated] (KAFKA-14814) Skip restart of connectors when redundant resume request is made

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14814: -- Priority: Minor (was: Major) > Skip restart of connectors when redundant resume request is ma

[jira] [Assigned] (KAFKA-14814) Skip restart of connectors when redundant resume request is made

2023-03-16 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14814?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14814: - Assignee: (was: Chris Egerton) > Skip restart of connectors when redundant resume r

[GitHub] [kafka] mumrah commented on pull request #13372: MINOR: Improved error handling in ZK migration

2023-03-16 Thread via GitHub
mumrah commented on PR #13372: URL: https://github.com/apache/kafka/pull/13372#issuecomment-1472608583 @cmccabe the latest test run fixed the unit test. The other failures will be addressed by #13407 -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-16 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139257566 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-16 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139276421 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -80,16 +97,18 @@ public CommitRequestManager( */ @Ove

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-16 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139280595 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -235,4 +373,105 @@ public void ack(final long currentTimeMs) {

[jira] [Created] (KAFKA-14815) Move Kafka documentation to Markdown/Hugo

2023-03-16 Thread Jorge Esteban Quilcate Otoya (Jira)
Jorge Esteban Quilcate Otoya created KAFKA-14815: Summary: Move Kafka documentation to Markdown/Hugo Key: KAFKA-14815 URL: https://issues.apache.org/jira/browse/KAFKA-14815 Project: Ka

[GitHub] [kafka] robobario commented on pull request #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-16 Thread via GitHub
robobario commented on PR #13404: URL: https://github.com/apache/kafka/pull/13404#issuecomment-1472733211 > @robobario please take a look if you have free cycle. LGTM. If you expose the internals of `Stats` a bit more we could test it with something like: ``` @Test pu

[jira] [Commented] (KAFKA-14523) Move RemoteLogManager to the storage module

2023-03-16 Thread Muralidhar Basani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701393#comment-17701393 ] Muralidhar Basani commented on KAFKA-14523: --- Hi [~satish.duggana] , I see this

[GitHub] [kafka] cmccabe merged pull request #13372: MINOR: Improved error handling in ZK migration

2023-03-16 Thread via GitHub
cmccabe merged PR #13372: URL: https://github.com/apache/kafka/pull/13372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] mumrah commented on pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

2023-03-16 Thread via GitHub
mumrah commented on PR #13390: URL: https://github.com/apache/kafka/pull/13390#issuecomment-1472771486 With the latest code, I got the following threads in KRaft mode: ``` "metrics-meter-tick-thread-1" #19 daemon prio=5 os_prio=31 cpu=0.57ms elapsed=9.63s tid=0x00012608ce00 nid

[GitHub] [kafka] gharris1727 commented on pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

2023-03-16 Thread via GitHub
gharris1727 commented on PR #13367: URL: https://github.com/apache/kafka/pull/13367#issuecomment-1472825496 @C0urante I refactored it so that we have zero and nonzero test cases in each suite. There's a little bit of duplication around the IdentityReplicationIntegrationTest that i'll addres

[jira] [Commented] (KAFKA-13913) Provide builders for KafkaProducer/KafkaConsumer and KafkaStreams

2023-03-16 Thread Kirk True (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701409#comment-17701409 ] Kirk True commented on KAFKA-13913: --- [~frosiere] what's the status of the accompanying

[GitHub] [kafka] gharris1727 commented on a diff in pull request #13367: KAFKA-14797: Emit offset sync when offset translation lag would exceed max.offset.lag

2023-03-16 Thread via GitHub
gharris1727 commented on code in PR #13367: URL: https://github.com/apache/kafka/pull/13367#discussion_r1139409839 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationTransactionsTest.java: ## @@ -45,7 +45,13 @@ public void star

[GitHub] [kafka] CalvinConfluent opened a new pull request, #13408: KAFKA-14617: Update AlterPartitionRequest and enable Kraft controller to reject stale request.

2023-03-16 Thread via GitHub
CalvinConfluent opened a new pull request, #13408: URL: https://github.com/apache/kafka/pull/13408 As the second part of the [KIP-903](https://cwiki.apache.org/confluence/display/KAFKA/KIP-903%3A+Replicas+with+stale+broker+epoch+should+not+be+allowed+to+join+the+ISR), it updates the AlterPa

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-16 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1472839086 ping @cadonna for a final look, this PR needs to go first before the next one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [kafka] guozhangwang commented on pull request #13318: KAFKA-14533: Do not interrupt state-updater thread during shutdown

2023-03-16 Thread via GitHub
guozhangwang commented on PR #13318: URL: https://github.com/apache/kafka/pull/13318#issuecomment-1472840025 > I triggered one now: https://jenkins.confluent.io/job/system-test-kafka-branch-builder//console @lucasbru the failure seems not related to the code but sock timeouts its

[GitHub] [kafka] cmccabe merged pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

2023-03-16 Thread via GitHub
cmccabe merged PR #13390: URL: https://github.com/apache/kafka/pull/13390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cmccabe commented on pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

2023-03-16 Thread via GitHub
cmccabe commented on PR #13390: URL: https://github.com/apache/kafka/pull/13390#issuecomment-1472852676 Thanks, @mumrah . I did another quick sweep of the thread named, like you did, and deleted the extra dash in one case, and added a dash in another. There are still a few ugly and/or unpre

[GitHub] [kafka] cmccabe commented on pull request #13390: MINOR: Standardize KRaft logging, thread names, and terminology

2023-03-16 Thread via GitHub
cmccabe commented on PR #13390: URL: https://github.com/apache/kafka/pull/13390#issuecomment-1472853759 > Did you find where the lone EventHandler is coming from? Sorry, I meant to respond to this comment earlier. But for completeness, the lone EventHandler is gone now, last I checked

[GitHub] [kafka] imcdo commented on a diff in pull request #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

2023-03-16 Thread via GitHub
imcdo commented on code in PR #12828: URL: https://github.com/apache/kafka/pull/12828#discussion_r1139460592 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java: ## @@ -43,10 +43,38 @@ import java.util.concurrent.ExecutionException; import ja

[GitHub] [kafka] C0urante commented on a diff in pull request #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

2023-03-16 Thread via GitHub
C0urante commented on code in PR #12828: URL: https://github.com/apache/kafka/pull/12828#discussion_r1139465010 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java: ## @@ -43,10 +43,38 @@ import java.util.concurrent.ExecutionException; import

[GitHub] [kafka] imcdo commented on a diff in pull request #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

2023-03-16 Thread via GitHub
imcdo commented on code in PR #12828: URL: https://github.com/apache/kafka/pull/12828#discussion_r1139470073 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java: ## @@ -43,10 +43,38 @@ import java.util.concurrent.ExecutionException; import ja

[GitHub] [kafka] imcdo commented on a diff in pull request #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

2023-03-16 Thread via GitHub
imcdo commented on code in PR #12828: URL: https://github.com/apache/kafka/pull/12828#discussion_r1139476999 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java: ## @@ -43,10 +43,38 @@ import java.util.concurrent.ExecutionException; import ja

[jira] [Created] (KAFKA-14816) Connect Http Client

2023-03-16 Thread Ian McDonald (Jira)
Ian McDonald created KAFKA-14816: Summary: Connect Http Client Key: KAFKA-14816 URL: https://issues.apache.org/jira/browse/KAFKA-14816 Project: Kafka Issue Type: Bug Components: Ka

[jira] [Updated] (KAFKA-14816) Connect Http Client loading SSL data when security protocol doesn't include ssl

2023-03-16 Thread Ian McDonald (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian McDonald updated KAFKA-14816: - Summary: Connect Http Client loading SSL data when security protocol doesn't include ssl (was:

[jira] [Updated] (KAFKA-14816) Connect Http Client loading SSL configs when security protocol doesn't include ssl

2023-03-16 Thread Ian McDonald (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ian McDonald updated KAFKA-14816: - Summary: Connect Http Client loading SSL configs when security protocol doesn't include ssl (wa

[GitHub] [kafka] imcdo commented on a diff in pull request #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

2023-03-16 Thread via GitHub
imcdo commented on code in PR #12828: URL: https://github.com/apache/kafka/pull/12828#discussion_r1139476999 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java: ## @@ -43,10 +43,38 @@ import java.util.concurrent.ExecutionException; import ja

[GitHub] [kafka] guozhangwang commented on a diff in pull request #13369: [DO NOT MERGE] KAFKA-14172: Should clear cache when active recycled from standby

2023-03-16 Thread via GitHub
guozhangwang commented on code in PR #13369: URL: https://github.com/apache/kafka/pull/13369#discussion_r1139441498 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/ProcessorStateManager.java: ## @@ -590,12 +590,13 @@ void recycle() { } } -

[GitHub] [kafka] vcrfxia opened a new pull request, #13409: KAFKA-14491: [18/N] Update versioned store to check latest value on timestamped get

2023-03-16 Thread via GitHub
vcrfxia opened a new pull request, #13409: URL: https://github.com/apache/kafka/pull/13409 Prior to this PR, versioned stores always returned null for `get(key, timestamp)` calls where the timestamp has exceeded the store's history retention, even if the latest value for the key (i.e., the

[GitHub] [kafka] hgeraldino commented on a diff in pull request #13294: KAFKA-5863: Avoid NPE when RestClient calls expecting no-content receive content.

2023-03-16 Thread via GitHub
hgeraldino commented on code in PR #13294: URL: https://github.com/apache/kafka/pull/13294#discussion_r1139545378 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestClientTest.java: ## @@ -157,23 +161,55 @@ private void setupHttpClient(int responseCode, S

[GitHub] [kafka] showuon commented on pull request #13362: KAFKA-14795: Provide message formatter for RemoteLogMetadata

2023-03-16 Thread via GitHub
showuon commented on PR #13362: URL: https://github.com/apache/kafka/pull/13362#issuecomment-1472989118 I'll take a look this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] mjsax commented on a diff in pull request #13409: KAFKA-14491: [18/N] Update versioned store to check latest value on timestamped get

2023-03-16 Thread via GitHub
mjsax commented on code in PR #13409: URL: https://github.com/apache/kafka/pull/13409#discussion_r1139545717 ## streams/src/main/java/org/apache/kafka/streams/state/VersionedKeyValueStore.java: ## @@ -59,12 +59,15 @@ * Delete the value associated with this key from the sto

[GitHub] [kafka] hudeqi commented on pull request #13404: KAFKA-14812: ProducerPerformance still counting successful sending in …

2023-03-16 Thread via GitHub
hudeqi commented on PR #13404: URL: https://github.com/apache/kafka/pull/13404#issuecomment-1473033928 Thank you both for your valuable comments! I have added optimization. @chia7712 @robobario -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] philipnee commented on a diff in pull request #13380: KAFKA-14468: Committed API

2023-03-16 Thread via GitHub
philipnee commented on code in PR #13380: URL: https://github.com/apache/kafka/pull/13380#discussion_r1139650990 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CommitRequestManager.java: ## @@ -137,31 +144,40 @@ CompletableFuture sendAutoCommit(final Map t

  1   2   >