imcdo commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1139460592
##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##########
@@ -43,10 +43,38 @@
import java.util.concurrent.ExecutionException;
import java.util.concurrent.TimeoutException;
-public class RestClient {
+public class RestClient implements AutoCloseable {
private static final Logger log =
LoggerFactory.getLogger(RestClient.class);
private static final ObjectMapper JSON_SERDE = new ObjectMapper();
+ private final HttpClient client;
+ public RestClient(WorkerConfig config) {
+ client = new
HttpClient(SSLUtils.createClientSideSslContextFactory(config));
Review Comment:
Hmm we are running into a wierd case because of this where we have ssl
configs configured however we set the security.protocol to `SASL_PLAINTEXT` and
ssl still makes an apearence (and fails our test because our test is a bit of a
ridiculous configuration where we set the keystore location value for ssl
however we dont create it as we arnt running with ssl). IDK if one should
consider the `security.protocol` here but anyway....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
