[GitHub] [kafka] imcdo commented on a diff in pull request #12828: KAFKA-14346: Remove hard-to-mock RestClient calls

[via GitHub]

imcdo commented on code in PR #12828:
URL: https://github.com/apache/kafka/pull/12828#discussion_r1139476999


##########
connect/runtime/src/main/java/org/apache/kafka/connect/runtime/rest/RestClient.java:
##########
@@ -43,10 +43,38 @@
 import java.util.concurrent.ExecutionException;
 import java.util.concurrent.TimeoutException;
 
-public class RestClient {
+public class RestClient implements AutoCloseable {
     private static final Logger log = 
LoggerFactory.getLogger(RestClient.class);
     private static final ObjectMapper JSON_SERDE = new ObjectMapper();
 
+    private final HttpClient client;
+    public RestClient(WorkerConfig config) {
+        client = new 
HttpClient(SSLUtils.createClientSideSslContextFactory(config));

Review Comment:
   https://issues.apache.org/jira/browse/KAFKA-14816 Feel free to close if 
deemed not an issue
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org