[GitHub] [kafka] fvaleri opened a new pull request, #13171: KAFKA-7735: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri opened a new pull request, #13171: URL: https://github.com/apache/kafka/pull/13171 This also includes a new test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [kafka] fvaleri commented on pull request #13171: KAFKA-7735: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on PR #13171: URL: https://github.com/apache/kafka/pull/13171#issuecomment-1408394028 @mimaison @OmniaGM @tombentley this is ready for review if any of you have time. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please l

[GitHub] [kafka] mimaison commented on pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

2023-01-30 Thread via GitHub
mimaison commented on PR #13148: URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408432038 Thanks for the PR @C0urante ! I think none of the tests actually reproduce the issue, I can get them to pass (minus the verify for the new methods) with the previous logic. However I don

[GitHub] [kafka] mimaison commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

2023-01-30 Thread via GitHub
mimaison commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1408441506 I simply meant that it looks like some changes in the system tests are required too. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] tinaselenge opened a new pull request, #13172: KAFKA-14590: Move DelegationTokenCommand to tools

2023-01-30 Thread via GitHub
tinaselenge opened a new pull request, #13172: URL: https://github.com/apache/kafka/pull/13172 Support delegationToken APIs in MockAdminClient. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build s

[jira] [Assigned] (KAFKA-14581) Move GetOffsetShell to tools

2023-01-30 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-14581: - Assignee: Gantigmaa Selenge > Move GetOffsetShell to tools > --

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
OmniaGM commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090495143 ## tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
OmniaGM commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090471930 ## tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Assigned] (KAFKA-14592) Move FeatureCommand to tools

2023-01-30 Thread Gantigmaa Selenge (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gantigmaa Selenge reassigned KAFKA-14592: - Assignee: Gantigmaa Selenge > Move FeatureCommand to tools > --

[GitHub] [kafka] vamossagar12 commented on pull request #13095: KAFKA-14580: Moving EndToEndLatency from core to tools module

2023-01-30 Thread via GitHub
vamossagar12 commented on PR #13095: URL: https://github.com/apache/kafka/pull/13095#issuecomment-1408469183 > I simply meant that it looks like some changes in the system tests are required too. Got it. Thanks for the confirmation. -- This is an automated message from the Apache

[jira] [Updated] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

2023-01-30 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-14660: Summary: Divide by zero security vulnerability (sonatype-2019-0422) (was: Divide by zero security

[jira] [Created] (KAFKA-14660) Divide by zero security vulnerability

2023-01-30 Thread Andy Coates (Jira)
Andy Coates created KAFKA-14660: --- Summary: Divide by zero security vulnerability Key: KAFKA-14660 URL: https://issues.apache.org/jira/browse/KAFKA-14660 Project: Kafka Issue Type: Bug

[jira] [Updated] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

2023-01-30 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy Coates updated KAFKA-14660: Description: Looks like SonaType has picked up a "Divide by Zero" issue reported in a PR and, bec

[jira] [Commented] (KAFKA-8217) MockConsumer.poll executes pollTasks before checking wakeup flag

2023-01-30 Thread Karsten Spang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8217?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682057#comment-17682057 ] Karsten Spang commented on KAFKA-8217: -- I think this is as it should be. I would wan

[jira] [Commented] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

2023-01-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682063#comment-17682063 ] Alexandre Dupriez commented on KAFKA-14139: --- Could reproduce without ZK contro

[jira] [Updated] (KAFKA-14139) Replaced disk can lead to loss of committed data even with non-empty ISR

2023-01-30 Thread Alexandre Dupriez (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexandre Dupriez updated KAFKA-14139: -- Description: We have been thinking about disk failure cases recently. Suppose that a d

[GitHub] [kafka] Hangleton commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-01-30 Thread via GitHub
Hangleton commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1090646744 ## clients/src/main/java/org/apache/kafka/common/utils/Time.java: ## @@ -86,4 +89,30 @@ default Timer timer(Duration timeout) { return timer(timeout.toMillis

[GitHub] [kafka] tledkov opened a new pull request, #13173: Demo of leaks file descriptors of deleted logs on KafkaEmbedded#stopAsync

2023-01-30 Thread via GitHub
tledkov opened a new pull request, #13173: URL: https://github.com/apache/kafka/pull/13173 Demonstrates the behavior of integration test that is used the `EmbeddedKafkaCluster`. In case a test suite contains a lot of tests that creates/deletes lot of topics the process if finished with t

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090657703 ## tools/src/main/java/org/apache/kafka/tools/StateChangeLogMerger.java: ## @@ -0,0 +1,329 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [kafka] Hangleton commented on a diff in pull request #13162: fix: replace an inefficient loop in kafka internals

2023-01-30 Thread via GitHub
Hangleton commented on code in PR #13162: URL: https://github.com/apache/kafka/pull/13162#discussion_r1090683591 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel destChannel, *

[GitHub] [kafka] Hangleton commented on a diff in pull request #13162: fix: replace an inefficient loop in kafka internals

2023-01-30 Thread via GitHub
Hangleton commented on code in PR #13162: URL: https://github.com/apache/kafka/pull/13162#discussion_r1090683591 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel destChannel, *

[GitHub] [kafka] mimaison opened a new pull request, #13174: MINOR: Various cleanups in common utils

2023-01-30 Thread via GitHub
mimaison opened a new pull request, #13174: URL: https://github.com/apache/kafka/pull/13174 - Remove unused methods - Cleanup syntax ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status

[GitHub] [kafka] mimaison commented on a diff in pull request #13174: MINOR: Various cleanups in common utils

2023-01-30 Thread via GitHub
mimaison commented on code in PR #13174: URL: https://github.com/apache/kafka/pull/13174#discussion_r1090688740 ## clients/src/main/java/org/apache/kafka/common/utils/MappedIterator.java: ## @@ -32,12 +32,12 @@ public MappedIterator(Iterator underlyingIterator, Function m

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090717453 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +104,17 @@ public static void prettyPrintTable( printRow(columnLength

[GitHub] [kafka] Hangleton commented on a diff in pull request #13161: Kafka 14128

2023-01-30 Thread via GitHub
Hangleton commented on code in PR #13161: URL: https://github.com/apache/kafka/pull/13161#discussion_r1090718859 ## clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java: ## @@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable cause)

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090717453 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +104,17 @@ public static void prettyPrintTable( printRow(columnLength

[GitHub] [kafka] fvaleri commented on pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on PR #13171: URL: https://github.com/apache/kafka/pull/13171#issuecomment-1408759302 Hi Omnia, thanks for the review. I've addressed some of your comments and answered the others. -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [kafka] dpcollins-google commented on a diff in pull request #13162: fix: replace an inefficient loop in kafka internals

2023-01-30 Thread via GitHub
dpcollins-google commented on code in PR #13162: URL: https://github.com/apache/kafka/pull/13162#discussion_r1090733865 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel destChannel,

[GitHub] [kafka] pprovenzano commented on pull request #13114: KAFKA-14084: SCRAM support in KRaft.

2023-01-30 Thread via GitHub
pprovenzano commented on PR #13114: URL: https://github.com/apache/kafka/pull/13114#issuecomment-1408812047 > The changes to `BrokerMetadataSnapshotterTest.scala` are needed and small. The size of the SCRAM records is larger than 1024 bytes and so I increased it to 4096 bytes in the

[GitHub] [kafka] C0urante commented on pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

2023-01-30 Thread via GitHub
C0urante commented on PR #13148: URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408822680 @mimaison Yeah, that's correct. I'm hoping that the `verify` calls for `plugins::withClassLoader` will be sufficient for now. I've also added a small comment explaining why we perform th

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090717453 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +104,17 @@ public static void prettyPrintTable( printRow(columnLength

[GitHub] [kafka] OmniaGM commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
OmniaGM commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090808339 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +104,17 @@ public static void prettyPrintTable( printRow(columnLength

[GitHub] [kafka] electrical commented on pull request #12358: KAFKA-13988:Fix mm2 auto.offset.reset=latest not working

2023-01-30 Thread via GitHub
electrical commented on PR #12358: URL: https://github.com/apache/kafka/pull/12358#issuecomment-1408885972 We are hitting the same issue while we want to switch from MM1 to MM2. Would be great to see this fixed so we can switch over Thanks! -- This is an automated message from th

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090852796 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +104,17 @@ public static void prettyPrintTable( printRow(columnLength

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090852796 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +104,17 @@ public static void prettyPrintTable( printRow(columnLength

[GitHub] [kafka] mimaison commented on pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

2023-01-30 Thread via GitHub
mimaison commented on PR #13148: URL: https://github.com/apache/kafka/pull/13148#issuecomment-1408944140 Thanks @C0urante, I just wanted to clarify this was indeed the intent. Like you, I don't think we necessarily need system tests for this. -- This is an automated message from the Apach

[GitHub] [kafka] fvaleri commented on a diff in pull request #13171: KAFKA-14584: Move StateChangeLogMerger tool

2023-01-30 Thread via GitHub
fvaleri commented on code in PR #13171: URL: https://github.com/apache/kafka/pull/13171#discussion_r1090852796 ## server-common/src/main/java/org/apache/kafka/server/util/ToolsUtils.java: ## @@ -100,4 +104,17 @@ public static void prettyPrintTable( printRow(columnLength

[jira] [Resolved] (KAFKA-9975) KIP-611: Improved Handling of Abandoned Connectors and Tasks

2023-01-30 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-9975. -- Resolution: Abandoned > KIP-611: Improved Handling of Abandoned Connectors and Tasks >

[GitHub] [kafka] mimaison merged pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

2023-01-30 Thread via GitHub
mimaison merged PR #13148: URL: https://github.com/apache/kafka/pull/13148 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] ijuma commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-30 Thread via GitHub
ijuma commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1408995921 Thanks for doing this. One thing I didn't understand is why the shared classes are in `server-common` instead of `tools`. Is this because `core` also uses the class? -- This is an automa

[GitHub] [kafka] C0urante commented on pull request #13148: KAFKA-14645: Use plugin classloader when retrieving connector plugin config definitions

2023-01-30 Thread via GitHub
C0urante commented on PR #13148: URL: https://github.com/apache/kafka/pull/13148#issuecomment-1409001897 Thanks Mickael! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Updated] (KAFKA-14623) OAuth's HttpAccessTokenRetriever potentially leaks secrets in logging

2023-01-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-14623: Fix Version/s: 3.4.0 (was: 3.4.1) > OAuth's HttpAccessTokenRetriever potent

[jira] [Assigned] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

2023-01-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax reassigned KAFKA-14660: --- Assignee: Matthias J. Sax > Divide by zero security vulnerability (sonatype-2019-04

[GitHub] [kafka] mjsax opened a new pull request, #13175: KAFAK-14660: Fix divide-by-zero vulnerability

2023-01-30 Thread via GitHub
mjsax opened a new pull request, #13175: URL: https://github.com/apache/kafka/pull/13175 This PR adds a safe-guard for divide-by-zero. While `totalCapacity` can never be zero, an explicit error message is desirable. -- This is an automated message from the Apache Git Service. To respond t

[GitHub] [kafka] divijvaidya commented on pull request #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

2023-01-30 Thread via GitHub
divijvaidya commented on PR #12620: URL: https://github.com/apache/kafka/pull/12620#issuecomment-1409015865 > It may make sense to wait a bit and go straight to 3.8.1 (once that's released Note that Zk 3.8.1 has released in Jan 2023. @ijuma, do you think it is the right time for us to mo

[GitHub] [kafka] ijuma commented on pull request #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

2023-01-30 Thread via GitHub
ijuma commented on PR #12620: URL: https://github.com/apache/kafka/pull/12620#issuecomment-1409023494 @divijvaidya Yes, I think that would make sense. That should tide us over until the KRaft transition happens. -- This is an automated message from the Apache Git Service. To respond to th

[GitHub] [kafka] ijuma commented on pull request #12620: KAFKA-14206: upgrade zookeeper version to 3.7.1

2023-01-30 Thread via GitHub
ijuma commented on PR #12620: URL: https://github.com/apache/kafka/pull/12620#issuecomment-1409028650 A couple of things to consider: 1. If we upgrade the zk server to 3.8.1, what is the impact on the zk clients. That is, what's the earliest zk client version that is supported by the 3.8

[GitHub] [kafka] C0urante commented on a diff in pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

2023-01-30 Thread via GitHub
C0urante commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1090935837 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java: ## @@ -255,13 +287,26 @@ private void addHerder(SourceAndTarget sourceAndTarget) {

[GitHub] [kafka] C0urante commented on a diff in pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

2023-01-30 Thread via GitHub
C0urante commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1090935837 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java: ## @@ -255,13 +287,26 @@ private void addHerder(SourceAndTarget sourceAndTarget) {

[jira] [Created] (KAFKA-14661) Upgrade Zk to 3.8.1

2023-01-30 Thread Divij Vaidya (Jira)
Divij Vaidya created KAFKA-14661: Summary: Upgrade Zk to 3.8.1 Key: KAFKA-14661 URL: https://issues.apache.org/jira/browse/KAFKA-14661 Project: Kafka Issue Type: Bug Components: zk

[GitHub] [kafka] C0urante commented on a diff in pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

2023-01-30 Thread via GitHub
C0urante commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1090936585 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMaker.java: ## @@ -119,7 +126,16 @@ public class MirrorMaker { public MirrorMaker(MirrorMake

[GitHub] [kafka] cmccabe commented on a diff in pull request #13159: KAFKA-14656 Send UMR first during ZK migration

2023-01-30 Thread via GitHub
cmccabe commented on code in PR #13159: URL: https://github.com/apache/kafka/pull/13159#discussion_r1090937161 ## metadata/src/main/java/org/apache/kafka/image/ConfigurationsImage.java: ## @@ -61,6 +61,15 @@ public Properties configProperties(ConfigResource configResource) {

[GitHub] [kafka] cmccabe commented on a diff in pull request #13159: KAFKA-14656 Send UMR first during ZK migration

2023-01-30 Thread via GitHub
cmccabe commented on code in PR #13159: URL: https://github.com/apache/kafka/pull/13159#discussion_r1090937902 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -403,7 +404,7 @@ public void run() throws Exception { At

[GitHub] [kafka] cmccabe commented on a diff in pull request #13159: KAFKA-14656 Send UMR first during ZK migration

2023-01-30 Thread via GitHub
cmccabe commented on code in PR #13159: URL: https://github.com/apache/kafka/pull/13159#discussion_r1090939081 ## core/src/main/scala/kafka/migration/MigrationPropagator.scala: ## @@ -118,9 +124,8 @@ class MigrationPropagator( } } -// If there are new brokers (

[jira] [Created] (KAFKA-14662) ACL listings in documentation are out of date

2023-01-30 Thread Mickael Maison (Jira)
Mickael Maison created KAFKA-14662: -- Summary: ACL listings in documentation are out of date Key: KAFKA-14662 URL: https://issues.apache.org/jira/browse/KAFKA-14662 Project: Kafka Issue Type:

[GitHub] [kafka] C0urante commented on a diff in pull request #13137: KAFKA-15086: Intra-cluster communication for Mirror Maker 2

2023-01-30 Thread via GitHub
C0urante commented on code in PR #13137: URL: https://github.com/apache/kafka/pull/13137#discussion_r1090943031 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/DedicatedMirrorIntegrationTest.java: ## @@ -0,0 +1,228 @@ +/* + * Licensed to the Apache So

[GitHub] [kafka] mumrah commented on a diff in pull request #13159: KAFKA-14656 Send UMR first during ZK migration

2023-01-30 Thread via GitHub
mumrah commented on code in PR #13159: URL: https://github.com/apache/kafka/pull/13159#discussion_r1090943050 ## metadata/src/main/java/org/apache/kafka/metadata/migration/KRaftMigrationDriver.java: ## @@ -403,7 +404,7 @@ public void run() throws Exception { Ato

[jira] [Updated] (KAFKA-14661) Upgrade Zk to 3.8.1

2023-01-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14661: - Issue Type: Improvement (was: Bug) > Upgrade Zk to 3.8.1 > > >

[jira] [Updated] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-01-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14661: - Summary: Upgrade Zookeeper to 3.8.1 (was: Upgrade Zk to 3.8.1 ) > Upgrade Zookeeper to 3.8.1

[jira] [Commented] (KAFKA-14661) Upgrade Zk to 3.8.1

2023-01-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682204#comment-17682204 ] Ismael Juma commented on KAFKA-14661: - We should focus on getting this done for 3.5.

[jira] [Updated] (KAFKA-14661) Upgrade Zk to 3.8.1

2023-01-30 Thread Divij Vaidya (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Divij Vaidya updated KAFKA-14661: - Component/s: packaging (was: zkclient) > Upgrade Zk to 3.8.1 > ---

[GitHub] [kafka] mumrah commented on a diff in pull request #13159: KAFKA-14656 Send UMR first during ZK migration

2023-01-30 Thread via GitHub
mumrah commented on code in PR #13159: URL: https://github.com/apache/kafka/pull/13159#discussion_r1090944813 ## core/src/main/scala/kafka/migration/MigrationPropagator.scala: ## @@ -118,9 +124,8 @@ class MigrationPropagator( } } -// If there are new brokers (i

[jira] [Comment Edited] (KAFKA-14661) Upgrade Zookeeper to 3.8.1

2023-01-30 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682204#comment-17682204 ] Ismael Juma edited comment on KAFKA-14661 at 1/30/23 5:39 PM:

[GitHub] [kafka] fvaleri commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-30 Thread via GitHub
fvaleri commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1409100823 > Thanks for doing this. One thing I didn't understand is why the shared classes are in `server-common` instead of `tools`. Is this because `core` also uses the class? Good questio

[GitHub] [kafka] Hangleton commented on a diff in pull request #13161: Kafka 14128

2023-01-30 Thread via GitHub
Hangleton commented on code in PR #13161: URL: https://github.com/apache/kafka/pull/13161#discussion_r1090718859 ## clients/src/main/java/org/apache/kafka/common/internals/KafkaFutureImpl.java: ## @@ -160,7 +160,7 @@ private void maybeThrowCancellationException(Throwable cause)

[GitHub] [kafka] Hangleton commented on a diff in pull request #13162: fix: replace an inefficient loop in kafka internals

2023-01-30 Thread via GitHub
Hangleton commented on code in PR #13162: URL: https://github.com/apache/kafka/pull/13162#discussion_r1091027869 ## clients/src/main/java/org/apache/kafka/common/utils/Utils.java: ## @@ -1225,13 +1226,11 @@ public static long tryWriteTo(TransferableChannel destChannel, *

[GitHub] [kafka] ijuma commented on pull request #13131: KAFKA-14628: Move CommandLineUtils and CommandDefaultOptions shared classes

2023-01-30 Thread via GitHub
ijuma commented on PR #13131: URL: https://github.com/apache/kafka/pull/13131#issuecomment-1409209835 Got it, so it's useful for `main` methods too - not just CLI tools. Then it's fine for it to be in `server-common`. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [kafka] cmccabe merged pull request #13153: MINOR: startup timeouts for KRaft integration tests

2023-01-30 Thread via GitHub
cmccabe merged PR #13153: URL: https://github.com/apache/kafka/pull/13153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] cmccabe commented on a diff in pull request #13161: Kafka 14128

2023-01-30 Thread via GitHub
cmccabe commented on code in PR #13161: URL: https://github.com/apache/kafka/pull/13161#discussion_r1091058054 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -521,7 +524,7 @@ protected Map getNumPartitions(final Set topics

[GitHub] [kafka] cmccabe commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-01-30 Thread via GitHub
cmccabe commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1091061226 ## clients/src/main/java/org/apache/kafka/common/utils/Time.java: ## @@ -86,4 +89,30 @@ default Timer timer(Duration timeout) { return timer(timeout.toMillis()

[GitHub] [kafka] C0urante commented on a diff in pull request #13163: KAFKA-14653: MirrorMakerConfig using raw properties instead of post-r…

2023-01-30 Thread via GitHub
C0urante commented on code in PR #13163: URL: https://github.com/apache/kafka/pull/13163#discussion_r1091016715 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -246,13 +246,22 @@ public Map originals(Map configOverrides) { */ public

[GitHub] [kafka] mjsax commented on a diff in pull request #12654: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

2023-01-30 Thread via GitHub
mjsax commented on code in PR #12654: URL: https://github.com/apache/kafka/pull/12654#discussion_r1091058442 ## streams/src/main/java/org/apache/kafka/streams/processor/StateRestoreListener.java: ## @@ -37,6 +37,9 @@ * These two interfaces serve different restoration purposes

[GitHub] [kafka] mjsax commented on pull request #12654: KAFKA-10575: Add onRestoreSuspsnded to StateRestoreListener

2023-01-30 Thread via GitHub
mjsax commented on PR #12654: URL: https://github.com/apache/kafka/pull/12654#issuecomment-1409251099 Why has this PR 392 commits? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [kafka] vladimirdyuzhev commented on a diff in pull request #13081: Re-using callbackHandler for refreshing Kerberos TGT when keytab is not used

2023-01-30 Thread via GitHub
vladimirdyuzhev commented on code in PR #13081: URL: https://github.com/apache/kafka/pull/13081#discussion_r1091084183 ## clients/src/main/java/org/apache/kafka/common/security/kerberos/KerberosLogin.java: ## @@ -90,6 +91,7 @@ public void configure(Map configs, String contextNa

[GitHub] [kafka] Hangleton commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-01-30 Thread via GitHub
Hangleton commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1091084191 ## clients/src/main/java/org/apache/kafka/common/utils/Time.java: ## @@ -86,4 +89,30 @@ default Timer timer(Duration timeout) { return timer(timeout.toMillis

[GitHub] [kafka] cmccabe commented on a diff in pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-01-30 Thread via GitHub
cmccabe commented on code in PR #13169: URL: https://github.com/apache/kafka/pull/13169#discussion_r1091087602 ## clients/src/main/java/org/apache/kafka/common/utils/Time.java: ## @@ -86,4 +89,30 @@ default Timer timer(Duration timeout) { return timer(timeout.toMillis()

[jira] [Commented] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

2023-01-30 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682265#comment-17682265 ] Andy Coates commented on KAFKA-14660: - Hey Matthias ;) > Divide by zero security vu

[GitHub] [kafka] C0urante commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-30 Thread via GitHub
C0urante commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091084063 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[jira] [Commented] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

2023-01-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682291#comment-17682291 ] Matthias J. Sax commented on KAFKA-14660: - Hey Andy – thanks for the ticket. We

[GitHub] [kafka] mjsax commented on a diff in pull request #13161: Kafka 14128

2023-01-30 Thread via GitHub
mjsax commented on code in PR #13161: URL: https://github.com/apache/kafka/pull/13161#discussion_r1091222822 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -466,7 +469,10 @@ public Set makeReady(final Map topics) {

[GitHub] [kafka] mjsax commented on a diff in pull request #13161: Kafka 14128

2023-01-30 Thread via GitHub
mjsax commented on code in PR #13161: URL: https://github.com/apache/kafka/pull/13161#discussion_r1091223587 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java: ## @@ -538,6 +544,8 @@ protected Map getNumPartitions(final Set topics,

[GitHub] [kafka] cmccabe commented on pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-01-30 Thread via GitHub
cmccabe commented on PR #13169: URL: https://github.com/apache/kafka/pull/13169#issuecomment-1409444203 Looks like Jenkins is having issues. ``` [2023-01-30T20:15:48.665Z] + ./retry_zinc ./gradlew -PscalaVersion=2.13 clean compileJava compileScala compileTestJava compileTestScala spot

[GitHub] [kafka] cmccabe opened a new pull request, #13176: MINOR: some ZK migration code cleanups.

2023-01-30 Thread via GitHub
cmccabe opened a new pull request, #13176: URL: https://github.com/apache/kafka/pull/13176 Some minor improvements to the JavaDoc for ZkMigrationState. Rename MigrationState to MigrationDriverState to avoid confusion with ZkMigrationState. Remove ClusterImage#zkBrokers. This co

[GitHub] [kafka] cmccabe commented on pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-01-30 Thread via GitHub
cmccabe commented on PR #13169: URL: https://github.com/apache/kafka/pull/13169#issuecomment-1409506162 retest this please -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[jira] [Commented] (KAFKA-14660) Divide by zero security vulnerability (sonatype-2019-0422)

2023-01-30 Thread Andy Coates (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682304#comment-17682304 ] Andy Coates commented on KAFKA-14660: - As per description, I think the best 'fix' mi

[GitHub] [kafka] anatasiavela commented on pull request #13078: KAFKA-13999: Add ProducerCount metrics (KIP-847)

2023-01-30 Thread via GitHub
anatasiavela commented on PR #13078: URL: https://github.com/apache/kafka/pull/13078#issuecomment-1409535758 @divijvaidya Since this PR is strictly focusing on the metric, I think it's reasonable for that change to be done in a separate PR. what do you think? -- This is an automated messa

[GitHub] [kafka] cmccabe commented on a diff in pull request #13116: KAFKA-14351: Controller Mutation Quota for KRaft

2023-01-30 Thread via GitHub
cmccabe commented on code in PR #13116: URL: https://github.com/apache/kafka/pull/13116#discussion_r1091311692 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -322,15 +325,37 @@ class ControllerApis(val requestChannel: RequestChannel, } }

[jira] [Created] (KAFKA-14663) High throughput topics can starve low-throughput MM2 offset syncs

2023-01-30 Thread Greg Harris (Jira)
Greg Harris created KAFKA-14663: --- Summary: High throughput topics can starve low-throughput MM2 offset syncs Key: KAFKA-14663 URL: https://issues.apache.org/jira/browse/KAFKA-14663 Project: Kafka

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-30 Thread via GitHub
beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-30 Thread via GitHub
beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-30 Thread via GitHub
beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[GitHub] [kafka] beardt commented on a diff in pull request #13168: Kafka 14565: Interceptor Resource Leak

2023-01-30 Thread via GitHub
beardt commented on code in PR #13168: URL: https://github.com/apache/kafka/pull/13168#discussion_r1091360138 ## clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java: ## @@ -476,14 +480,34 @@ public List getConfiguredInstances(List classNames, Class t, M

[jira] [Created] (KAFKA-14664) Raft idle ratio is inaccurate

2023-01-30 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-14664: --- Summary: Raft idle ratio is inaccurate Key: KAFKA-14664 URL: https://issues.apache.org/jira/browse/KAFKA-14664 Project: Kafka Issue Type: Bug

[GitHub] [kafka] Nayana-ibm commented on pull request #11929: MINOR: s390x Stage

2023-01-30 Thread via GitHub
Nayana-ibm commented on PR #11929: URL: https://github.com/apache/kafka/pull/11929#issuecomment-1409780907 Any update on this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (KAFKA-14646) SubscriptionWrapper is of an incompatible version (Kafka Streams 3.2.3 -> 3.3.2)

2023-01-30 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17682401#comment-17682401 ] Matthias J. Sax commented on KAFKA-14646: - I was thinking about this issue, and

[GitHub] [kafka] cmccabe merged pull request #13159: KAFKA-14656 Send UMR first during ZK migration

2023-01-30 Thread via GitHub
cmccabe merged PR #13159: URL: https://github.com/apache/kafka/pull/13159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] Hangleton commented on pull request #13169: KAFKA-14658: Do not open broker ports until we are ready to accept traffic

2023-01-30 Thread via GitHub
Hangleton commented on PR #13169: URL: https://github.com/apache/kafka/pull/13169#issuecomment-1409850803 Taking a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Assigned] (KAFKA-14585) Move StorageTool to tools

2023-01-30 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14585: - Assignee: Sagar Rao > Move StorageTool to tools > - > >

[jira] [Assigned] (KAFKA-14487) Move LogManager to storage module

2023-01-30 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-14487?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sagar Rao reassigned KAFKA-14487: - Assignee: Sagar Rao > Move LogManager to storage module > - > >

[jira] [Created] (KAFKA-14665) my custom SMT that converts Int to String does not work for primary keys

2023-01-30 Thread Fuxin Hao (Jira)
Fuxin Hao created KAFKA-14665: - Summary: my custom SMT that converts Int to String does not work for primary keys Key: KAFKA-14665 URL: https://issues.apache.org/jira/browse/KAFKA-14665 Project: Kafka

  1   2   >