[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1034451061 ## clients/src/main/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignor.java: ## @@ -84,6 +84,11 @@ public ByteBuffer subscriptionUserData(Set topics) {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1034452624 ## clients/src/main/java/org/apache/kafka/clients/consumer/StickyAssignor.java: ## @@ -216,6 +216,8 @@ public ByteBuffer subscriptionUserData(Set topics) { @Over

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1034454065 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -162,6 +162,28 @@ private boolean allSubscriptionsEqual(Set all

[GitHub] [kafka] dajac merged pull request #12910: MINOR: JoinGroup and SyncGroup callbacks should catch exceptions

dajac merged PR #12910: URL: https://github.com/apache/kafka/pull/12910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on pull request #12910: MINOR: JoinGroup and SyncGroup callbacks should catch exceptions

dajac commented on PR #12910: URL: https://github.com/apache/kafka/pull/12910#issuecomment-1330291981 Merged to trunk and 3.3. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [kafka] divijvaidya commented on pull request #12916: MINOR: fix the header size calculation

divijvaidya commented on PR #12916: URL: https://github.com/apache/kafka/pull/12916#issuecomment-1330352840 Thanks for catching this Luke! Bad of me to assume that buffer will be header data only. Seems like we incrementally read the buffer. `ResponseHeader` size is also modified at

[GitHub] [kafka] mimaison commented on pull request #12916: MINOR: fix the header size calculation

mimaison commented on PR #12916: URL: https://github.com/apache/kafka/pull/12916#issuecomment-1330362495 @divijvaidya Yeah I missed that too! Can you make a PR to address the issues? If so we probably don't need to revert #12890 -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] tinaselenge commented on pull request #12912: MINOR: Fix some compiler warnings

tinaselenge commented on PR #12912: URL: https://github.com/apache/kafka/pull/12912#issuecomment-1330377219 @showuon I have addressed your comment. There seem to be some unrelated tests failing. Would you be able to retrigger them? -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] showuon commented on pull request #12916: MINOR: fix the header size calculation

showuon commented on PR #12916: URL: https://github.com/apache/kafka/pull/12916#issuecomment-1330377511 Making another PR to address the issue is a good option. Let's fix this issue together! :) -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [kafka] dajac commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

dajac commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1034544258 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() { asser

[GitHub] [kafka] patrik-marton commented on pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

patrik-marton commented on PR #12846: URL: https://github.com/apache/kafka/pull/12846#issuecomment-1330445244 @C0urante can you take a look when you have some time? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] divijvaidya opened a new pull request, #12917: KAFKA-14414: Modify approach to calculate size of request header

divijvaidya opened a new pull request, #12917: URL: https://github.com/apache/kafka/pull/12917 https://github.com/apache/kafka/pull/12890 introduced the notion of calculating (and caching) the size for the request header during the first parse operation. This prevents re-calculation and hen

[GitHub] [kafka] divijvaidya commented on pull request #12916: MINOR: fix the header size calculation

divijvaidya commented on PR #12916: URL: https://github.com/apache/kafka/pull/12916#issuecomment-1330516571 I used a different approach to calculate the size in the PR https://github.com/apache/kafka/pull/12917 Instead of using `buffer.remaining()` which provide the un-traversed suffix

[GitHub] [kafka] divijvaidya commented on pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)

divijvaidya commented on PR #12908: URL: https://github.com/apache/kafka/pull/12908#issuecomment-1330518989 @showuon please take a look when you get a chance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[jira] [Updated] (KAFKA-14419) Same message consumed again by the same stream task after partition is lost and reassigned

[ https://issues.apache.org/jira/browse/KAFKA-14419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mikael updated KAFKA-14419: --- Description: Trigger scenario: Four Kafka client application instances on separate EC2 instances with a tot

[GitHub] [kafka] ijuma commented on pull request #12907: MINOR: [KAFKA-14421] fix NPE from OffsetFetchRequest toString

ijuma commented on PR #12907: URL: https://github.com/apache/kafka/pull/12907#issuecomment-1330706726 Thanks for the PR. Can you please target the trunk branch? We no longer update the 0.10.2 branch. -- This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [kafka] dajac commented on pull request #12897: KAFKA-14379: consumer should refresh preferred read replica on update metadata

dajac commented on PR #12897: URL: https://github.com/apache/kafka/pull/12897#issuecomment-1330712535 > A specific example is when a partition is reassigned. the consumer will get NOT_LEADER_OR_FOLLOWER which triggers a metadata update but the preferred read replica will not be refreshed as

[GitHub] [kafka] dajac commented on a diff in pull request #12897: KAFKA-14379: consumer should refresh preferred read replica on update metadata

dajac commented on code in PR #12897: URL: https://github.com/apache/kafka/pull/12897#discussion_r1034773867 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -346,8 +346,10 @@ public void onFailure(RuntimeException e) {

[GitHub] [kafka] ijuma opened a new pull request, #12918: MINOR: Update Gradle to 7.6

ijuma opened a new pull request, #12918: URL: https://github.com/apache/kafka/pull/12918 The highlights are: * Support for Java 19 * Support for incremental compilation following a compilation failure * Flag for individual task rerun (eg "gradle test --rerun") * Re-use Scala compi

[GitHub] [kafka] C0urante commented on a diff in pull request #12876: KAFKA-12476: Prevent herder tick thread from sleeping excessively after slow operations

C0urante commented on code in PR #12876: URL: https://github.com/apache/kafka/pull/12876#discussion_r1034841309 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/DistributedHerderTest.java: ## @@ -2138,7 +2137,6 @@ public void testConnectorPausedRunni

[GitHub] [kafka] C0urante merged pull request #12876: KAFKA-12476: Prevent herder tick thread from sleeping excessively after slow operations

C0urante merged PR #12876: URL: https://github.com/apache/kafka/pull/12876 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] C0urante commented on a diff in pull request #12846: KAFKA-14293: Basic Auth filter should set the SecurityContext after a…

C0urante commented on code in PR #12846: URL: https://github.com/apache/kafka/pull/12846#discussion_r1034907024 ## connect/basic-auth-extension/src/main/java/org/apache/kafka/connect/rest/basic/auth/extension/JaasBasicAuthFilter.java: ## @@ -174,4 +153,85 @@ public void handle(C

[GitHub] [kafka] C0urante commented on pull request #12898: optimize: -Dcom.sun.management.jmxremote.rmi.port=$JMX_PORT

C0urante commented on PR #12898: URL: https://github.com/apache/kafka/pull/12898#issuecomment-1330882784 @a364176773 from the JDK issue you linked, it doesn't seem like the private RMI port should have any implications in firewalled environments: > The additional port is for the RMI r

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12897: KAFKA-14379: consumer should refresh preferred read replica on update metadata

jeffkbkim commented on code in PR #12897: URL: https://github.com/apache/kafka/pull/12897#discussion_r1035045272 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -346,8 +346,10 @@ public void onFailure(RuntimeException e) {

[GitHub] [kafka] hachikuji commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

hachikuji commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1035062033 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1290,7 +1290,7 @@ public void handleResponse(AbstractResponse res

[GitHub] [kafka] hachikuji commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

hachikuji commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1035081487 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1290,7 +1290,7 @@ public void handleResponse(AbstractResponse res

[GitHub] [kafka] ijuma opened a new pull request, #12919: MINOR: buildoutput.log should be under the `build` directory

ijuma opened a new pull request, #12919: URL: https://github.com/apache/kafka/pull/12919 Otherwise it can cause `rat` to fail. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Ve

[GitHub] [kafka] mumrah commented on a diff in pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

mumrah commented on code in PR #12885: URL: https://github.com/apache/kafka/pull/12885#discussion_r1035093043 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1925,9 +1925,18 @@ class KafkaApis(val requestChannel: RequestChannel, val hasClusterAuthorization = a

[GitHub] [kafka] jolshan commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

jolshan commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1035110895 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1290,7 +1290,7 @@ public void handleResponse(AbstractResponse respo

[GitHub] [kafka] hachikuji commented on a diff in pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

hachikuji commented on code in PR #12885: URL: https://github.com/apache/kafka/pull/12885#discussion_r1035115000 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -400,7 +407,8 @@ class ControllerApis(val requestChannel: RequestChannel, if (!authorizedTopi

[GitHub] [kafka] hachikuji commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

hachikuji commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1035124199 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1290,7 +1290,7 @@ public void handleResponse(AbstractResponse res

[GitHub] [kafka] gharris1727 opened a new pull request, #12920: KAFKA-14339 : Do not perform producerCommit on serializationError when trying offsetWriter flush

gharris1727 opened a new pull request, #12920: URL: https://github.com/apache/kafka/pull/12920 Description from #12784: We shouldn't commitTransaction() on producer, when offsetWriter faces some issue and returns without sending offsets to producer. Additionally adds a test for

[GitHub] [kafka] gharris1727 commented on pull request #12784: KAFKA-14339 : Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

gharris1727 commented on PR #12784: URL: https://github.com/apache/kafka/pull/12784#issuecomment-1331129495 Superseded by #12920. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [kafka] ijuma commented on pull request #12919: MINOR: `buildoutput.log` should be under the `build` directory

ijuma commented on PR #12919: URL: https://github.com/apache/kafka/pull/12919#issuecomment-1331154011 The part of the build that uses `retry_zinc` has passed, merging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

[GitHub] [kafka] ijuma merged pull request #12919: MINOR: `buildoutput.log` should be under the `build` directory

ijuma merged PR #12919: URL: https://github.com/apache/kafka/pull/12919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] ijuma commented on pull request #12918: MINOR: Update Gradle to 7.6

ijuma commented on PR #12918: URL: https://github.com/apache/kafka/pull/12918#issuecomment-1331163702 `rat` was failing due to the `buildoutput.log` file created by `retry_zinc`. Fixed that via #12919 and rebased this PR. -- This is an automated message from the Apache Git Service. To res

[GitHub] [kafka] C0urante commented on a diff in pull request #12899: KAFKA-14413: Separate MirrorMaker configurations for each connector

C0urante commented on code in PR #12899: URL: https://github.com/apache/kafka/pull/12899#discussion_r1034980195 ## connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorCheckpointConnector.java: ## @@ -45,7 +45,7 @@ public class MirrorCheckpointConnector extends So

[GitHub] [kafka] C0urante commented on a diff in pull request #12920: KAFKA-14339 : Do not perform producerCommit on serializationError when trying offsetWriter flush

C0urante commented on code in PR #12920: URL: https://github.com/apache/kafka/pull/12920#discussion_r1035151360 ## connect/runtime/src/main/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTask.java: ## @@ -282,16 +282,18 @@ private void commitTransaction() {

[jira] [Assigned] (KAFKA-14339) producer commits-transaction even if offsetWriter faces serializationError

[ https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14339: - Assignee: Greg Harris (was: Sudesh Wasnik) > producer commits-transaction even if offs

[GitHub] [kafka] dajac merged pull request #12845: KAFKA-14367; Add `JoinGroup` to the new `GroupCoordinator` interface

dajac merged PR #12845: URL: https://github.com/apache/kafka/pull/12845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

[GitHub] [kafka] dajac commented on a diff in pull request #12847: KAFKA-14367; Add `SyncGroup` to the new `GroupCoordinator` interface

dajac commented on code in PR #12847: URL: https://github.com/apache/kafka/pull/12847#discussion_r1035221877 ## core/src/test/scala/unit/kafka/server/KafkaApisTest.scala: ## @@ -2690,110 +2689,150 @@ class KafkaApisTest { assertEquals(Errors.GROUP_AUTHORIZATION_FAILED, resp

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12920: KAFKA-14339 : Do not perform producerCommit on serializationError when trying offsetWriter flush

gharris1727 commented on code in PR #12920: URL: https://github.com/apache/kafka/pull/12920#discussion_r1035223460 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/ExactlyOnceWorkerSourceTaskTest.java: ## @@ -687,7 +687,26 @@ public void testCommitFlushCallbackF

[GitHub] [kafka] jsancio commented on a diff in pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

jsancio commented on code in PR #12885: URL: https://github.com/apache/kafka/pull/12885#discussion_r1035279719 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -400,7 +407,8 @@ class ControllerApis(val requestChannel: RequestChannel, if (!authorizedTopicN

[GitHub] [kafka] jsancio commented on pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

jsancio commented on PR #12885: URL: https://github.com/apache/kafka/pull/12885#issuecomment-1331311469 > Thanks for the patch @jsancio. Just a couple of comments. > > I tried creating `__cluster_metadata` on trunk and got a non-fatal error: > > ``` > [2022-11-29 13:11:47,725

[jira] [Commented] (KAFKA-14415) ThreadCache is getting slower with every additional state store

[ https://issues.apache.org/jira/browse/KAFKA-14415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640936#comment-17640936 ] Lucas Brutschy commented on KAFKA-14415: I fear the tool for generating this is

[GitHub] [kafka] joel-hamill opened a new pull request, #12921: MINOR: fix config syntax

joel-hamill opened a new pull request, #12921: URL: https://github.com/apache/kafka/pull/12921 *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comment to ping reviewers.* *Summary of tes

[GitHub] [kafka] joel-hamill commented on pull request #12921: MINOR: fix config syntax

joel-hamill commented on PR #12921: URL: https://github.com/apache/kafka/pull/12921#issuecomment-1331343528 cc @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [kafka] jolshan commented on a diff in pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

jolshan commented on code in PR #12915: URL: https://github.com/apache/kafka/pull/12915#discussion_r1035309932 ## clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java: ## @@ -1290,7 +1290,7 @@ public void handleResponse(AbstractResponse respo

[GitHub] [kafka] hachikuji opened a new pull request, #12922: KAFKA-14397; Don't reset producer sequence number after delivery timeout

hachikuji opened a new pull request, #12922: URL: https://github.com/apache/kafka/pull/12922 When a batch is failed after reaching its delivery timeout, we do not necessarily know whether the broker actually committed it to disk. For example, in the case of a `REQUEST_TIMEOUT` error, it is

[GitHub] [kafka] jsancio commented on a diff in pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

jsancio commented on code in PR #12885: URL: https://github.com/apache/kafka/pull/12885#discussion_r1035322059 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1925,9 +1925,18 @@ class KafkaApis(val requestChannel: RequestChannel, val hasClusterAuthorization =

[GitHub] [kafka] jolshan commented on a diff in pull request #12922: KAFKA-14397; Don't reset producer sequence number after delivery timeout

jolshan commented on code in PR #12922: URL: https://github.com/apache/kafka/pull/12922#discussion_r1035324593 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -808,6 +808,162 @@ public void testIdempotenceWithMultipleInflights() throws

[GitHub] [kafka] jolshan commented on a diff in pull request #12922: KAFKA-14397; Don't reset producer sequence number after delivery timeout

jolshan commented on code in PR #12922: URL: https://github.com/apache/kafka/pull/12922#discussion_r1035325704 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -808,6 +808,162 @@ public void testIdempotenceWithMultipleInflights() throws

[GitHub] [kafka] ijuma opened a new pull request, #12923: MINOR: Remove config/kraft/README.md from rat exclusion list

ijuma opened a new pull request, #12923: URL: https://github.com/apache/kafka/pull/12923 This file was deleted a while back. ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Veri

[GitHub] [kafka] jsancio commented on a diff in pull request #12921: MINOR: fix config syntax

jsancio commented on code in PR #12921: URL: https://github.com/apache/kafka/pull/12921#discussion_r1035335635 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -61,10 +61,10 @@ public class BrokerSecurityConfigs { public st

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1026994564 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorManager.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] hachikuji commented on a diff in pull request #12922: KAFKA-14397; Don't reset producer sequence number after delivery timeout

hachikuji commented on code in PR #12922: URL: https://github.com/apache/kafka/pull/12922#discussion_r1035364675 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -808,6 +808,162 @@ public void testIdempotenceWithMultipleInflights() thro

[GitHub] [kafka] hachikuji commented on a diff in pull request #12922: KAFKA-14397; Don't reset producer sequence number after delivery timeout

hachikuji commented on code in PR #12922: URL: https://github.com/apache/kafka/pull/12922#discussion_r1035364839 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -808,6 +808,162 @@ public void testIdempotenceWithMultipleInflights() thro

[GitHub] [kafka] jolshan commented on a diff in pull request #12922: KAFKA-14397; Don't reset producer sequence number after delivery timeout

jolshan commented on code in PR #12922: URL: https://github.com/apache/kafka/pull/12922#discussion_r1035369652 ## clients/src/test/java/org/apache/kafka/clients/producer/internals/SenderTest.java: ## @@ -808,6 +808,162 @@ public void testIdempotenceWithMultipleInflights() throws

[GitHub] [kafka] joel-hamill commented on pull request #12921: MINOR: fix config syntax

joel-hamill commented on PR #12921: URL: https://github.com/apache/kafka/pull/12921#issuecomment-1331430529 @jsancio updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Created] (KAFKA-14424) Cancellation of an ongoing replica reassignment should have sanity checks

Lucas Wang created KAFKA-14424: -- Summary: Cancellation of an ongoing replica reassignment should have sanity checks Key: KAFKA-14424 URL: https://issues.apache.org/jira/browse/KAFKA-14424 Project: Kafka

[GitHub] [kafka] jsancio commented on a diff in pull request #12921: MINOR; Fix config documentation formatting

jsancio commented on code in PR #12921: URL: https://github.com/apache/kafka/pull/12921#discussion_r1035377520 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -61,10 +61,10 @@ public class BrokerSecurityConfigs { public st

[GitHub] [kafka] jsancio commented on a diff in pull request #12921: MINOR; Fix config documentation formatting

jsancio commented on code in PR #12921: URL: https://github.com/apache/kafka/pull/12921#discussion_r1035377520 ## clients/src/main/java/org/apache/kafka/common/config/internals/BrokerSecurityConfigs.java: ## @@ -61,10 +61,10 @@ public class BrokerSecurityConfigs { public st

[GitHub] [kafka] jeffkbkim commented on pull request #12897: KAFKA-14379: consumer should refresh preferred read replica on update metadata

jeffkbkim commented on PR #12897: URL: https://github.com/apache/kafka/pull/12897#issuecomment-1331446867 thanks @dajac for the review. as discussed offline: `nodeIfOnline` will be updated to also check whether the node is within the given partition info replica set. this will help cl

[GitHub] [kafka] hachikuji commented on a diff in pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

hachikuji commented on code in PR #12885: URL: https://github.com/apache/kafka/pull/12885#discussion_r1035394196 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -400,7 +407,8 @@ class ControllerApis(val requestChannel: RequestChannel, if (!authorizedTopi

[GitHub] [kafka] C0urante commented on pull request #12920: KAFKA-14339 : Do not perform producerCommit on serializationError when trying offsetWriter flush

C0urante commented on PR #12920: URL: https://github.com/apache/kafka/pull/12920#issuecomment-1331477599 Test failures are unrelated; merging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] C0urante merged pull request #12920: KAFKA-14339 : Do not perform producerCommit on serializationError when trying offsetWriter flush

C0urante merged PR #12920: URL: https://github.com/apache/kafka/pull/12920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1035407440 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -190,7 +190,7 @@ class KafkaApis(val requestChannel: RequestChannel, case ApiKeys.HEARTBEAT => handl

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1035408371 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1567,53 +1567,54 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleDescribeG

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1035408521 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1567,53 +1567,54 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleDescribeG

[GitHub] [kafka] jolshan commented on a diff in pull request #12855: KAFKA-14367; Add `DescribeGroups` to the new `GroupCoordinator` interface

jolshan commented on code in PR #12855: URL: https://github.com/apache/kafka/pull/12855#discussion_r1035413661 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1567,53 +1567,54 @@ class KafkaApis(val requestChannel: RequestChannel, } } - def handleDescribeG

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035410111 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035426004 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorManager.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation

[jira] [Updated] (KAFKA-14339) Source task producers commit transactions even if offsets cannot be serialized

[ https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14339: -- Summary: Source task producers commit transactions even if offsets cannot be serialized (was:

[jira] [Updated] (KAFKA-14339) Source task producers commit transactions even if offsets cannot be serialized

[ https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14339: -- Priority: Major (was: Minor) > Source task producers commit transactions even if offsets cann

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035428028 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorManager.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jolshan commented on pull request #12915: KAFKA-14417: Producer doesn't handle REQUEST_TIMED_OUT for InitProducerIdRequest, treats as fatal error

jolshan commented on PR #12915: URL: https://github.com/apache/kafka/pull/12915#issuecomment-1331508810 Test failures so far seem to be unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Updated] (KAFKA-14339) Source task producers commit transactions even if offsets cannot be serialized

[ https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton updated KAFKA-14339: -- Labels: exactly-once (was: ) > Source task producers commit transactions even if offsets cann

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035430301 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035431454 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/DefaultBackgroundThread.java: ## @@ -109,34 +129,31 @@ public void run() { try {

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035432323 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorManager.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] vamossagar12 commented on pull request #12802: KAFKA-14311: Connect Worker clean shutdown does not cleanly stop connectors/tasks

vamossagar12 commented on PR #12802: URL: https://github.com/apache/kafka/pull/12802#issuecomment-1331521687 @C0urante , bumping this one again. Can you plz take a look whenever you get the chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035413023 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorManager.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] jsancio commented on a diff in pull request #12885: KAFKA-14358; Disallow creation of cluster metadata partition

jsancio commented on code in PR #12885: URL: https://github.com/apache/kafka/pull/12885#discussion_r1035441299 ## core/src/main/scala/kafka/server/ControllerApis.scala: ## @@ -400,7 +407,8 @@ class ControllerApis(val requestChannel: RequestChannel, if (!authorizedTopicN

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035445551 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] a364176773 commented on pull request #12898: optimize: -Dcom.sun.management.jmxremote.rmi.port=$JMX_PORT

a364176773 commented on PR #12898: URL: https://github.com/apache/kafka/pull/12898#issuecomment-1331580521 > @a364176773 from the JDK issue you linked, it doesn't seem like the private RMI port should have any implications in firewalled environments: > > > The additional port is for t

[GitHub] [kafka] stan-confluent opened a new pull request, #12924: try-finally around super call in http.py

stan-confluent opened a new pull request, #12924: URL: https://github.com/apache/kafka/pull/12924 Adds a safety check in `HttpMetricsCollector` - if the `super()` call fails we still want to shut down httpd thread. The issue with `HttpMetricsCollector` is that it starts httpd thread o

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035495650 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/NetworkClientDelegate.java: ## @@ -0,0 +1,221 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [kafka] hachikuji commented on a diff in pull request #12862: Consumer refator find coordinator

hachikuji commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035495877 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorManager.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] showuon closed pull request #12916: MINOR: fix the header size calculation

showuon closed pull request #12916: MINOR: fix the header size calculation URL: https://github.com/apache/kafka/pull/12916 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

[GitHub] [kafka] showuon commented on pull request #12916: MINOR: fix the header size calculation

showuon commented on PR #12916: URL: https://github.com/apache/kafka/pull/12916#issuecomment-1331607350 Close this PR and fix in https://github.com/apache/kafka/pull/12917 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12847: KAFKA-14367; Add `SyncGroup` to the new `GroupCoordinator` interface

jeffkbkim commented on code in PR #12847: URL: https://github.com/apache/kafka/pull/12847#discussion_r1035483192 ## core/src/main/scala/kafka/server/KafkaApis.scala: ## @@ -1696,45 +1696,37 @@ class KafkaApis(val requestChannel: RequestChannel, def handleSyncGroupRequest(requ

[GitHub] [kafka] philipnee commented on a diff in pull request #12862: Consumer refator find coordinator

philipnee commented on code in PR #12862: URL: https://github.com/apache/kafka/pull/12862#discussion_r1035514117 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/CoordinatorManager.java: ## @@ -0,0 +1,245 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [kafka] showuon commented on a diff in pull request #12917: KAFKA-14414: Modify approach to calculate size of request header

showuon commented on code in PR #12917: URL: https://github.com/apache/kafka/pull/12917#discussion_r1035539675 ## clients/src/main/java/org/apache/kafka/common/requests/RequestHeader.java: ## @@ -117,23 +117,23 @@ public static RequestHeader parse(ByteBuffer buffer) { t

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035598438 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() { ass

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035598601 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() { ass

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035598812 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() { ass

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035599008 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() { ass

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035599539 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -116,6 +130,74 @@ public void testAllConsumersHaveOwnedPartitionIn

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035600480 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {

[GitHub] [kafka] showuon commented on pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on PR #12748: URL: https://github.com/apache/kafka/pull/12748#issuecomment-1331732502 @dajac , Thanks for the comments. PR updated. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

  1   2   >