divijvaidya commented on PR #12916: URL: https://github.com/apache/kafka/pull/12916#issuecomment-1330352840
Thanks for catching this Luke! Bad of me to assume that buffer will be header data only. Seems like we incrementally read the buffer. `ResponseHeader` size is also modified at https://github.com/apache/kafka/pull/12890, we need to revert that back too. Perhaps revert the entire commit? I can create a new one which would fix the performance problem (not using ObjectSerialization cache when it isn't required) and yet keep the correct semantics. After the revert, we can use this PR to add tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
