jsancio commented on code in PR #12885:
URL: https://github.com/apache/kafka/pull/12885#discussion_r1035441299
##########
core/src/main/scala/kafka/server/ControllerApis.scala:
##########
@@ -400,7 +407,8 @@ class ControllerApis(val requestChannel: RequestChannel,
if (!authorizedTopicNames.contains(name)) {
response.topics().add(new CreatableTopicResult().
setName(name).
- setErrorCode(TOPIC_AUTHORIZATION_FAILED.code))
+ setErrorCode(TOPIC_AUTHORIZATION_FAILED.code).
+ setErrorMessage("Authorization failed."))
Review Comment:
Thanks for the background information. I found another issue while trying to
implement this. The default for `CreateTopicsResponse.errorMessage` is the
empty string, `""`, not `null`. This means that `ApiError.messageWithFallback`
doesn't behave as expected.
I am going to create an issue for this and tackle it in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
