[GitHub] [kafka] shirenchuang closed pull request #11445: createTopic need sort brokerMetadata

shirenchuang closed pull request #11445: createTopic need sort brokerMetadata URL: https://github.com/apache/kafka/pull/11445 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] shirenchuang closed pull request #11453: createTopic need sort brokerMetadata

shirenchuang closed pull request #11453: createTopic need sort brokerMetadata URL: https://github.com/apache/kafka/pull/11453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [kafka] shirenchuang closed pull request #12793: [KAFKA-14328]: KafkaAdminClient should be Changing the exception level …

shirenchuang closed pull request #12793: [KAFKA-14328]: KafkaAdminClient should be Changing the exception level … URL: https://github.com/apache/kafka/pull/12793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] Scanteianu commented on a diff in pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

Scanteianu commented on code in PR #12753: URL: https://github.com/apache/kafka/pull/12753#discussion_r1007759537 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -694,6 +694,73 @@ class PlaintextConsumerTest extends BaseConsumerTest { assertE

[GitHub] [kafka] Scanteianu commented on a diff in pull request #12753: MINOR: Document Offset and Partition 0-indexing, fix typo

Scanteianu commented on code in PR #12753: URL: https://github.com/apache/kafka/pull/12753#discussion_r1007760016 ## core/src/test/scala/integration/kafka/api/PlaintextConsumerTest.scala: ## @@ -694,6 +694,73 @@ class PlaintextConsumerTest extends BaseConsumerTest { assertE

[jira] [Updated] (KAFKA-14281) Multi-level rack awareness

[ https://issues.apache.org/jira/browse/KAFKA-14281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-14281: Labels: cloudera (was: ) > Multi-level rack awareness > -

[jira] [Updated] (KAFKA-14250) Exception during normal operation in MirrorSourceTask causes the task to fail instead of shutting down gracefully

[ https://issues.apache.org/jira/browse/KAFKA-14250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated KAFKA-14250: Labels: cloudera (was: ) > Exception during normal operation in MirrorSourceTask

[GitHub] [kafka] mimaison commented on a diff in pull request #12769: KAFKA-14314: Add check for null upstreamTopic

mimaison commented on code in PR #12769: URL: https://github.com/apache/kafka/pull/12769#discussion_r1007784731 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -319,4 +320,17 @@ public void testRefreshTopicPartitionsTopicOnTa

[jira] [Commented] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625532#comment-17625532 ] David Jacot commented on KAFKA-13419: - [~ableegoldman] [~showuon] Looking at the cod

[jira] [Commented] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625541#comment-17625541 ] Luke Chen commented on KAFKA-13419: --- [~dajac] , you're right. We don't use owned parti

[jira] [Commented] (KAFKA-13419) sync group failed with rebalanceInProgress error might cause out-of-date ownedPartition in Cooperative protocol

[ https://issues.apache.org/jira/browse/KAFKA-13419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625542#comment-17625542 ] David Jacot commented on KAFKA-13419: - [~showuon] Thanks for confirming. > sync gro

[jira] [Commented] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625551#comment-17625551 ] David Jacot commented on KAFKA-14016: - > The sticky assignment algorithm should acco

[jira] [Assigned] (KAFKA-14339) producer commits-transaction even if offsetWriter faces serializationError

[ https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14339: - Assignee: Chris Egerton > producer commits-transaction even if offsetWriter faces seria

[jira] [Assigned] (KAFKA-14339) producer commits-transaction even if offsetWriter faces serializationError

[ https://issues.apache.org/jira/browse/KAFKA-14339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-14339: - Assignee: Sudesh Wasnik (was: Chris Egerton) > producer commits-transaction even if of

[jira] [Comment Edited] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625551#comment-17625551 ] David Jacot edited comment on KAFKA-14016 at 10/28/22 9:29 AM: ---

[jira] [Comment Edited] (KAFKA-14016) Revoke more partitions than expected in Cooperative rebalance

[ https://issues.apache.org/jira/browse/KAFKA-14016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17625551#comment-17625551 ] David Jacot edited comment on KAFKA-14016 at 10/28/22 9:30 AM: ---

[GitHub] [kafka] C0urante commented on pull request #12671: KAFKA-14250: MirrorSourceTask exception causes the task to fail

C0urante commented on PR #12671: URL: https://github.com/apache/kafka/pull/12671#issuecomment-1294775103 I'm not opposed to improving error messages, but I'd like to ask again which version of Kafka Connect / MirrorMaker 2 you were running when you encountered this issue. We've already made

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1007859820 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -82,15 +84,17 @@ public void testClientConfigProperties() {

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1008030917 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -123,91 +134,91 @@ private enum SourceSink { priva

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1008040282 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) {

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r1008043521 ## connect/runtime/src/main/java/org/apache/kafka/connect/util/ConnectUtils.java: ## @@ -171,4 +175,28 @@ public static ConnectException maybeWrap(Throwable t, String

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008047026 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,553 @@ +/* + *

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12728: KAFKA-14132; Replace EasyMock with Mockito in StandaloneHerderTest

mdedetrich commented on code in PR #12728: URL: https://github.com/apache/kafka/pull/12728#discussion_r1008052072 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/standalone/StandaloneHerderTest.java: ## @@ -319,35 +318,28 @@ public void testRestartConnectorNewT

[GitHub] [kafka] mimaison commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

mimaison commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008070254 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,553 @@ +/* + *

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008071035 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -82,15 +84,17 @@ public void testClientConfigProperties() {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008071035 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -82,15 +84,17 @@ public void testClientConfigProperties() {

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008074680 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -82,15 +84,17 @@ public void testClientConfigProperties() {

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1008075576 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -262,127 +254,96 @@ public void testFullExpandCon

[GitHub] [kafka] mdedetrich commented on a diff in pull request #12725: KAFKA-14132; Replace EasyMock with Mockito ConnectorsResourceTest

mdedetrich commented on code in PR #12725: URL: https://github.com/apache/kafka/pull/12725#discussion_r1008075576 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/resources/ConnectorsResourceTest.java: ## @@ -262,127 +254,96 @@ public void testFullExpandCon

[GitHub] [kafka] sudeshwasnik commented on pull request #12784: KAFKA-14339 : Do not perform prodcuerCommit on serializationError when trying offsetWriter flush

sudeshwasnik commented on PR #12784: URL: https://github.com/apache/kafka/pull/12784#issuecomment-1295033345 @C0urante @vamossagar12 quick dumb question - if there is an Async failure (detected after offsets are dispatched to producer), won't producer.commitTransaction also throw exception

[GitHub] [kafka] LinShunKang commented on a diff in pull request #12545: KIP-863: Reduce Fetcher#parseRecord() memory copy

LinShunKang commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1008118806 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java: ## @@ -1413,22 +1414,19 @@ private ConsumerRecord parseRecord(TopicPartition par

[GitHub] [kafka] LinShunKang commented on a diff in pull request #12545: KIP-863: Reduce Fetcher#parseRecord() memory copy

LinShunKang commented on code in PR #12545: URL: https://github.com/apache/kafka/pull/12545#discussion_r1008120362 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -263,6 +264,16 @@ public String deserialize(String topic, byte[] data) {

[GitHub] [kafka] cowlike commented on a diff in pull request #12769: KAFKA-14314: Add check for null upstreamTopic

cowlike commented on code in PR #12769: URL: https://github.com/apache/kafka/pull/12769#discussion_r1008128725 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorSourceConnectorTest.java: ## @@ -319,4 +320,17 @@ public void testRefreshTopicPartitionsTopicOnTar

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008147190 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,553 @@ +/* + *

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008147190 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsWithCustomForwardingAdminIntegrationTest.java: ## @@ -0,0 +1,553 @@ +/* + *

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008149257 ## connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java: ## @@ -56,7 +58,11 @@ public class MirrorClientConfig extends AbstractCo

[GitHub] [kafka] lucasbru commented on a diff in pull request #12772: KAFKA-14299: Avoid busy polling in state updater

lucasbru commented on code in PR #12772: URL: https://github.com/apache/kafka/pull/12772#discussion_r1008150108 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java: ## @@ -353,19 +353,21 @@ public static StreamThread create(final TopologyMetad

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008151052 ## clients/src/main/java/org/apache/kafka/clients/admin/ForwardingAdmin.java: ## @@ -0,0 +1,284 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [kafka] OmniaGM commented on a diff in pull request #12577: KAFKA-13401: KIP-787 - MM2 manage Kafka resources with custom Admin implementation.

OmniaGM commented on code in PR #12577: URL: https://github.com/apache/kafka/pull/12577#discussion_r1008151429 ## connect/mirror/src/test/java/org/apache/kafka/connect/mirror/MirrorMakerConfigTest.java: ## @@ -82,15 +84,17 @@ public void testClientConfigProperties() {

[GitHub] [kafka] lucasbru commented on a diff in pull request #12773: KAFKA-14299: Return emptied ChangelogReader to ACTIVE_RESTORING

lucasbru commented on code in PR #12773: URL: https://github.com/apache/kafka/pull/12773#discussion_r1008163226 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java: ## @@ -990,6 +991,10 @@ public void unregister(final Collection revok

[GitHub] [kafka] lucasbru commented on a diff in pull request #12773: KAFKA-14299: Return emptied ChangelogReader to ACTIVE_RESTORING

lucasbru commented on code in PR #12773: URL: https://github.com/apache/kafka/pull/12773#discussion_r1008181271 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/StoreChangelogReaderTest.java: ## @@ -1070,6 +1071,11 @@ public void shouldTransitState() {

[GitHub] [kafka] nicktelford commented on a diff in pull request #12393: WIP: KAFKA-12549 Prototype for transactional state stores

nicktelford commented on code in PR #12393: URL: https://github.com/apache/kafka/pull/12393#discussion_r1008188697 ## streams/src/test/java/org/apache/kafka/streams/integration/EOSUncleanShutdownIntegrationTest.java: ## @@ -73,16 +75,25 @@ public class EOSUncleanShutdownIntegrat

[GitHub] [kafka] mimaison merged pull request #12769: KAFKA-14314: Add check for null upstreamTopic

mimaison merged PR #12769: URL: https://github.com/apache/kafka/pull/12769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14314) MirrorSourceConnector throwing NPE during `isCycle` check

[ https://issues.apache.org/jira/browse/KAFKA-14314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-14314. Fix Version/s: 3.4.0 Resolution: Fixed > MirrorSourceConnector throwing NPE during

[GitHub] [kafka] mimaison merged pull request #12692: MINOR: Add test cases to the Raft module

mimaison merged PR #12692: URL: https://github.com/apache/kafka/pull/12692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007536584 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007536584 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1007536584 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,97 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] lucasbru opened a new pull request, #12795: KAFKA-14299: Initialize directly after handleAssignment

lucasbru opened a new pull request, #12795: URL: https://github.com/apache/kafka/pull/12795 The original state updater code path put tasks into an "initialization queue", with created, but not initialized tasks. These are later, during the event-loop, initialized and added to the state upda

[GitHub] [kafka] lucasbru commented on pull request #12795: KAFKA-14299: Initialize directly after handleAssignment

lucasbru commented on PR #12795: URL: https://github.com/apache/kafka/pull/12795#issuecomment-1295197667 @cadonna Could you have a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [kafka] hachikuji opened a new pull request, #12796: MINOR: Add test case for topic recreation with collision chars

hachikuji opened a new pull request, #12796: URL: https://github.com/apache/kafka/pull/12796 This patch adds a unit test for topic recreation with colliding characters (such as `.`). This was broken up until https://github.com/apache/kafka/pull/12790. ### Committer Checklist (exclud

[GitHub] [kafka] hachikuji merged pull request #12790: KAFKA-14337: correctly remove topicsWithCollisionChars after topic deletion

hachikuji merged PR #12790: URL: https://github.com/apache/kafka/pull/12790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] justinrlee opened a new pull request, #12797: [WIP] MINOR: Remove requirement to specify --bootstrap-server in utility scripts if specified in property file

justinrlee opened a new pull request, #12797: URL: https://github.com/apache/kafka/pull/12797 This is a relatively minor quality of life change. Currently, some of the various `kafka-X` commands (which wrap various Kafka admin calls) require that `--bootstrap-server` (or, occasionally

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1008302178 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplica

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1008309856 ## core/src/main/scala/kafka/server/ReplicaFetcherThread.scala: ## @@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String, brokerTopicStats.updateReplica

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12789: KAFKA-13989: Errors while evaluating connector type should return UNKNOWN

gharris1727 commented on code in PR #12789: URL: https://github.com/apache/kafka/pull/12789#discussion_r1008315241 ## connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java: ## @@ -192,6 +193,41 @@ public void testConnectorStatus() { Conn

[GitHub] [kafka] jeffkbkim commented on pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on PR #12783: URL: https://github.com/apache/kafka/pull/12783#issuecomment-1295299541 i've benchmarked the change in our internal infrastructure and stressed the number of topic partitions. there were no noticeable differences (lock contention/cpu/load) and confirmed the

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1008321714 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,110 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] jeffkbkim commented on a diff in pull request #12783: KAFKA-14334: complete delayed purgatory after replication

jeffkbkim commented on code in PR #12783: URL: https://github.com/apache/kafka/pull/12783#discussion_r1008323698 ## core/src/test/scala/integration/kafka/server/FetchFromFollowerIntegrationTest.scala: ## @@ -0,0 +1,110 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12791: KAFKA-14338: Use MockTime in RetryUtilTest to eliminate flakiness

gharris1727 commented on code in PR #12791: URL: https://github.com/apache/kafka/pull/12791#discussion_r1008325977 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/RetryUtilTest.java: ## @@ -116,16 +117,20 @@ public void testNoBackoffTimeAndSucceed() throws Except

[GitHub] [kafka] gharris1727 commented on a diff in pull request #12791: KAFKA-14338: Use MockTime in RetryUtilTest to eliminate flakiness

gharris1727 commented on code in PR #12791: URL: https://github.com/apache/kafka/pull/12791#discussion_r1008326288 ## connect/runtime/src/test/java/org/apache/kafka/connect/util/RetryUtilTest.java: ## @@ -50,16 +52,15 @@ public void setUp() throws Exception { @Test pub

[GitHub] [kafka] C0urante commented on pull request #12366: KAFKA-14021: Implement new KIP-618 APIs in MirrorSourceConnector

C0urante commented on PR #12366: URL: https://github.com/apache/kafka/pull/12366#issuecomment-1295343296 It turns out that the `testReplication` flakiness persisted in Jenkins, and was not solved by increasing timeouts. Instead, the root of the problem was a change in the Connect fram

[GitHub] [kafka] jsancio commented on a diff in pull request #12796: MINOR: Add test case for topic recreation with collision chars

jsancio commented on code in PR #12796: URL: https://github.com/apache/kafka/pull/12796#discussion_r1008380883 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -698,6 +714,21 @@ public void testCreateTopicsWithPolicy() throws Except

[GitHub] [kafka] hachikuji commented on pull request #12392: KAFKA-14053: Transactional producer should bump the epoch and skip ab…

hachikuji commented on PR #12392: URL: https://github.com/apache/kafka/pull/12392#issuecomment-1295396711 Thanks for all the discussion here and sorry for the late arrival. I have seen this issue in practice as well, often in the context of hanging transactions. The late-arriving `Produce`

[GitHub] [kafka] hachikuji commented on a diff in pull request #12796: MINOR: Add test case for topic recreation with collision chars

hachikuji commented on code in PR #12796: URL: https://github.com/apache/kafka/pull/12796#discussion_r1008405909 ## metadata/src/test/java/org/apache/kafka/controller/ReplicationControlManagerTest.java: ## @@ -698,6 +714,21 @@ public void testCreateTopicsWithPolicy() throws Exce

[GitHub] [kafka] ijuma commented on pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

ijuma commented on PR #12543: URL: https://github.com/apache/kafka/pull/12543#issuecomment-1295433463 @junrao Was there an underlying reason not to allow this previously? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] junrao commented on pull request #12543: KAFKA-10149: Allow auto preferred leader election when there are ongoing partition reassignments

junrao commented on PR #12543: URL: https://github.com/apache/kafka/pull/12543#issuecomment-1295446037 Previously, the controller logic wasn't single threaded. So, this check is probably just to prevent concurrent actions. Now that all logic in the controller runs in a single thread, this c

[GitHub] [kafka] hachikuji merged pull request #12796: MINOR: Add test case for topic recreation with collision chars

hachikuji merged PR #12796: URL: https://github.com/apache/kafka/pull/12796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach