jeffkbkim commented on code in PR #12783:
URL: https://github.com/apache/kafka/pull/12783#discussion_r1008309856
##########
core/src/main/scala/kafka/server/ReplicaFetcherThread.scala:
##########
@@ -132,9 +141,17 @@ class ReplicaFetcherThread(name: String,
brokerTopicStats.updateReplicationBytesIn(records.sizeInBytes)
+ logAppendInfo.foreach { _ => partitionsWithNewRecords += topicPartition }
Review Comment:
@dajac i think in order to resolve the scenario you've mentioned, we would
ideally only want to complete the purgatory when HWM is updated. and since HWM
update is not asynchronous for the follower, it seems safe. what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
