gharris1727 commented on code in PR #12791:
URL: https://github.com/apache/kafka/pull/12791#discussion_r1008326288
##########
connect/runtime/src/test/java/org/apache/kafka/connect/util/RetryUtilTest.java:
##########
@@ -50,16 +52,15 @@ public void setUp() throws Exception {
@Test
public void testSuccess() throws Exception {
Mockito.when(mockCallable.call()).thenReturn("success");
- assertEquals("success", RetryUtil.retryUntilTimeout(mockCallable,
testMsg, Duration.ofMillis(100), 1));
+ assertEquals("success", RetryUtil.retryUntilTimeout(mockCallable,
testMsg, Duration.ofMillis(100), 1, mockTime));
Mockito.verify(mockCallable, Mockito.times(1)).call();
}
- // timeout the test after 1000ms if unable to complete within a reasonable
time frame
- @Test(timeout = 1000)
+ @Test
public void testExhaustingRetries() throws Exception {
Mockito.when(mockCallable.call()).thenThrow(new TimeoutException());
ConnectException e = assertThrows(ConnectException.class,
Review Comment:
I copied the error message assertion from a similar test, it looks like the
original PR omitted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
