[GitHub] [kafka] srishti-saraswat commented on a diff in pull request #12567: Migrate connect system tests to KRaft

srishti-saraswat commented on code in PR #12567: URL: https://github.com/apache/kafka/pull/12567#discussion_r965588572 ## tests/kafkatest/tests/connect/connect_rest_test.py: ## @@ -34,9 +35,7 @@ class ConnectRestApiTest(KafkaTest): FILE_SOURCE_CONFIGS = {'name', 'connecto

[jira] [Updated] (KAFKA-13766) Use `max.poll.interval.ms` as the timeout during complete-rebalance phase

[ https://issues.apache.org/jira/browse/KAFKA-13766?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Jacot updated KAFKA-13766: Component/s: group-coordinator > Use `max.poll.interval.ms` as the timeout during complete-rebalan

[GitHub] [kafka] dajac commented on pull request #12275: MINOR: Change groupInstanceId type from Optional to String in ConsumerGroupMetadata and GroupRebalanceConfig

dajac commented on PR #12275: URL: https://github.com/apache/kafka/pull/12275#issuecomment-1240403160 Thanks @il-kyun for the patch. I looked into it and I don't think that the change is worth it. Using Optional here seems fine to me. I am going to close it for now. Feel free to reopen if n

[GitHub] [kafka] dajac closed pull request #12275: MINOR: Change groupInstanceId type from Optional to String in ConsumerGroupMetadata and GroupRebalanceConfig

dajac closed pull request #12275: MINOR: Change groupInstanceId type from Optional to String in ConsumerGroupMetadata and GroupRebalanceConfig URL: https://github.com/apache/kafka/pull/12275 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[GitHub] [kafka] mimaison merged pull request #12606: MINOR: Fix usage of @see in IncrementalCooperativeAssignor doc comments

mimaison merged PR #12606: URL: https://github.com/apache/kafka/pull/12606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

Qingsheng Ren created KAFKA-14208: - Summary: KafkaConsumer#commitAsync throws unexpected WakeupException Key: KAFKA-14208 URL: https://issues.apache.org/jira/browse/KAFKA-14208 Project: Kafka

[jira] [Updated] (KAFKA-14132) Remaining PowerMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yash Mayya updated KAFKA-14132: --- Description: {color:#de350b}Some of the tests below use EasyMock as well. For those migrate both Po

[jira] [Commented] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

[ https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601779#comment-17601779 ] Ian Corne commented on KAFKA-12887: --- Why wouldn't you allow the user to handle this?

[GitHub] [kafka] cadonna commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

cadonna commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r965876179 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(final Ma

[jira] [Comment Edited] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

[ https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601779#comment-17601779 ] Ian Corne edited comment on KAFKA-12887 at 9/8/22 12:13 PM:

[GitHub] [kafka] ashmeet13 commented on pull request #12414: KAFKA-14073 Logging the reason for Snapshot

ashmeet13 commented on PR #12414: URL: https://github.com/apache/kafka/pull/12414#issuecomment-1240694324 Thank you @jsancio, I see that the build for JVM 17 and JDK 2.13 has timed out again. What can be done from my end to fix this? -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] divijvaidya commented on pull request #12590: KAFKA-7109: Close fetch sessions on close of consumer

divijvaidya commented on PR #12590: URL: https://github.com/apache/kafka/pull/12590#issuecomment-1240714341 @dajac since you are working on the consumer client protocol, perhaps you may also be interested in taking a look at this PR? -- This is an automated message from the Apache Git Ser

[GitHub] [kafka] clolov opened a new pull request, #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov opened a new pull request, #12607: URL: https://github.com/apache/kafka/pull/12607 Batch 5 of the tests detailed in https://issues.apache.org/jira/browse/KAFKA-14133 which use EasyMock and need to be moved to Mockito. -- This is an automated message from the Apache Git Service. To

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1240754283 There were stubbings which were no longer on the call path so I have removed them. The way I checked that I wasn't changing the test behaviour was to use EasyMock.verify on the mocks and c

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1240756214 I am aware that there are merge conflicts and I will aim to address them over the coming days. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] clolov commented on pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

clolov commented on PR #12607: URL: https://github.com/apache/kafka/pull/12607#issuecomment-1240757288 @guozhangwang and @cadonna for visibility -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Updated] (KAFKA-14133) Remaining EasyMock to Mockito tests

[ https://issues.apache.org/jira/browse/KAFKA-14133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christo Lolov updated KAFKA-14133: -- Description: {color:#de350b}There are tests which use both PowerMock and EasyMock. I have put

[GitHub] [kafka] C0urante merged pull request #12478: KAFKA-13952 fix RetryWithToleranceOperator to respect infinite retries configuration

C0urante merged PR #12478: URL: https://github.com/apache/kafka/pull/12478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-13952) Infinite retry timeout is not working

[ https://issues.apache.org/jira/browse/KAFKA-13952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-13952. --- Fix Version/s: 3.4.0 Resolution: Fixed > Infinite retry timeout is not working >

[GitHub] [kafka] yashmayya commented on pull request #12478: KAFKA-13952 fix RetryWithToleranceOperator to respect infinite retries configuration

yashmayya commented on PR #12478: URL: https://github.com/apache/kafka/pull/12478#issuecomment-1240782194 Thanks for the detailed reviews and for bearing with me through multiple rounds of review on this one Chris! -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] mimaison commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

mimaison commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r966049063 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -1138,5 +1142,13 @@ else if (value instanceof Long) private S

[jira] [Commented] (KAFKA-14198) Release package contains snakeyaml 1.30

[ https://issues.apache.org/jira/browse/KAFKA-14198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601858#comment-17601858 ] Mickael Maison commented on KAFKA-14198: [~jagsancio] I'm on PTO tomorrow for 2

[GitHub] [kafka] C0urante commented on pull request #12602: KAFKA-13985: Skip committing MirrorSourceTask records without metadata

C0urante commented on PR #12602: URL: https://github.com/apache/kafka/pull/12602#issuecomment-1240821236 Thanks @rgroothuijsen! I agree with the `DEBUG` level for logging; it's tempting to make this silent, but I'd prefer to err on the side of giving users more information since we can't ad

[GitHub] [kafka] cadonna commented on pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

cadonna commented on PR #12600: URL: https://github.com/apache/kafka/pull/12600#issuecomment-1240827367 > we reduce removeRevokedTasksFromStateUpdater to only record in the pending tasks to suspend, but not try to remove from state updaters. And in handleAssignment we just update the tasks

[GitHub] [kafka] jsancio commented on pull request #12601: MINOR: Retry on test failure for branch builds and increase max test retry to 10

jsancio commented on PR #12601: URL: https://github.com/apache/kafka/pull/12601#issuecomment-1240836278 Merging changes and cherry picking to 3.3. Errors seem unrelated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] jsancio merged pull request #12601: MINOR: Retry on test failure for branch builds and increase max test retry to 10

jsancio merged PR #12601: URL: https://github.com/apache/kafka/pull/12601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r966081693 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) { /

[GitHub] [kafka] Danny02 opened a new pull request, #12608: Enable KStream to be merged with itself

Danny02 opened a new pull request, #12608: URL: https://github.com/apache/kafka/pull/12608 Why: It is an interesting question what should be the result when merging a KStream with itself. Should the merge duplicate the messages or should it be a noop. I think the only reasonable solut

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r966084441 ## connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java: ## @@ -1138,5 +1142,13 @@ else if (value instanceof Long) private S

[GitHub] [kafka] C0urante commented on a diff in pull request #12544: KAFKA-14098: Add meaningful default client IDs for Connect workers

C0urante commented on code in PR #12544: URL: https://github.com/apache/kafka/pull/12544#discussion_r966088764 ## connect/runtime/src/main/java/org/apache/kafka/connect/cli/ConnectDistributed.java: ## @@ -106,6 +108,7 @@ public Connect startConnect(Map workerProps) { /

[GitHub] [kafka] jsancio commented on pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

jsancio commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1240857861 @showuon @C0urante @mimaison these are the test failures: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/system-test-kafka-branch-builder--1662600230-

[GitHub] [kafka] C0urante commented on pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

C0urante commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1240862547 @jsancio looks like all the Connect tests were green, and the failures were unrelated. LGTY? -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [kafka] jsancio commented on pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

jsancio commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1240920282 @C0urante sounds good. Do you want to merge it and cherry-pick it to 3.3? I can also merge it if you update the description with what you want me to write in the commit message. -- Thi

[jira] [Assigned] (KAFKA-14203) KRaft broker should disable snapshot generation after error replaying the metadata log

[ https://issues.apache.org/jira/browse/KAFKA-14203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-14203: -- Assignee: David Arthur > KRaft broker should disable snapshot

[GitHub] [kafka] hachikuji commented on a diff in pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (server side)

hachikuji commented on code in PR #12598: URL: https://github.com/apache/kafka/pull/12598#discussion_r966196258 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -982,6 +982,12 @@ class GroupCoordinator(val brokerId: Int, ): Option[Errors] = {

[GitHub] [kafka] dajac commented on a diff in pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (server side)

dajac commented on code in PR #12598: URL: https://github.com/apache/kafka/pull/12598#discussion_r966198873 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -982,6 +982,12 @@ class GroupCoordinator(val brokerId: Int, ): Option[Errors] = { if (

[GitHub] [kafka] jsancio commented on a diff in pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

jsancio commented on code in PR #12604: URL: https://github.com/apache/kafka/pull/12604#discussion_r966204598 ## docs/quickstart.html: ## @@ -46,6 +46,14 @@ NOTE: Your local environment must have Java 8+ installed. + +Apache Kafka ca

[GitHub] [kafka] jsancio commented on a diff in pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

jsancio commented on code in PR #12604: URL: https://github.com/apache/kafka/pull/12604#discussion_r966205030 ## docs/quickstart.html: ## @@ -64,6 +72,28 @@ Once all services have successfully launched, you will have a basic Kafka environment running and

[GitHub] [kafka] jsancio commented on pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

jsancio commented on PR #12604: URL: https://github.com/apache/kafka/pull/12604#issuecomment-1240981827 Thanks for the review @showuon . I addressed your comments. I also fixed the `rm` command at the end of the quickstart. -- This is an automated message from the Apache Git Service. To r

[GitHub] [kafka] hachikuji commented on a diff in pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (server side)

hachikuji commented on code in PR #12598: URL: https://github.com/apache/kafka/pull/12598#discussion_r966208033 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -982,6 +982,12 @@ class GroupCoordinator(val brokerId: Int, ): Option[Errors] = {

[GitHub] [kafka] dajac commented on a diff in pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (server side)

dajac commented on code in PR #12598: URL: https://github.com/apache/kafka/pull/12598#discussion_r966208886 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -982,6 +982,12 @@ class GroupCoordinator(val brokerId: Int, ): Option[Errors] = { if (

[GitHub] [kafka] dajac commented on a diff in pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (server side)

dajac commented on code in PR #12598: URL: https://github.com/apache/kafka/pull/12598#discussion_r966215071 ## core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala: ## @@ -982,6 +982,12 @@ class GroupCoordinator(val brokerId: Int, ): Option[Errors] = { if (

[GitHub] [kafka] ijuma opened a new pull request, #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

ijuma opened a new pull request, #12609: URL: https://github.com/apache/kafka/pull/12609 Verified that the artifact generated by `releaseTarGz` no longer includes swagger-jaxrs2 or its dependencies (like snakeyaml). ### Committer Checklist (excluded from commit message) - [ ] Ver

[GitHub] [kafka] jsancio commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

jsancio commented on PR #12609: URL: https://github.com/apache/kafka/pull/12609#issuecomment-1240998511 Thanks for the PR @ijuma . What do think @showuon @C0urante @mimaison? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

[GitHub] [kafka] jsancio opened a new pull request, #12610: MINOR; Update documentation for printing dependencies

jsancio opened a new pull request, #12610: URL: https://github.com/apache/kafka/pull/12610 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade n

[GitHub] [kafka] ijuma commented on a diff in pull request #12610: MINOR; Update documentation for printing dependencies

ijuma commented on code in PR #12610: URL: https://github.com/apache/kafka/pull/12610#discussion_r966242324 ## README.md: ## @@ -202,7 +202,7 @@ If needed, you can specify the Scala version with `-PscalaVersion=2.13`. ./gradlew testJar ### Determining how transitive dep

[GitHub] [kafka] jsancio commented on a diff in pull request #12610: MINOR; Update documentation for printing dependencies

jsancio commented on code in PR #12610: URL: https://github.com/apache/kafka/pull/12610#discussion_r966244134 ## README.md: ## @@ -202,7 +202,7 @@ If needed, you can specify the Scala version with `-PscalaVersion=2.13`. ./gradlew testJar ### Determining how transitive d

[jira] [Assigned] (KAFKA-14198) Release package contains snakeyaml 1.30

[ https://issues.apache.org/jira/browse/KAFKA-14198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio reassigned KAFKA-14198: -- Assignee: Ismael Juma > Release package contains snakeyaml 1.

[GitHub] [kafka] philipnee commented on a diff in pull request #12603: Pausing partition to prevent duplication

philipnee commented on code in PR #12603: URL: https://github.com/apache/kafka/pull/12603#discussion_r966254369 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -756,10 +756,15 @@ protected boolean onJoinPrepare(Timer timer, in

[jira] [Commented] (KAFKA-13766) Use `max.poll.interval.ms` as the timeout during complete-rebalance phase

[ https://issues.apache.org/jira/browse/KAFKA-13766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601949#comment-17601949 ] Guozhang Wang commented on KAFKA-13766: --- Inside onCompleteJoin, in the block start

[GitHub] [kafka] guozhangwang commented on pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

guozhangwang commented on PR #12600: URL: https://github.com/apache/kafka/pull/12600#issuecomment-1241058075 > I am not sure I can follow. Are you proposing to not recycle or resume revoked active tasks? What I'm proposing is that, for restoring active tasks, we can actually ignore t

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

guozhangwang commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966274214 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -421,73 +421,120 @@ private void classifyTasksWithoutStateUpdater(fina

[jira] [Updated] (KAFKA-14201) Consumer should not send group instance ID if committing with empty member ID

[ https://issues.apache.org/jira/browse/KAFKA-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio updated KAFKA-14201: --- Fix Version/s: 3.3.0 > Consumer should not send group instance ID if

[GitHub] [kafka] guozhangwang commented on a diff in pull request #12607: KAFKA-14133: Replace EasyMock with Mockito in streams tests

guozhangwang commented on code in PR #12607: URL: https://github.com/apache/kafka/pull/12607#discussion_r966289656 ## streams/src/test/java/org/apache/kafka/streams/processor/internals/TaskManagerTest.java: ## @@ -1300,28 +1229,16 @@ public void shouldCloseActiveTasksWhenHandli

[jira] [Updated] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14196: Affects Version/s: (was: 3.2.1) > Duplicated consumption during rebalance, causing Off

[jira] [Updated] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14196: Fix Version/s: 3.3.0 3.2.2 > Duplicated consumption during rebalance, c

[jira] [Updated] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14196: Priority: Blocker (was: Major) > Duplicated consumption during rebalance, causing OffsetV

[jira] [Updated] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Gustafson updated KAFKA-14196: Affects Version/s: 3.2.1 (was: 3.3.0) > Duplicated consumption

[jira] [Created] (KAFKA-14209) Optimize stream stream self join to use single state store

Vicky Papavasileiou created KAFKA-14209: --- Summary: Optimize stream stream self join to use single state store Key: KAFKA-14209 URL: https://issues.apache.org/jira/browse/KAFKA-14209 Project: Kafk

[GitHub] [kafka] hachikuji commented on a diff in pull request #12593: KAFKA-14196: Prevent fetching during the rebalancing

hachikuji commented on code in PR #12593: URL: https://github.com/apache/kafka/pull/12593#discussion_r966321913 ## clients/src/main/java/org/apache/kafka/clients/consumer/KafkaConsumer.java: ## @@ -1282,6 +1282,11 @@ private Fetch pollForFetches(Timer timer) { long poll

[GitHub] [kafka] philipnee closed pull request #12593: KAFKA-14196: Prevent fetching during the rebalancing

philipnee closed pull request #12593: KAFKA-14196: Prevent fetching during the rebalancing URL: https://github.com/apache/kafka/pull/12593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Updated] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philip Nee updated KAFKA-14196: --- Description: Several flaky tests under OffsetValidationTest are indicating potential consumer dupli

[GitHub] [kafka] C0urante commented on pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

C0urante commented on PR #11783: URL: https://github.com/apache/kafka/pull/11783#issuecomment-1241120740 I can handle the merge. Thanks @jsancio, @showuon, @mimaison, and @tombentley for the review! -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [kafka] C0urante merged pull request #11783: KAFKA-14143: Exactly-once source connector system tests (KIP-618)

C0urante merged PR #11783: URL: https://github.com/apache/kafka/pull/11783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Resolved] (KAFKA-14143) Exactly-once source system tests

[ https://issues.apache.org/jira/browse/KAFKA-14143?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton resolved KAFKA-14143. --- Resolution: Fixed > Exactly-once source system tests > > >

[GitHub] [kafka] C0urante commented on pull request #12575: KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest

C0urante commented on PR #12575: URL: https://github.com/apache/kafka/pull/12575#issuecomment-1241138425 Now that we've merged and backported https://github.com/apache/kafka/pull/11783, this should hopefully no longer be necessary. @yashmayya let me know if anything still fails; otherwise,

[GitHub] [kafka] C0urante commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

C0urante commented on PR #12609: URL: https://github.com/apache/kafka/pull/12609#issuecomment-1241219303 This appears to break the docs generation added in https://github.com/apache/kafka/pull/12067; running `./gradlew siteDocsTar` with this change causes the generated `docs/generated/conne

[GitHub] [kafka] jsancio commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

jsancio commented on PR #12609: URL: https://github.com/apache/kafka/pull/12609#issuecomment-1241226713 > Are we okay with spending some time on trying to fix the docs generation, or does this need to be merged ASAP to unblock the 3.3 release? @C0urante I am open to suggestions on how

[GitHub] [kafka] C0urante commented on pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

C0urante commented on PR #12609: URL: https://github.com/apache/kafka/pull/12609#issuecomment-1241229865 Yeah, I can try to find something. Thanks José! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] cmccabe commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

cmccabe commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r966431199 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -844,6 +855,72 @@ public String toString() { } } +/** + * Appe

[GitHub] [kafka] cmccabe commented on a diff in pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

cmccabe commented on code in PR #12595: URL: https://github.com/apache/kafka/pull/12595#discussion_r966431807 ## metadata/src/main/java/org/apache/kafka/controller/QuorumController.java: ## @@ -844,6 +855,72 @@ public String toString() { } } +/** + * Appe

[GitHub] [kafka] cmccabe merged pull request #12595: KAFKA-14204: QuorumController must correctly handle overly large batches

cmccabe merged PR #12595: URL: https://github.com/apache/kafka/pull/12595 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[GitHub] [kafka] C0urante commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

C0urante commented on code in PR #12609: URL: https://github.com/apache/kafka/pull/12609#discussion_r966438130 ## build.gradle: ## @@ -2652,7 +2653,7 @@ project(':connect:runtime') { } task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, depe

[GitHub] [kafka] hachikuji merged pull request #12598: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (server side)

hachikuji merged PR #12598: URL: https://github.com/apache/kafka/pull/12598 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[jira] [Resolved] (KAFKA-14204) QuorumController must correctly handle overly large batches

[ https://issues.apache.org/jira/browse/KAFKA-14204?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jose Armando Garcia Sancio resolved KAFKA-14204. Resolution: Fixed > QuorumController must correctly handle overly

[GitHub] [kafka] jsancio commented on pull request #12575: KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest

jsancio commented on PR #12575: URL: https://github.com/apache/kafka/pull/12575#issuecomment-1241267992 I am going to close the PR. @yashmayya feel free to open the PR if you disagree. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] jsancio closed pull request #12575: KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest

jsancio closed pull request #12575: KAFKA-14193: Add EOS related source connector configs to expected config defs in ConnectRestApiTest URL: https://github.com/apache/kafka/pull/12575 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] jsancio commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

jsancio commented on code in PR #12609: URL: https://github.com/apache/kafka/pull/12609#discussion_r966451504 ## build.gradle: ## @@ -2652,7 +2653,7 @@ project(':connect:runtime') { } task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, depen

[GitHub] [kafka] ijuma commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

ijuma commented on code in PR #12609: URL: https://github.com/apache/kafka/pull/12609#discussion_r966455049 ## build.gradle: ## @@ -2652,7 +2653,7 @@ project(':connect:runtime') { } task genConnectOpenAPIDocs(type: io.swagger.v3.plugins.gradle.tasks.ResolveTask, depends

[GitHub] [kafka] hachikuji commented on pull request #12599: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (client side)

hachikuji commented on PR #12599: URL: https://github.com/apache/kafka/pull/12599#issuecomment-1241281654 Thanks, I was a little hesitant about the client-side fix since I thought there might be a debugging benefit of having group instance ID in request logs. But I guess this speculative be

[GitHub] [kafka] hachikuji merged pull request #12599: KAFKA-14201; Consumer should not send group instance ID if committing with empty member ID (client side)

hachikuji merged PR #12599: URL: https://github.com/apache/kafka/pull/12599 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apach

[GitHub] [kafka] jsancio commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

jsancio commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r966459040 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -307,11 +322,18 @@ class BrokerMetadataListener( private def publish(publisher: Met

[GitHub] [kafka] jsancio commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

jsancio commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r964300580 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -41,8 +43,19 @@ class BrokerMetadataListener( val maxBytesBetweenSnapshots: Long,

[GitHub] [kafka] jsancio commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

jsancio commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r966471788 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -28,6 +28,8 @@ import org.apache.kafka.server.common.ApiMessageAndVersion import org.ap

[GitHub] [kafka] cmccabe commented on a diff in pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

cmccabe commented on code in PR #12604: URL: https://github.com/apache/kafka/pull/12604#discussion_r966476362 ## docs/streams/quickstart.html: ## @@ -98,19 +97,46 @@ Step Step 2: Start the Kafka server -Kafka uses https://zookeeper.apache.org/";>ZooKeeper so you need to fi

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r966480469 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -307,11 +322,18 @@ class BrokerMetadataListener( private def publish(publisher: Meta

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r966480469 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -307,11 +322,18 @@ class BrokerMetadataListener( private def publish(publisher: Meta

[GitHub] [kafka] mumrah commented on a diff in pull request #12596: KAFKA-14203 Don't make snapshots on broker after metadata errors

mumrah commented on code in PR #12596: URL: https://github.com/apache/kafka/pull/12596#discussion_r966484578 ## core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala: ## @@ -307,11 +322,18 @@ class BrokerMetadataListener( private def publish(publisher: Meta

[jira] [Commented] (KAFKA-12887) Do not trigger user-customized ExceptionalHandler for RTE

[ https://issues.apache.org/jira/browse/KAFKA-12887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602033#comment-17602033 ] Guozhang Wang commented on KAFKA-12887: --- Hello [~icorne] We have reverted this cha

[GitHub] [kafka] jsancio commented on pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

jsancio commented on PR #12604: URL: https://github.com/apache/kafka/pull/12604#issuecomment-1241324010 > We should move “Once all services have successfully launched, you will have a basic Kafka environment running and ready to use.” under both ZK and KRaft sections. @forlack Thanks

[jira] [Commented] (KAFKA-14189) Improve connection limit and reuse of coordinator and leader in KafkaConsumer

[ https://issues.apache.org/jira/browse/KAFKA-14189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602037#comment-17602037 ] Guozhang Wang commented on KAFKA-14189: --- Hi [~aglicacha] [~vongosling] The main m

[GitHub] [kafka] jsancio merged pull request #12604: KAFKA-14188; Getting started for Kafka with KRaft

jsancio merged PR #12604: URL: https://github.com/apache/kafka/pull/12604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.

[jira] [Commented] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

[ https://issues.apache.org/jira/browse/KAFKA-14208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602046#comment-17602046 ] Guozhang Wang commented on KAFKA-14208: --- Hello Qingsheng, thanks for reporting thi

[jira] [Commented] (KAFKA-14196) Duplicated consumption during rebalance, causing OffsetValidationTest to act flaky

[ https://issues.apache.org/jira/browse/KAFKA-14196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17602049#comment-17602049 ] Guozhang Wang commented on KAFKA-14196: --- Thanks Philip, and regarding your two que

[GitHub] [kafka] hachikuji commented on a diff in pull request #12603: KAFKA-14196: Pausing partition to prevent duplication when autocommit is enabled

hachikuji commented on code in PR #12603: URL: https://github.com/apache/kafka/pull/12603#discussion_r966512403 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerCoordinator.java: ## @@ -799,64 +804,95 @@ protected boolean onJoinPrepare(Timer timer, in

[GitHub] [kafka] guozhangwang opened a new pull request, #12611: KAFKA-14208: Should not wake-up with non-blocking coordinator discovery

guozhangwang opened a new pull request, #12611: URL: https://github.com/apache/kafka/pull/12611 Today we may try to discover coordinator in both blocking (e.g. in `poll`) and non-blocking (e.g. in `commitAsync`) way. For the latter we would poll the underlying network client with timeout 0,

[GitHub] [kafka] guozhangwang commented on pull request #12611: KAFKA-14208: Should not wake-up with non-blocking coordinator discovery

guozhangwang commented on PR #12611: URL: https://github.com/apache/kafka/pull/12611#issuecomment-1241358026 Call @philipnee @showuon for reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Assigned] (KAFKA-14208) KafkaConsumer#commitAsync throws unexpected WakeupException

[ https://issues.apache.org/jira/browse/KAFKA-14208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reassigned KAFKA-14208: - Assignee: Guozhang Wang > KafkaConsumer#commitAsync throws unexpected WakeupException >

[GitHub] [kafka] lihaosky commented on a diff in pull request #12600: KAFKA-10199: Remove and suspend tasks in the state updater on revocation

lihaosky commented on code in PR #12600: URL: https://github.com/apache/kafka/pull/12600#discussion_r966520188 ## streams/src/main/java/org/apache/kafka/streams/processor/internals/TaskManager.java: ## @@ -960,7 +1011,7 @@ private void removeRevokedTasksFromStateUpdater(final S

  1   2   >