[GitHub] [kafka] C0urante commented on a diff in pull request #12609: KAFKA-14198: swagger-jaxrs2 dependency should be compileOnly

[GitBox]

C0urante commented on code in PR #12609:
URL: https://github.com/apache/kafka/pull/12609#discussion_r966438130


##########
build.gradle:
##########
@@ -2652,7 +2653,7 @@ project(':connect:runtime') {
   }
 
   task genConnectOpenAPIDocs(type: 
io.swagger.v3.plugins.gradle.tasks.ResolveTask, dependsOn: 
setVersionInOpenAPISpec) {
-    classpath = sourceSets.main.runtimeClasspath
+    classpath = sourceSets.main.compileClasspath

Review Comment:
   This feels like a terrible hack but by combining the runtime and compile 
classpaths, we can still generate the correct docs with `siteDocsTar` and omit 
the unnecessary Swagger dependencies from the release artifact generated with 
`releaseTarGz`:
   ```suggestion
       classpath = sourceSets.main.compileClasspath + 
sourceSets.main.runtimeClasspath
   
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org