C0urante commented on code in PR #12544:
URL: https://github.com/apache/kafka/pull/12544#discussion_r966084441
##########
connect/runtime/src/main/java/org/apache/kafka/connect/storage/KafkaConfigBackingStore.java:
##########
@@ -1138,5 +1142,13 @@ else if (value instanceof Long)
private String className(Object o) {
return o != null ? o.getClass().getName() : "null";
}
-}
+ private static void maybeAddClientId(Map<String, ? super String>
clientProps, String groupId) {
+ String clientId = "connect-cluster";
+ if (groupId != null) {
Review Comment:
Right now we have that guarantee, but since the `*BackingStore` classes
accept a `WorkerConfig` instead of a `DistributedConfig`, it's difficult to
enforce that guarantee. Plus, if we ever want to use any of these backing
stores with standalone mode (or a new mode that doesn't use Kafka's group
membership API), it'll make that migration easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
