clolov commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r855836217
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1139,7 +1139,7 @@ object KafkaConfig {
.define(MetadataMaxRetentionMillisProp, LONG, Defaults.LogRete
clolov commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r855843521
##
core/src/main/scala/kafka/admin/BrokerApiVersionsCommand.scala:
##
@@ -231,6 +232,7 @@ object BrokerApiVersionsCommand {
CommonClientConfigs.SECURITY_PROTOC
[
https://issues.apache.org/jira/browse/KAFKA-13845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-13845:
--
Assignee: dengziming
> Add support for reading KRaft snapshots in kafka-dump-log
> --
Andras Csaki created KAFKA-13848:
Summary: Clients remaing connected after SASL re-authentication
fails
Key: KAFKA-13848
URL: https://issues.apache.org/jira/browse/KAFKA-13848
Project: Kafka
dengziming opened a new pull request, #12084:
URL: https://github.com/apache/kafka/pull/12084
*More detailed description of your change*
1. Support metadata snapshot suffix ".checkpoint"
2. print metadata snapshot header and footer
*Summary of testing strategy (including rat
[
https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526248#comment-17526248
]
Andras Csaki commented on KAFKA-13848:
--
Please assign this to me.
My fix is underw
[
https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Csaki updated KAFKA-13848:
-
Summary: Clients remaining connected after SASL re-authentication fails
(was: Clients remaing c
mimaison commented on code in PR #12046:
URL: https://github.com/apache/kafka/pull/12046#discussion_r855922918
##
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##
@@ -331,7 +331,7 @@ public class KafkaAdminClient extends AdminClient {
/**
[
https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Csaki updated KAFKA-13848:
-
Summary: Clients remain connected after SASL re-authentication fails (was:
Clients remaining co
RivenSun created KAFKA-13849:
Summary: All topics whose cleanup policy contains `compact` are
not executing deleteLogStartOffsetBreachedSegments as expected
Key: KAFKA-13849
URL: https://issues.apache.org/jira/browse
C0urante commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r856198705
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -203,4 +205,15 @@ public static Map
postProcessReconnectBackoffConfigs(AbstractCon
[
https://issues.apache.org/jira/browse/KAFKA-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526409#comment-17526409
]
RivenSun commented on KAFKA-13849:
--
Hi [~guozhang] [~hachikuji] , [~showuon]
Could yo
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r856210085
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -203,4 +205,15 @@ public static Map
postProcessReconnectBackoffConfigs(AbstractCon
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r856211769
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -203,4 +205,15 @@ public static Map
postProcessReconnectBackoffConfigs(AbstractCon
C0urante commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r856213267
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -203,4 +205,15 @@ public static Map
postProcessReconnectBackoffConfigs(AbstractCon
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r856214743
##
clients/src/test/java/org/apache/kafka/clients/admin/AdminClientConfigTest.java:
##
@@ -0,0 +1,52 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r856218757
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -203,4 +205,15 @@ public static Map
postProcessReconnectBackoffConfigs(AbstractCon
mumrah commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r856220444
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
mumrah commented on PR #12050:
URL: https://github.com/apache/kafka/pull/12050#issuecomment-1106518486
@dengziming @cmccabe FYI, there is another PR coming soon which includes a
big consolidation of ApiVersion and MetadataVersion. I will wait to merge this
one until that one is done.
--
[
https://issues.apache.org/jira/browse/KAFKA-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526443#comment-17526443
]
RivenSun commented on KAFKA-13849:
--
After reading the code carefully, I found that the
[
https://issues.apache.org/jira/browse/KAFKA-13849?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
RivenSun resolved KAFKA-13849.
--
Resolution: Not A Bug
> All topics whose cleanup policy contains `compact` are not executing
> delet
David Arthur created KAFKA-13850:
Summary: kafka-metadata-shell is missing some record types
Key: KAFKA-13850
URL: https://issues.apache.org/jira/browse/KAFKA-13850
Project: Kafka
Issue Type:
dajac commented on code in PR #12081:
URL: https://github.com/apache/kafka/pull/12081#discussion_r856260128
##
core/src/test/scala/unit/kafka/cluster/LogTest.scala:
##
@@ -0,0 +1,132 @@
+/*
Review Comment:
I have renamed this file. Those tests have nothing to do with the Rep
[
https://issues.apache.org/jira/browse/KAFKA-13620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-13620:
--
Assignee: dengziming
> The request handler metric name for ControllerApis should be different
dajac opened a new pull request, #12085:
URL: https://github.com/apache/kafka/pull/12085
This PR sits on top of https://github.com/apache/kafka/pull/12071 and
https://github.com/apache/kafka/pull/12081. They should be merged before
proceeding with this one.
WIP - Opening it to get th
nicolasguyomar opened a new pull request, #12086:
URL: https://github.com/apache/kafka/pull/12086
Minor doc improvement
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify do
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r856374878
##
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##
@@ -0,0 +1,292 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
Divij Vaidya created KAFKA-13851:
Summary: Tests are missing for DeleteRecords API
Key: KAFKA-13851
URL: https://issues.apache.org/jira/browse/KAFKA-13851
Project: Kafka
Issue Type: Improveme
divijvaidya opened a new pull request, #12087:
URL: https://github.com/apache/kafka/pull/12087
## Changes
Added integration tests to test the DeleteRecords API for the following
scenarios:
1. Happy case when the records are deleted
2. Error case when an invalid topic is provided
[
https://issues.apache.org/jira/browse/KAFKA-13848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Csaki reassigned KAFKA-13848:
Assignee: Andras Csaki
> Clients remain connected after SASL re-authentication fails
> --
ArvinZheng closed pull request #11840: KAFKA-13707: unify the naming convention
of in-flight
URL: https://github.com/apache/kafka/pull/11840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
philipnee opened a new pull request, #12088:
URL: https://github.com/apache/kafka/pull/12088
Duplicated to https://github.com/apache/kafka/pull/12064 - but the tests
aren't being fired up there. So created this PR to trigger the tests.
The bug was introduced in https://github.com/apache/k
dajac merged PR #12071:
URL: https://github.com/apache/kafka/pull/12071
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or
mumrah commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r856529766
##
core/src/test/scala/unit/kafka/api/ApiVersionTest.scala:
##
@@ -184,6 +184,37 @@ class ApiVersionTest {
assertEquals("3.2", KAFKA_3_2_IV0.shortVersion)
}
+
philipnee commented on PR #12064:
URL: https://github.com/apache/kafka/pull/12064#issuecomment-1106836089
Hey @junrao - I think I rebased it onto the wrong head. It seems fixed now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
artemlivshits commented on code in PR #12049:
URL: https://github.com/apache/kafka/pull/12049#discussion_r855698824
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -1321,21 +1339,30 @@ private ClusterResourceListeners
configureClusterResourc
ahuang98 commented on code in PR #12072:
URL: https://github.com/apache/kafka/pull/12072#discussion_r856573612
##
core/src/test/scala/unit/kafka/api/ApiVersionTest.scala:
##
@@ -184,6 +184,37 @@ class ApiVersionTest {
assertEquals("3.2", KAFKA_3_2_IV0.shortVersion)
}
+
artemlivshits commented on code in PR #12006:
URL: https://github.com/apache/kafka/pull/12006#discussion_r856590081
##
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##
@@ -187,7 +187,7 @@ private void startSequencesAtBeginning(TopicPa
hachikuji commented on code in PR #11951:
URL: https://github.com/apache/kafka/pull/11951#discussion_r856590248
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig,
}
private def s
hachikuji commented on code in PR #12081:
URL: https://github.com/apache/kafka/pull/12081#discussion_r856597477
##
core/src/main/scala/kafka/cluster/Partition.scala:
##
@@ -885,15 +885,18 @@ class Partition(val topicPartition: TopicPartition,
*
* @return true if the HW w
hachikuji opened a new pull request, #12089:
URL: https://github.com/apache/kafka/pull/12089
Since we have changed the `AlterIsr` API to `AlterPartition`, it makes sense
to rename `AlterIsrManager` as well.
### Committer Checklist (excluded from commit message)
- [ ] Verify design
hachikuji commented on code in PR #12032:
URL: https://github.com/apache/kafka/pull/12032#discussion_r856620950
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -2348,7 +2348,20 @@ class KafkaController(val config: KafkaConfig,
controllerContext.pa
hachikuji commented on code in PR #12032:
URL: https://github.com/apache/kafka/pull/12032#discussion_r856620950
##
core/src/main/scala/kafka/controller/KafkaController.scala:
##
@@ -2348,7 +2348,20 @@ class KafkaController(val config: KafkaConfig,
controllerContext.pa
jsancio commented on code in PR #12032:
URL: https://github.com/apache/kafka/pull/12032#discussion_r856654851
##
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala:
##
@@ -890,65 +890,289 @@ class ControllerIntegrationTest extends
QuorumTestHarness {
jsancio commented on code in PR #11732:
URL: https://github.com/apache/kafka/pull/11732#discussion_r856668003
##
core/src/test/scala/integration/kafka/admin/ConfigCommandIntegrationTest.scala:
##
@@ -43,8 +45,9 @@ class ConfigCommandIntegrationTest extends QuorumTestHarness
wit
ddrid commented on PR #12080:
URL: https://github.com/apache/kafka/pull/12080#issuecomment-1107097330
@hachikuji hi, could you help review this bug fix？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/KAFKA-13398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
RivenSun resolved KAFKA-13398.
--
Resolution: Not A Problem
> The caller program will be shut down directly when the execution of Kafka
dengziming commented on code in PR #11951:
URL: https://github.com/apache/kafka/pull/11951#discussion_r856745020
##
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##
@@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig,
}
private def
dengziming commented on code in PR #12089:
URL: https://github.com/apache/kafka/pull/12089#discussion_r856745253
##
core/src/test/scala/unit/kafka/cluster/AbstractPartitionTest.scala:
##
@@ -49,7 +49,7 @@ class AbstractPartitionTest {
var logDir1: File = _
var logDir2: Fil
dengziming commented on code in PR #11732:
URL: https://github.com/apache/kafka/pull/11732#discussion_r856750503
##
core/src/test/scala/integration/kafka/admin/ConfigCommandIntegrationTest.scala:
##
@@ -26,15 +26,17 @@ import org.apache.kafka.common.config.ConfigException
impor
[
https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526746#comment-17526746
]
dengziming commented on KAFKA-13850:
In fact I already found this problem, however,
[
https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526750#comment-17526750
]
David Arthur commented on KAFKA-13850:
--
Awesome! Good to know [~dengziming]. I'll a
[
https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526750#comment-17526750
]
David Arthur edited comment on KAFKA-13850 at 4/23/22 2:25 AM:
---
[
https://issues.apache.org/jira/browse/KAFKA-13850?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming reassigned KAFKA-13850:
--
Assignee: dengziming
> kafka-metadata-shell is missing some record types
> --
dajac commented on code in PR #12089:
URL: https://github.com/apache/kafka/pull/12089#discussion_r856832341
##
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##
@@ -61,12 +61,14 @@ trait AlterIsrManager {
): CompletableFuture[LeaderAndIsr]
}
-case class Alte
gitlw commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r856845084
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -306,24 +306,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* - Otherwise set _topicId to None
gitlw commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r856845305
##
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##
@@ -2703,6 +2711,26 @@ class ReplicaManagerTest {
assertEquals(HostedPartition.None, replicaMa
gitlw commented on PR #12029:
URL: https://github.com/apache/kafka/pull/12029#issuecomment-1107367652
@dajac In the new test
`UnifiedLogTest.testRenamingDirWithoutReinitialization`, after renaming a log's
dir without re-initialization, I added logic to trigger
`UnifiedLog.appendAsLeader`,
58 matches
Mail list logo
