[GitHub] [kafka] hachikuji commented on a diff in pull request #11951: KAFKA-13836: Improve KRaft broker heartbeat logic

[GitBox]

hachikuji commented on code in PR #11951:
URL: https://github.com/apache/kafka/pull/11951#discussion_r856590248


##########
core/src/main/scala/kafka/server/BrokerLifecycleManager.scala:
##########
@@ -333,7 +353,11 @@ class BrokerLifecycleManager(val config: KafkaConfig,
   }
 
   private def sendBrokerHeartbeat(): Unit = {
-    val metadataOffset = _highestMetadataOffsetProvider()
+    val metadataOffset = if (readyToUnfence) {

Review Comment:
   Why not use the published offset consistently in heartbeats?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org