dajac commented on code in PR #12089:
URL: https://github.com/apache/kafka/pull/12089#discussion_r856832341
##########
core/src/main/scala/kafka/server/AlterPartitionManager.scala:
##########
@@ -61,12 +61,14 @@ trait AlterIsrManager {
): CompletableFuture[LeaderAndIsr]
}
-case class AlterIsrItem(topicPartition: TopicPartition,
- leaderAndIsr: LeaderAndIsr,
- future: CompletableFuture[LeaderAndIsr],
- controllerEpoch: Int) // controllerEpoch needed for Zk
impl
+case class AlterPartitionItem(
+ topicPartition: TopicPartition,
+ leaderAndIsr: LeaderAndIsr,
+ future: CompletableFuture[LeaderAndIsr],
+ controllerEpoch: Int // controllerEpoch needed for Zk impl
Review Comment:
nit: Should we say ZkAlterPartitionManager or ZK controller instead of « zk
impl »?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
