[
https://issues.apache.org/jira/browse/KAFKA-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523604#comment-17523604
]
Sagar Rao commented on KAFKA-13816:
---
hey [~ChrisEgerton] , i looked at the rough draft
shizhenzhen created KAFKA-13834:
---
Summary: Some problems with producers choosing batches of messages
to send
Key: KAFKA-13834
URL: https://issues.apache.org/jira/browse/KAFKA-13834
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523655#comment-17523655
]
ruanliang commented on KAFKA-13834:
---
[~guozhang] I'm interested in this problem. Ca
[
https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523689#comment-17523689
]
王文诏 commented on KAFKA-13834:
-
彦祖，我来了:D
> Some problems with producers choosing batches of
[ https://issues.apache.org/jira/browse/KAFKA-13834 ]
王文诏 deleted comment on KAFKA-13834:
-
was (Author: JIRAUSER288173):
彦祖，我来了:D
> Some problems with producers choosing batches of messages to send
>
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r851351864
##
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##
@@ -883,15 +905,49 @@ public void handleLeaderChange(LeaderAndEpoch newLeader) {
mumrah commented on code in PR #12050:
URL: https://github.com/apache/kafka/pull/12050#discussion_r852197868
##
core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala:
##
@@ -102,11 +112,16 @@ class RawMetaProperties(val props: Properties = new
Properties()) {
}
ob
vvcephei commented on code in PR #11993:
URL: https://github.com/apache/kafka/pull/11993#discussion_r852154793
##
streams/streams-scala/src/main/scala/org/apache/kafka/streams/scala/kstream/KStream.scala:
##
@@ -18,30 +18,10 @@ package org.apache.kafka.streams.scala
package kst
mjsax commented on code in PR #11977:
URL: https://github.com/apache/kafka/pull/11977#discussion_r852257822
##
streams/src/main/java/org/apache/kafka/streams/processor/internals/StateDirectory.java:
##
@@ -418,12 +418,20 @@ public synchronized void clean() {
}
[
https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523801#comment-17523801
]
Guozhang Wang commented on KAFKA-13834:
---
[~shizhenzhen] Thanks for filing the JIRA
[
https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523804#comment-17523804
]
Guozhang Wang commented on KAFKA-13834:
---
Also I'm wondering if you can resize the
jsancio merged PR #12061:
URL: https://github.com/apache/kafka/pull/12061
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
junrao commented on code in PR #12029:
URL: https://github.com/apache/kafka/pull/12029#discussion_r852311641
##
core/src/main/scala/kafka/log/UnifiedLog.scala:
##
@@ -306,24 +306,27 @@ class UnifiedLog(@volatile var logStartOffset: Long,
* - Otherwise set _topicId to None
[
https://issues.apache.org/jira/browse/KAFKA-13748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523901#comment-17523901
]
Luca Carettoni commented on KAFKA-13748:
Since Apache is a CVE program partner,
hachikuji merged PR #12027:
URL: https://github.com/apache/kafka/pull/12027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apach
[
https://issues.apache.org/jira/browse/KAFKA-13835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Colin McCabe updated KAFKA-13835:
-
Summary: Fix two bugs related to dynamic broker configs in KRaft (was: Fix
two bugs related to
Colin McCabe created KAFKA-13835:
Summary: Fix two bugs related to applying dynamic broker configs
in KRaft
Key: KAFKA-13835
URL: https://issues.apache.org/jira/browse/KAFKA-13835
Project: Kafka
cmccabe opened a new pull request, #12063:
URL: https://github.com/apache/kafka/pull/12063
The first bug is that we are calling reloadUpdatedFilesWithoutConfigChange
when a topic
configuration is changed, but not when a broker configuration is changed.
This is backwards.
This function
junrao commented on code in PR #11689:
URL: https://github.com/apache/kafka/pull/11689#discussion_r852429053
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -995,8 +995,17 @@ private Future doSend(ProducerRecord
record, Callback call
[
https://issues.apache.org/jira/browse/KAFKA-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523936#comment-17523936
]
Chris Egerton commented on KAFKA-13816:
---
Hi [~sagarrao]--I think this approach fai
philipnee opened a new pull request, #12064:
URL: https://github.com/apache/kafka/pull/12064
The bug was introduced in https://github.com/apache/kafka/pull/11689/ that
an additional onAcknowledgement was made using the InterceptorCallback class.
This is undesirable since onSendError will a
hachikuji commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852470161
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -906,17 +906,22 @@ class DynamicClientQuotaCallback(server: KafkaBroker)
extends Reconfigurable {
cmccabe commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852476929
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -906,17 +906,22 @@ class DynamicClientQuotaCallback(server: KafkaBroker)
extends Reconfigurable {
philipnee commented on code in PR #11689:
URL: https://github.com/apache/kafka/pull/11689#discussion_r852477525
##
clients/src/main/java/org/apache/kafka/clients/producer/KafkaProducer.java:
##
@@ -995,8 +995,17 @@ private Future doSend(ProducerRecord
record, Callback call
C0urante commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852469399
##
clients/src/main/java/org/apache/kafka/clients/admin/AdminClientConfig.java:
##
@@ -212,6 +213,7 @@ public class AdminClientConfig extends AbstractConfig {
cmccabe commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852482123
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -950,16 +963,17 @@ class DynamicListenerConfig(server: KafkaBroker) extends
BrokerReconfigurable wi
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852484756
##
clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerConfig.java:
##
@@ -486,10 +488,14 @@ public class ConsumerConfig extends AbstractConfig {
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852486098
##
clients/src/main/java/org/apache/kafka/common/config/SaslConfigs.java:
##
@@ -202,7 +202,7 @@ public static void addClientSaslSupport(ConfigDef config) {
cmccabe commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852487013
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala:
##
@@ -248,6 +248,24 @@ class BrokerMetadataListener(
}
}
+ // This is used in test
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852487421
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1324,9 +1324,9 @@ object KafkaConfig {
.define(SslEngineFactoryClassProp, CLASS, null, LOW,
SslEn
cmccabe commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852488861
##
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala:
##
@@ -187,21 +189,26 @@ class BrokerMetadataPublisher(conf: KafkaConfig,
to
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852490767
##
clients/src/test/java/org/apache/kafka/clients/consumer/ConsumerConfigTest.java:
##
@@ -108,4 +112,42 @@ public void testDefaultPartitionAssignor() {
asser
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852494899
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1324,9 +1324,9 @@ object KafkaConfig {
.define(SslEngineFactoryClassProp, CLASS, null, LOW,
SslEn
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852494899
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1324,9 +1324,9 @@ object KafkaConfig {
.define(SslEngineFactoryClassProp, CLASS, null, LOW,
SslEn
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852487421
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1324,9 +1324,9 @@ object KafkaConfig {
.define(SslEngineFactoryClassProp, CLASS, null, LOW,
SslEn
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852487421
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1324,9 +1324,9 @@ object KafkaConfig {
.define(SslEngineFactoryClassProp, CLASS, null, LOW,
SslEn
RivenSun2 commented on code in PR #12010:
URL: https://github.com/apache/kafka/pull/12010#discussion_r852494899
##
core/src/main/scala/kafka/server/KafkaConfig.scala:
##
@@ -1324,9 +1324,9 @@ object KafkaConfig {
.define(SslEngineFactoryClassProp, CLASS, null, LOW,
SslEn
C0urante commented on PR #11773:
URL: https://github.com/apache/kafka/pull/11773#issuecomment-1101877201
@tombentley @mimaison gentle reminder, can you revisit this when you have a
chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
C0urante commented on PR #11775:
URL: https://github.com/apache/kafka/pull/11775#issuecomment-1101877431
@showuon is there anything left you'd like me to address?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
RivenSun2 commented on PR #12010:
URL: https://github.com/apache/kafka/pull/12010#issuecomment-1101877626
Hi @C0urante thank you for your review.
I just responded to your comment and resubmitted the code changes as well.
If you have time, please help to review it again.
Thanks.
--
[
https://issues.apache.org/jira/browse/KAFKA-13799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523960#comment-17523960
]
RivenSun commented on KAFKA-13799:
--
Hi [~guozhang]
Could you help to review the PR?
Th
cmccabe commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852482123
##
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##
@@ -950,16 +963,17 @@ class DynamicListenerConfig(server: KafkaBroker) extends
BrokerReconfigurable wi
cmccabe commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852507178
##
core/src/test/scala/unit/kafka/server/metadata/BrokerMetadataPublisherTest.scala:
##
@@ -142,4 +157,80 @@ class BrokerMetadataPublisherTest {
new TopicsImage(ids
cmccabe commented on PR #12063:
URL: https://github.com/apache/kafka/pull/12063#issuecomment-1101889675
I pushed some changes. Sorry that this is a rebase. I was testing something
out and it got annoying to do it as a merge.
Still looking into a test failure in
`DynamicBrokerReconfig
showuon commented on PR #11775:
URL: https://github.com/apache/kafka/pull/11775#issuecomment-1101905729
@C0urante , thanks for the reminder!
@tombentley , do you have any other comments for this PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to t
showuon commented on code in PR #11681:
URL: https://github.com/apache/kafka/pull/11681#discussion_r852533776
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -373,13 +373,19 @@ public void startup() throws ExecutionException,
InterruptedException {
/*
RivenSun2 commented on PR #12000:
URL: https://github.com/apache/kafka/pull/12000#issuecomment-1101921177
Hi @showuon @guozhangwang
could you help to review the PR?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
[
https://issues.apache.org/jira/browse/KAFKA-13816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17523997#comment-17523997
]
Sagar Rao commented on KAFKA-13816:
---
[~ChrisEgerton] , thanks for that info. I think i
dengziming opened a new pull request, #12065:
URL: https://github.com/apache/kafka/pull/12065
*More detailed description of your change*
The bug can be reproduced by KAFKA-13788, when creating an invalid broker
config, we wouldn't treat it as invalid and will treat it as sensitive, and if
dengziming commented on PR #12065:
URL: https://github.com/apache/kafka/pull/12065#issuecomment-1101929610
Hello @rajinisivaram , I think you can take a look at this since most of the
logic I changed is authored by you, thank you.
--
This is an automated message from the Apache Git Servic
showuon commented on code in PR #12000:
URL: https://github.com/apache/kafka/pull/12000#discussion_r852544698
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -182,6 +182,17 @@ public class CommonClientConfigs {
public static final String DE
RivenSun2 commented on PR #11919:
URL: https://github.com/apache/kafka/pull/11919#issuecomment-1101935819
Hi@dajac @guozhangwang
could you help to review the PR ?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
RivenSun2 commented on code in PR #12000:
URL: https://github.com/apache/kafka/pull/12000#discussion_r852549177
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -182,6 +182,17 @@ public class CommonClientConfigs {
public static final String
RivenSun2 commented on code in PR #12000:
URL: https://github.com/apache/kafka/pull/12000#discussion_r852551027
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -182,6 +182,17 @@ public class CommonClientConfigs {
public static final String
dengziming commented on code in PR #11681:
URL: https://github.com/apache/kafka/pull/11681#discussion_r852554581
##
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##
@@ -373,13 +373,19 @@ public void startup() throws ExecutionException,
InterruptedException {
showuon commented on code in PR #11211:
URL: https://github.com/apache/kafka/pull/11211#discussion_r85227
##
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java:
##
@@ -234,7 +275,11 @@ public void put(final Bytes key,
showuon commented on PR #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-1101956387
And BTW, thanks for your patience to work on this issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
showuon commented on code in PR #12000:
URL: https://github.com/apache/kafka/pull/12000#discussion_r852563712
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -182,6 +182,17 @@ public class CommonClientConfigs {
public static final String DE
RivenSun2 commented on code in PR #12000:
URL: https://github.com/apache/kafka/pull/12000#discussion_r852571226
##
clients/src/main/java/org/apache/kafka/clients/CommonClientConfigs.java:
##
@@ -182,6 +182,17 @@ public class CommonClientConfigs {
public static final String
RivenSun2 commented on PR #12000:
URL: https://github.com/apache/kafka/pull/12000#issuecomment-1101975816
Hi @showuon
Please help to review again.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
cmccabe commented on PR #12063:
URL: https://github.com/apache/kafka/pull/12063#issuecomment-1102118688
I had to re-fix this a bit. It turns out that my PR had a bug where if an
advertised listener was modified (but not removed or added) we would not update
the registration in ZK. This shou
showuon commented on PR #12000:
URL: https://github.com/apache/kafka/pull/12000#issuecomment-1102126168
@RivenSun2 , sorry, have a second check, I think the config not declaring as
`public` is on purpose, which will not expose as a public API
[here](https://javadoc.io/doc/org.apache.kafka/k
showuon commented on PR #11681:
URL: https://github.com/apache/kafka/pull/11681#issuecomment-1102130815
Rebase to the latest trunk and the failed tests are unrelated:
```
Build / JDK 8 and Scala 2.12 /
kafka.admin.TopicCommandIntegrationTest.testDescribeAtMinIsrPartitions(String).q
showuon merged PR #11681:
URL: https://github.com/apache/kafka/pull/11681
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.
[
https://issues.apache.org/jira/browse/KAFKA-13737?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen resolved KAFKA-13737.
---
Resolution: Fixed
Resolved with PR: https://github.com/apache/kafka/pull/11681
> Flaky kafka.admin.
showuon commented on code in PR #12060:
URL: https://github.com/apache/kafka/pull/12060#discussion_r852634046
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -320,6 +320,9 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarnes
showuon commented on PR #12060:
URL: https://github.com/apache/kafka/pull/12060#issuecomment-1102137990
Note: All tests passed in Jenkins!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
showuon commented on code in PR #12060:
URL: https://github.com/apache/kafka/pull/12060#discussion_r852634046
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -320,6 +320,9 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHarnes
dengziming commented on code in PR #12060:
URL: https://github.com/apache/kafka/pull/12060#discussion_r852639804
##
core/src/test/scala/integration/kafka/admin/TopicCommandIntegrationTest.scala:
##
@@ -320,6 +320,9 @@ class TopicCommandIntegrationTest extends
KafkaServerTestHar
ruanliang-hualun opened a new pull request, #12066:
URL: https://github.com/apache/kafka/pull/12066
Maintains a drainIndex for each node
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
RivenSun2 commented on PR #12000:
URL: https://github.com/apache/kafka/pull/12000#issuecomment-1102148232
Luke, Thanks for your confirmation.
I will colse this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
showuon commented on PR #12060:
URL: https://github.com/apache/kafka/pull/12060#issuecomment-1102148265
@dengziming , sorry, one more little thing that you missed in my previous
"edited" comment.
Timeout waiting for new assignment [propagating] to broker
--
This is an automated mes
RivenSun2 closed pull request #12000: MINOR: Use the
LEAVE_GROUP_ON_CLOSE_CONFIG configuration uniformly to avoid multiple codes
using the `internal.leave.group.on.close` string alone
URL: https://github.com/apache/kafka/pull/12000
--
This is an automated message from the Apache Git Service.
dengziming commented on PR #12060:
URL: https://github.com/apache/kafka/pull/12060#issuecomment-1102160292
@showuon Aha, this is reasonable, I pushed another commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/KAFKA-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17524115#comment-17524115
]
Luke Chen commented on KAFKA-13834:
---
[~shizhenzhen] , Thanks for reporting the issue.
75 matches
Mail list logo
