cmccabe commented on code in PR #12063:
URL: https://github.com/apache/kafka/pull/12063#discussion_r852476929
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -906,17 +906,22 @@ class DynamicClientQuotaCallback(server: KafkaBroker)
extends Reconfigurable {
}
}
-class DynamicListenerConfig(server: KafkaBroker) extends BrokerReconfigurable
with Logging {
+class DynamicListenerConfig(
+ broker: KafkaBroker,
+) extends BrokerReconfigurable with Logging {
override def reconfigurableConfigs: Set[String] = {
DynamicListenerConfig.ReconfigurableConfigs
}
- def validateReconfiguration(newConfig: KafkaConfig): Unit = {
- val oldConfig = server.config
- if (!oldConfig.requiresZookeeper) {
+ def checkIsNotKRaft(): Unit = {
+ if (!broker.config.requiresZookeeper) {
throw new ConfigException("Dynamic reconfiguration of listeners is not
yet supported when using a Raft-based metadata quorum")
Review Comment:
changed to `verifyAdditionOrRemovalIsSupported` which is more specific. I
also updated the exception text to be more specific.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
