dengziming opened a new pull request, #12065:
URL: https://github.com/apache/kafka/pull/12065

   *More detailed description of your change*
   The bug can be reproduced by KAFKA-13788, when creating an invalid broker 
config, we wouldn't treat it as invalid and will treat it as sensitive, and if 
we want to create a valid broker config, we will fail since the deprecated 
`AdminClient.alterConfigs` requires we specify all sensitive configs.
   
   1. If we user `AdminClient.incrementalAlterConfigs`, this can be avoided.
   2. I find we lack integration tests for altering topic and broker configs, 
so I added a bunch of test cases.
   3. As a convenience, I added KRaft support for `ConfigCommandIntegrationTest`
   
   *Summary of testing strategy (including rationale)*
   A integration test `testUpdateConfigNotAffectedByInvalidConfig`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to