[GitHub] [kafka] showuon commented on pull request #11681: KAFKA-8785: fix request timeout by waiting for metadata cache up-to-date

2022-03-14 Thread GitBox
showuon commented on pull request #11681: URL: https://github.com/apache/kafka/pull/11681#issuecomment-1066451508 > What do you think about modifying the heartbeating logic so that we do not advertise an offset to the controller until it has been published? @hachikuji , thanks for yo

[jira] [Updated] (KAFKA-13733) Reset consumer group offset with not exist topic throw wrong exception

2022-03-14 Thread Yujie Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yujie Li updated KAFKA-13733: - Description: Hey, I'm seen a bug with misleading exception when I try to reset consumer group offset w

[jira] [Updated] (KAFKA-13733) Reset consumer group offset with not exist topic throw wrong exception

2022-03-14 Thread Yujie Li (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Yujie Li updated KAFKA-13733: - Description: Hey, I'm seen a bug with misleading exception when I try to reset consumer group offset w

[jira] [Created] (KAFKA-13733) Reset consumer group offset with not exist topic throw wrong exception

2022-03-14 Thread Yujie Li (Jira)
Yujie Li created KAFKA-13733: Summary: Reset consumer group offset with not exist topic throw wrong exception Key: KAFKA-13733 URL: https://issues.apache.org/jira/browse/KAFKA-13733 Project: Kafka

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825755024 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -144,10 +148,15 @@ private static final long DEFAULT_COMMIT

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825755435 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -1146,6 +1187,36 @@ private void verifyEOSTransactionTimeoutComp

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825757133 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/RackAwarenessIntegrationTest.java ## @@ -0,0 +1,340 @@ +/* + * Licensed to t

[GitHub] [kafka] lkokhreidze commented on pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on pull request #11837: URL: https://github.com/apache/kafka/pull/11837#issuecomment-1066575752 Ready for the review @cadonna @showuon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825761673 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/HighAvailabilityTaskAssignor.java ## @@ -142,15 +142,6 @@

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825762550 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/StandbyTaskAssignmentUtils.java ## @@ -49,7 +53,11 @@ sta

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825762885 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -211,17 +194

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825763496 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -211,17 +194

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825755024 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -144,10 +148,15 @@ private static final long DEFAULT_COMMIT

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825755024 ## File path: streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java ## @@ -144,10 +148,15 @@ private static final long DEFAULT_COMMIT

[GitHub] [kafka] dengziming opened a new pull request #11889: KAFKA-13667: Make listeners mandatory in kraft mode

2022-03-14 Thread GitBox
dengziming opened a new pull request #11889: URL: https://github.com/apache/kafka/pull/11889 *More detailed description of your change* Currently, default "listeners" value for kraft broker node is permitted but it's not allowed for kraft controller node and combine node, this is not ver

[GitHub] [kafka] lkokhreidze commented on pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on pull request #11837: URL: https://github.com/apache/kafka/pull/11837#issuecomment-1066647730 There are few tests failing. Will be fixing them now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

[GitHub] [kafka] cadonna commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
cadonna commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825779088 ## File path: clients/src/test/java/org/apache/kafka/common/config/ConfigDefTest.java ## @@ -722,4 +723,24 @@ public void testNiceTimeUnits() {

[GitHub] [kafka] mimaison merged pull request #11817: KAFKA-13438: Replace EasyMock and PowerMock with Mockito in WorkerTest

2022-03-14 Thread GitBox
mimaison merged pull request #11817: URL: https://github.com/apache/kafka/pull/11817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr

[jira] [Resolved] (KAFKA-13438) Replace EasyMock and PowerMock with Mockito for WorkerTest

2022-03-14 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison resolved KAFKA-13438. Fix Version/s: 3.2.0 Resolution: Fixed > Replace EasyMock and PowerMock with Mockit

[GitHub] [kafka] ijuma commented on pull request #10976: KAFKA-13036 Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-03-14 Thread GitBox
ijuma commented on pull request #10976: URL: https://github.com/apache/kafka/pull/10976#issuecomment-1066717748 @showuon maybe you can help review this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [kafka] ijuma commented on a change in pull request #10904: KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest

2022-03-14 Thread GitBox
ijuma commented on a change in pull request #10904: URL: https://github.com/apache/kafka/pull/10904#discussion_r702976716 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMemberTest.java ## @@ -86,18 +83,12 @@ public void test

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825763496 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -211,17 +194

[GitHub] [kafka] showuon commented on pull request #10976: KAFKA-13036 Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-03-14 Thread GitBox
showuon commented on pull request #10976: URL: https://github.com/apache/kafka/pull/10976#issuecomment-1066731290 Ok, I'll take a look this week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [kafka] showuon commented on pull request #10976: KAFKA-13036 Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2022-03-14 Thread GitBox
showuon commented on pull request #10976: URL: https://github.com/apache/kafka/pull/10976#issuecomment-1066740223 @wycc , I saw there are conflict files with trunk branch, could you help fix them? Thanks. -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Created] (KAFKA-13734) Selector can make use of JDK 11 zero copy NIO select

2022-03-14 Thread Francesco Nigro (Jira)
Francesco Nigro created KAFKA-13734: --- Summary: Selector can make use of JDK 11 zero copy NIO select Key: KAFKA-13734 URL: https://issues.apache.org/jira/browse/KAFKA-13734 Project: Kafka Is

[jira] [Updated] (KAFKA-13734) Selector can make use of JDK 11 zero copy NIO select

2022-03-14 Thread Francesco Nigro (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Francesco Nigro updated KAFKA-13734: Description: JDK 11 has introduced zero copy select ie [https://docs.oracle.com/en/java/j

[GitHub] [kafka] lkokhreidze commented on pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on pull request #11837: URL: https://github.com/apache/kafka/pull/11837#issuecomment-1066811726 Thanks @cadonna for the feedback. I've addressed your comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [kafka] cadonna commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
cadonna commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825994022 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1464,6 +1464,10 @@ protected byte u

[GitHub] [kafka] cadonna commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
cadonna commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r825998032 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1464,6 +1464,10 @@ protected byte u

[GitHub] [kafka] mimaison commented on a change in pull request #11471: MINOR: Replace EasyMock with Mockito in connect:file

2022-03-14 Thread GitBox
mimaison commented on a change in pull request #11471: URL: https://github.com/apache/kafka/pull/11471#discussion_r825963067 ## File path: connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java ## @@ -73,14 +76,12 @@ public void teardown() {

[GitHub] [kafka] vendamere commented on pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2022-03-14 Thread GitBox
vendamere commented on pull request #9345: URL: https://github.com/apache/kafka/pull/9345#issuecomment-1066888018 Was this change meant to work for the schema registry client as well? I've tried connecting to the schema registry using these settings, but it fails with a message indicating

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r826097248 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1464,6 +1464,10 @@ protected by

[GitHub] [kafka] lkokhreidze commented on a change in pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on a change in pull request #11837: URL: https://github.com/apache/kafka/pull/11837#discussion_r826097248 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamsPartitionAssignor.java ## @@ -1464,6 +1464,10 @@ protected by

[jira] [Commented] (KAFKA-9366) Upgrade log4j to log4j2

2022-03-14 Thread Ron Craig (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506307#comment-17506307 ] Ron Craig commented on KAFKA-9366: -- Hi, [~dongjin] please can you confirm that the lates

[GitHub] [kafka] lkokhreidze commented on pull request #11837: KAFKA-6718 / Add rack awareness configurations to StreamsConfig

2022-03-14 Thread GitBox
lkokhreidze commented on pull request #11837: URL: https://github.com/apache/kafka/pull/11837#issuecomment-1066982773 Ran `./gradlew :streams:testAll` locally. The only test that failed was `EosIntegrationTest. shouldCommitCorrectOffsetIfInputTopicIsTransactional[at_least_once]` but seems

[GitHub] [kafka] junrao merged pull request #11816: MINOR: Adding kafka-storage.bat file (similar to kafka-storage.sh) fo…

2022-03-14 Thread GitBox
junrao merged pull request #11816: URL: https://github.com/apache/kafka/pull/11816 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr..

[GitHub] [kafka] mjsax merged pull request #11877: KAKFA-13699: new ProcessorContext is missing methods

2022-03-14 Thread GitBox
mjsax merged pull request #11877: URL: https://github.com/apache/kafka/pull/11877 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] guozhangwang commented on a change in pull request #11887: KAFKA-13690: Fix flaky test in EosIntegrationTest

2022-03-14 Thread GitBox
guozhangwang commented on a change in pull request #11887: URL: https://github.com/apache/kafka/pull/11887#discussion_r826200456 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -1088,17 +1036,21 @@ private void writeInputD

[GitHub] [kafka] C0urante commented on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-14 Thread GitBox
C0urante commented on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067097745 Thanks for finding and fixing this @sunshujie1990. Changes like this one should usually come with a unit test to verify that the original bug exists, and that the proposed fix

[GitHub] [kafka] C0urante edited a comment on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-14 Thread GitBox
C0urante edited a comment on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067097745 Thanks for finding and fixing this @sunshujie1990! Changes like this one should usually come with a unit test to verify that the original bug exists, and that the propo

[GitHub] [kafka] C0urante edited a comment on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-14 Thread GitBox
C0urante edited a comment on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067097745 Thanks for finding and fixing this @sunshujie1990! Changes like this one should usually come with a unit test to verify that the original bug exists, and that the propo

[GitHub] [kafka] C0urante commented on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-14 Thread GitBox
C0urante commented on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067099906 cc @rhauch @kpatelatwork -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [kafka] C0urante edited a comment on pull request #11869: KAFKA-13719: fix connector restart cause duplicate tasks

2022-03-14 Thread GitBox
C0urante edited a comment on pull request #11869: URL: https://github.com/apache/kafka/pull/11869#issuecomment-1067099906 cc @rhauch @kpatelatwork this is a pretty serious bug with the recently-added mass restart feature, worth taking a look if you have the time. -- This is an automated

[GitHub] [kafka] teabot commented on pull request #9345: KAFKA-10338; Support PEM format for SSL key and trust stores (KIP-651)

2022-03-14 Thread GitBox
teabot commented on pull request #9345: URL: https://github.com/apache/kafka/pull/9345#issuecomment-1067106590 See: https://github.com/confluentinc/schema-registry/pull/2062 On Mon, 14 Mar 2022 at 14:44, Peter Vendamere ***@***.***> wrote: > Was this change meant to work for

[GitHub] [kafka] lihaosky commented on a change in pull request #11887: KAFKA-13690: Fix flaky test in EosIntegrationTest

2022-03-14 Thread GitBox
lihaosky commented on a change in pull request #11887: URL: https://github.com/apache/kafka/pull/11887#discussion_r826220140 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -1088,17 +1036,21 @@ private void writeInputData(

[GitHub] [kafka] lihaosky commented on a change in pull request #11705: KAFKA-9847: add config to set default store type (KIP-591)

2022-03-14 Thread GitBox
lihaosky commented on a change in pull request #11705: URL: https://github.com/apache/kafka/pull/11705#discussion_r826228402 ## File path: streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java ## @@ -153,6 +166,17 @@ public TopologyConfig(final String topologyName,

[GitHub] [kafka] lihaosky commented on a change in pull request #11705: KAFKA-9847: add config to set default store type (KIP-591)

2022-03-14 Thread GitBox
lihaosky commented on a change in pull request #11705: URL: https://github.com/apache/kafka/pull/11705#discussion_r826228402 ## File path: streams/src/main/java/org/apache/kafka/streams/TopologyConfig.java ## @@ -153,6 +166,17 @@ public TopologyConfig(final String topologyName,

[GitHub] [kafka] C0urante opened a new pull request #11890: KAFKA-13731: Allow standalone workers to be started without providing any connector configurations

2022-03-14 Thread GitBox
C0urante opened a new pull request #11890: URL: https://github.com/apache/kafka/pull/11890 [Jira](https://issues.apache.org/jira/browse/KAFKA-13731) (Copied from Jira): In order to start a standalone Connect worker, it's currently necessary to provide at least two command-line

[GitHub] [kafka] tim-patterson commented on pull request #11760: KAFKA-13600: Kafka Streams - Fall back to most caught up client if no caught up clients exist

2022-03-14 Thread GitBox
tim-patterson commented on pull request #11760: URL: https://github.com/apache/kafka/pull/11760#issuecomment-1067231809 Hi @cadonna, Sorry day job stuff got in the way for a bit. I've merged in trunk and the streams integration tests all run locally for me now. I also split up

[GitHub] [kafka] hachikuji opened a new pull request #11891: KAFKA-13727; Preserve txn markers after partial segment cleaning

2022-03-14 Thread GitBox
hachikuji opened a new pull request #11891: URL: https://github.com/apache/kafka/pull/11891 It is possible to clean a segment partially if the offset map is filled. The highest offset that is reached becomes the new dirty offset after the cleaning completes. The data above this offset is n

[jira] [Commented] (KAFKA-7540) Flaky Test ConsumerBounceTest#testClose

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506529#comment-17506529 ] Guozhang Wang commented on KAFKA-7540: -- This test case is now very consistently fail

[GitHub] [kafka] hachikuji commented on a change in pull request #11891: KAFKA-13727; Preserve txn markers after partial segment cleaning

2022-03-14 Thread GitBox
hachikuji commented on a change in pull request #11891: URL: https://github.com/apache/kafka/pull/11891#discussion_r826359121 ## File path: clients/src/main/java/org/apache/kafka/common/record/RecordBatchIterator.java ## @@ -36,6 +38,8 @@ protected T makeNext() {

[jira] [Reopened] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reopened KAFKA-13421: --- Re-opening this ticket since the test is still failing. > Fix > ConsumerBounceTest#testRolling

[GitHub] [kafka] guozhangwang commented on pull request #11705: KAFKA-9847: add config to set default store type (KIP-591)

2022-03-14 Thread GitBox
guozhangwang commented on pull request #11705: URL: https://github.com/apache/kafka/pull/11705#issuecomment-1067276610 Re-triggered jenkins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Created] (KAFKA-13735) Flaky kafka.network.SocketServerTest.remoteCloseWithoutBufferedReceives

2022-03-14 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13735: - Summary: Flaky kafka.network.SocketServerTest.remoteCloseWithoutBufferedReceives Key: KAFKA-13735 URL: https://issues.apache.org/jira/browse/KAFKA-13735 Project: Ka

[GitHub] [kafka] C0urante commented on pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure

2022-03-14 Thread GitBox
C0urante commented on pull request #11844: URL: https://github.com/apache/kafka/pull/11844#issuecomment-1067286831 @Corlobin this should probably come with a unit test. I see that you mentioned that the `RestClient` class doesn't have any tests--I think now would be a good time to add one.

[GitHub] [kafka] C0urante edited a comment on pull request #11844: KAFKA#13702 - Connect RestClient overrides response status code on request failure

2022-03-14 Thread GitBox
C0urante edited a comment on pull request #11844: URL: https://github.com/apache/kafka/pull/11844#issuecomment-1067286831 @Corlobin thanks for identifying this issue and filing a fix! This should probably come with a unit test. I see that you mentioned that the `RestClient` class doe

[GitHub] [kafka] lihaosky opened a new pull request #11892: [Emit final] add time ordered store factory

2022-03-14 Thread GitBox
lihaosky opened a new pull request #11892: URL: https://github.com/apache/kafka/pull/11892 ### Description Add factory to create time ordered store supplier ### Testing Added new unit test ### Committer Checklist (excluded from commit message) - [ ] Verify design and i

[GitHub] [kafka] jsancio opened a new pull request #11893: KAFKA-13682; KRaft Controller auto preferred leader election

2022-03-14 Thread GitBox
jsancio opened a new pull request #11893: URL: https://github.com/apache/kafka/pull/11893 Implement auto leader rebalance for KRaft by keeping track of the set of topic partitions which have a leader that is not the preferred replica. If this set is non-empty then schedule a leader balance

[jira] [Comment Edited] (KAFKA-13613) Kafka Connect has a hard dependency on KeyGenerator.HmacSHA256

2022-03-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506571#comment-17506571 ] Chris Egerton edited comment on KAFKA-13613 at 3/14/22, 9:29 PM: -

[jira] [Commented] (KAFKA-13613) Kafka Connect has a hard dependency on KeyGenerator.HmacSHA256

2022-03-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506571#comment-17506571 ] Chris Egerton commented on KAFKA-13613: --- Thanks for reporting this, [~that_guy]. I

[GitHub] [kafka] C0urante opened a new pull request #11894: KAFKA-13613: Remove hard dependency on HmacSHA256 algorithm for Connect

2022-03-14 Thread GitBox
C0urante opened a new pull request #11894: URL: https://github.com/apache/kafka/pull/11894 [Jira](https://issues.apache.org/jira/browse/KAFKA-13613) Some JVMs don't come with the `HmacSHA256` algorithm out of the box, but do come with other key generation and/or MAC algorithms. Howev

[GitHub] [kafka] C0urante commented on pull request #11894: KAFKA-13613: Remove hard dependency on HmacSHA256 algorithm for Connect

2022-03-14 Thread GitBox
C0urante commented on pull request #11894: URL: https://github.com/apache/kafka/pull/11894#issuecomment-1067359447 Note that, while this aims to enable Connect workers to be brought up on JVMs that do not provide the `HmacSHA256` algorithm, it does add support for Connect to be built from

[GitHub] [kafka] guozhangwang opened a new pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
guozhangwang opened a new pull request #11895: URL: https://github.com/apache/kafka/pull/11895 I collected a list of the most flaky tests observed lately, checked / created their corresponding tickets, and mark them as ignored for now. Many of these failures are: 0) Failing very fr

[GitHub] [kafka] guozhangwang commented on pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
guozhangwang commented on pull request #11895: URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067371045 Ping @hachikuji @showuon @rajinisivaram @rhauch who have involved in at least reviewing or investigating some of those tests -- This is an automated message from the Apa

[GitHub] [kafka] guozhangwang edited a comment on pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
guozhangwang edited a comment on pull request #11895: URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067371045 Ping @hachikuji @showuon @rajinisivaram @lbradstreet @rhauch who have involved in reviewing or investigating at least one of those flaky test PRs. -- This is an a

[GitHub] [kafka] guozhangwang commented on a change in pull request #11887: KAFKA-13690: Fix flaky test in EosIntegrationTest

2022-03-14 Thread GitBox
guozhangwang commented on a change in pull request #11887: URL: https://github.com/apache/kafka/pull/11887#discussion_r826437887 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/EosIntegrationTest.java ## @@ -1088,17 +1036,21 @@ private void writeInputD

[GitHub] [kafka] guozhangwang merged pull request #11887: KAFKA-13690: Fix flaky test in EosIntegrationTest

2022-03-14 Thread GitBox
guozhangwang merged pull request #11887: URL: https://github.com/apache/kafka/pull/11887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[jira] [Resolved] (KAFKA-8276) Schema Registry Security settings as Props

2022-03-14 Thread Karthik Murugesan (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8276?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karthik Murugesan resolved KAFKA-8276. -- Resolution: Invalid > Schema Registry Security settings as Props >

[jira] [Assigned] (KAFKA-13613) Kafka Connect has a hard dependency on KeyGenerator.HmacSHA256

2022-03-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris Egerton reassigned KAFKA-13613: - Assignee: Chris Egerton > Kafka Connect has a hard dependency on KeyGenerator.HmacSHA25

[jira] [Comment Edited] (KAFKA-13613) Kafka Connect has a hard dependency on KeyGenerator.HmacSHA256

2022-03-14 Thread Chris Egerton (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17506571#comment-17506571 ] Chris Egerton edited comment on KAFKA-13613 at 3/14/22, 10:58 PM:

[GitHub] [kafka] jsancio commented on a change in pull request #11835: MINOR: refactor how ConfigurationControl checks for resource existence

2022-03-14 Thread GitBox
jsancio commented on a change in pull request #11835: URL: https://github.com/apache/kafka/pull/11835#discussion_r826476938 ## File path: metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java ## @@ -114,7 +114,6 @@ import static org.apache.kafka.c

[GitHub] [kafka] lihaosky opened a new pull request #11896: [Emit final][5/N] emit final for TimeWindowedKStreamImpl

2022-03-14 Thread GitBox
lihaosky opened a new pull request #11896: URL: https://github.com/apache/kafka/pull/11896 ### Description Initial implementation to emit final for TimeWindowedKStreamImpl. This PR is on top of https://github.com/apache/kafka/pull/11892 ### Testing Pending unit test -- T

[GitHub] [kafka] junrao commented on a change in pull request #11891: KAFKA-13727; Preserve txn markers after partial segment cleaning

2022-03-14 Thread GitBox
junrao commented on a change in pull request #11891: URL: https://github.com/apache/kafka/pull/11891#discussion_r826482022 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -270,6 +270,100 @@ class LogCleanerTest { assertEquals(2L, logAppendInfo.l

[GitHub] [kafka] hachikuji commented on a change in pull request #11891: KAFKA-13727; Preserve txn markers after partial segment cleaning

2022-03-14 Thread GitBox
hachikuji commented on a change in pull request #11891: URL: https://github.com/apache/kafka/pull/11891#discussion_r826494909 ## File path: core/src/test/scala/unit/kafka/log/LogCleanerTest.scala ## @@ -270,6 +270,100 @@ class LogCleanerTest { assertEquals(2L, logAppendInf

[jira] [Created] (KAFKA-13736) Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives

2022-03-14 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13736: - Summary: Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives Key: KAFKA-13736 URL: https://issues.apache.org/jira/browse/KAFKA-13736 Project: Ka

[jira] [Resolved] (KAFKA-13736) Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang resolved KAFKA-13736. --- Resolution: Duplicate > Flaky kafka.network.SocketServerTest.closingChannelWithBufferedRecei

[jira] [Assigned] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2022-03-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13421: - Assignee: (was: Jason Gustafson) > Fix > ConsumerBounceTest#testRollingBrokerRestartsWithS

[jira] [Assigned] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2022-03-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-8391: Assignee: (was: Randall Hauch) > Flaky Test RebalanceSourceConnectorsIntegrationTest#testDelet

[jira] [Assigned] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2022-03-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-6527: Assignee: (was: Rajini Sivaram) > Transient failure in DynamicBrokerReconfigurationTest.testDe

[jira] [Reopened] (KAFKA-13736) Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang reopened KAFKA-13736: --- > Flaky kafka.network.SocketServerTest.closingChannelWithBufferedReceives >

[jira] [Created] (KAFKA-13737) Flaky kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection

2022-03-14 Thread Guozhang Wang (Jira)
Guozhang Wang created KAFKA-13737: - Summary: Flaky kafka.admin.LeaderElectionCommandTest.testPreferredReplicaElection Key: KAFKA-13737 URL: https://issues.apache.org/jira/browse/KAFKA-13737 Project: K

[jira] [Assigned] (KAFKA-7540) Flaky Test ConsumerBounceTest#testClose

2022-03-14 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-7540: Assignee: Luke Chen (was: Jason Gustafson) > Flaky Test ConsumerBounceTest#testClose > --

[GitHub] [kafka] showuon commented on a change in pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
showuon commented on a change in pull request #11895: URL: https://github.com/apache/kafka/pull/11895#discussion_r826526579 ## File path: core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala ## @@ -211,6 +211,7 @@ class ConsumerBounceTest extends AbstractConsumerT

[GitHub] [kafka] guozhangwang commented on pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
guozhangwang commented on pull request #11895: URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067511142 Hello @showuon thanks for your thoughts. Just to clarify my intention is that I'm only disabling those tests that have been failed for a while, and if for such time no one

[GitHub] [kafka] mjsax commented on pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
mjsax commented on pull request #11895: URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067515324 If these tests are important, should we not rather fix them asap? Do we have blocker tickets to re-enable the tests before the next release? If the test are not valuable, s

[GitHub] [kafka] showuon commented on pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
showuon commented on pull request #11895: URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067516618 > Hello @showuon thanks for your thoughts. Just to clarify my intention is that I'm only disabling those tests that have been failed for a while, and if for such time no one ha

[GitHub] [kafka] vvcephei commented on pull request #11895: MINOR: Disable those flaky tests

2022-03-14 Thread GitBox
vvcephei commented on pull request #11895: URL: https://github.com/apache/kafka/pull/11895#issuecomment-1067517638 Chiming back in, I think @mjsax 's suggestion is a good middle ground. Perhaps we can just mark all those tests as blockers. 3.2 is just around the corner, and Bruno would be

[jira] [Updated] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-8391: - Fix Version/s: 3.2.0 (was: 2.3.2) (was: 2.6.0)

[jira] [Updated] (KAFKA-12495) Unbalanced connectors/tasks distribution will happen in Connect's incremental cooperative assignor

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-12495: -- Priority: Blocker (was: Major) > Unbalanced connectors/tasks distribution will happen in Conn

[jira] [Updated] (KAFKA-8391) Flaky Test RebalanceSourceConnectorsIntegrationTest#testDeleteConnector

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-8391: - Priority: Blocker (was: Critical) > Flaky Test RebalanceSourceConnectorsIntegrationTest#testDele

[GitHub] [kafka] showuon merged pull request #11475: KAFKA-7077: Use default producer settings in Connect Worker

2022-03-14 Thread GitBox
showuon merged pull request #11475: URL: https://github.com/apache/kafka/pull/11475 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[GitHub] [kafka] showuon commented on pull request #11475: KAFKA-7077: Use default producer settings in Connect Worker

2022-03-14 Thread GitBox
showuon commented on pull request #11475: URL: https://github.com/apache/kafka/pull/11475#issuecomment-1067520890 Failed tests are unrelated: ``` Build / ARM / org.apache.kafka.streams.integration.NamedTopologyIntegrationTest.shouldRemoveOneNamedTopologyWhileAnotherContinuesProcessing

[jira] [Updated] (KAFKA-7540) Flaky Test ConsumerBounceTest#testClose

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-7540: - Priority: Blocker (was: Critical) > Flaky Test ConsumerBounceTest#testClose > --

[jira] [Updated] (KAFKA-7540) Flaky Test ConsumerBounceTest#testClose

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7540?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-7540: - Fix Version/s: 3.2.0 > Flaky Test ConsumerBounceTest#testClose >

[jira] [Updated] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13421: -- Priority: Blocker (was: Major) > Fix > ConsumerBounceTest#testRollingBrokerRestartsWithSmall

[jira] [Updated] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-6527: - Fix Version/s: 3.2.0 > Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConf

[jira] [Updated] (KAFKA-13421) Fix ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupSizeConfigDisruptsBigGroup

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13421?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-13421: -- Fix Version/s: 3.2.0 > Fix > ConsumerBounceTest#testRollingBrokerRestartsWithSmallerMaxGroupS

[jira] [Updated] (KAFKA-6527) Transient failure in DynamicBrokerReconfigurationTest.testDefaultTopicConfig

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-6527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-6527: - Priority: Blocker (was: Major) > Transient failure in DynamicBrokerReconfigurationTest.testDefau

[jira] [Updated] (KAFKA-8280) Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderElectionEnable

2022-03-14 Thread Guozhang Wang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guozhang Wang updated KAFKA-8280: - Fix Version/s: 3.2.0 > Flaky Test DynamicBrokerReconfigurationTest#testUncleanLeaderElectionEnabl

  1   2   >