hachikuji commented on a change in pull request #11891:
URL: https://github.com/apache/kafka/pull/11891#discussion_r826359121



##########
File path: 
clients/src/main/java/org/apache/kafka/common/record/RecordBatchIterator.java
##########
@@ -36,6 +38,8 @@ protected T makeNext() {
             if (batch == null)
                 return allDone();
             return batch;
+        } catch (EOFException e) {

Review comment:
       `LogCleanerTest.testCorruptMessageSizeLargerThanBytesAvailable` was 
failing after the change to `readNextOffset` in `LogCleaner` due to an 
unexpected EOF. It seems reasonable to catch it here and raise as a 
`CorruptRecordException` (which is also a `KafkaException`). This made the test 
pass.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to