mimaison commented on a change in pull request #11471:
URL: https://github.com/apache/kafka/pull/11471#discussion_r825963067
##########
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##########
@@ -73,14 +76,12 @@ public void teardown() {
}
private void replay() {
- replayAll();
Review comment:
This method is not called anymore. So `verifyMocks` is always `false`
now and `teardown()` does not call `verifyAll()`. Is this expected?
##########
File path:
connect/file/src/test/java/org/apache/kafka/connect/file/FileStreamSourceTaskTest.java
##########
@@ -220,6 +222,8 @@ public void testMissingFile() throws InterruptedException {
task.stop();
}
+ @Test
+ @Disabled
Review comment:
This test is not great but I don't think disabling it is the way forward.
I suggest keeping it but maybe reducing the number of retries. We can't
really assert `poll()` will _indefinitely_ return `null` and there's little
value in spending 100 seconds on this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
