zzccctv commented on pull request #11496:
URL: https://github.com/apache/kafka/pull/11496#issuecomment-972630217
@guozhangwang This suggestion looks very good, But there is a problem. The
BrokerConfigHandler class also calls the updateDefaultConfig and
updateBrrokerConfig functions respect
zzccctv edited a comment on pull request #11496:
URL: https://github.com/apache/kafka/pull/11496#issuecomment-972630217
@guozhangwang This suggestion looks very good, But there is a problem. The
BrokerConfigHandler class also calls the updateDefaultConfig and
updateBrrokerConfig functions
zzccctv edited a comment on pull request #11496:
URL: https://github.com/apache/kafka/pull/11496#issuecomment-972630217
@guozhangwang This suggestion looks very good, But there is a problem. The
BrokerConfigHandler class also calls the updateDefaultConfig and
updateBrrokerConfig functions
[
https://issues.apache.org/jira/browse/KAFKA-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445735#comment-17445735
]
Darshan Marathe commented on KAFKA-13458:
-
Kafka broker Version: 2.6.1
> The St
zzccctv edited a comment on pull request #11496:
URL: https://github.com/apache/kafka/pull/11496#issuecomment-972630217
@guozhangwang This suggestion looks very good, But there is a problem. The
BrokerConfigHandler class also calls the updateDefaultConfig and
updateBrrokerConfig functions
[
https://issues.apache.org/jira/browse/KAFKA-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445793#comment-17445793
]
RivenSun commented on KAFKA-13463:
--
Supplement to the suggestion:
h2. 6） Strip the paus
[
https://issues.apache.org/jira/browse/KAFKA-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445793#comment-17445793
]
RivenSun edited comment on KAFKA-13463 at 11/18/21, 9:57 AM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445793#comment-17445793
]
RivenSun edited comment on KAFKA-13463 at 11/18/21, 10:01 AM:
dajac merged pull request #11510:
URL: https://github.com/apache/kafka/pull/11510
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac commented on pull request #11510:
URL: https://github.com/apache/kafka/pull/11510#issuecomment-972717480
Merged to trunk and 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/KAFKA-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17445793#comment-17445793
]
RivenSun edited comment on KAFKA-13463 at 11/18/21, 10:06 AM:
dajac commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r752115394
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -443,7 +443,9 @@ boolean joinGroupIfNeeded(f
dajac commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r752117851
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -746,8 +748,8 @@ public void handle(SyncGrou
mimaison merged pull request #11472:
URL: https://github.com/apache/kafka/pull/11472
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
mimaison commented on a change in pull request #11500:
URL: https://github.com/apache/kafka/pull/11500#discussion_r752125838
##
File path: docs/quickstart.html
##
@@ -158,15 +158,78 @@
-You probably have lots of data in existing systems like r
mimaison merged pull request #11467:
URL: https://github.com/apache/kafka/pull/11467
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
mdedetrich commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-972784982
I have updated the PR to add some upgrade notes to `docs/upgrade.html`. I am
not sure if additional documentation is needed elsewhere (I had a look at
`docs` in general and c
katheris commented on a change in pull request #11500:
URL: https://github.com/apache/kafka/pull/11500#discussion_r752179967
##
File path: docs/quickstart.html
##
@@ -158,15 +158,78 @@
-You probably have lots of data in existing systems like r
katheris commented on a change in pull request #11500:
URL: https://github.com/apache/kafka/pull/11500#discussion_r752179967
##
File path: docs/quickstart.html
##
@@ -158,15 +158,78 @@
-You probably have lots of data in existing systems like r
mdedetrich commented on pull request #11478:
URL: https://github.com/apache/kafka/pull/11478#issuecomment-972827297
I have updated the PR to add documentation to
https://kafka.apache.org/documentation/#brokerconfigs_listeners
--
This is an automated message from the Apache Git Service.
T
mimaison commented on pull request #11450:
URL: https://github.com/apache/kafka/pull/11450#issuecomment-972840100
@chia7712 @tombentley Can you take a look? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
RivenSun2 opened a new pull request #11512:
URL: https://github.com/apache/kafka/pull/11512
Modify the Exception type of the testCommitOffsetAsyncNotCoordinator method
Committer Checklist (excluded from commit message)
Verify design and implementation
Verify test coverage and
RivenSun2 commented on pull request #11512:
URL: https://github.com/apache/kafka/pull/11512#issuecomment-972857020
Hi @dajac @hachikuji , please help to review the PR .
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
RivenSun2 edited a comment on pull request #11512:
URL: https://github.com/apache/kafka/pull/11512#issuecomment-972857020
Hi @dajac @hachikuji and @showuon , please help to review the PR .
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message,
mimaison commented on pull request #11393:
URL: https://github.com/apache/kafka/pull/11393#issuecomment-972862126
Rebased on trunk.
@dajac @hachikuji Gentle reminder :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
vpapavas opened a new pull request #11513:
URL: https://github.com/apache/kafka/pull/11513
As part of the consistency work, a RocksDBStore has a consistency vector
that contains the latest seen offset of every partition. We need this
information on StandBy servers as well. To achieve this,
dengziming commented on a change in pull request #11450:
URL: https://github.com/apache/kafka/pull/11450#discussion_r752292519
##
File path:
connect/runtime/src/test/java/org/apache/kafka/connect/storage/FileOffsetBackingStoreTest.java
##
@@ -77,21 +74,17 @@ public void teardo
patrickstuedi opened a new pull request #11514:
URL: https://github.com/apache/kafka/pull/11514
This PR is levering the previously added StateStoreContext::recordMetadata()
to track the current position seen by a state store.
--
This is an automated message from the Apache Git Service.
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752307030
##
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##
@@ -404,10 +404,6 @@ class BrokerServer(
config.numIoThreads,
s"${Sock
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752312628
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -2007,8 +2007,13 @@ class KafkaConfig private(doLog: Boolean, val props:
java
[
https://issues.apache.org/jira/browse/KAFKA-13462?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
dengziming resolved KAFKA-13462.
Resolution: Invalid
__consumer_offsets will not be created unless we store commit offset
> KRaft
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752324936
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -2011,12 +2012,68 @@ class KafkaConfig private(doLog: Boolean, val props:
jav
vpapavas commented on a change in pull request #11513:
URL: https://github.com/apache/kafka/pull/11513#discussion_r752325491
##
File path:
streams/src/test/java/org/apache/kafka/streams/integration/ConsistencyVectorIntegrationTest.java
##
@@ -0,0 +1,239 @@
+/*
+ * Licensed to
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752328227
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -2011,12 +2012,68 @@ class KafkaConfig private(doLog: Boolean, val props:
jav
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752327468
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -2011,12 +2012,68 @@ class KafkaConfig private(doLog: Boolean, val props:
jav
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752331857
##
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##
@@ -2031,11 +2088,7 @@ class KafkaConfig private(doLog: Boolean, val props:
java
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752335041
##
File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
##
@@ -186,34 +186,31 @@ class KafkaConfigTest {
// listeners with d
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752341197
##
File path: core/src/test/scala/unit/kafka/server/KafkaConfigTest.scala
##
@@ -223,31 +220,26 @@ class KafkaConfigTest {
//advertised listen
rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752346217
##
File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala
##
@@ -297,7 +297,7 @@ object TestUtils extends Logging {
props.put(KafkaCo
dajac commented on pull request #11459:
URL: https://github.com/apache/kafka/pull/11459#issuecomment-973030538
The flaky tests are unrelated to this PR. Going to merge to trunk and 3.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
dajac merged pull request #11459:
URL: https://github.com/apache/kafka/pull/11459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
dajac commented on pull request #11459:
URL: https://github.com/apache/kafka/pull/11459#issuecomment-973034180
@jolshan Let's try to address that flaky test separately as it is not
related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message,
hgeraldino opened a new pull request #11515:
URL: https://github.com/apache/kafka/pull/11515
As part of KIP-795, this PR relocates some classes from the
`org.apache.kafka.clients.consumer.internals` package to the
`org.apache.kafka.clients.consumer` package, in order to make them part of
cadonna commented on pull request #11462:
URL: https://github.com/apache/kafka/pull/11462#issuecomment-973069804
Test failures are unrelated and known to be flaky.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
cadonna merged pull request #11462:
URL: https://github.com/apache/kafka/pull/11462
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
guozhangwang commented on a change in pull request #11496:
URL: https://github.com/apache/kafka/pull/11496#discussion_r752509125
##
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##
@@ -291,23 +291,23 @@ class DynamicBrokerConfig(private val kafkaConfig:
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446106#comment-17446106
]
Guozhang Wang commented on KAFKA-13435:
---
[~rleslie] today only the brokers can det
[
https://issues.apache.org/jira/browse/KAFKA-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446107#comment-17446107
]
Guozhang Wang commented on KAFKA-13375:
---
There are actually multiple known issues
[
https://issues.apache.org/jira/browse/KAFKA-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446108#comment-17446108
]
Guozhang Wang commented on KAFKA-13458:
---
I think you are hitting some known issues
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752580337
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -121,9 +164,9 @@ public void maybeWaitForN
wcarlson5 commented on pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#issuecomment-973307507
@guozhangwang @ableegoldman I think this is ready for another pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752680014
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -83,6 +100,7 @@ public TopologyMetadata(fi
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752680404
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -908,20 +908,25 @@ private void initializeAndR
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752681064
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##
@@ -908,20 +908,25 @@ private void initializeAndR
hachikuji commented on a change in pull request #11046:
URL: https://github.com/apache/kafka/pull/11046#discussion_r752683020
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -638,15 +636,15 @@ public void onFailure(RuntimeExce
hachikuji commented on a change in pull request #11046:
URL: https://github.com/apache/kafka/pull/11046#discussion_r752683020
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -638,15 +636,15 @@ public void onFailure(RuntimeExce
hachikuji commented on a change in pull request #11046:
URL: https://github.com/apache/kafka/pull/11046#discussion_r752683020
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -638,15 +636,15 @@ public void onFailure(RuntimeExce
Travis Bischel created KAFKA-13464:
--
Summary: SCRAM does not validate client-final-message's nonce
Key: KAFKA-13464
URL: https://issues.apache.org/jira/browse/KAFKA-13464
Project: Kafka
Issu
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446202#comment-17446202
]
Ryan Leslie edited comment on KAFKA-13435 at 11/18/21, 11:17 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446202#comment-17446202
]
Ryan Leslie commented on KAFKA-13435:
-
[~dajac] Thank you for picking this up quickl
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446202#comment-17446202
]
Ryan Leslie edited comment on KAFKA-13435 at 11/18/21, 11:18 PM:
-
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446206#comment-17446206
]
Guozhang Wang commented on KAFKA-13435:
---
[~rleslie] Sorry I misunderstood your sce
[
https://issues.apache.org/jira/browse/KAFKA-13435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446209#comment-17446209
]
Ryan Leslie commented on KAFKA-13435:
-
[~guozhang] Awesome, glad we are more in sync
[
https://issues.apache.org/jira/browse/KAFKA-13464?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Chen reassigned KAFKA-13464:
-
Assignee: Luke Chen
> SCRAM does not validate client-final-message's nonce
> --
ableegoldman commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752809604
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -108,6 +124,48 @@ private void unlock()
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752821836
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##
@@ -118,40 +133
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752821836
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##
@@ -118,40 +133
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752822683
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -108,6 +124,48 @@ private void unlock() {
ableegoldman commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752831095
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##
@@ -118,40 +
ableegoldman commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752831258
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/TopologyMetadata.java
##
@@ -108,6 +124,48 @@ private void unlock()
wcarlson5 commented on a change in pull request #11479:
URL: https://github.com/apache/kafka/pull/11479#discussion_r752834113
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/namedtopology/KafkaStreamsNamedTopologyWrapper.java
##
@@ -118,40 +133
ZhenChun Pan created KAFKA-13465:
Summary: when auto create topics enable,server create inner topic
of MirrorMaker unexpectedly
Key: KAFKA-13465
URL: https://issues.apache.org/jira/browse/KAFKA-13465
[
https://issues.apache.org/jira/browse/KAFKA-13465?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ZhenChun Pan updated KAFKA-13465:
-
Description:
Hi Team
Mirror Maker: 2.7.0
when i enable auto create topic in both side:
auto.
jsancio commented on pull request #11511:
URL: https://github.com/apache/kafka/pull/11511#issuecomment-973737297
@hachikuji I updated the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
RivenSun2 commented on pull request #11512:
URL: https://github.com/apache/kafka/pull/11512#issuecomment-973762702
@dajac @hachikuji
This commit avoids repeated tests of testCommitOffsetAsyncNotCoordinator and
testCommitOffsetAsyncCoordinatorNotAvailable.
please help to review it.
[
https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446288#comment-17446288
]
RivenSun commented on KAFKA-13422:
--
Can anyone give me a response? I feel very frustrat
[
https://issues.apache.org/jira/browse/KAFKA-13437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446289#comment-17446289
]
RivenSun commented on KAFKA-13437:
--
Is this issue worthless? No one has been willing to
[
https://issues.apache.org/jira/browse/KAFKA-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446292#comment-17446292
]
RivenSun commented on KAFKA-13463:
--
Is anyone willing to give some discussion?
I feel v
[
https://issues.apache.org/jira/browse/KAFKA-13463?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446295#comment-17446295
]
RivenSun commented on KAFKA-13463:
--
Hi [~tombentley]
I recently noticed that you have
[
https://issues.apache.org/jira/browse/KAFKA-13458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446297#comment-17446297
]
Darshan Marathe commented on KAFKA-13458:
-
[~guozhang] Thanks, No we are not usi
[
https://issues.apache.org/jira/browse/KAFKA-13370?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446303#comment-17446303
]
Luke Chen commented on KAFKA-13370:
---
[~rhauch] , PR: [https://github.com/apache/kafka/
showuon commented on pull request #11509:
URL: https://github.com/apache/kafka/pull/11509#issuecomment-973787826
Failed tests are unrelated. Thank you.
```
Build / JDK 17 and Scala 2.13 /
kafka.admin.LeaderElectionCommandTest.[1] Type=Raft, Name=testTopicPartition,
Security=PLAIN
[
https://issues.apache.org/jira/browse/KAFKA-13464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446311#comment-17446311
]
Travis Bischel commented on KAFKA-13464:
AFAICT this compromises no integrity. I
showuon commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r752900442
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -746,8 +748,8 @@ public void handle(SyncGr
showuon commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r752901904
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##
@@ -443,7 +443,9 @@ boolean joinGroupIfNeeded
showuon edited a comment on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-973803318
@dajac , thanks for your comments. Yes, you are right, I didn't make the if
condition correct. I've updated it to use a `hasGenerationReset` helper method:
```java
p
showuon commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-973803318
@dajac , thanks for your comments. Yes, you are right, I didn't make the if
condition correct. I've updated it to use a `hasGenerationReset` helper method:
```java
private
[
https://issues.apache.org/jira/browse/KAFKA-13465?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17446337#comment-17446337
]
ZhenChun Pan commented on KAFKA-13465:
--
I already have a patch for this issue, mayb
88 matches
Mail list logo
