rondagostino commented on a change in pull request #11503:
URL: https://github.com/apache/kafka/pull/11503#discussion_r752331857



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -2031,11 +2088,7 @@ class KafkaConfig private(doLog: Boolean, val props: 
java.util.Map[_, _], dynami
       s"${KafkaConfig.AdvertisedListenersProp} cannot use the nonroutable 
meta-address 0.0.0.0. "+
       s"Use a routable IP address.")
 
-    // Ensure controller listeners are not in the advertised listeners list
-    require(!controllerListeners.exists(advertisedListeners.contains),
-      s"${KafkaConfig.AdvertisedListenersProp} cannot contain any of 
${KafkaConfig.ControllerListenerNamesProp}")
-

Review comment:
       This is now checked above -- this exact check is done when running the 
broker role, but the check for when running just the controller role is 
actually now more constrained: advertised listeners must be empty in that case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to