dajac commented on a change in pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#discussion_r752115394
##########
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java
##########
@@ -443,7 +443,9 @@ boolean joinGroupIfNeeded(final Timer timer) {
stateSnapshot = this.state;
}
- if (!generationSnapshot.equals(Generation.NO_GENERATION) &&
stateSnapshot == MemberState.STABLE) {
+ if ((generationSnapshot.generationId !=
Generation.NO_GENERATION.generationId ||
+
!generationSnapshot.memberId.equals(Generation.NO_GENERATION.memberId)) &&
+ stateSnapshot == MemberState.STABLE) {
Review comment:
Is the `||` in this condition correct? I thought that we would consider
the rebalance successful only if we have a valid generation and a valid member
id. Am I missing something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
