[
https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437766#comment-17437766
]
RivenSun commented on KAFKA-13422:
--
Hi [~guozhang] , [~showuon]
For suggestion 2, I cr
dajac commented on pull request #11368:
URL: https://github.com/apache/kafka/pull/11368#issuecomment-958704520
@mjsax Sounds reasonable to me. Please go ahead and cherry-pick it to the
3.1 branch as well.
--
This is an automated message from the Apache Git Service.
To respond to the mess
shirenchuang commented on a change in pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#discussion_r741666574
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -152,7 +152,7 @@ class ZkAdminManager(val config: KafkaConfig,
[
https://issues.apache.org/jira/browse/KAFKA-6080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437826#comment-17437826
]
Sönke Liebau commented on KAFKA-6080:
-
Thanks [~tombentley]!! I'll give that a read.
cadonna merged pull request #11441:
URL: https://github.com/apache/kafka/pull/11441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r741840561
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,203
[
https://issues.apache.org/jira/browse/KAFKA-6498?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna resolved KAFKA-6498.
--
Resolution: Done
> Add RocksDB statistics via Streams metrics
> ---
[
https://issues.apache.org/jira/browse/KAFKA-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17437950#comment-17437950
]
Aleksandr Sorokoumov commented on KAFKA-13373:
--
Thank you for a quick respo
[
https://issues.apache.org/jira/browse/KAFKA-13373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Aleksandr Sorokoumov resolved KAFKA-13373.
--
Resolution: Cannot Reproduce
> ValueTransformerWithKeySupplier doesn't work wi
[
https://issues.apache.org/jira/browse/KAFKA-8941?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Cadonna updated KAFKA-8941:
-
Fix Version/s: 3.2.0
> Add RocksDB Metrics that Could not be Added due to RocksDB Version
> -
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r741896976
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,205
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r741897677
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,203
showuon commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
@guozhangwang , that's a good point. Yes, I was focusing on the fix 1) above
only. For 2), yes, we should also fix that, but I need some time to think a
good way to fix that iss
showuon edited a comment on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
@guozhangwang , that's a good point. Yes, I was focusing on the fix 1) above
only. For 2), yes, we should also fix that, but I need some time to think a
good way to fix t
[
https://issues.apache.org/jira/browse/KAFKA-13428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438045#comment-17438045
]
David Jacot commented on KAFKA-13428:
-
Thanks, [~yuhuo]. We can close this ticket as
[
https://issues.apache.org/jira/browse/KAFKA-13428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13428.
-
Resolution: Duplicate
> server hang on shutdown
> ---
>
> Ke
showuon edited a comment on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
@guozhangwang , that's a good point. Yes, I was focusing on the fix 1) above
only. For 2), yes, we should also fix that, but I need some time to think a
good way to fix t
showuon edited a comment on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
@guozhangwang , that's a good point. Yes, I was focusing on the fix 1) above
only. For 2), yes, we should also fix that, but I need some time to think a
good way to fix t
cadonna opened a new pull request #11462:
URL: https://github.com/apache/kafka/pull/11462
With a nice mock in
`RocksDBMetricsRecorderTest#shouldCorrectlyHandleHitRatioRecordingsWithZeroHitsAndMisses()`
and
`RocksDBMetricsRecorderTest#shouldCorrectlyHandleAvgRecordingsWithZeroSumAndCount()
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r741923941
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,205
cadonna commented on pull request #11462:
URL: https://github.com/apache/kafka/pull/11462#issuecomment-959048389
Call for review: @Luizfrf3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-959050366
Hi @cadonna
Very sorry for disappearing, didn't find time to deal with this PR.
I've addressed your comments. Please have another look when you got time.
--
This is
cadonna commented on a change in pull request #11462:
URL: https://github.com/apache/kafka/pull/11462#discussion_r741926434
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java
##
@@ -557,10 +555,10 @@ public void
showuon edited a comment on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
@guozhangwang , that's a good point. Yes, I was focusing on the fix 1) above
only. For 2), yes, we should also fix that, but I need some time to think a
good way to fix t
[
https://issues.apache.org/jira/browse/KAFKA-13422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438056#comment-17438056
]
RivenSun commented on KAFKA-13422:
--
And for Suggestion 1, the ideas I provided are feas
cadonna merged pull request #10678:
URL: https://github.com/apache/kafka/pull/10678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r741789472
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -285,52 +268,57 @@ public FetchRequestData build() {
mimaison commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r742002383
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##
@@ -519,6 +521,47 @@
dongjinleekr commented on pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#issuecomment-959282035
@cadonna :bow::bow::bow::bow:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
Dongjin Lee created KAFKA-13430:
---
Summary: Remove broker-wide quota properties from the documentation
Key: KAFKA-13430
URL: https://issues.apache.org/jira/browse/KAFKA-13430
Project: Kafka
Issu
dongjinleekr opened a new pull request #11463:
URL: https://github.com/apache/kafka/pull/11463
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade
[
https://issues.apache.org/jira/browse/KAFKA-13430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dongjin Lee updated KAFKA-13430:
Description:
I found this problem while working on
[KAFKA-13341|https://issues.apache.org/jira/br
[
https://issues.apache.org/jira/browse/KAFKA-13430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438118#comment-17438118
]
Dongjin Lee commented on KAFKA-13430:
-
[~dajac] Could you kindly have a look? It see
mimaison commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r742038737
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public MirrorClientConfig cli
mimaison commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r742040313
##
File path:
connect/mirror-client/src/main/java/org/apache/kafka/connect/mirror/MirrorClientConfig.java
##
@@ -50,8 +50,7 @@
public static final
mimaison commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r742038737
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public MirrorClientConfig cli
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742113471
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -285,52 +268,57 @@ public FetchRequestData build() {
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742114292
##
File path:
clients/src/main/java/org/apache/kafka/clients/consumer/internals/Fetcher.java
##
@@ -824,6 +823,14 @@ static boolean
hasUsableOffsetForLe
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742116109
##
File path: core/src/main/scala/kafka/server/AbstractFetcherThread.scala
##
@@ -374,7 +374,7 @@ abstract class AbstractFetcherThread(name: String,
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742119691
##
File path: core/src/main/scala/kafka/server/KafkaApis.scala
##
@@ -708,40 +701,41 @@ class KafkaApis(val requestChannel: RequestChannel,
None
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742121483
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -1021,17 +1018,17 @@ class ReplicaManager(val config: KafkaConfig,
var byte
mimaison commented on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-959671382
Sorry I'm still not quite sure I fully understand the issue you're
describing.
If the path is not readable, yes Connect won't load plugins in it. But it's
printing an error
akatona84 commented on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-959759146
IMHO we could enhance the code to log those which are not eligible for the
conditions (readable, directory or jar, whatever) if that helps.
The problem is that if it's not r
akatona84 edited a comment on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-959759146
IMHO we could enhance the code to log those which are not eligible for the
conditions (readable, directory or jar, whatever) if that helps.
The problem is that if it'
[
https://issues.apache.org/jira/browse/KAFKA-8541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438217#comment-17438217
]
Matthias J. Sax commented on KAFKA-8541:
Failed again (different test)
{code:java
mjsax merged pull request #11368:
URL: https://github.com/apache/kafka/pull/11368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
mjsax commented on pull request #11368:
URL: https://github.com/apache/kafka/pull/11368#issuecomment-959793533
Thanks.
Merged to `trunk` and cherry-picked to `3.1` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
guozhangwang commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959797459
@showuon Sounds good, let's just focus on 1) here then. The proposed fix
looks reasonable to me.
--
This is an automated message from the Apache Git Service.
To respond t
guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-959799444
@shirenchuang Thanks. Let's just focus on the ZK path for this PR then.
Please ping @junrao and myself after you've added the unit test: note it should
verify that upon the
junrao commented on a change in pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#discussion_r742217440
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -152,7 +152,7 @@ class ZkAdminManager(val config: KafkaConfig,
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742232425
##
File path:
clients/src/main/java/org/apache/kafka/common/requests/FetchRequest.java
##
@@ -66,16 +69,28 @@ public PartitionData(
int maxB
guozhangwang commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-959812833
> While InMemoryWindowStore does enable strict retention but when combined
with the caching store, it breaks. That's where doing it on MeteredStore might
be beneficial.
Diego Erdody created KAFKA-13431:
Summary: Sink Connectors: Support topic-mutating SMTs for async
connectors (preCommit users)
Key: KAFKA-13431
URL: https://issues.apache.org/jira/browse/KAFKA-13431
P
[
https://issues.apache.org/jira/browse/KAFKA-13431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Diego Erdody updated KAFKA-13431:
-
Labels: needs-kip (was: )
> Sink Connectors: Support topic-mutating SMTs for async connectors (
guozhangwang commented on pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#issuecomment-959833451
@cadonna I had some discussions with @mjsax about this, and my main
motivation comes from the old logic before the latest PR that modifies the
instance level diagram and in
[
https://issues.apache.org/jira/browse/KAFKA-10457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438256#comment-17438256
]
Arjun Satish commented on KAFKA-10457:
--
looks like we would need a new [data
type|
erdody opened a new pull request #11464:
URL: https://github.com/apache/kafka/pull/11464
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of
[
https://issues.apache.org/jira/browse/KAFKA-12487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438272#comment-17438272
]
Konstantine Karantasis commented on KAFKA-12487:
Hi [~dajac]. I'd like t
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742285803
##
File path: core/src/main/scala/kafka/server/FetchSession.scala
##
@@ -163,18 +173,35 @@ class CachedPartition(val topic: String,
mustRespond
}
bdesert commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r742290825
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##
@@ -519,6 +521,47 @@ p
Vikas Singh created KAFKA-13432:
---
Summary: ApiException should provide a way to capture stacktrace
Key: KAFKA-13432
URL: https://issues.apache.org/jira/browse/KAFKA-13432
Project: Kafka
Issue T
kirktrue opened a new pull request #11465:
URL: https://github.com/apache/kafka/pull/11465
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testin
guozhangwang commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r742366571
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1030,8 +1038,11 @@ private static Metrics getMetrics(final Stre
[
https://issues.apache.org/jira/browse/KAFKA-13432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438341#comment-17438341
]
Vikas Singh commented on KAFKA-13432:
-
One simple solution can be to fill in the sta
mjsax commented on pull request #11368:
URL: https://github.com/apache/kafka/pull/11368#issuecomment-958635275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
mjsax commented on a change in pull request #11447:
URL: https://github.com/apache/kafka/pull/11447#discussion_r741604615
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GroupedTableOperationRepartitionNode.java
##
@@ -119,5 +119,10 @@ publ
dajac commented on pull request #11368:
URL: https://github.com/apache/kafka/pull/11368#issuecomment-958704520
@mjsax Sounds reasonable to me. Please go ahead and cherry-pick it to the
3.1 branch as well.
--
This is an automated message from the Apache Git Service.
To respond to the mess
shirenchuang commented on a change in pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#discussion_r741666574
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -152,7 +152,7 @@ class ZkAdminManager(val config: KafkaConfig,
cadonna commented on pull request #11462:
URL: https://github.com/apache/kafka/pull/11462#issuecomment-959048389
Call for review: @Luizfrf3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
akatona84 commented on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-959759146
IMHO we could enhance the code to log those which are not eligible for the
conditions (readable, directory or jar, whatever) if that helps.
The problem is that if it's not r
cadonna merged pull request #10678:
URL: https://github.com/apache/kafka/pull/10678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
mimaison commented on a change in pull request #11431:
URL: https://github.com/apache/kafka/pull/11431#discussion_r742038737
##
File path:
connect/mirror/src/main/java/org/apache/kafka/connect/mirror/MirrorMakerConfig.java
##
@@ -183,12 +187,18 @@ public MirrorClientConfig cli
showuon edited a comment on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
guozhangwang commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959797459
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
[
https://issues.apache.org/jira/browse/KAFKA-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438376#comment-17438376
]
Guozhang Wang commented on KAFKA-13375:
---
Hello [~Lerh] Thanks for reporting this i
showuon commented on pull request #11451:
URL: https://github.com/apache/kafka/pull/11451#issuecomment-959028970
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
cadonna commented on a change in pull request #11462:
URL: https://github.com/apache/kafka/pull/11462#discussion_r741926434
##
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java
##
@@ -557,10 +555,10 @@ public void
[
https://issues.apache.org/jira/browse/KAFKA-13375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guozhang Wang updated KAFKA-13375:
--
Component/s: (was: streams)
> Kafka streams apps w/EOS unable to start at InitProducerId
>
lkokhreidze commented on a change in pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#discussion_r741840561
##
File path:
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java
##
@@ -0,0 +1,203
lkokhreidze commented on pull request #10851:
URL: https://github.com/apache/kafka/pull/10851#issuecomment-959050366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
mjsax merged pull request #11368:
URL: https://github.com/apache/kafka/pull/11368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@k
cadonna merged pull request #11441:
URL: https://github.com/apache/kafka/pull/11441
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
bdesert commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r742290825
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##
@@ -519,6 +521,47 @@ p
akatona84 edited a comment on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-959759146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
guozhangwang commented on a change in pull request #11424:
URL: https://github.com/apache/kafka/pull/11424#discussion_r742366571
##
File path: streams/src/main/java/org/apache/kafka/streams/KafkaStreams.java
##
@@ -1030,8 +1038,11 @@ private static Metrics getMetrics(final Stre
mimaison commented on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-959671382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
guozhangwang commented on pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#issuecomment-959799444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
guozhangwang commented on pull request #11455:
URL: https://github.com/apache/kafka/pull/11455#issuecomment-959833451
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
guozhangwang commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-959812833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
junrao commented on a change in pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#discussion_r742217440
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -152,7 +152,7 @@ class ZkAdminManager(val config: KafkaConfig,
jolshan commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r742113471
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -285,52 +268,57 @@ public FetchRequestData build() {
mimaison commented on a change in pull request #11401:
URL: https://github.com/apache/kafka/pull/11401#discussion_r742002383
##
File path:
connect/mirror/src/test/java/org/apache/kafka/connect/mirror/integration/MirrorConnectorsIntegrationBaseTest.java
##
@@ -519,6 +521,47 @@
dajac commented on a change in pull request #11331:
URL: https://github.com/apache/kafka/pull/11331#discussion_r741789472
##
File path:
clients/src/main/java/org/apache/kafka/clients/FetchSessionHandler.java
##
@@ -285,52 +268,57 @@ public FetchRequestData build() {
dongjinleekr commented on pull request #10678:
URL: https://github.com/apache/kafka/pull/10678#issuecomment-959282035
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
cadonna commented on pull request #11462:
URL: https://github.com/apache/kafka/pull/11462#issuecomment-959048389
Call for review: @Luizfrf3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
akatona84 commented on pull request #11371:
URL: https://github.com/apache/kafka/pull/11371#issuecomment-959759146
IMHO we could enhance the code to log those which are not eligible for the
conditions (readable, directory or jar, whatever) if that helps.
The problem is that if it's not r
mjsax commented on pull request #11368:
URL: https://github.com/apache/kafka/pull/11368#issuecomment-958635275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
mjsax commented on a change in pull request #11447:
URL: https://github.com/apache/kafka/pull/11447#discussion_r741604615
##
File path:
streams/src/main/java/org/apache/kafka/streams/kstream/internals/graph/GroupedTableOperationRepartitionNode.java
##
@@ -119,5 +119,10 @@ publ
dajac commented on pull request #11368:
URL: https://github.com/apache/kafka/pull/11368#issuecomment-958704520
@mjsax Sounds reasonable to me. Please go ahead and cherry-pick it to the
3.1 branch as well.
--
This is an automated message from the Apache Git Service.
To respond to the mess
shirenchuang commented on a change in pull request #11453:
URL: https://github.com/apache/kafka/pull/11453#discussion_r741666574
##
File path: core/src/main/scala/kafka/server/ZkAdminManager.scala
##
@@ -152,7 +152,7 @@ class ZkAdminManager(val config: KafkaConfig,
1 - 100 of 151 matches
Mail list logo
