guozhangwang commented on pull request #11211:
URL: https://github.com/apache/kafka/pull/11211#issuecomment-959812833


   > While InMemoryWindowStore does enable strict retention but when combined 
with the caching store, it breaks. That's where doing it on MeteredStore might 
be beneficial.
   
   I see that, and personally I think this is a bug in the caching layer that 
we should be fixing --- in fact, the cache itself should better be trimmed by 
retention so that we can improve on our cache hit as well. I think it is fine 
to not piggy-back that fix in this PR if the scope suddenly become much larger, 
as I feel that the issue @mjsax raised worth being fixed by its own PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to