cadonna opened a new pull request #11462:
URL: https://github.com/apache/kafka/pull/11462
With a nice mock in
`RocksDBMetricsRecorderTest#shouldCorrectlyHandleHitRatioRecordingsWithZeroHitsAndMisses()`
and
`RocksDBMetricsRecorderTest#shouldCorrectlyHandleAvgRecordingsWithZeroSumAndCount()`
were green although `getTickerCount()` was never called. The tests were green
because EasyMock returns 0 for a numerical return value by default if no
expectation is specified. Thus, commenting out the expectation for
`getTickerCount()` did not change the result of the test.
This commit changes the mock to a default mock and fixes the expectation to
expect `getAndResetTickerCount()`. Now, commenting out the expectation leads to
a test failure.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
