[GitHub] [kafka] chia7712 commented on a change in pull request #11296: KAFKA-13273: Add support for Java 17

2021-09-06 Thread GitBox
chia7712 commented on a change in pull request #11296: URL: https://github.com/apache/kafka/pull/11296#discussion_r702636878 ## File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java ## @@ -45,7 +44,7 @@ private final MockTime time = new MockTime();

[GitHub] [kafka] gunnarmorling commented on a change in pull request #11296: KAFKA-13273: Add support for Java 17

2021-09-06 Thread GitBox
gunnarmorling commented on a change in pull request #11296: URL: https://github.com/apache/kafka/pull/11296#discussion_r702642533 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -2799,4 +2779,11 @@ public void testObserverFetchWithNoLocalId

[jira] [Comment Edited] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-06 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410256#comment-17410256 ] Tomas Forsman edited comment on KAFKA-13261 at 9/6/21, 7:15 AM: --

[GitHub] [kafka] dajac commented on a change in pull request #11295: KAFKA-13270: Set JUTE_MAXBUFFER to 4 MB by default

2021-09-06 Thread GitBox
dajac commented on a change in pull request #11295: URL: https://github.com/apache/kafka/pull/11295#discussion_r702694677 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -354,10 +354,10 @@ object KafkaConfig { // For ZooKeeper TLS client authenticati

[jira] [Commented] (KAFKA-8295) Add merge() operator to State Stores.

2021-09-06 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410473#comment-17410473 ] Sagar Rao commented on KAFKA-8295: -- Sure thanks [~guozhang] > Add merge() operator to S

[GitHub] [kafka] jlprat commented on a change in pull request #11298: MINOR: "partition" typos and method doc arg fix

2021-09-06 Thread GitBox
jlprat commented on a change in pull request #11298: URL: https://github.com/apache/kafka/pull/11298#discussion_r702762251 ## File path: core/src/main/scala/kafka/log/LogCleanerManager.scala ## @@ -359,9 +359,10 @@ private[log] class LogCleanerManager(val logDirs: Seq[File],

[GitHub] [kafka] mimaison opened a new pull request #11299: KAFKA-13258/KAFKA-13259: Fix error response generation

2021-09-06 Thread GitBox
mimaison opened a new pull request #11299: URL: https://github.com/apache/kafka/pull/11299 AlterClientQuotas and DescribeProducers have issues when building error responses. This can lead to brokers returning responses without errors even when some have happened. ### Committer Chec

[GitHub] [kafka] cadonna commented on pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-09-06 Thread GitBox
cadonna commented on pull request #11241: URL: https://github.com/apache/kafka/pull/11241#issuecomment-913522749 > As for the user exception task we discussed before, I was trying to create a ticket but I realized that I could not fully understand the requirement and ideal outcome of that

[GitHub] [kafka] sknot-rh edited a comment on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
sknot-rh edited a comment on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-91220 I am using this deprecated ctor in my tests. How can I set, for example `source` option now? The other ctor has a package protected access. ``` ConfigEntry(String n

[GitHub] [kafka] cadonna merged pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-09-06 Thread GitBox
cadonna merged pull request #11241: URL: https://github.com/apache/kafka/pull/11241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr.

[jira] [Updated] (KAFKA-13265) Kafka consumers disappearing after certain point of time

2021-09-06 Thread Ayyandurai Mani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ayyandurai Mani updated KAFKA-13265: Priority: Blocker (was: Critical) > Kafka consumers disappearing after certain point of t

[jira] [Commented] (KAFKA-13265) Kafka consumers disappearing after certain point of time

2021-09-06 Thread Ayyandurai Mani (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410574#comment-17410574 ] Ayyandurai Mani commented on KAFKA-13265: - We are blocked with this behavior, ex

[GitHub] [kafka] mimaison opened a new pull request #11300: KAFKA-13258/13259/13260: Fix error response generation

2021-09-06 Thread GitBox
mimaison opened a new pull request #11300: URL: https://github.com/apache/kafka/pull/11300 AlterClientQuotas, DescribeProducers and FindCoordinator have issues when building error responses. This can lead to brokers returning responses without errors even when some have happened.

[GitHub] [kafka] mimaison commented on pull request #11299: KAFKA-13258/KAFKA-13259: Fix error response generation

2021-09-06 Thread GitBox
mimaison commented on pull request #11299: URL: https://github.com/apache/kafka/pull/11299#issuecomment-913641292 cc @dajac -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[jira] [Updated] (KAFKA-13259) DescribeProducers response does not include an error when it failed

2021-09-06 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13259: --- Description: This is broken since 2.8 but this is directly visible by users in 3.0 because o

[jira] [Updated] (KAFKA-13259) DescribeProducers response does not include an error when it failed

2021-09-06 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mickael Maison updated KAFKA-13259: --- Priority: Blocker (was: Major) > DescribeProducers response does not include an error when

[GitHub] [kafka] mimaison commented on pull request #11300: KAFKA-13258/13259/13260: Fix error response generation

2021-09-06 Thread GitBox
mimaison commented on pull request #11300: URL: https://github.com/apache/kafka/pull/11300#issuecomment-913646455 cc @dajac @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[jira] [Commented] (KAFKA-13259) DescribeProducers response does not include an error when it failed

2021-09-06 Thread Mickael Maison (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410601#comment-17410601 ] Mickael Maison commented on KAFKA-13259: [~kkonstantine] I've tagged this as a b

[GitHub] [kafka] mimaison commented on pull request #11288: MINOR: Fix error response generation

2021-09-06 Thread GitBox
mimaison commented on pull request #11288: URL: https://github.com/apache/kafka/pull/11288#issuecomment-913647816 Backports: - 2.8: https://github.com/apache/kafka/pull/11299 - 3.0: https://github.com/apache/kafka/pull/11300 -- This is an automated message from the Apache Git Servic

[GitHub] [kafka] ijuma commented on a change in pull request #11296: KAFKA-13273: Add support for Java 17

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11296: URL: https://github.com/apache/kafka/pull/11296#discussion_r702919129 ## File path: raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java ## @@ -2799,4 +2779,11 @@ public void testObserverFetchWithNoLocalId() throw

[GitHub] [kafka] ijuma commented on a change in pull request #11296: KAFKA-13273: Add support for Java 17

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11296: URL: https://github.com/apache/kafka/pull/11296#discussion_r702919570 ## File path: raft/src/test/java/org/apache/kafka/raft/MockableRandom.java ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) unde

[GitHub] [kafka] ijuma commented on a change in pull request #11296: KAFKA-13273: Add support for Java 17

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11296: URL: https://github.com/apache/kafka/pull/11296#discussion_r702921721 ## File path: raft/src/test/java/org/apache/kafka/raft/QuorumStateTest.java ## @@ -45,7 +44,7 @@ private final MockTime time = new MockTime(); pri

[GitHub] [kafka] ijuma commented on a change in pull request #11296: KAFKA-13273: Add support for Java 17

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11296: URL: https://github.com/apache/kafka/pull/11296#discussion_r702921946 ## File path: raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java ## @@ -164,7 +162,7 @@ Builder withVotedCandidate(int epoch, int votedId)

[GitHub] [kafka] chia7712 commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
chia7712 commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913671739 > I am using this deprecated ctor in my tests just curious. Why you need to create `ConfigEntry` in your tests? Could you share the use case to me? thanks -- This is a

[GitHub] [kafka] ijuma commented on a change in pull request #11295: KAFKA-13270: Set JUTE_MAXBUFFER to 4 MB by default

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11295: URL: https://github.com/apache/kafka/pull/11295#discussion_r702924352 ## File path: core/src/main/scala/kafka/server/KafkaConfig.scala ## @@ -354,10 +354,10 @@ object KafkaConfig { // For ZooKeeper TLS client authenticati

[GitHub] [kafka] sknot-rh commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
sknot-rh commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913679136 The test scenario is basically "mocking" server response to `describeConfig`. Then I am looking at the `source` property to determine whether the changed configuration property

[GitHub] [kafka] ijuma commented on a change in pull request #11295: KAFKA-13270: Set JUTE_MAXBUFFER to 4 MB by default

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11295: URL: https://github.com/apache/kafka/pull/11295#discussion_r702929731 ## File path: core/src/test/scala/unit/kafka/zk/KafkaZkClientTest.scala ## @@ -1340,6 +1343,32 @@ class KafkaZkClientTest extends ZooKeeperTestHarness {

[GitHub] [kafka] ijuma commented on pull request #11295: KAFKA-13270: Set JUTE_MAXBUFFER to 4 MB by default

2021-09-06 Thread GitBox
ijuma commented on pull request #11295: URL: https://github.com/apache/kafka/pull/11295#issuecomment-913681527 @dajac Thanks for the review, I pushed a commit that addresses your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [kafka] chia7712 commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
chia7712 commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913687917 > The test scenario is basically "mocking" server response to describeConfig. Do you create a mock kafka admin and then mock response for specify request. If so, it seems

[GitHub] [kafka] sknot-rh commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
sknot-rh commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913689790 No, it is just a junit test consuming properties in `key=value` format. And I want to mark init configuration as default. -- This is an automated message from the Apache Git

[jira] [Comment Edited] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-06 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17409883#comment-17409883 ] Tomas Forsman edited comment on KAFKA-13261 at 9/6/21, 2:26 PM: --

[GitHub] [kafka] chia7712 commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
chia7712 commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913701007 ok. How about using reflection to update private fields of `ConfigEntry`? For example: ```java Class clazz = ConfigEntry.class; ConfigEntry entry =

[GitHub] [kafka] sknot-rh commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
sknot-rh commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913702209 Yes, I used seemthing similar. Thank you for looking :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-06 Thread Tomas Forsman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410650#comment-17410650 ] Tomas Forsman commented on KAFKA-13261: --- I think I need some help to verify if tha

[GitHub] [kafka] sknot-rh edited a comment on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
sknot-rh edited a comment on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913702209 Yes, I used something similar. Thank you for looking :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [kafka] ijuma commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
ijuma commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913705180 I think it makes sense to make the constructor public, but it would require a small kip. We don't gain anything by not making it public if people access it via reflection anyway.

[GitHub] [kafka] sknot-rh commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
sknot-rh commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913710299 Let me know if I can do my first contribution! :laughing: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] tombentley commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
tombentley commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913714434 [KIP-692](https://cwiki.apache.org/confluence/display/KAFKA/KIP-692:+Make+AdminClient+value+object+constructors+public) proposed to do this for all the record-like classes in

[GitHub] [kafka] ijuma commented on pull request #10436: KAFKA-12577; Remove deprecated `ConfigEntry` constructor for 3.0

2021-09-06 Thread GitBox
ijuma commented on pull request #10436: URL: https://github.com/apache/kafka/pull/10436#issuecomment-913715227 @tombentley maybe we should vote for it then :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [kafka] ijuma commented on pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

2021-09-06 Thread GitBox
ijuma commented on pull request #11017: URL: https://github.com/apache/kafka/pull/11017#issuecomment-913720572 @wycc Can you please fix the conflict? @chia7712 How do you feel about this PR, is it close to being ready to be merged? -- This is an automated message from the Apache Git

[GitHub] [kafka] ijuma merged pull request #11051: KAFKA-13088: Replace EasyMock with Mockito for ForwardingDisabledProcessorContextTest

2021-09-06 Thread GitBox
ijuma merged pull request #11051: URL: https://github.com/apache/kafka/pull/11051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma merged pull request #11027: KAFKA-13066: Replace EasyMock with Mockito for FileStreamSinkConnectorTest

2021-09-06 Thread GitBox
ijuma merged pull request #11027: URL: https://github.com/apache/kafka/pull/11027 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma commented on pull request #10976: KAFKA-13036 Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2021-09-06 Thread GitBox
ijuma commented on pull request #10976: URL: https://github.com/apache/kafka/pull/10976#issuecomment-913726974 @wycc Is this ready for another round of reviews from @chia7712 ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] ijuma commented on pull request #10881: KAFKA-12947 Replace EasyMock and PowerMock with Mockito for Streams…

2021-09-06 Thread GitBox
ijuma commented on pull request #10881: URL: https://github.com/apache/kafka/pull/10881#issuecomment-913727723 @wycc Are you planning to address the outstanding review comments? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [kafka] ijuma commented on a change in pull request #10904: KAFKA-13060: Replace EasyMock and PowerMock with Mockito in WorkerGroupMemberTest

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #10904: URL: https://github.com/apache/kafka/pull/10904#discussion_r702976716 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/distributed/WorkerGroupMemberTest.java ## @@ -86,18 +83,12 @@ public void test

[GitHub] [kafka] dajac commented on a change in pull request #11299: KAFKA-13258/KAFKA-13259: Fix error response generation

2021-09-06 Thread GitBox
dajac commented on a change in pull request #11299: URL: https://github.com/apache/kafka/pull/11299#discussion_r702978011 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -657,6 +657,11 @@ private void checkDescribeConfigsResp

[GitHub] [kafka] mimaison commented on a change in pull request #11299: KAFKA-13258/KAFKA-13259: Fix error response generation

2021-09-06 Thread GitBox
mimaison commented on a change in pull request #11299: URL: https://github.com/apache/kafka/pull/11299#discussion_r702982585 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -657,6 +657,11 @@ private void checkDescribeConfigsR

[GitHub] [kafka] ijuma merged pull request #11296: KAFKA-13273: Add support for Java 17

2021-09-06 Thread GitBox
ijuma merged pull request #11296: URL: https://github.com/apache/kafka/pull/11296 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] chia7712 commented on a change in pull request #10976: KAFKA-13036 Replace EasyMock and PowerMock with Mockito for RocksDBMetricsRecorderTest

2021-09-06 Thread GitBox
chia7712 commented on a change in pull request #10976: URL: https://github.com/apache/kafka/pull/10976#discussion_r702987181 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/metrics/RocksDBMetricsRecorderTest.java ## @@ -70,99 +63,90 @@ private

[GitHub] [kafka] chia7712 commented on pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

2021-09-06 Thread GitBox
chia7712 commented on pull request #11017: URL: https://github.com/apache/kafka/pull/11017#issuecomment-913747482 > How do you feel about this PR, is it close to being ready to be merged? I need to take another look after those conflicts are fixed. -- This is an automated message f

[GitHub] [kafka] ijuma commented on a change in pull request #11024: KAFKA-13065: Replace EasyMock with Mockito for BasicAuthSecurityRestExtensionTest

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11024: URL: https://github.com/apache/kafka/pull/11024#discussion_r702993808 ## File path: connect/basic-auth-extension/src/test/java/org/apache/kafka/connect/rest/basic/auth/extension/BasicAuthSecurityRestExtensionTest.java ## @@ -

[jira] [Created] (KAFKA-13276) Public DescribeConsumerGroupsResult constructor refers to KafkaFutureImpl

2021-09-06 Thread Tom Bentley (Jira)
Tom Bentley created KAFKA-13276: --- Summary: Public DescribeConsumerGroupsResult constructor refers to KafkaFutureImpl Key: KAFKA-13276 URL: https://issues.apache.org/jira/browse/KAFKA-13276 Project: Kafk

[GitHub] [kafka] ijuma merged pull request #11295: KAFKA-13270: Set JUTE_MAXBUFFER to 4 MB by default

2021-09-06 Thread GitBox
ijuma merged pull request #11295: URL: https://github.com/apache/kafka/pull/11295 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[jira] [Resolved] (KAFKA-13270) Kafka may fail to connect to ZooKeeper, retry forever, and never start

2021-09-06 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13270?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-13270. - Assignee: Ismael Juma (was: Ron Dagostino) Resolution: Fixed > Kafka may fail to connect

[GitHub] [kafka] ijuma commented on a change in pull request #11074: KAFKA-13101: Replace EasyMock and PowerMock with Mockito for RestServerTest

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11074: URL: https://github.com/apache/kafka/pull/11074#discussion_r702994755 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/rest/RestServerTest.java ## @@ -61,18 +56,23 @@ import static org.junit.Asser

[jira] [Updated] (KAFKA-13101) Replace EasyMock and PowerMock with Mockito for RestServerTest

2021-09-06 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma updated KAFKA-13101: Fix Version/s: 3.1.0 > Replace EasyMock and PowerMock with Mockito for RestServerTest > --

[GitHub] [kafka] ijuma commented on pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2021-09-06 Thread GitBox
ijuma commented on pull request #11137: URL: https://github.com/apache/kafka/pull/11137#issuecomment-913758905 @kkonstantine @rhauch It would be great to have a review from one of you two so that we can get this merged. -- This is an automated message from the Apache Git Service. To resp

[GitHub] [kafka] ijuma commented on a change in pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11137: URL: https://github.com/apache/kafka/pull/11137#discussion_r703001846 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java ## @@ -135,90 +133,75 @@ private final int genera

[GitHub] [kafka] ijuma commented on pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2021-09-06 Thread GitBox
ijuma commented on pull request #11137: URL: https://github.com/apache/kafka/pull/11137#issuecomment-913759692 We should also remove this test from https://github.com/apache/kafka/blob/trunk/build.gradle#L381 before we merge this PR. -- This is an automated message from the Apache Git S

[GitHub] [kafka] tombentley commented on pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
tombentley commented on pull request #11301: URL: https://github.com/apache/kafka/pull/11301#issuecomment-913760134 @dajac @mimaison @ijuma perhaps one of you could review? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [kafka] ijuma commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703003174 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeConsumerGroupsResult.java ## @@ -35,9 +34,9 @@ @InterfaceStability.Evolving pu

[GitHub] [kafka] tombentley commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
tombentley commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703010447 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeConsumerGroupsResult.java ## @@ -35,9 +34,9 @@ @InterfaceStability.Evolvin

[GitHub] [kafka] ijuma commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703013390 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeConsumerGroupsResult.java ## @@ -35,9 +34,9 @@ @InterfaceStability.Evolving pu

[GitHub] [kafka] tombentley commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
tombentley commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703018601 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DescribeConsumerGroupsResult.java ## @@ -35,9 +34,9 @@ @InterfaceStability.Evolvin

[GitHub] [kafka] wycccccc commented on pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

2021-09-06 Thread GitBox
wycc commented on pull request #11017: URL: https://github.com/apache/kafka/pull/11017#issuecomment-913789041 @chia7712 The conflict has been resolved, let me know if you have any situation. -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [kafka] ijuma commented on pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

2021-09-06 Thread GitBox
ijuma commented on pull request #11017: URL: https://github.com/apache/kafka/pull/11017#issuecomment-913789472 Btw, this is the only Streams test that is disabled with Java 16 and newer: https://github.com/apache/kafka/blob/trunk/build.gradle#L389 -- This is an automated message from t

[GitHub] [kafka] ijuma commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r703026597 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -111,9 +104,24 @@ import static org.junit.Assert.assertThrows; im

[GitHub] [kafka] ijuma commented on a change in pull request #11017: KAFKA-12950 Replace EasyMock and PowerMock with Mockito for KafkaStream

2021-09-06 Thread GitBox
ijuma commented on a change in pull request #11017: URL: https://github.com/apache/kafka/pull/11017#discussion_r703026597 ## File path: streams/src/test/java/org/apache/kafka/streams/KafkaStreamsTest.java ## @@ -111,9 +104,24 @@ import static org.junit.Assert.assertThrows; im

[GitHub] [kafka] dajac commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
dajac commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703030864 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -32,9 +31,9 @@ */ @InterfaceStability.Evolving

[GitHub] [kafka] dajac commented on a change in pull request #11299: KAFKA-13258/KAFKA-13259: Fix error response generation

2021-09-06 Thread GitBox
dajac commented on a change in pull request #11299: URL: https://github.com/apache/kafka/pull/11299#discussion_r703031302 ## File path: clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java ## @@ -657,6 +657,11 @@ private void checkDescribeConfigsResp

[GitHub] [kafka] wycccccc commented on a change in pull request #11137: KAFKA-13133 Replace EasyMock and PowerMock with Mockito for AbstractHerderTest

2021-09-06 Thread GitBox
wycc commented on a change in pull request #11137: URL: https://github.com/apache/kafka/pull/11137#discussion_r703032964 ## File path: connect/runtime/src/test/java/org/apache/kafka/connect/runtime/AbstractHerderTest.java ## @@ -135,90 +133,75 @@ private final int gen

[GitHub] [kafka] ijuma commented on pull request #11074: KAFKA-13101: Replace EasyMock and PowerMock with Mockito for RestServerTest

2021-09-06 Thread GitBox
ijuma commented on pull request #11074: URL: https://github.com/apache/kafka/pull/11074#issuecomment-913801179 Tests passed for JDK 8, 11 and 17. Merging to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [kafka] ijuma merged pull request #11074: KAFKA-13101: Replace EasyMock and PowerMock with Mockito for RestServerTest

2021-09-06 Thread GitBox
ijuma merged pull request #11074: URL: https://github.com/apache/kafka/pull/11074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...

[GitHub] [kafka] ijuma commented on pull request #11074: KAFKA-13101: Replace EasyMock and PowerMock with Mockito for RestServerTest

2021-09-06 Thread GitBox
ijuma commented on pull request #11074: URL: https://github.com/apache/kafka/pull/11074#issuecomment-913801648 cc @rhauch @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] ijuma commented on pull request #11027: KAFKA-13066: Replace EasyMock with Mockito for FileStreamSinkConnectorTest

2021-09-06 Thread GitBox
ijuma commented on pull request #11027: URL: https://github.com/apache/kafka/pull/11027#issuecomment-913801895 cc @kkonstantine @rhauch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [kafka] ijuma commented on pull request #11051: KAFKA-13088: Replace EasyMock with Mockito for ForwardingDisabledProcessorContextTest

2021-09-06 Thread GitBox
ijuma commented on pull request #11051: URL: https://github.com/apache/kafka/pull/11051#issuecomment-913801988 cc @rhauch @kkonstantine -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[jira] [Commented] (KAFKA-8116) Add Kafka Streams archetype for Java11

2021-09-06 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410761#comment-17410761 ] Ismael Juma commented on KAFKA-8116: Java 8 support has been deprecated in 3.0 and wi

[GitHub] [kafka] jlprat opened a new pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

2021-09-06 Thread GitBox
jlprat opened a new pull request #11302: URL: https://github.com/apache/kafka/pull/11302 Implementation of [KIP-773](https://cwiki.apache.org/confluence/x/ZwNACw) - Deprecates inconsistent metrics `bufferpool-wait-time-total`, `io-waittime-total`, and `iotime-total`. - Introduces

[GitHub] [kafka] jlprat commented on a change in pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

2021-09-06 Thread GitBox
jlprat commented on a change in pull request #11302: URL: https://github.com/apache/kafka/pull/11302#discussion_r703047638 ## File path: clients/src/main/java/org/apache/kafka/common/network/Selector.java ## @@ -1272,12 +1274,27 @@ private Meter createMeter(Metrics metrics, Str

[GitHub] [kafka] ijuma commented on pull request #11289: KAFKA-13254 [WIP]: Fix deadlock when AlterIsr response returns

2021-09-06 Thread GitBox
ijuma commented on pull request #11289: URL: https://github.com/apache/kafka/pull/11289#issuecomment-913838350 @hachikuji Thanks for the PR. Can we please also mention the change that introduced this? -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [kafka] jlprat commented on pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

2021-09-06 Thread GitBox
jlprat commented on pull request #11302: URL: https://github.com/apache/kafka/pull/11302#issuecomment-913863510 Failure was: ``` [2021-09-06T19ː26ː29.273Z] FAILURE: Build failed with an exception. [2021-09-06T19ː26ː29.273Z] [2021-09-06T19ː26ː29.273Z] * What went wrong: [2021-09-0

[GitHub] [kafka] jlprat edited a comment on pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

2021-09-06 Thread GitBox
jlprat edited a comment on pull request #11302: URL: https://github.com/apache/kafka/pull/11302#issuecomment-913863510 Failure was: ``` [2021-09-06T19ː26ː29.273Z] FAILURE: Build failed with an exception. [2021-09-06T19ː26ː29.273Z] [2021-09-06T19ː26ː29.273Z] * What went wrong:

[GitHub] [kafka] jlprat commented on pull request #11302: KAFKA-13243: KIP-773 Differentiate metric latency measured in ms and ns

2021-09-06 Thread GitBox
jlprat commented on pull request #11302: URL: https://github.com/apache/kafka/pull/11302#issuecomment-913864416 @guozhangwang @cadonna and @tombentley if you want and have time, feel free to review the PR for KIP-773 Thanks! -- This is an automated message from the Apache Git Service

[jira] [Commented] (KAFKA-13261) KTable to KTable foreign key join loose events when using several partitions

2021-09-06 Thread Adam Bellemare (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17410827#comment-17410827 ] Adam Bellemare commented on KAFKA-13261: Hi [~xnix] - Thank you for the test cod

[GitHub] [kafka] showuon commented on pull request #11147: KAFKA-13108: improve ConfigCommandTest test coverage

2021-09-06 Thread GitBox
showuon commented on pull request #11147: URL: https://github.com/apache/kafka/pull/11147#issuecomment-913896267 @ijuma , please help take a look at the follow up PR to add tests. Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [kafka] ijuma opened a new pull request #11303: MINOR: Upgrade compression libraries (Q3 2021)

2021-09-06 Thread GitBox
ijuma opened a new pull request #11303: URL: https://github.com/apache/kafka/pull/11303 lz4-java: 1.7.1 -> 1.8.0 The most noteworthy change is the upgrade of the underlying C library to 1.9.3. Details: * https://github.com/lz4/lz4-java/releases/tag/1.8.0 * https://github.

[GitHub] [kafka] yangdaixai opened a new pull request #11304: MINOR: Supplement unit test for KAFKA-13175 : Optimization TopicExis…

2021-09-06 Thread GitBox
yangdaixai opened a new pull request #11304: URL: https://github.com/apache/kafka/pull/11304 …tsException,When a topic is marked for deletion. *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separa

[GitHub] [kafka] yangdaixai commented on pull request #11226: KAFKA-13175; Optimization TopicExistsException,When a topic is marked…

2021-09-06 Thread GitBox
yangdaixai commented on pull request #11226: URL: https://github.com/apache/kafka/pull/11226#issuecomment-914008135 > 通常,我们应该包括对此类更改的测试。 Supplement unit test for KAFKA-13175: https://github.com/apache/kafka/pull/11304 @ijuma @guozhangwang -- This is an automated message from

[GitHub] [kafka] yangdaixai commented on pull request #11304: MINOR: Supplement unit test for KAFKA-13175 : Optimization TopicExis…

2021-09-06 Thread GitBox
yangdaixai commented on pull request #11304: URL: https://github.com/apache/kafka/pull/11304#issuecomment-914008453 @ijuma @guozhangwang Supplement unit test for KAFKA-13175. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [kafka] jlprat commented on pull request #11303: MINOR: Upgrade compression libraries (Q3 2021)

2021-09-06 Thread GitBox
jlprat commented on pull request #11303: URL: https://github.com/apache/kafka/pull/11303#issuecomment-914028927 I had the same error on another PR yesterday. Might be a Gradle build instance turned into a zombie on a Jenkins worker. > I saw there's a build error: > ``` > * Wha

[GitHub] [kafka] showuon commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
showuon commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703229535 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/AdminApiFuture.java ## @@ -109,7 +110,7 @@ private void completeExceptionall

[GitHub] [kafka] showuon commented on a change in pull request #11301: KAFKA-13276: Prefer KafkaFuture in admin Result constructors

2021-09-06 Thread GitBox
showuon commented on a change in pull request #11301: URL: https://github.com/apache/kafka/pull/11301#discussion_r703230627 ## File path: clients/src/main/java/org/apache/kafka/clients/admin/DeleteConsumerGroupsResult.java ## @@ -32,9 +31,9 @@ */ @InterfaceStability.Evolvin