tombentley commented on a change in pull request #11301:
URL: https://github.com/apache/kafka/pull/11301#discussion_r703010447
##########
File path:
clients/src/main/java/org/apache/kafka/clients/admin/DescribeConsumerGroupsResult.java
##########
@@ -35,9 +34,9 @@
@InterfaceStability.Evolving
public class DescribeConsumerGroupsResult {
- private final Map<CoordinatorKey,
KafkaFutureImpl<ConsumerGroupDescription>> futures;
+ private final Map<CoordinatorKey, KafkaFuture<ConsumerGroupDescription>>
futures;
- public DescribeConsumerGroupsResult(final Map<CoordinatorKey,
KafkaFutureImpl<ConsumerGroupDescription>> futures) {
+ public DescribeConsumerGroupsResult(final Map<CoordinatorKey,
KafkaFuture<ConsumerGroupDescription>> futures) {
Review comment:
I don't think so, but f5d5f65 changed the type arguments too, from
`Map<String, KafkaFuture<ConsumerGroupDescription>>` to `Map<CoordinatorKey,
KafkaFutureImpl<ConsumerGroupDescription>>`. f5d5f65 hasn't been released yet.
If we need to be compatible with the old constructor then we'll have to change
the `CoordinatorKey` type argument as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
