mimaison commented on a change in pull request #11299:
URL: https://github.com/apache/kafka/pull/11299#discussion_r702982585
##########
File path:
clients/src/test/java/org/apache/kafka/common/requests/RequestResponseTest.java
##########
@@ -657,6 +657,11 @@ private void checkDescribeConfigsResponseVersions() {
private void checkErrorResponse(AbstractRequest req, Throwable e, boolean
checkEqualityAndHashCode) {
AbstractResponse response = req.getErrorResponse(e);
checkResponse(response, req.version(), checkEqualityAndHashCode);
+ Errors error = Errors.forException(e);
+ Map<Errors, Integer> errorCounts = response.errorCounts();
+ assertEquals(Collections.singleton(error), errorCounts.keySet(),
+ "API Key " + req.apiKey().name + " v" + req.version() + " failed
errorCounts test");
+ assertTrue(errorCounts.get(error) > 0);
Review comment:
It has no impact on functionality. It just makes the request looks
better as by defaut the topic name is empty string. Happy to add it if you
prefer having it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
