[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r695463229 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,208

[jira] [Commented] (KAFKA-5666) Need feedback to user if consumption fails due to offsets.topic.replication.factor=3

2021-08-25 Thread Rens Groothuijsen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404267#comment-17404267 ] Rens Groothuijsen commented on KAFKA-5666: -- [~ll1124278064] No, I'm no longer wo

[GitHub] [kafka] cadonna commented on a change in pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-08-25 Thread GitBox
cadonna commented on a change in pull request #11241: URL: https://github.com/apache/kafka/pull/11241#discussion_r695498527 ## File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMap.java ## @@ -41,6 +43,7 @@ public void process(fina

[jira] [Created] (KAFKA-13226) Partition expansion may cause uneven distribution

2021-08-25 Thread shizhenzhen (Jira)
shizhenzhen created KAFKA-13226: --- Summary: Partition expansion may cause uneven distribution Key: KAFKA-13226 URL: https://issues.apache.org/jira/browse/KAFKA-13226 Project: Kafka Issue Type: B

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-25 Thread GitBox
patrickstuedi commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r695535522 ## File path: checkstyle/suppressions.xml ## @@ -160,6 +160,9 @@ + Review comment: I guess this is because of InMemoryWindowStor

[GitHub] [kafka] cadonna commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-25 Thread GitBox
cadonna commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r695567992 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -1925,6 +1926,56 @@ public void testCommittedAuthentic

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-25 Thread GitBox
patrickstuedi commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r695631238 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentIterator.java ## @@ -74,7 +74,7 @@ public boolean hasNext() {

[GitHub] [kafka] cadonna commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
cadonna commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r695633134 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,208 @@ +

[GitHub] [kafka] cadonna commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
cadonna commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r695669488 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,208 @@ +

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-25 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r695715007 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ## @@ -931,16 +979,6 @@ public void should

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r695717497 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,208

[GitHub] [kafka] patrickstuedi commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-25 Thread GitBox
patrickstuedi commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r695731353 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java ## @@ -931,16 +979,6 @@ public void

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r695735723 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,208

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r695736026 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,208

[GitHub] [kafka] lkokhreidze commented on a change in pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze commented on a change in pull request #10851: URL: https://github.com/apache/kafka/pull/10851#discussion_r695735854 ## File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientTagAwareStandbyTaskAssignor.java ## @@ -0,0 +1,208

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-905490438 Thanks for the feedback @cadonna , I've pushed the new changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-25 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r695757204 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractRocksDBSegmentedBytesStore.java ## @@ -124,8 +124,8 @@ fi

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-25 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r695757591 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/SegmentIterator.java ## @@ -74,7 +74,7 @@ public boolean hasNext() {

[GitHub] [kafka] showuon commented on a change in pull request #11227: KAFKA-13211: add support for infinite range query for WindowStore

2021-08-25 Thread GitBox
showuon commented on a change in pull request #11227: URL: https://github.com/apache/kafka/pull/11227#discussion_r695758175 ## File path: streams/src/test/java/org/apache/kafka/streams/state/internals/CachingPersistentWindowStoreTest.java ## @@ -297,6 +297,186 @@ public void s

[GitHub] [kafka] dajac commented on pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-25 Thread GitBox
dajac commented on pull request #11104: URL: https://github.com/apache/kafka/pull/11104#issuecomment-905509721 @jolshan Some tests failed and it seems related to the changes done in this PR. Could you check them? -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] lkokhreidze commented on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze commented on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-905514160 The general thought on the implementation. As of now, we choose concrete `StandbyTaskAssignor` implementation based on passed `AssignmentConfigs` value. Instead, an al

[GitHub] [kafka] lkokhreidze edited a comment on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze edited a comment on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-905514160 The general thought on the implementation. As of now, we choose concrete `StandbyTaskAssignor` implementation based on passed `AssignmentConfigs` value. Instead

[GitHub] [kafka] rondagostino commented on pull request #11200: KAFKA-13192: Prevent inconsistent broker.id/node.id values

2021-08-25 Thread GitBox
rondagostino commented on pull request #11200: URL: https://github.com/apache/kafka/pull/11200#issuecomment-905514929 This PR is likely going to be replaced by https://github.com/apache/kafka/pull/11256. Will probably eventually close this assuming that other PR gets merged. -- This is

[GitHub] [kafka] lkokhreidze edited a comment on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze edited a comment on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-905514160 The general thought on the implementation. As of now, we choose concrete `StandbyTaskAssignor` implementation based on passed `AssignmentConfigs` value. Instead

[GitHub] [kafka] lkokhreidze edited a comment on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze edited a comment on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-905514160 The general thought on the implementation. As of now, we choose concrete `StandbyTaskAssignor` implementation based on passed `AssignmentConfigs` value. Instead

[GitHub] [kafka] jolshan commented on pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-25 Thread GitBox
jolshan commented on pull request #11104: URL: https://github.com/apache/kafka/pull/11104#issuecomment-905656665 Looks like it was a really subtle bug. Consider the case where we have a partition in the session without a topic ID. We then add a new partition from that topic with an ID, but

[GitHub] [kafka] jolshan edited a comment on pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-25 Thread GitBox
jolshan edited a comment on pull request #11104: URL: https://github.com/apache/kafka/pull/11104#issuecomment-905656665 Looks like it was a really subtle bug. Consider the case where we have a partition in the session without a topic ID. We then add a new partition from that topic with an

[GitHub] [kafka] dajac commented on pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-25 Thread GitBox
dajac commented on pull request #11104: URL: https://github.com/apache/kafka/pull/11104#issuecomment-905684062 We can merge once we get clean builds. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (KAFKA-13115) doSend can be blocking

2021-08-25 Thread Ivan Vaskevych (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Vaskevych updated KAFKA-13115: --- Labels: pull-request-available (was: ) > doSend can be blocking > -- >

[jira] [Updated] (KAFKA-13115) doSend can be blocking

2021-08-25 Thread Ivan Vaskevych (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Vaskevych updated KAFKA-13115: --- Component/s: docs > doSend can be blocking > -- > > Key:

[jira] [Updated] (KAFKA-13115) doSend can be blocking

2021-08-25 Thread Ivan Vaskevych (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ivan Vaskevych updated KAFKA-13115: --- Labels: documentation pull-request-available (was: pull-request-available) > doSend can be

[jira] [Updated] (KAFKA-10847) Avoid spurious left/outer join results in stream-stream join

2021-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-10847: Fix Version/s: (was: 3.0.0) 3.1.0 > Avoid spurious left/outer join

[jira] [Commented] (KAFKA-10847) Avoid spurious left/outer join results in stream-stream join

2021-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10847?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404607#comment-17404607 ] Matthias J. Sax commented on KAFKA-10847: - Updated fixed version to 3.1.0 becaus

[GitHub] [kafka] jolshan commented on pull request #11104: KAFKA-13079: Forgotten Topics in Fetch Requests may incorrectly use topic IDs

2021-08-25 Thread GitBox
jolshan commented on pull request #11104: URL: https://github.com/apache/kafka/pull/11104#issuecomment-905758403 Hmmm. Not sure what to make of this exit code 1: ``` * What went wrong: Execution failed for task ':storage:unitTest'. > Process 'Gradle Test Executor 133' fi

[GitHub] [kafka] wcarlson5 opened a new pull request #11258: MINOR: add to empty, remove then add different test

2021-08-25 Thread GitBox
wcarlson5 opened a new pull request #11258: URL: https://github.com/apache/kafka/pull/11258 add a test for named topology ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify

[GitHub] [kafka] lkokhreidze edited a comment on pull request #10851: KAFKA-6718 / Rack aware standby task assignor

2021-08-25 Thread GitBox
lkokhreidze edited a comment on pull request #10851: URL: https://github.com/apache/kafka/pull/10851#issuecomment-905514160 The general thought on the implementation. As of now, we choose concrete `StandbyTaskAssignor` implementation based on passed `AssignmentConfigs` value. Instead

[jira] [Created] (KAFKA-13227) Cancel pending AlterIsr requests after receiving LeaderAndIsr

2021-08-25 Thread Jason Gustafson (Jira)
Jason Gustafson created KAFKA-13227: --- Summary: Cancel pending AlterIsr requests after receiving LeaderAndIsr Key: KAFKA-13227 URL: https://issues.apache.org/jira/browse/KAFKA-13227 Project: Kafka

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-25 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r696035745 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -630,7 +630,7 @@ class KafkaController(val config: KafkaConfig, // If

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-25 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r696115948 ## File path: clients/src/main/java/org/apache/kafka/common/requests/ElectLeadersRequest.java ## @@ -103,20 +103,22 @@ public AbstractResponse getError

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-25 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r696116190 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -90,8 +90,7 @@ class BrokerServer( this.logIdent = logContext.logPrefix -

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-25 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r696117735 ## File path: core/src/test/java/kafka/test/junit/RaftClusterInvocationContext.java ## @@ -189,17 +197,39 @@ public void start() { @Override

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-25 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r696118985 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -1622,19 +1623,37 @@ object TestUtils extends Logging { waitForLeaderToBec

[GitHub] [kafka] hachikuji commented on a change in pull request #11186: KAFKA-13162: Ensure ElectLeaders is properly handled in KRaft

2021-08-25 Thread GitBox
hachikuji commented on a change in pull request #11186: URL: https://github.com/apache/kafka/pull/11186#discussion_r696118985 ## File path: core/src/test/scala/unit/kafka/utils/TestUtils.scala ## @@ -1622,19 +1623,37 @@ object TestUtils extends Logging { waitForLeaderToBec

[GitHub] [kafka] ableegoldman commented on pull request #11258: MINOR: add to empty, remove then add different test

2021-08-25 Thread GitBox
ableegoldman commented on pull request #11258: URL: https://github.com/apache/kafka/pull/11258#issuecomment-905900986 Sounds like this is waiting on the blocking functionality coming in Pt. 4 -- thanks for the test, do you want to just leave this PR until Pt. 4 is merged and then make sure

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-25 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r696141192 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -630,7 +630,7 @@ class KafkaController(val config: KafkaConfig, // I

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-25 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r696141192 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -630,7 +630,7 @@ class KafkaController(val config: KafkaConfig, // I

[GitHub] [kafka] splett2 commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-25 Thread GitBox
splett2 commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r696141192 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -630,7 +630,7 @@ class KafkaController(val config: KafkaConfig, // I

[GitHub] [kafka] hachikuji commented on a change in pull request #11225: MINOR; Small optimizations in `ReplicaManager#becomeLeaderOrFollower`

2021-08-25 Thread GitBox
hachikuji commented on a change in pull request #11225: URL: https://github.com/apache/kafka/pull/11225#discussion_r696142107 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -2207,15 +2191,27 @@ class ReplicaManager(val config: KafkaConfig,

[GitHub] [kafka] wcarlson5 commented on pull request #11258: MINOR: add to empty, remove then add different test

2021-08-25 Thread GitBox
wcarlson5 commented on pull request #11258: URL: https://github.com/apache/kafka/pull/11258#issuecomment-905910457 @ableegoldman whatever works best for you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [kafka] ableegoldman commented on a change in pull request #9858: KAFKA-12173 Migrate streams:streams-scala module to JUnit 5

2021-08-25 Thread GitBox
ableegoldman commented on a change in pull request #9858: URL: https://github.com/apache/kafka/pull/9858#discussion_r696181741 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -75,9 +76,19 @@ @Category(Integration

[GitHub] [kafka] ableegoldman opened a new pull request #11259: HOTFIX: decrease session timeout in flaky NamedTopologyIntegrationTest

2021-08-25 Thread GitBox
ableegoldman opened a new pull request #11259: URL: https://github.com/apache/kafka/pull/11259 Since the default session timeout was bumped to 45s a number of our integration tests have begun failing. Let's reset it back to 10s for these NamedTopologyIntegrationTests which have been a bit

[GitHub] [kafka] ableegoldman commented on pull request #11259: HOTFIX: decrease session timeout in flaky NamedTopologyIntegrationTest

2021-08-25 Thread GitBox
ableegoldman commented on pull request #11259: URL: https://github.com/apache/kafka/pull/11259#issuecomment-905946923 @wcarlson5 @vvcephei @guozhangwang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [kafka] showuon commented on a change in pull request #9858: KAFKA-12173 Migrate streams:streams-scala module to JUnit 5

2021-08-25 Thread GitBox
showuon commented on a change in pull request #9858: URL: https://github.com/apache/kafka/pull/9858#discussion_r696201298 ## File path: streams/src/test/java/org/apache/kafka/streams/integration/AdjustStreamThreadCountTest.java ## @@ -75,9 +76,19 @@ @Category(IntegrationTest.

[GitHub] [kafka] jasonyanwenl commented on pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-08-25 Thread GitBox
jasonyanwenl commented on pull request #11241: URL: https://github.com/apache/kafka/pull/11241#issuecomment-905975169 > Thanks for the PR @jasonyanwenl ! > > Here my feedback! > > I think we should consider to introduce a specific exception for exceptions that originate from u

[GitHub] [kafka] jasonyanwenl edited a comment on pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-08-25 Thread GitBox
jasonyanwenl edited a comment on pull request #11241: URL: https://github.com/apache/kafka/pull/11241#issuecomment-905975169 > Thanks for the PR @jasonyanwenl ! > > Here my feedback! > > I think we should consider to introduce a specific exception for exceptions that originate

[GitHub] [kafka] jasonyanwenl commented on a change in pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-08-25 Thread GitBox
jasonyanwenl commented on a change in pull request #11241: URL: https://github.com/apache/kafka/pull/11241#discussion_r696210814 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java ## @@ -86,4 +88,12 @@ public void testFlatMap

[GitHub] [kafka] junrao commented on a change in pull request #11255: KAFKA-13225: Controller skips sending UpdateMetadataRequest when no change in partition state.

2021-08-25 Thread GitBox
junrao commented on a change in pull request #11255: URL: https://github.com/apache/kafka/pull/11255#discussion_r696210968 ## File path: core/src/main/scala/kafka/controller/KafkaController.scala ## @@ -630,7 +630,7 @@ class KafkaController(val config: KafkaConfig, // If

[GitHub] [kafka] jasonyanwenl commented on a change in pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-08-25 Thread GitBox
jasonyanwenl commented on a change in pull request #11241: URL: https://github.com/apache/kafka/pull/11241#discussion_r696210814 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamFlatMapTest.java ## @@ -86,4 +88,12 @@ public void testFlatMap

[jira] [Resolved] (KAFKA-8734) Remove PartitionAssignorAdapter and deprecated PartitionAssignor interface

2021-08-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman resolved KAFKA-8734. --- Fix Version/s: 3.0.0 Resolution: Fixed > Remove PartitionAssignorAdapt

[jira] [Updated] (KAFKA-8734) Remove PartitionAssignorAdapter and deprecated PartitionAssignor interface

2021-08-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-8734: -- Affects Version/s: (was: 3.0.0) > Remove PartitionAssignorAdapter and depre

[jira] [Commented] (KAFKA-8767) Optimize StickyAssignor for Cooperative mode

2021-08-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404833#comment-17404833 ] A. Sophie Blee-Goldman commented on KAFKA-8767: --- Note that since https://is

[jira] [Assigned] (KAFKA-9792) Improve sticky task assignment for previous active tasks

2021-08-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-9792: - Assignee: (was: A. Sophie Blee-Goldman) > Improve sticky task assign

[jira] [Created] (KAFKA-13228) ApiVersionRequest are not correctly handled in kraft mode

2021-08-25 Thread dengziming (Jira)
dengziming created KAFKA-13228: -- Summary: ApiVersionRequest are not correctly handled in kraft mode Key: KAFKA-13228 URL: https://issues.apache.org/jira/browse/KAFKA-13228 Project: Kafka Issue T

[GitHub] [kafka] kkonstantine opened a new pull request #11260: MINOR: Add missing license entry for jline in LICENSE-binary

2021-08-25 Thread GitBox
kkonstantine opened a new pull request #11260: URL: https://github.com/apache/kafka/pull/11260 Adding the license for https://github.com/jline/jline3 This is a commit that was missed when https://github.com/apache/kafka/pull/11232 was merged. ### Committer Checklist (excluded fr

[GitHub] [kafka] dengziming opened a new pull request #11261: KAFKA-13228: Ensure ApiVersionRequest is properly handled in KRaft

2021-08-25 Thread GitBox
dengziming opened a new pull request #11261: URL: https://github.com/apache/kafka/pull/11261 *More detailed description of your change* When I described quorum in Kraft mode I got `org.apache.kafka.common.errors.UnsupportedVersionException: The broker does not support DESCRIBE_QUORUM`.

[GitHub] [kafka] kkonstantine commented on pull request #11260: MINOR: Add missing license entry for jline in LICENSE-binary

2021-08-25 Thread GitBox
kkonstantine commented on pull request #11260: URL: https://github.com/apache/kafka/pull/11260#issuecomment-906020193 Merging to include to 3.0 without waiting for tests to run because this is just documentation. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [kafka] kkonstantine merged pull request #11260: MINOR: Add missing license entry for jline in LICENSE-binary

2021-08-25 Thread GitBox
kkonstantine merged pull request #11260: URL: https://github.com/apache/kafka/pull/11260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] showuon commented on pull request #11218: MINOR: optimize performAssignment to skip unnecessary check

2021-08-25 Thread GitBox
showuon commented on pull request #11218: URL: https://github.com/apache/kafka/pull/11218#issuecomment-906022496 @ableegoldman , do you think this optimization make sense? And will `StreamsPartitionAssignor` have chance to distribute partitions not in the subscription list? Thank you. --

[jira] [Assigned] (KAFKA-12963) Improve error message for Class cast exception

2021-08-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman reassigned KAFKA-12963: -- Assignee: A. Sophie Blee-Goldman > Improve error message for Class ca

[jira] [Commented] (KAFKA-12963) Improve error message for Class cast exception

2021-08-25 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404853#comment-17404853 ] A. Sophie Blee-Goldman commented on KAFKA-12963: Hey [~RasmusAtNordea],

[jira] [Assigned] (KAFKA-12963) Improve error message for Class cast exception

2021-08-25 Thread Andrew Lapidas (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrew Lapidas reassigned KAFKA-12963: -- Assignee: Andrew Lapidas (was: A. Sophie Blee-Goldman) > Improve error message for C

[GitHub] [kafka] mjsax commented on a change in pull request #11235: KAFKA-13216: write correct tombstones into stream-stream join store changelog

2021-08-25 Thread GitBox
mjsax commented on a change in pull request #11235: URL: https://github.com/apache/kafka/pull/11235#discussion_r696258817 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RawKeyAccessor.java ## @@ -0,0 +1,24 @@ +/* + * Licensed to the Apache

[GitHub] [kafka] alapidas opened a new pull request #11262: KAFKA-12963: Add processor name to error

2021-08-25 Thread GitBox
alapidas opened a new pull request #11262: URL: https://github.com/apache/kafka/pull/11262 This PR adds the processor name to the `ClassCastException` exception text in `process()` ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation -

[jira] [Updated] (KAFKA-13223) Idempotent producer error with Kraft

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13223: --- Fix Version/s: (was: 3.0.0) > Idempotent producer error with Kraft > --

[jira] [Closed] (KAFKA-13223) Idempotent producer error with Kraft

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13223?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis closed KAFKA-13223. -- > Idempotent producer error with Kraft > - >

[jira] [Updated] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13159: --- Fix Version/s: (was: 3.0.0) 3.0.1 > Enable system tes

[jira] [Commented] (KAFKA-13159) Enable system tests for transactions in KRaft mode

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404886#comment-17404886 ] Konstantine Karantasis commented on KAFKA-13159: For the remainder of th

[jira] [Updated] (KAFKA-13095) TransactionsTest is failing in kraft mode

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13095: --- Fix Version/s: (was: 3.0.0) > TransactionsTest is failing in kraft mode

[jira] [Resolved] (KAFKA-12930) KIP-751: Deprecate support for Scala 2.12 in Kafka 3.0

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12930. Resolution: Fixed Resolving to unblock the RC for 3.0.0 and will keep a no

[jira] [Updated] (KAFKA-12599) Remove deprecated --zookeeper in preferredReplicaLeaderElectionCommand

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12599?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12599: --- Fix Version/s: (was: 3.0.0) > Remove deprecated --zookeeper in preferred

[jira] [Resolved] (KAFKA-12929) KIP-750: Deprecate support for Java 8 in Kafka 3.0

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis resolved KAFKA-12929. Resolution: Fixed Resolving to unblock the RC for 3.0.0 and will keep a no

[jira] [Updated] (KAFKA-10329) Enable connector context in logs by default

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-10329: --- Fix Version/s: (was: 3.0.0) > Enable connector context in logs by defaul

[jira] [Updated] (KAFKA-12582) Remove deprecated `ConfigEntry` constructor

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-12582: --- Fix Version/s: (was: 3.0.0) > Remove deprecated `ConfigEntry` constructo

[jira] [Updated] (KAFKA-5905) Remove PrincipalBuilder and DefaultPrincipalBuilder

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-5905: -- Fix Version/s: (was: 3.0.0) > Remove PrincipalBuilder and DefaultPrincipalB

[jira] [Updated] (KAFKA-7271) Fix ignored test in streams_upgrade_test.py: test_upgrade_downgrade_brokers

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-7271?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-7271: -- Fix Version/s: (was: 3.0.0) > Fix ignored test in streams_upgrade_test.py:

[jira] [Commented] (KAFKA-13195) StateSerde don't honor DeserializationExceptionHandler

2021-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404900#comment-17404900 ] Matthias J. Sax commented on KAFKA-13195: - [~cadonna] – I think it's still open

[jira] [Commented] (KAFKA-13032) Impossible stacktrace

2021-08-25 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17404902#comment-17404902 ] Matthias J. Sax commented on KAFKA-13032: - It seems [~cadonna] reviewed the PR –

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-25 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r696280437 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -1925,6 +1926,56 @@ public void testCommittedAuthentic

[jira] [Updated] (KAFKA-13160) Fix the code that calls the broker's config handler to pass the expected default resource name when using KRaft.

2021-08-25 Thread Konstantine Karantasis (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13160?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konstantine Karantasis updated KAFKA-13160: --- Summary: Fix the code that calls the broker's config handler to pass the exp

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-25 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r696282952 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -1925,6 +1926,56 @@ public void testCommittedAuthentic

[GitHub] [kafka] mjsax commented on pull request #11233: HOTFIX: Disable spurious left/outer stream-stream join fix

2021-08-25 Thread GitBox
mjsax commented on pull request #11233: URL: https://github.com/apache/kafka/pull/11233#issuecomment-906091101 @showuon -- thanks for taking care of the docs -- I did actually not forget about it and was just about to do a follow up PR -- great that it is already done! -- This is an aut

[GitHub] [kafka] ableegoldman merged pull request #11259: HOTFIX: decrease session timeout in flaky NamedTopologyIntegrationTest

2021-08-25 Thread GitBox
ableegoldman merged pull request #11259: URL: https://github.com/apache/kafka/pull/11259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsu

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-25 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r696290580 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -1925,6 +1926,56 @@ public void testCommittedAuthentic

[GitHub] [kafka] rodesai commented on a change in pull request #11149: KIP-761: add total blocked time metric to streams

2021-08-25 Thread GitBox
rodesai commented on a change in pull request #11149: URL: https://github.com/apache/kafka/pull/11149#discussion_r696290766 ## File path: clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java ## @@ -1925,6 +1926,56 @@ public void testCommittedAuthentic

[GitHub] [kafka] ableegoldman opened a new pull request #11263: MINOR: remove unused Properties from GraphNode#writeToTopology

2021-08-25 Thread GitBox
ableegoldman opened a new pull request #11263: URL: https://github.com/apache/kafka/pull/11263 While going through the StreamsBuilder#build method to see if any of the steps actually modify internal state, I noticed this GraphNode method accepts a Properties input parameter but never uses

[jira] [Created] (KAFKA-13229) KIP-761: implement a total blocked time metric in Kafka Streams

2021-08-25 Thread Rohan Desai (Jira)
Rohan Desai created KAFKA-13229: --- Summary: KIP-761: implement a total blocked time metric in Kafka Streams Key: KAFKA-13229 URL: https://issues.apache.org/jira/browse/KAFKA-13229 Project: Kafka

[jira] [Comment Edited] (KAFKA-10313) Out of range offset errors leading to offset reset

2021-08-25 Thread qiang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403089#comment-17403089 ] qiang Liu edited comment on KAFKA-10313 at 8/26/21, 6:30 AM: -

[jira] [Comment Edited] (KAFKA-10313) Out of range offset errors leading to offset reset

2021-08-25 Thread qiang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403089#comment-17403089 ] qiang Liu edited comment on KAFKA-10313 at 8/26/21, 6:31 AM: -

[jira] [Comment Edited] (KAFKA-10313) Out of range offset errors leading to offset reset

2021-08-25 Thread qiang Liu (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-10313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17403089#comment-17403089 ] qiang Liu edited comment on KAFKA-10313 at 8/26/21, 6:35 AM: -