hachikuji commented on a change in pull request #11186:
URL: https://github.com/apache/kafka/pull/11186#discussion_r696116190
##########
File path: core/src/main/scala/kafka/server/BrokerServer.scala
##########
@@ -90,8 +90,7 @@ class BrokerServer(
this.logIdent = logContext.logPrefix
- val lifecycleManager: BrokerLifecycleManager =
- new BrokerLifecycleManager(config, time, threadNamePrefix)
+ private var lifecycleManager: BrokerLifecycleManager = null
Review comment:
This was a workaround to allow `BrokerServer` to be restartable in the
same way that `KafkaServer` is. It would be better to let the test kit
construct a new instance, but I decided to save that for a follow-up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
