showuon commented on a change in pull request #11227:
URL: https://github.com/apache/kafka/pull/11227#discussion_r695715007
##########
File path:
streams/src/test/java/org/apache/kafka/streams/state/internals/AbstractWindowBytesStoreTest.java
##########
@@ -931,16 +979,6 @@ public void shouldThrowNullPointerExceptionOnGetNullKey() {
assertThrows(NullPointerException.class, () -> windowStore.fetch(null,
ofEpochMilli(1L), ofEpochMilli(2L)));
}
- @Test
- public void shouldThrowNullPointerExceptionOnRangeNullFromKey() {
- assertThrows(NullPointerException.class, () -> windowStore.fetch(null,
2, ofEpochMilli(1L), ofEpochMilli(2L)));
- }
-
- @Test
- public void shouldThrowNullPointerExceptionOnRangeNullToKey() {
- assertThrows(NullPointerException.class, () -> windowStore.fetch(1,
null, ofEpochMilli(1L), ofEpochMilli(2L)));
- }
-
Review comment:
Yes, but I've already tested these 2 test cases above (i.e.
`testFetchRange` and `testBackwardFetchRange`). I don't think we should test
them again here. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
