[GitHub] [kafka] dengziming commented on a change in pull request #11173: MINOR: Support max timestamp in GetOffsetShell

2021-08-19 Thread GitBox
dengziming commented on a change in pull request #11173: URL: https://github.com/apache/kafka/pull/11173#discussion_r691845925 ## File path: core/src/main/scala/kafka/tools/GetOffsetShell.scala ## @@ -224,9 +227,14 @@ object GetOffsetShell { /** * Return the partition in

[GitHub] [kafka] dajac commented on pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-19 Thread GitBox
dajac commented on pull request #11230: URL: https://github.com/apache/kafka/pull/11230#issuecomment-901717039 @lbradstreet I have updated the PR based on your feedback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [kafka] dajac commented on a change in pull request #11231: KAFKA-13214; Consumer should not reset state after retriable error in rebalance

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11231: URL: https://github.com/apache/kafka/pull/11231#discussion_r692154377 ## File path: clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java ## @@ -476,7 +476,6 @@ boolean joinGroupIfNeeded(f

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692162163 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig, partitionsT

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692164057 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1420,6 +1423,10 @@ class ReplicaManager(val config: KafkaConfig, }

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692164654 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1544,7 +1554,7 @@ class ReplicaManager(val config: KafkaConfig, // rep

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692165645 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig, partitionsT

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692166774 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig, partitionsT

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692168365 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig, partitionsT

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692169643 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig, partitionsT

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692175152 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -82,7 +82,7 @@ class AbstractFetcherThreadTest { // add one

[GitHub] [kafka] dajac commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692175152 ## File path: core/src/test/scala/unit/kafka/server/AbstractFetcherThreadTest.scala ## @@ -82,7 +82,7 @@ class AbstractFetcherThreadTest { // add one

[GitHub] [kafka] vvcephei commented on pull request #11231: KAFKA-13214; Consumer should not reset state after retriable error in rebalance

2021-08-19 Thread GitBox
vvcephei commented on pull request #11231: URL: https://github.com/apache/kafka/pull/11231#issuecomment-901975557 Thanks @hachikuji ! FYI: I ran three full batches of system tests on your PR branch, and did not see a failure in that test or any other consistent test failure:

[GitHub] [kafka] lbradstreet commented on pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-19 Thread GitBox
lbradstreet commented on pull request #11230: URL: https://github.com/apache/kafka/pull/11230#issuecomment-901975481 @dajac the updated changes look good to me overall. It seems like we're hitting some gradle executor errors across multiple runs, so it may not be a coincidence. -- This

[GitHub] [kafka] dajac commented on pull request #11230: KAFKA-12840; Removing `compact` cleaning on a topic should abort on-going compactions

2021-08-19 Thread GitBox
dajac commented on pull request #11230: URL: https://github.com/apache/kafka/pull/11230#issuecomment-901980004 Let me check those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [kafka] andricDu commented on pull request #8103: KAFKA-7061: KIP-280 Enhanced log compaction

2021-08-19 Thread GitBox
andricDu commented on pull request #8103: URL: https://github.com/apache/kafka/pull/8103#issuecomment-902003678 Bump. Status update on this feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [kafka] akatona84 commented on pull request #11174: KAFKA-9747: Creating connect reconfiguration URL safely

2021-08-19 Thread GitBox
akatona84 commented on pull request #11174: URL: https://github.com/apache/kafka/pull/11174#issuecomment-902006686 > Thanks for the PR, it looks good. Is it possible to add a test for it? @mimaison , Thanks for the review, unfortunately that code part where the restclient is used, n

[GitHub] [kafka] dajac commented on a change in pull request #11229: KAFKA-12961; Verify group generation in `DelayedJoin`

2021-08-19 Thread GitBox
dajac commented on a change in pull request #11229: URL: https://github.com/apache/kafka/pull/11229#discussion_r692245978 ## File path: core/src/main/scala/kafka/coordinator/group/GroupCoordinator.scala ## @@ -1391,78 +1392,92 @@ class GroupCoordinator(val brokerId: Int, }

[GitHub] [kafka] dajac commented on pull request #11229: KAFKA-12961; Verify group generation in `DelayedJoin`

2021-08-19 Thread GitBox
dajac commented on pull request #11229: URL: https://github.com/apache/kafka/pull/11229#issuecomment-902020042 > Thanks for the PR. It makes sense to me. Would it be possible to add a test for the case when a late `DelayedJoin` completes? Yeah, let me see if I can add something. --

[GitHub] [kafka] spena commented on a change in pull request #11235: KAFKA-13216: write correct tombstones into stream-stream join store changelog

2021-08-19 Thread GitBox
spena commented on a change in pull request #11235: URL: https://github.com/apache/kafka/pull/11235#discussion_r692180473 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/internals/KStreamKStreamLeftJoinTest.java ## @@ -214,6 +223,128 @@ public void testLef

[jira] [Commented] (KAFKA-4669) KafkaProducer.flush hangs when NetworkClient.handleCompletedReceives throws exception

2021-08-19 Thread BurningIce (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401736#comment-17401736 ] BurningIce commented on KAFKA-4669: --- I'm using kafka-clients 2.5.0, also encountering

[GitHub] [kafka] mjsax commented on a change in pull request #11235: KAFKA-13216: write correct tombstones into stream-stream join store changelog

2021-08-19 Thread GitBox
mjsax commented on a change in pull request #11235: URL: https://github.com/apache/kafka/pull/11235#discussion_r692305287 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeySchema.java ## @@ -43,12 +45,12 @@ @Override public

[GitHub] [kafka] mjsax commented on a change in pull request #11235: KAFKA-13216: write correct tombstones into stream-stream join store changelog

2021-08-19 Thread GitBox
mjsax commented on a change in pull request #11235: URL: https://github.com/apache/kafka/pull/11235#discussion_r692305627 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/TimeOrderedKeySchema.java ## @@ -72,27 +74,47 @@ public long segmentTimestamp(

[GitHub] [kafka] vvcephei opened a new pull request #11236: MINOR: Set session timeout back to 10s for Streams system tests

2021-08-19 Thread GitBox
vvcephei opened a new pull request #11236: URL: https://github.com/apache/kafka/pull/11236 We increased the default session timeout to 30s in KIP-735: https://cwiki.apache.org/confluence/display/KAFKA/KIP-735%3A+Increase+default+consumer+session+timeout Since then, we are observin

[GitHub] [kafka] officialpatterson commented on pull request #11215: kafka-12994: Migrate TimeWindowsTest to new API

2021-08-19 Thread GitBox
officialpatterson commented on pull request #11215: URL: https://github.com/apache/kafka/pull/11215#issuecomment-902088249 Doesn't look like I have permissions to assign reviewers to this PR @ableegoldman. Also, fairly new to this, but it looks like these test failures are down to a

[jira] [Commented] (KAFKA-13152) Replace "buffered.records.per.partition" with "input.buffer.max.bytes"

2021-08-19 Thread Sagar Rao (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401763#comment-17401763 ] Sagar Rao commented on KAFKA-13152: --- Thanks [~mjsax]/[~guozhang]. I will start writing

[GitHub] [kafka] vvcephei commented on pull request #11236: MINOR: Set session timeout back to 10s for Streams system tests

2021-08-19 Thread GitBox
vvcephei commented on pull request #11236: URL: https://github.com/apache/kafka/pull/11236#issuecomment-902094127 system test run: https://jenkins.confluent.io/job/system-test-kafka-branch-builder/4657/ -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [kafka] vvcephei commented on a change in pull request #11236: MINOR: Set session timeout back to 10s for Streams system tests

2021-08-19 Thread GitBox
vvcephei commented on a change in pull request #11236: URL: https://github.com/apache/kafka/pull/11236#discussion_r692334355 ## File path: tests/kafkatest/services/streams.py ## @@ -569,16 +572,17 @@ def __init__(self, test_context, kafka): def prop_file(self):

[GitHub] [kafka] vvcephei commented on a change in pull request #11236: MINOR: Set session timeout back to 10s for Streams system tests

2021-08-19 Thread GitBox
vvcephei commented on a change in pull request #11236: URL: https://github.com/apache/kafka/pull/11236#discussion_r692334950 ## File path: tests/kafkatest/services/streams.py ## @@ -659,14 +663,15 @@ def __init__(self, test_context, kafka): def prop_file(self):

[GitHub] [kafka] vvcephei commented on a change in pull request #11236: MINOR: Set session timeout back to 10s for Streams system tests

2021-08-19 Thread GitBox
vvcephei commented on a change in pull request #11236: URL: https://github.com/apache/kafka/pull/11236#discussion_r692335138 ## File path: tests/kafkatest/services/streams.py ## @@ -686,12 +691,13 @@ def prop_file(self): streams_property.KAFKA_SERVERS: s

[GitHub] [kafka] jolshan commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
jolshan commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692338540 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig, partition

[GitHub] [kafka] jolshan commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

2021-08-19 Thread GitBox
jolshan commented on a change in pull request #11170: URL: https://github.com/apache/kafka/pull/11170#discussion_r692343425 ## File path: core/src/main/scala/kafka/server/ReplicaManager.scala ## @@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig, partition

[jira] [Updated] (KAFKA-12984) Cooperative sticky assignor can get stuck with invalid SubscriptionState input metadata

2021-08-19 Thread A. Sophie Blee-Goldman (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] A. Sophie Blee-Goldman updated KAFKA-12984: --- Fix Version/s: 2.8.1 > Cooperative sticky assignor can get stuck with invali

[jira] [Commented] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2021-08-19 Thread Yiming Zang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401818#comment-17401818 ] Yiming Zang commented on KAFKA-9320: We have seen some regression after enabling and

[jira] [Comment Edited] (KAFKA-9320) Enable TLSv1.3 by default and disable some of the older protocols

2021-08-19 Thread Yiming Zang (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-9320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401818#comment-17401818 ] Yiming Zang edited comment on KAFKA-9320 at 8/19/21, 6:45 PM: -

[GitHub] [kafka] jsancio opened a new pull request #11237: MINOR: Fix how the last borker id is computed

2021-08-19 Thread GitBox
jsancio opened a new pull request #11237: URL: https://github.com/apache/kafka/pull/11237 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes

[GitHub] [kafka] rondagostino opened a new pull request #11238: MINOR: Fix force kill of KRaft colocated controllers in system tests

2021-08-19 Thread GitBox
rondagostino opened a new pull request #11238: URL: https://github.com/apache/kafka/pull/11238 I noticed that a system test using a KRaft cluster with 3 brokers but only 1 co-located controller did not force-kill the second and third broker after shutting down the first broker (the one wit

[jira] [Updated] (KAFKA-8613) Make Grace Period Mandatory in Windowed Operations

2021-08-19 Thread Israel Ekpo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Israel Ekpo updated KAFKA-8613: --- Summary: Make Grace Period Mandatory in Windowed Operations (was: Make grace period mandatory) > Ma

[jira] [Updated] (KAFKA-8613) Make Grace Period Mandatory for Windowed Operations in Streams

2021-08-19 Thread Israel Ekpo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Israel Ekpo updated KAFKA-8613: --- Summary: Make Grace Period Mandatory for Windowed Operations in Streams (was: Make Grace Period Mand

[jira] [Created] (KAFKA-13219) BrokerState metric not working for KRaft clusters

2021-08-19 Thread Ron Dagostino (Jira)
Ron Dagostino created KAFKA-13219: - Summary: BrokerState metric not working for KRaft clusters Key: KAFKA-13219 URL: https://issues.apache.org/jira/browse/KAFKA-13219 Project: Kafka Issue Typ

[jira] [Updated] (KAFKA-8613) Make Grace Period Mandatory for Windowed Operations in Streams

2021-08-19 Thread Israel Ekpo (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-8613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Israel Ekpo updated KAFKA-8613: --- Description: Currently, the grace period is set to retention time if the grace period is not specifi

[GitHub] [kafka] hachikuji merged pull request #11237: MINOR: Fix how the last borker id is computed

2021-08-19 Thread GitBox
hachikuji merged pull request #11237: URL: https://github.com/apache/kafka/pull/11237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubsc

[GitHub] [kafka] rondagostino opened a new pull request #11239: KAFKA-13219: BrokerState metric not working for KRaft clusters

2021-08-19 Thread GitBox
rondagostino opened a new pull request #11239: URL: https://github.com/apache/kafka/pull/11239 The BrokerState metric always has a value of 0, for NOT_RUNNING, in KRaft clusters. This patch fixes it and adds a test. ### Committer Checklist (excluded from commit message) - [ ] Veri

[GitHub] [kafka] izzyacademy commented on a change in pull request #11235: KAFKA-13216: write correct tombstones into stream-stream join store changelog

2021-08-19 Thread GitBox
izzyacademy commented on a change in pull request #11235: URL: https://github.com/apache/kafka/pull/11235#discussion_r692514791 ## File path: streams/src/main/java/org/apache/kafka/streams/state/internals/metrics/RawKeyAccessor.java ## @@ -0,0 +1,24 @@ +/* + * Licensed to the

[GitHub] [kafka] ijuma commented on a change in pull request #11239: KAFKA-13219: BrokerState metric not working for KRaft clusters

2021-08-19 Thread GitBox
ijuma commented on a change in pull request #11239: URL: https://github.com/apache/kafka/pull/11239#discussion_r692518398 ## File path: core/src/main/scala/kafka/server/KafkaBroker.scala ## @@ -85,7 +85,8 @@ trait KafkaBroker extends KafkaMetricsGroup { explicitMetricName(

[GitHub] [kafka] ijuma commented on a change in pull request #11239: KAFKA-13219: BrokerState metric not working for KRaft clusters

2021-08-19 Thread GitBox
ijuma commented on a change in pull request #11239: URL: https://github.com/apache/kafka/pull/11239#discussion_r692520138 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -84,6 +84,8 @@ class BrokerServer( val supportedFeatures: util.Map[String, Versio

[GitHub] [kafka] ijuma commented on a change in pull request #11239: KAFKA-13219: BrokerState metric not working for KRaft clusters

2021-08-19 Thread GitBox
ijuma commented on a change in pull request #11239: URL: https://github.com/apache/kafka/pull/11239#discussion_r692520138 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -84,6 +84,8 @@ class BrokerServer( val supportedFeatures: util.Map[String, Versio

[GitHub] [kafka] ableegoldman commented on pull request #11215: KAFKA-12994: Migrate TimeWindowsTest to new API

2021-08-19 Thread GitBox
ableegoldman commented on pull request #11215: URL: https://github.com/apache/kafka/pull/11215#issuecomment-902302847 Yep don't worry about it, that test is known to be flaky and unrelated. And yeah, the ability to set reviewers is restricted to committers. You can just ping people in a co

[GitHub] [kafka] ableegoldman commented on a change in pull request #11215: KAFKA-12994: Migrate TimeWindowsTest to new API

2021-08-19 Thread GitBox
ableegoldman commented on a change in pull request #11215: URL: https://github.com/apache/kafka/pull/11215#discussion_r692546162 ## File path: streams/src/test/java/org/apache/kafka/streams/kstream/TimeWindowsTest.java ## @@ -95,27 +91,19 @@ public void advanceIntervalMustNotB

[GitHub] [kafka] rondagostino commented on a change in pull request #11239: KAFKA-13219: BrokerState metric not working for KRaft clusters

2021-08-19 Thread GitBox
rondagostino commented on a change in pull request #11239: URL: https://github.com/apache/kafka/pull/11239#discussion_r692561312 ## File path: core/src/main/scala/kafka/server/BrokerServer.scala ## @@ -84,6 +84,8 @@ class BrokerServer( val supportedFeatures: util.Map[String,

[GitHub] [kafka] rondagostino commented on a change in pull request #11239: KAFKA-13219: BrokerState metric not working for KRaft clusters

2021-08-19 Thread GitBox
rondagostino commented on a change in pull request #11239: URL: https://github.com/apache/kafka/pull/11239#discussion_r692561636 ## File path: core/src/main/scala/kafka/server/KafkaBroker.scala ## @@ -85,7 +85,8 @@ trait KafkaBroker extends KafkaMetricsGroup { explicitMetr

[jira] [Updated] (KAFKA-13216) Streams left/outer joins cause new internal changelog topic to grow unbounded

2021-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13216: Affects Version/s: (was: 3.0.0) > Streams left/outer joins cause new internal changelo

[jira] [Updated] (KAFKA-13216) Streams left/outer joins cause new internal changelog topic to grow unbounded

2021-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13216: Priority: Critical (was: Blocker) > Streams left/outer joins cause new internal changelog

[jira] [Commented] (KAFKA-13216) Streams left/outer joins cause new internal changelog topic to grow unbounded

2021-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401940#comment-17401940 ] Matthias J. Sax commented on KAFKA-13216: - We disabled the feature in 3.0.0, and

[jira] [Updated] (KAFKA-13216) Streams left/outer joins cause new internal changelog topic to grow unbounded

2021-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matthias J. Sax updated KAFKA-13216: Fix Version/s: (was: 3.0.0) 3.1.0 > Streams left/outer joins cause

[jira] [Comment Edited] (KAFKA-13216) Streams left/outer joins cause new internal changelog topic to grow unbounded

2021-08-19 Thread Matthias J. Sax (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401940#comment-17401940 ] Matthias J. Sax edited comment on KAFKA-13216 at 8/20/21, 1:04 AM: ---

[jira] [Commented] (KAFKA-13218) kafka deleted unexpired message unexpectedly

2021-08-19 Thread Haruki Okada (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17401943#comment-17401943 ] Haruki Okada commented on KAFKA-13218: -- One possible cause I can imagine is because

[GitHub] [kafka] vvcephei commented on pull request #11236: MINOR: Set session timeout back to 10s for Streams system tests

2021-08-19 Thread GitBox
vvcephei commented on pull request #11236: URL: https://github.com/apache/kafka/pull/11236#issuecomment-902390477 System test results: http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2021-08-19--001.system-test-kafka-branch-builder--1629415396--vvcephei-

[jira] [Assigned] (KAFKA-13211) fetch queries with open endpoints for WindowStore

2021-08-19 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13211?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13211: - Assignee: Luke Chen > fetch queries with open endpoints for WindowStore > -

[jira] [Updated] (KAFKA-13212) fetch/findSessions queries with open endpoints for SessionStore

2021-08-19 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen updated KAFKA-13212: -- Summary: fetch/findSessions queries with open endpoints for SessionStore (was: findSessions queries w

[jira] [Assigned] (KAFKA-13212) findSessions queries with open endpoints for SessionStore

2021-08-19 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-13212?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-13212: - Assignee: Luke Chen > findSessions queries with open endpoints for SessionStore > -

[GitHub] [kafka] vvcephei commented on pull request #11236: MINOR: Set session timeout back to 10s for Streams system tests

2021-08-19 Thread GitBox
vvcephei commented on pull request #11236: URL: https://github.com/apache/kafka/pull/11236#issuecomment-902407705 Thanks, @ableegoldman ! I agree it might be overkill, and I wouldn't fault the conservative approach. The reason I went for a blanket approach is that it seems like

[GitHub] [kafka] yangdaixai opened a new pull request #11240: KAFKA-13175; test

2021-08-19 Thread GitBox
yangdaixai opened a new pull request #11240: URL: https://github.com/apache/kafka/pull/11240 test Signed-off-by: yangdaixai *More detailed description of your change, if necessary. The PR title and PR message become the squashed commit message, so use a separate comme

[GitHub] [kafka] jasonyanwenl opened a new pull request #11241: KAFKA-13032: add NPE checker for KeyValueMapper

2021-08-19 Thread GitBox
jasonyanwenl opened a new pull request #11241: URL: https://github.com/apache/kafka/pull/11241 Currently in both `KStreamMap` and `KStreamFlatMap` classes, they will throw NPE if the call to `KeyValueMapper#apply` return Null. We should check whether the result of that call is Null and thr

[GitHub] [kafka] clolov commented on pull request #11214: KAFKA-12994 Migrate JoinWindowsTest and SessionWindowsTest to new API

2021-08-19 Thread GitBox
clolov commented on pull request #11214: URL: https://github.com/apache/kafka/pull/11214#issuecomment-902458908 @ableegoldman - I am kindly requesting a review :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [kafka] yangdaixai closed pull request #11240: KAFKA-13175; test

2021-08-19 Thread GitBox
yangdaixai closed pull request #11240: URL: https://github.com/apache/kafka/pull/11240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubs

[GitHub] [kafka] yangdaixai commented on pull request #11226: KAFKA-13175; Optimization TopicExistsException,When a topic is marked…

2021-08-19 Thread GitBox
yangdaixai commented on pull request #11226: URL: https://github.com/apache/kafka/pull/11226#issuecomment-902474644 @ijuma -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.