[GitHub] [kafka] jolshan commented on a change in pull request #11170: KAFKA-13102: Topic IDs not propagated to metadata cache quickly enough for Fetch path

[GitBox]

jolshan commented on a change in pull request #11170:
URL: https://github.com/apache/kafka/pull/11170#discussion_r692338540



##########
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##########
@@ -1755,6 +1765,78 @@ class ReplicaManager(val config: KafkaConfig,
     partitionsToMakeFollower
   }
 
+  private def updateTopicIdForFollowers(controllerId: Int,

Review comment:
       there is an issue with alter isr which is partially explained in this 
comment:
   ```
   * With the addition of AlterIsr, we also consider newly added replicas as 
part of the ISR when advancing
   * the HW. These replicas have not yet been committed to the ISR by the 
controller, so we could revert to the previously
   * committed ISR. However, adding additional replicas to the ISR makes it 
more restrictive and therefor safe. We call
   * this set the "maximal" ISR. See KIP-497 for more details
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org